Re: PS3 platform is broken on Linux 3.7.0

2013-02-12 Thread Geoff Levand
Hi, On Fri, 2012-12-14 at 16:35 +0400, Phileas Fogg wrote: > I wanted to bring to your attention the fact that the PS3 platform is broken > on Linux 3.7.0. > So i cloned the Linux powerpc GIT repository and tried to find out which > commits broke the PS3 platform. > ---

[PATCH 17/17] powerpc: Documentation for transactional memory on powerpc

2013-02-12 Thread Michael Neuling
Signed-off-by: Matt Evans Signed-off-by: Michael Neuling --- Documentation/powerpc/transactional_memory.txt | 175 1 file changed, 175 insertions(+) create mode 100644 Documentation/powerpc/transactional_memory.txt diff --git a/Documentation/powerpc/transactional_memo

[PATCH 16/17] powerpc: Add transactional memory to pseries and ppc64 defconfigs

2013-02-12 Thread Michael Neuling
Signed-off-by: Matt Evans Signed-off-by: Michael Neuling --- arch/powerpc/configs/ppc64_defconfig |2 ++ arch/powerpc/configs/pseries_defconfig |2 ++ 2 files changed, 4 insertions(+) diff --git a/arch/powerpc/configs/ppc64_defconfig b/arch/powerpc/configs/ppc64_defconfig index 6cbde

[PATCH 15/17] powerpc: Add config option for transactional memory

2013-02-12 Thread Michael Neuling
Kconfig option for transactional memory on powerpc. Signed-off-by: Matt Evans Signed-off-by: Michael Neuling --- arch/powerpc/Kconfig |8 1 file changed, 8 insertions(+) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 4b27edb..fbeb6d2 100644 --- a/arch/powerpc/Kconf

[PATCH 14/17] powerpc: Add transactional memory to POWER8 cpu features

2013-02-12 Thread Michael Neuling
Signed-off-by: Matt Evans Signed-off-by: Michael Neuling --- arch/powerpc/include/asm/cputable.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/include/asm/cputable.h b/arch/powerpc/include/asm/cputable.h index 3636081..fb3245e 100644 --- a/arch/powerpc/in

[PATCH 13/17] powerpc: Add new transactional memory state to the signal context

2013-02-12 Thread Michael Neuling
This adds the new transactional memory archtected state to the signal context in both 32 and 64 bit. Signed-off-by: Matt Evans Signed-off-by: Michael Neuling --- arch/powerpc/include/asm/reg.h |1 + arch/powerpc/kernel/signal.h|8 + arch/powerpc/kernel/signal_32.c | 500 ++

[PATCH 12/17] powerpc: Hook in new transactional memory code

2013-02-12 Thread Michael Neuling
This hooks the new transactional memory code into context switching, FP/VMX/VMX unavailable and exception return. Signed-off-by: Matt Evans Signed-off-by: Michael Neuling --- arch/powerpc/kernel/exceptions-64s.S | 56 -- arch/powerpc/kernel/process.c|

[PATCH 11/17] powerpc: Routines for FP/VSX/VMX unavailable during a transaction

2013-02-12 Thread Michael Neuling
We do lazy FP but not lazy TM (ie. userspace starts with MSR TM=1 FP=0). Hence if userspace does an FP instruction during a transaction, we'll take an fp unavailable exception. This adds functions needed to handle this case. We have to inject the current FP state into the checkpoint so that the

[PATCH 10/17] powerpc: Add transactional memory unavaliable execption handler

2013-02-12 Thread Michael Neuling
These should never happen since we always turn on MSR TM when in userspace. We don't do lazy TM. Hence if we hit this, we barf and kill the task as something's gone horribly wrong. Signed-off-by: Matt Evans Signed-off-by: Michael Neuling --- arch/powerpc/kernel/exceptions-64s.S | 19

[PATCH 09/17] powerpc: Add reclaim and recheckpoint functions for context switching transactional memory processes

2013-02-12 Thread Michael Neuling
When we switch out a task, we need to save both the checkpointed and the speculated state into the thread struct. Similarly when we are switching in a task we need to load both the checkpointed and speculated state. If the task was using FP, we non-lazily reload both the original and the speculat

[PATCH 08/17] powerpc: Add FP/VSX and VMX register load functions for transactional memory

2013-02-12 Thread Michael Neuling
This adds functions to restore the state of the FP/VSX registers from what's stored in the thread_struct. Two version for FP/VSX are required since one restores them from transactional/checkpoint side of the thread_struct and the other from the speculated side. Similar functions are added for VMX

[PATCH 07/17] powerpc: Add helper functions for transactional memory context switching

2013-02-12 Thread Michael Neuling
Here we add the helper functions to be used when context switching. These allow us to fully reclaim and recheckpoint a transaction. We introduce a new paca field called tm_scratch to help us store away register values when doing the low level tm reclaim register save. Signed-off-by: Matt Evans

[PATCH 06/17] powerpc: Add transactional memory paca scratch register to show_regs

2013-02-12 Thread Michael Neuling
Add transactional memory paca scratch register to show_regs. This is useful for debugging. Signed-off-by: Matt Evans Signed-off-by: Michael Neuling --- arch/powerpc/include/asm/paca.h |1 + arch/powerpc/kernel/asm-offsets.c |1 + arch/powerpc/kernel/entry_64.S|4 arch/po

[PATCH 05/17] powerpc: Register defines for various transactional memory registers

2013-02-12 Thread Michael Neuling
Defines for MSR bits and transactional memory related SPRs TFIAR, TEXASR and TEXASRU. Signed-off-by: Matt Evans Signed-off-by: Michael Neuling --- arch/powerpc/include/asm/reg.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/arch/powerpc/include/asm/reg.h b/a

[PATCH 04/17] powerpc: New macros for transactional memory support

2013-02-12 Thread Michael Neuling
This adds new macros for saving and restoring checkpointed architected state from and to the thread_struct. It also adds some debugging macros for when your brain explodes trying to debug your transactional memory enabled kernel. Signed-off-by: Matt Evans Signed-off-by: Michael Neuling --- arc

[PATCH 03/17] powerpc: Add additional state needed for transactional memory to thread struct

2013-02-12 Thread Michael Neuling
Set of new archtected state for saving away on context switch. Signed-off-by: Matt Evans Signed-off-by: Michael Neuling --- arch/powerpc/include/asm/processor.h | 28 1 file changed, 28 insertions(+) diff --git a/arch/powerpc/include/asm/processor.h b/arch/power

[PATCH 02/17] powerpc: Add new instructions for transactional memory

2013-02-12 Thread Michael Neuling
Here we define the new instructions we need for transactional memory in the kernel. This is so we can support compiling with binutils that don't support the new transactional memory instructions. Transactional memory results in two sets of architected state (GPRs/VSRs etc). treclaim allows us to

[PATCH 01/17] powerpc: Add new CPU feature bit for transactional memory

2013-02-12 Thread Michael Neuling
Signed-off-by: Matt Evans Signed-off-by: Michael Neuling --- arch/powerpc/include/asm/cputable.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/powerpc/include/asm/cputable.h b/arch/powerpc/include/asm/cputable.h index 5f1938f..3636081 100644 --- a/arch/powerpc/include/asm/c

[PATCH 00/17] powerpc: Hardware transactional memory support for POWER8

2013-02-12 Thread Michael Neuling
POWER8 implements hardware transactional memory support. This patch series adds kernel support so that user programs can use this hardware transactional memory and the new state is properly context switched. It is not currently used by the kernel itself. This patch series was originally develope

RE: BOOKE KVM calling load_up_fpu from C?

2013-02-12 Thread Bhushan Bharat-R65777
> -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, February 13, 2013 6:53 AM > To: Bhushan Bharat-R65777 > Cc: Wood Scott-B07421; Michael Neuling; linuxppc-dev@lists.ozlabs.org > Subject: Re: BOOKE KVM calling load_up_fpu from C? > > On 02/12/2013 07:18:14 PM, Bhushan Bhar

Re: [PATCH 2/2] powerpc: Make context bits depend on virtual addr size.

2013-02-12 Thread Benjamin Herrenschmidt
On Wed, 2013-02-13 at 08:54 +0530, Aneesh Kumar K.V wrote: > > A compile option ? Really ? Ugh... > > I actually wanted that to be done in Kconfig.cputype, but haven't found > a nice way to do it. Considering we are switching between only two > values, I was thinking an #ifdef would work. No, we

Re: [PATCH 2/2] powerpc: Make context bits depend on virtual addr size.

2013-02-12 Thread Aneesh Kumar K.V
Benjamin Herrenschmidt writes: > On Wed, 2013-02-13 at 00:01 +0530, Aneesh Kumar K.V wrote: >> + * Be careful with this value. This determines the VSID_MODULUS_* and that >> + * need to be co-prime with VSID_MULTIPLIER* >> + */ >> +#if defined(CONFIG_POWER6_CPU) || defined(CONFIG_POWER7_CPU) >>

RE: BOOKE KVM calling load_up_fpu from C?

2013-02-12 Thread Bhushan Bharat-R65777
> -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, February 13, 2013 6:53 AM > To: Bhushan Bharat-R65777 > Cc: Wood Scott-B07421; Michael Neuling; linuxppc-dev@lists.ozlabs.org > Subject: Re: BOOKE KVM calling load_up_fpu from C? > > On 02/12/2013 07:18:14 PM, Bhushan Bhar

Re: BOOKE KVM calling load_up_fpu from C?

2013-02-12 Thread Scott Wood
On 02/12/2013 07:18:14 PM, Bhushan Bharat-R65777 wrote: > -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, February 13, 2013 12:03 AM > To: Bhushan Bharat-R65777 > Cc: Michael Neuling; Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org > Subject: Re: BOOKE KVM calling lo

RE: BOOKE KVM calling load_up_fpu from C?

2013-02-12 Thread Bhushan Bharat-R65777
> -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, February 13, 2013 12:03 AM > To: Bhushan Bharat-R65777 > Cc: Michael Neuling; Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org > Subject: Re: BOOKE KVM calling load_up_fpu from C? > > On 02/12/2013 03:01:07 AM, Bhushan Bha

[PATCH] powerpc: Apply early paca fixups to boot_paca and the boot cpu's paca

2013-02-12 Thread Michael Ellerman
In commit 466921c we added a hack to set the paca data_offset to zero so that per-cpu accesses would work on the boot cpu prior to per-cpu areas being setup. This fixed a problem with lockdep touching per-cpu areas very early in boot. However if we combine CONFIG_LOCK_STAT=y with any of the PPC_EA

Re: BOOKE KVM calling load_up_fpu from C?

2013-02-12 Thread Michael Neuling
Scott Wood wrote: > On 02/12/2013 03:01:07 AM, Bhushan Bharat-R65777 wrote: > > > > > > > -Original Message- > > > From: Michael Neuling [mailto:mi...@neuling.org] > > > Sent: Tuesday, February 12, 2013 9:46 AM > > > To: Bhushan Bharat-R65777 > > > Cc: Wood Scott-B07421; linuxppc-dev@li

Re: [PATCH v3] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread David Miller
From: Stefan Roese Date: Tue, 12 Feb 2013 14:05:38 +0100 > v3: > - Use of_get_mac_address() instead of of_get_property() Just to clarify, I applied this version (v3), not v2 (which I just replied to with "applied"). ___ Linuxppc-dev mailing list Linuxp

Re: [PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread David Miller
From: Stefan Roese Date: Tue, 12 Feb 2013 10:08:08 +0100 > Until now, the MPC5200 FEC ethernet driver relied upon the bootloader > (U-Boot) to write the MAC address into the ethernet controller > registers. The Linux driver should not rely on such a thing. So > lets read the MAC address from the

Re: [PATCH 2/2] powerpc: Make context bits depend on virtual addr size.

2013-02-12 Thread Benjamin Herrenschmidt
On Wed, 2013-02-13 at 00:01 +0530, Aneesh Kumar K.V wrote: > + * Be careful with this value. This determines the VSID_MODULUS_* and that > + * need to be co-prime with VSID_MULTIPLIER* > + */ > +#if defined(CONFIG_POWER6_CPU) || defined(CONFIG_POWER7_CPU) > +/* > + * Even if cpu support 68 bits, w

Re: [PATCH v2 1/1] powerpc/85xx: Board support for ppa8548

2013-02-12 Thread Kumar Gala
On Feb 4, 2013, at 9:30 AM, Timur Tabi wrote: > On 02/03/2013 01:39 PM, Stef van Os wrote: > >> +pci0: pci@fe0008000 { >> +status = "disabled"; >> +}; >> + >> +pci1: pci@fe0009000 { >> +status = "disabled"; >> +}; >> + >> +pci2: pcie@fe000a000 { >> +

Re: [PATCH 1/4] powerpc/fsl: msi: sparse fixes

2013-02-12 Thread Kumar Gala
On Nov 30, 2012, at 5:34 PM, Kim Phillips wrote: > arch/powerpc/sysdev/fsl_msi.c:31:1: warning: symbol 'msi_head' was not > declared. Should it be static? > arch/powerpc/sysdev/fsl_msi.c:138:40: warning: incorrect type in argument 1 > (different base types) > arch/powerpc/sysdev/fsl_msi.c:138:4

Re: [PATCHv1] crypto: caam - Added property fsl, sec-era in SEC4.0 device tree binding.

2013-02-12 Thread Kumar Gala
On Jan 23, 2013, at 1:21 AM, Vakul Garg wrote: > This new property defines the era of the particular SEC version. > The compatible property in device tree "crypto" node has been updated > not to contain SEC era numbers. > > Signed-off-by: Vakul Garg > --- > Changelog: > 1. Marked fsl,sec-

Re: [PATCH -next] powerpc/85xx: use for_each_compatible_node() macro

2013-02-12 Thread Kumar Gala
On Dec 3, 2012, at 7:36 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Use for_each_compatible_node() macro instead of open coding it. > > Signed-off-by: Wei Yongjun > --- > arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) applied to next -

Re: [PATCH 1/4] powerpc/fsl: msi: sparse fixes

2013-02-12 Thread Kumar Gala
On Nov 30, 2012, at 5:34 PM, Kim Phillips wrote: > arch/powerpc/sysdev/fsl_msi.c:31:1: warning: symbol 'msi_head' was not > declared. Should it be static? > arch/powerpc/sysdev/fsl_msi.c:138:40: warning: incorrect type in argument 1 > (different base types) > arch/powerpc/sysdev/fsl_msi.c:138:4

Re: [PATCH 1/4] powerpc: split sbc8548 dts file into pre and post chunks

2013-02-12 Thread Kumar Gala
On Jan 23, 2013, at 2:13 PM, Paul Gortmaker wrote: > Updates to u-boot allow this board to boot off of either > the 8MB soldered on flash, or the 64MB SODIMM flash. > > This is achieved by changing JP12 and SW2.8 which in turn > swaps which flash device appears on /CS0 and /CS6 respectively. >

Re: [PATCH 2/2] powerpc/85xx: describe the PAMU topology in the device tree

2013-02-12 Thread Gala Kumar-B11780
On Jan 17, 2013, at 4:34 PM, Timur Tabi wrote: > From: Timur Tabi > > The PAMU caches use the LIODNs to determine which cache lines hold the > entries for the corresponding LIODs. The LIODNs must therefore be > carefully assigned to avoid cache thrashing -- two active LIODs with > LIODNs that

Re: [PATCH 1/2] powerpc/85xx: fix various PCI node compatible strings

2013-02-12 Thread Gala Kumar-B11780
On Jan 17, 2013, at 4:34 PM, Timur Tabi wrote: > From: Timur Tabi > > Fix and/or improve the compatible strings of the PCI device tree nodes for > some Freescale SOCs. This fixes some issues and improves consistency among > the SOCs. > > Specifically: > > 1) The P1022 has a v1 PCIe controlle

Re: [PATCH 1/5] powerpc/82xx: fix checkpatch warnings for km82xx.c

2013-02-12 Thread Kumar Gala
On Dec 7, 2012, at 9:09 AM, Holger Brunck wrote: > Signed-off-by: Holger Brunck > cc: Kumar Gala > --- > arch/powerpc/platforms/82xx/km82xx.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) applied 1-5 to next - k ___ Linuxppc-dev m

Re: BOOKE KVM calling load_up_fpu from C?

2013-02-12 Thread Scott Wood
On 02/12/2013 03:01:07 AM, Bhushan Bharat-R65777 wrote: > -Original Message- > From: Michael Neuling [mailto:mi...@neuling.org] > Sent: Tuesday, February 12, 2013 9:46 AM > To: Bhushan Bharat-R65777 > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org > Subject: Re: BOOKE KVM calling

Re: [PATCH v5 04/45] percpu_rwlock: Implement the core design of Per-CPU Reader-Writer Locks

2013-02-12 Thread Paul E. McKenney
On Sun, Feb 10, 2013 at 11:54:17AM -0800, Paul E. McKenney wrote: > On Sun, Feb 10, 2013 at 07:06:07PM +0100, Oleg Nesterov wrote: > > On 02/08, Paul E. McKenney wrote: > > [ . . . ] > > > > > +static inline void sync_reader(struct percpu_rwlock *pcpu_rwlock, > > > > +

[PATCH 2/2] powerpc: Make context bits depend on virtual addr size.

2013-02-12 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" Different platforms supports different virtual addr size(n bits). We need to mak sure 0:77-n bits of the VA generated is forced to zero. Signed-off-by: Aneesh Kumar K.V --- arch/powerpc/include/asm/mmu-hash64.h | 22 +- 1 file changed, 21 inserti

[PATCH 1/2] powerpc: Make VSID_BITS* dependency explicit

2013-02-12 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" VSID_BITS and VSID_BITS_1T depends on the context bits and user esid bits. Make the dependency explicit Signed-off-by: Aneesh Kumar K.V --- arch/powerpc/include/asm/mmu-hash64.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/pow

Re: [PATCH] powerpc/85xx: dts - add ranges property for SEC

2013-02-12 Thread Kumar Gala
On Jan 18, 2013, at 2:40 PM, Kim Phillips wrote: > On Fri, 18 Jan 2013 17:16:13 +0800 > Po Liu wrote: > >> This facilitates getting the physical address of the SEC node. >> >> Signed-off-by: Liu po >> --- > Reviewed-by: Kim Phillips > > Kim This was missing a trailing ';', so wondering if

Re: [PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread David Miller
From: Bhushan Bharat-R65777 Date: Tue, 12 Feb 2013 10:56:05 + > Why we read from MAC registers if Linux should not rely on bootloader? Because it used to and if you just remove that code then you break existing setups, and I explicitly told him to code things this way. __

[PATCH v3] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread Stefan Roese
Until now, the MPC5200 FEC ethernet driver relied upon the bootloader (U-Boot) to write the MAC address into the ethernet controller registers. The Linux driver should not rely on such a thing. So lets read the MAC address from the DT as it should be done here. The following priority is now used t

Re: [PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread Timur Tabi
On Tue, Feb 12, 2013 at 3:08 AM, Stefan Roese wrote: > +* First try to read MAC address from DT > +*/ > + p = of_get_property(np, "local-mac-address", NULL); of_get_mac_address() ___ Linuxppc-dev mailing list Linuxppc-dev@lists.oz

Re: [PATCH] Centralise CONFIG_ARCH_NO_VIRT_TO_BUS

2013-02-12 Thread James Hogan
On 12/02/13 11:47, Stephen Rothwell wrote: > Change it to CONFIG_HAVE_VIRT_TO_BUS and set it in all architecures nit: typo in "architecures" > that already provide virt_to_bus(). > > Signed-off-by: Stephen Rothwell Reviewed-by: James Hogan Cheers James signature.asc Description: OpenPGP d

Re: [PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread Stefan Roese
On 12.02.2013 12:23, Bhushan Bharat-R65777 wrote: >>> Why we read from MAC registers if Linux should not rely on bootloader? >> >> It was suggested by David. Backwards compatibility. Here Davids comment to my >> original patch which removed this register reading completely: >> >> " >> I don't think

[PATCH] Centralise CONFIG_ARCH_NO_VIRT_TO_BUS

2013-02-12 Thread Stephen Rothwell
Change it to CONFIG_HAVE_VIRT_TO_BUS and set it in all architecures that already provide virt_to_bus(). Signed-off-by: Stephen Rothwell --- arch/Kconfig| 7 +++ arch/alpha/Kconfig | 1 + arch/arm/Kconfig| 1 + arch/avr32/Kconfig | 1 + arch/blackfin/Kconfig |

RE: [PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread Bhushan Bharat-R65777
> -Original Message- > From: Stefan Roese [mailto:s...@denx.de] > Sent: Tuesday, February 12, 2013 4:34 PM > To: Bhushan Bharat-R65777 > Cc: net...@vger.kernel.org; linuxppc-...@ozlabs.org; Anatolij Gustschin; David > S. Miller > Subject: Re: [PATCH v2] net: fec_mpc52xx: Read MAC address

Re: [PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread Stefan Roese
On 12.02.2013 11:56, Bhushan Bharat-R65777 wrote: >> Until now, the MPC5200 FEC ethernet driver relied upon the bootloader >> (U-Boot) to write the MAC address into the ethernet controller registers. The >> Linux driver should not rely on such a thing. So lets read the MAC address >> from >> the D

RE: [PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread Bhushan Bharat-R65777
> -Original Message- > From: Linuxppc-dev [mailto:linuxppc-dev- > bounces+bharat.bhushan=freescale@lists.ozlabs.org] On Behalf Of Stefan > Roese > Sent: Tuesday, February 12, 2013 2:38 PM > To: net...@vger.kernel.org > Cc: linuxppc-...@ozlabs.org; Anatolij Gustschin > Subject: [PATCH

[PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread Stefan Roese
Until now, the MPC5200 FEC ethernet driver relied upon the bootloader (U-Boot) to write the MAC address into the ethernet controller registers. The Linux driver should not rely on such a thing. So lets read the MAC address from the DT as it should be done here. The following priority is now used t

RE: BOOKE KVM calling load_up_fpu from C?

2013-02-12 Thread Bhushan Bharat-R65777
> -Original Message- > From: Michael Neuling [mailto:mi...@neuling.org] > Sent: Tuesday, February 12, 2013 9:46 AM > To: Bhushan Bharat-R65777 > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org > Subject: Re: BOOKE KVM calling load_up_fpu from C? > > Bhushan Bharat-R65777 wrote: >

Re: [BUG] irq_dispose_mapping after irq request failure

2013-02-12 Thread Benjamin Herrenschmidt
On Tue, 2013-02-12 at 17:18 +1100, Michael Ellerman wrote: > > I don't think you can, "active" is not well defined. Other code may have > done nothing other than create the mapping and remembered the virq, > which will break if you destroy the mapping. Or? Active as in "requested". Yes there's a