On Feb 4, 2013, at 9:30 AM, Timur Tabi wrote:
> On 02/03/2013 01:39 PM, Stef van Os wrote:
>
>> + pci0: pci@fe0008000 {
>> + status = "disabled";
>> + };
>> +
>> + pci1: pci@fe0009000 {
>> + status = "disabled";
>> + };
>> +
>> + pci2: pcie@fe000a000 {
>> + status = "disabled";
>> + };
>
> I was hoping you'd follow my example and include a comment indicating why the
> PCI devices are all disabled.
>
>> +static void ppa8548_show_cpuinfo(struct seq_file *m)
>> +{
>> + uint svid, phid1;
>
> Please don't used unsized integers for hardware registers.
>
> uint32_t svid, phid1;
Stef,
If you'd like this included for 3.9, please make the minor updates.
thanks
- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
