Re: [PATCH 1/3] arch/powerpc: Add kmalloc NULL tests

2009-08-06 Thread Julia Lawall
On Fri, 7 Aug 2009, Daniel K. wrote: > Julia Lawall wrote: > > --- a/arch/powerpc/sysdev/fsl_rio.c > > +++ b/arch/powerpc/sysdev/fsl_rio.c > > @@ -1057,6 +1057,10 @@ int fsl_rio_setup(struct of_device *dev) > > law_start, law_size); > > > > ops = kmalloc(sizeof(struct rio_ops), GFP_KERNE

[PATCH v3 2/2] 82xx, mgcoge: update defconfig for 2.6.32

2009-08-06 Thread Heiko Schocher
- add I2C support - add FCC1 and FCC2 support Signed-off-by: Heiko Schocher --- - against git://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git next branch - checked with checkpatch.pl: $ ./scripts/checkpatch.pl 0001-82xx-mgcoge-update-defconfig-for-2.6.32.patch total: 0 errors, 0 war

Re: [PATCH v2 2/2] 82xx, mgcoge: update defconfig for 2.6.32

2009-08-06 Thread Heiko Schocher
Hello Kumar, Kumar Gala wrote: > On Aug 3, 2009, at 2:35 AM, Heiko Schocher wrote: > >> - add I2C support >> - add FCC1 and FCC2 support >> >> Signed-off-by: Heiko Schocher >> --- >> - against git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git >> next branch >> - checked with checkp

Re: 2.6.31-rc5-git2 crash [net/core/flow.c:flow_cache_new_hashrnd]

2009-08-06 Thread Tony Breeds
On Fri, Aug 07, 2009 at 01:13:54PM +1000, Benjamin Herrenschmidt wrote: > I think Tony did yes. Not sure what's the status with the "enterprise" > distros. It's fixed in F11 and F12 (thanks to dwmw2), it's in my for-1.3.15 branch for yaboot. We're working on updateing the version in the enterpr

Re: 2.6.31-rc5-git2 crash [net/core/flow.c:flow_cache_new_hashrnd]

2009-08-06 Thread Benjamin Herrenschmidt
On Thu, 2009-08-06 at 22:54 -0400, Josh Boyer wrote: > On Fri, Aug 07, 2009 at 08:23:05AM +1000, Benjamin Herrenschmidt wrote: > >On Wed, 2009-08-05 at 00:15 +1000, Michael Ellerman wrote: > > > >> > c060 1010 .long 0x1010 > >> > 0:mon> > >> > c064 0008 .

Please pull from 'next' branch

2009-08-06 Thread Kumar Gala
Please pull from 'next' branch of master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git next to receive the following updates: arch/powerpc/boot/dts/gef_sbc310.dts | 64 +++- arch/powerpc/boot/dts/mgcoge.dts | 53 +++ arch/powerpc/boot/dts/mpc8377_rdb.dts |

Re: 2.6.31-rc5-git2 crash [net/core/flow.c:flow_cache_new_hashrnd]

2009-08-06 Thread Josh Boyer
On Fri, Aug 07, 2009 at 08:23:05AM +1000, Benjamin Herrenschmidt wrote: >On Wed, 2009-08-05 at 00:15 +1000, Michael Ellerman wrote: > >> > c060 1010 .long 0x1010 >> > 0:mon> >> > c064 0008 .long 0x8 >> > c068 1013 .long 0x1013 >> > c

Re: [PATCH v2] powerpc/86xx: Update GE Fanuc sbc310 DTS

2009-08-06 Thread Kumar Gala
On Aug 6, 2009, at 9:38 PM, Kumar Gala wrote: On Jul 30, 2009, at 3:13 AM, Martyn Welch wrote: Update GE Fanuc DTS to match the alterations suggested during the merge of the ppc9a DTS in commit 740d36ae6344f38c4da64c2ede765d7d2dd1f132 Signed-off-by: Martyn Welch --- v2: Fixed run on mes

Re: [PATCH] powerpc/86xx: Enable XMC site on GE Fanuc SBC310

2009-08-06 Thread Kumar Gala
On Jun 30, 2009, at 9:32 AM, Martyn Welch wrote: This patch enables the XMC (PCIe daughter card) site on the SBC310. STG enter the description for the patch above. Signed-off-by: Martyn Welch --- arch/powerpc/boot/dts/gef_sbc310.dts | 37 + + 1 files change

Re: [PATCH] powerpc/86xx: Correct reading of information presented in cpuinfo

2009-08-06 Thread Kumar Gala
On Jun 30, 2009, at 9:32 AM, Martyn Welch wrote: /proc/cpuinfo should be showing the boards revision and the revision of the FPGA fitted. The functions currently used to access this information as incorrect. Additionally the VME geographical address of the PPC9A and it's status as system

Re: [PATCH] powerpc/85xx: Add support for I2C EEPROMs on MPC8548CDS boards

2009-08-06 Thread Kumar Gala
On Jul 9, 2009, at 1:36 PM, Anton Vorontsov wrote: This patch simply adds four eeprom nodes to MPC8548CDS' device tree. Signed-off-by: Anton Vorontsov --- arch/powerpc/boot/dts/mpc8548cds.dts | 20 1 files changed, 20 insertions(+), 0 deletions(-) applied to next. -

Re: [PATCH 1/2] powerpc/83xx: Add support for MPC8377E-WLAN boards

2009-08-06 Thread Kumar Gala
On Jul 24, 2009, at 4:42 PM, Anton Vorontsov wrote: MPC8377E-WLAN are basically RDB boards except: - RAM extended to 512 MB; - NAND flash removed, NOR flash extended to 64 MB; - Vitesse VSC7385 5-port switch removed, RTL8211B PHY added; - Power management MCU removed; - PCI slot removed, anoth

Re: [PATCH 2/2] powerpc/83xx: Add eSDHC support for MPC837xE-RDB/WLAN boards

2009-08-06 Thread Kumar Gala
On Jul 24, 2009, at 4:42 PM, Anton Vorontsov wrote: Actually, the support is already there, but it requires newer U-Boots (to fill-in clock-frequency, and setup pin multiplexing). Though, it appears that on RDB boards USBB pins aren't multiplexed between USB and eSDHC (unlike MDS boards, where

Re: [PATCH v2] powerpc/86xx: Update GE Fanuc sbc310 DTS

2009-08-06 Thread Kumar Gala
On Jul 30, 2009, at 3:13 AM, Martyn Welch wrote: Update GE Fanuc DTS to match the alterations suggested during the merge of the ppc9a DTS in commit 740d36ae6344f38c4da64c2ede765d7d2dd1f132 Signed-off-by: Martyn Welch --- v2: Fixed run on message. Kumar: I think the problem may be that thi

Re: [PATCH v2 1/2] 82xx, mgcoge: updates for 2.6.32

2009-08-06 Thread Kumar Gala
On Aug 3, 2009, at 2:34 AM, Heiko Schocher wrote: [PATCH v2 1/2] 82xx, mgcoge: updates for 2.6.32 - add I2C support - add FCC1 and FCC2 support - fix bogus gpio numbering in plattformcode Signed-off-by: Heiko Schocher --- - against git://git.kernel.org/pub/scm/linux/kernel/git/benh/ powerpc

Re: [PATCH v2 2/2] 82xx, mgcoge: update defconfig for 2.6.32

2009-08-06 Thread Kumar Gala
On Aug 3, 2009, at 2:35 AM, Heiko Schocher wrote: - add I2C support - add FCC1 and FCC2 support Signed-off-by: Heiko Schocher --- - against git://git.kernel.org/pub/scm/linux/kernel/git/benh/ powerpc.git next branch - checked with checkpatch.pl: $ ./scripts/checkpatch.pl 0002-82xx-mgcoge-u

Re: [PATCH 1/10] arch/powerpc/sysdev/qe_lib: introduce missing kfree

2009-08-06 Thread Kumar Gala
On Aug 1, 2009, at 3:52 AM, Julia Lawall wrote: From: Julia Lawall Error handling code following a kzalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; statement S; exp

Re: [PATCH] powerpc/ipic: unmask all interrupt sources

2009-08-06 Thread Kumar Gala
On Aug 5, 2009, at 2:41 PM, Sebastian Andrzej Siewior wrote: in case the interrupt controller was used in an earlier life then it is possible it is that some of its sources were used and are still unmask. If the (unmasked) device is active and is creating interrupts (or one interrupts was p

Re: [patch 2/3] powerpc/fsl-booke: read buffer overflow

2009-08-06 Thread Kumar Gala
On Aug 6, 2009, at 6:00 PM, a...@linux-foundation.org wrote: From: Roel Kluin cam[tlbcam_index] is checked before tlbcam_index < ARRAY_SIZE(cam) Signed-off-by: Roel Kluin Signed-off-by: Andrew Morton --- arch/powerpc/mm/fsl_booke_mmu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH 1/3] arch/powerpc: Add kmalloc NULL tests

2009-08-06 Thread Kumar Gala
On Aug 6, 2009, at 3:04 PM, Julia Lawall wrote: From: Julia Lawall Check that the result of kmalloc/kzalloc is not NULL before dereferencing it. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression *x; identifier f; constant char *C; @@

Re: [PATCH 2/10] arch/powerpc: introduce missing kfree

2009-08-06 Thread Kumar Gala
On Aug 2, 2009, at 3:44 AM, Julia Lawall wrote: From: Julia Lawall Error handling code following a kzalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; statement S; exp

[PATCH] powerpc/85xx: Added 36-bit physical device tree for mpc8572ds board

2009-08-06 Thread Kumar Gala
Added a device tree that should be similiar to mpc8536ds.dtb except the physical addresses for all IO are above the 4G boundary. Signed-off-by: Kumar Gala --- arch/powerpc/boot/dts/mpc8536ds_36b.dts | 467 +++ 1 files changed, 467 insertions(+), 0 deletions(-) creat

[PATCH] powerpc/85xx: Move mpc8536ds.dts to address-cells/size-cells = <2>

2009-08-06 Thread Kumar Gala
Change the top-level #address-cells and #size-cells to <2> so the mpc8536ds.dts is easier to deal with both a true 32-bit physical or 36-bit physical address space. Signed-off-by: Kumar Gala --- arch/powerpc/boot/dts/mpc8536ds.dts | 32 1 files changed, 16 inse

Re: [PATCH 0/3] cpu: idle state framework for offline CPUs.

2009-08-06 Thread Shaohua Li
On Thu, Aug 06, 2009 at 09:48:44PM +0800, Gautham R Shenoy wrote: > Hi Shaohua, > > On Thu, Aug 06, 2009 at 09:58:55AM +0800, Shaohua Li wrote: > > Hi, > > > > On Wed, Aug 05, 2009 at 10:25:53PM +0800, Gautham R Shenoy wrote: > > > In this patch-series, we propose to extend the CPU-Hotplug infras

Re: [PATCH][powerpc/85xx] P2020RDB Platform Support Added

2009-08-06 Thread Sean MacLennan
On Thu, 6 Aug 2009 17:04:18 +0530 "Aggrwal Poonam-B10812" wrote: > Can u point me to some reference of this, shud they be partit...@0, > partit...@1, etc... > I am not able to configure all the partitions successfully. Not unless all your partitions are 1 byte long ;) The number is the offset i

[patch 3/3] powerpc: avoid calculating possibly-invalid address

2009-08-06 Thread akpm
From: Roel Kluin Check whether index is within bounds prior to calculating a possibly-invalid address. Signed-off-by: Roel Kluin Cc: Bernd Petrovitsch Cc: Benjamin Herrenschmidt Signed-off-by: Andrew Morton --- drivers/char/hvsi.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[patch 1/3] powerpc: Sky CPU: redundant or incorrect tests on unsigned

2009-08-06 Thread akpm
From: Roel Kluin count is unsigned and cannot be less than 0. Signed-off-by: Roel Kluin Cc: Cyrill Gorcunov Cc: Benjamin Herrenschmidt Cc: Kumar Gala Cc: Brian Waite Signed-off-by: Andrew Morton --- drivers/misc/hdpuftrs/hdpu_cpustate.c |5 - 1 file changed, 5 deletions(-) diff

[patch 2/3] powerpc/fsl-booke: read buffer overflow

2009-08-06 Thread akpm
From: Roel Kluin cam[tlbcam_index] is checked before tlbcam_index < ARRAY_SIZE(cam) Signed-off-by: Roel Kluin Signed-off-by: Andrew Morton --- arch/powerpc/mm/fsl_booke_mmu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN arch/powerpc/mm/fsl_booke_mmu.c~powerpc-fsl-book

Re: 2.6.31-rc5-git2 crash [net/core/flow.c:flow_cache_new_hashrnd]

2009-08-06 Thread Benjamin Herrenschmidt
On Wed, 2009-08-05 at 00:15 +1000, Michael Ellerman wrote: > > c060 1010 .long 0x1010 > > 0:mon> > > c064 0008 .long 0x8 > > c068 1013 .long 0x1013 > > c06c 000f .long 0xf > > c0600010 7961626f rl

Re: 2.6.31-rc5-git2 crash on a idle system.

2009-08-06 Thread Benjamin Herrenschmidt
On Thu, 2009-08-06 at 19:03 +0530, Sachin Sant wrote: > I added few printks in the initcall debug code patch. The o/p suggests > that by the time first initicall debug message is printed the code is > already corrupted. Further debug suggests, when start_kernel() is > called the code at address(0xc

[PATCH 1/3] arch/powerpc: Add kmalloc NULL tests

2009-08-06 Thread Julia Lawall
From: Julia Lawall Check that the result of kmalloc/kzalloc is not NULL before dereferencing it. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression *x; identifier f; constant char *C; @@ x = \(kmalloc\|kcalloc\|kzalloc\)(...); ... when != x

Re: MPC8313 performance evaluation

2009-08-06 Thread Kumar Gala
On Aug 6, 2009, at 1:00 PM, Lutz Jaenicke wrote: Hi! I am currently evaluating the performance of the MPC8313E for firewall (and VPN) purposes. The results obtained do not match my expectations so I would be interested in some discussion. Test setup: --- A linux 2.6.27 based firewa

MPC8313 performance evaluation

2009-08-06 Thread Lutz Jaenicke
Hi! I am currently evaluating the performance of the MPC8313E for firewall (and VPN) purposes. The results obtained do not match my expectations so I would be interested in some discussion. Test setup: --- A linux 2.6.27 based firewall software is used. The software is the same among To b

Re: PowerPC kernel linux-2.6.29.6 crashes at mm/slab.c for ipsec application

2009-08-06 Thread srikanth krishnakar
Yes, You are right. CONFIG_PREEMPT is enabled in the kernel config. Attached is the config. Thanks -Srikanth On Thu, Aug 6, 2009 at 7:56 PM, Josh Boyer wrote: > On Thu, Aug 06, 2009 at 06:46:26PM +0530, srikanth krishnakar wrote: > >Hi all, > > > >Here is kernel bug for linux-2.6.29.6 for Pow

need help getting SPI controller working on 405EX

2009-08-06 Thread Nathan French
Hi, I am trying to add support for the 405EX's SPI controller on a Kilauea board. I've added the below to the device tree (under plb/opb/): [nfre...@nfrench-laptop linux-2.6-denx]$ diff -C2 arch/powerpc/boot/dts/kilauea.dts spi.dts *** arch/powerpc/boot/dts/kilauea.dts 2009-05-05 15:56:16.000

Re: kexec on e300 core / mpc5121

2009-08-06 Thread Scott Wood
On Thu, Aug 06, 2009 at 02:20:50AM +0200, Kenneth Johansson wrote: > > > Before you turn off the cache you need to flush out all dirty data. best > > > done by simply reading in 32kb of crap from somewhere. otherwise you are > > > sure to loose at least the stack and you do not want that. > > > >

Re: [PATCH 0/3] cpu: idle state framework for offline CPUs.

2009-08-06 Thread Peter Zijlstra
On Thu, 2009-08-06 at 10:03 +0530, Vaidyanathan Srinivasan wrote: > This was the > main objection to Venki's deepest sleep state for offline cpus patch. Well, my main objection was that is was a single raw function pointer without any management layer around it. We have the exact same mess with t

Re: [PATCH 0/3] cpu: idle state framework for offline CPUs.

2009-08-06 Thread Peter Zijlstra
On Thu, 2009-08-06 at 17:03 +0200, Peter Zijlstra wrote: > On Thu, 2009-08-06 at 10:03 +0530, Vaidyanathan Srinivasan wrote: > > This was the > > main objection to Venki's deepest sleep state for offline cpus patch. > > Well, my main objection was that is was a single raw function pointer > withou

Re: ftrace scripts and make V=1

2009-08-06 Thread Steven Rostedt
On Thu, 6 Aug 2009, Ingo Molnar wrote: > > diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl > > index d29baa2..4889c44 100755 > > --- a/scripts/recordmcount.pl > > +++ b/scripts/recordmcount.pl > > @@ -414,7 +414,10 @@ while () { > > $offset = hex $1; > > } else { > >

Re: PowerPC kernel linux-2.6.29.6 crashes at mm/slab.c for ipsec application

2009-08-06 Thread Josh Boyer
On Thu, Aug 06, 2009 at 06:46:26PM +0530, srikanth krishnakar wrote: >Hi all, > >Here is kernel bug for linux-2.6.29.6 for PowerPC (ppc440) target, while >running ipsec application it is observed that kernel oops'es oftenly as show >below : > >r...@powerpc:~# ./ipsec >[ cut here ]--

Re: [PATCH] Do not inline putprops function

2009-08-06 Thread Michael Ellerman
On Wed, 2009-08-05 at 22:19 +0530, M. Mohan Kumar wrote: > Hi, > > When I align the dtstruct variable to 8 bytes, I am able to invoke kdump. > > When the line > static unsigned dtstruct[TREEWORDS], *dt; > changed to > static unsigned dtstruct[TREEWORDS] __attribute__ ((aligned (8))),

Re: AW: Kernel fault with simple UIO interrupt driver in 2.6.30.4

2009-08-06 Thread Michael Ellerman
On Tue, 2009-08-04 at 09:23 +0200, Frank Prepelica wrote: > Oh okay, I didnt think anybody would need it :) > IRQ 20/IRQ3 Kernel Driver: IRQF_DISABLED is not guaranteed on shared IRQs > Unable to handle kernel paging request for instruction fetch > Faulting instruction address: 0x > Oops:

Re: kexec on e300 core / mpc5121

2009-08-06 Thread Kumar Gala
On Aug 5, 2009, at 5:49 PM, Kenneth Johansson wrote: On Wed, 2009-08-05 at 01:06 +0200, Sebastian Andrzej Siewior wrote: I've tried kexec on e300 core which should be easy since it is possible to disable the MMU on that core. However it does not work. Is it not possible to disable the mmu

PowerPC kernel linux-2.6.29.6 crashes at mm/slab.c for ipsec application

2009-08-06 Thread srikanth krishnakar
Hi all, Here is kernel bug for linux-2.6.29.6 for PowerPC (ppc440) target, while running ipsec application it is observed that kernel oops'es oftenly as show below : r...@powerpc:~# ./ipsec [ cut here ] kernel BUG at mm/slab.c:3002! Oops: Exception in kernel mode, sig: 5 [

Re: [PATCH 0/3] cpu: idle state framework for offline CPUs.

2009-08-06 Thread Gautham R Shenoy
Hi Shaohua, On Thu, Aug 06, 2009 at 09:58:55AM +0800, Shaohua Li wrote: > Hi, > > On Wed, Aug 05, 2009 at 10:25:53PM +0800, Gautham R Shenoy wrote: > > In this patch-series, we propose to extend the CPU-Hotplug infrastructure > > and allow the system administrator to choose the desired state the

Re: 2.6.31-rc5-git2 crash on a idle system.

2009-08-06 Thread Michael Ellerman
On Thu, 2009-08-06 at 19:03 +0530, Sachin Sant wrote: > Benjamin Herrenschmidt wrote: > > Thanks. Since it's a memory corruption (or seems to be) however, it's > > possible that the bisection will mislead you. IE. The culprit could be > > somewhere else, and the commit you'll find via bisection jus

Re: 2.6.31-rc5-git2 crash on a idle system.

2009-08-06 Thread Sachin Sant
Benjamin Herrenschmidt wrote: Thanks. Since it's a memory corruption (or seems to be) however, it's possible that the bisection will mislead you. IE. The culprit could be somewhere else, and the commit you'll find via bisection just happens to move things around in the kernel in such a way that t

Re: [PATCH] powerpc/perfctr: Check oprofile_cpu_type for NULL before using it

2009-08-06 Thread Benjamin Herrenschmidt
On Thu, 2009-08-06 at 21:03 +1000, Michael Ellerman wrote: > > Typing it seven times didn't make you think "how about a helper?" :) Copy/paste works fine :-) Seriously, I did think about it, but a couple of cases test more than one string so a totally trivial helper wouldn't do and I couldn't be

RE: [PATCH][powerpc/85xx] P2020RDB Platform Support Added

2009-08-06 Thread Aggrwal Poonam-B10812
> -Original Message- > From: > linuxppc-dev-bounces+poonam.aggrwal=freescale@lists.ozlabs > .org > [mailto:linuxppc-dev-bounces+poonam.aggrwal=freescale@list s.ozlabs.org] On Behalf Of Felix Radensky > Sent: Thursday, August 06, 2009 12:16 PM > To: Aggrwal Poonam-B10812 > Cc: l

Re: [PATCH] powerpc/perfctr: Check oprofile_cpu_type for NULL before using it

2009-08-06 Thread Michael Ellerman
On Thu, 2009-08-06 at 14:02 +1000, Benjamin Herrenschmidt wrote: > If the current CPU doesn't support performance counters, > cur_cpu_spec->oprofile_cpu_type can be NULL. The current > perfctr modules don't test for that case and would thus > crash. > + if (!cur_cpu_spec->oprofile_cpu_type ||

uio driver cannot be registered to uio subsystem

2009-08-06 Thread Frank Prepelica
Hi everbody, I've got an custom uio interrupt driver. The driver will be registered as platfrom driver. static int __init uio_irq3_init(void) { return platform_driver_register(&uio_irq3_driver); } After starting the kernel the driver is registered under /sys/bus/platform/drivers. (I guess thi

Re: kexec on e300 core / mpc5121

2009-08-06 Thread Sebastian Andrzej Siewior
* Kenneth Johansson | 2009-08-06 02:20:50 [+0200]: >> > Is it not possible to disable the mmu on all cpu's that have one ?? >> >> No, on e500 for example it is always on. You can use large pages with >> identity maps to make it seem like it's off, though. > >why do something like that ? on e50

RE: [PATCH][powerpc/85xx] P2020RDB Platform Support Added

2009-08-06 Thread Aggrwal Poonam-B10812
> -Original Message- > From: > linuxppc-dev-bounces+poonam.aggrwal=freescale@lists.ozlabs > .org > [mailto:linuxppc-dev-bounces+poonam.aggrwal=freescale@list > s.ozlabs.org] On Behalf Of Felix Radensky > Sent: Thursday, August 06, 2009 12:16 PM > To: Aggrwal Poonam-B10812 > Cc: