[BUGFIX PATCH] USB: chipidea: fix use after free bug

The pointer to a platform_device struct must not be dereferenced after the device has been unregistered. This bug produces a crash when unloading the ci13xxx kernel module compiled with CONFIG_PAGE_POISONING enabled. Signed-off-by: Lothar Waßmann --- drivers/usb/chipidea/core.c |3 ++- 1

[PATCH] USB: chipidea: promote error code from ci_role_start() start instead of returning -ENODEV

Signed-off-by: Lothar Waßmann --- drivers/usb/chipidea/core.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index b726c49..bd6e7a4 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c

Re: [PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

c-mx51". I personally hate the '!strcmp()' notation and prefer 'strcmp() == 0' though they are technically equivalent. Using '==' makes it much clearer to the reader what is intended. !strcmp() lets one assume that it is true when the comparison fails, though actually

Re: [PATCH 00/44] usb: don't print on ENOMEM

mation in that > case. If the message was specific (e.g. "can't save CLEAR_TT_BUFFER state"), I > left it. This series saves ~4.5KB of "out of memory" permutations in .text and > .rodata. For modified lines, (x == NULL) was replaced with (!NULL) as well. s/!NULL/!x/

[PATCH 3/4] usb: chipidea: don't clobber return value of ci_role_start()

Signed-off-by: Lothar Waßmann --- drivers/usb/chipidea/core.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index a5df24c..38b0a7a 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c

[PATCH 2/4] usb: chipidea: ci_hdrc_imx: remove an unsolicited module_put() call from ci_hdrc_imx_remove()

This prevents the USB PHY refcount to be decremented below zero upon unloading the ci-hdrc-imx module. Signed-off-by: Lothar Waßmann --- drivers/usb/chipidea/ci_hdrc_imx.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers

[PATCH 1/4] usb: chipidea: improve kconfig 2.0

wback, that USB_CHIPIDEA could be chosen as 'y' though USB_EHCI_HCD or USB_GADGET (or both) were 'm' leading to a situation where USB_CHIPIDEA_HOST or USB_CHIPIDEA_UDC vanished from the config options producing a compilable but dysfunctional driver. Signed-off-by: Lothar

[PATCH 4/4] usb: chipidea: Prevent endless loop registering platform_devices when ci_hdrc_probe() fails.

... ad nauseam. Signed-off-by: Lothar Waßmann --- drivers/usb/chipidea/core.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 38b0a7a..c5aad81 100644 --- a/drivers/usb/chipidea/core.c +++ b/driv

Re: [PATCH 2/4] usb: chipidea: ci_hdrc_imx: remove an unsolicited module_put() call from ci_hdrc_imx_remove()

Hi, Peter Chen writes: > On Wed, Jul 31, 2013 at 04:21:14PM +0200, Lothar Waßmann wrote: > > This prevents the USB PHY refcount to be decremented below zero upon > > unloading the ci-hdrc-imx module. > > > > Signed-off-by: Lothar Waßmann > > --- > > dr

Re: [PATCH 3/4] usb: chipidea: don't clobber return value of ci_role_start()

Hi, Peter Chen writes: > On Wed, Jul 31, 2013 at 04:21:15PM +0200, Lothar Waßmann wrote: > > > > Signed-off-by: Lothar Waßmann > > --- > > drivers/usb/chipidea/core.c |1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --gi

Re: [PATCH 4/4] usb: chipidea: Prevent endless loop registering platform_devices when ci_hdrc_probe() fails.

Hi, Peter Chen writes: > On Wed, Jul 31, 2013 at 04:21:16PM +0200, Lothar Waßmann wrote: > > commit 40dcd0e introduced the following code to the ci_hdrc_probe() > > function: > > > > + if (!dev->of_node && dev->parent) > > + dev

Re: [PATCH 3/4] usb: chipidea: don't clobber return value of ci_role_start()

Peter Chen writes: > On Thu, Aug 01, 2013 at 10:40:42AM +0200, Lothar Waßmann wrote: > > Hi, > > > > Peter Chen writes: > > > On Wed, Jul 31, 2013 at 04:21:15PM +0200, Lothar Waßmann wrote: > > > > > > > > Signed-off-by: Lothar Waßmann &

Re: [PATCH 01/11] usb: chipidea: Add power management support

sting/assinging a simple integer. Note that just because the function has 'atomic' in its name the sequence: atomic_read(); ... atomic_set(); does not magically become an atomic operation. Lothar Waßmann -- ___ Ka-

Re: [Patch v2 08/10] usb: chipidea: host: add quirk for ehci operation

ut within 3ms after resume ends, then the > + * device will enter suspend again. > + */ > + if (hcd->self.root_hub->do_remote_wakeup) { > + ehci_dbg(ehci, > + "Remote wakeu

Re: [PATCH v6 01/15] usb: doc: phy-mxs: Add more compatible strings

phy.txt > @@ -1,7 +1,8 @@ > * Freescale MXS USB Phy Device > > Required properties: > -- compatible: Should be "fsl,imx23-usbphy" > +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q-usbphy" > +for imx6dq and imx6dl, "fsl,imx6sl-usbphy

Re: [PATCH v6 01/15] usb: doc: phy-mxs: Add more compatible strings

Hi, Peter Chen wrote: > On Fri, Dec 13, 2013 at 3:15 PM, Lothar Waßmann > wrote: > > Hi, > > > > Peter Chen wrote: > >> Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add > >> "fsl,imx6sl-usbphy" for imx6sl. > >> > >

Re: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.

data->phy = devm_usb_get_phy_by_phandle(&pdev->dev, "usb-phy", 0); > if (IS_ERR(data->phy)) { > ret = PTR_ERR(data->phy); > goto err_clk; > How about accepting the old property too and

Re: [PATCH 07/10] usb: chipidea: usbmisc_imx: add unburst setting for imx6

Hi, > With this setting and AHBBRST at SBUSCFG as "Incremental burst of > unspecified length", each unburst size can be taken as one single transfer. > It is benefit for unburst size transfer. > What is an '

Re: [PATCH 07/10] usb: chipidea: usbmisc_imx: add unburst setting for imx6

Hi, > On Wed, Jul 29, 2015 at 10:30:22AM +0200, Lothar Waßmann wrote: > > Hi, > > > > > With this setting and AHBBRST at SBUSCFG as "Incremental burst of > > > unspecified length", each unburst size can be taken as one single > > > tra

[PATCH 0/2] BUGFIX: usb: musb: dsps: fix the base address for accessing the mode register

The first patch cleans up the coding style of the register accessor functions which made my eyes sore. The second patch makes the function added in commit 943c13971c08 "usb: musb: dsps: implement ->set_mode()" actually functional by using the correct base address for the register accesses. -- To

[PATCH 2/2] usb: musb: dsps: fix the base address for accessing the mode register

ses different base addresses in different places to access the same register (phy_utmi). Signed-off-by: Lothar Waßmann --- drivers/usb/musb/musb_dsps.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c inde

[PATCH 1/2] usb: musb: dsps: coding style cleanup

There is no reason for the register accessor functions not to adhere to the CodingStyle rules. Signed-off-by: Lothar Waßmann --- drivers/usb/musb/musb_dsps.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb

[PATCH 3/9] usb: musb_am335x: source cleanup

produce a compile time error rather than an unreachable entry in the list. - consistently use tabs for indentation Signed-off-by: Lothar Waßmann --- drivers/usb/musb/musb_am335x.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/musb/musb_am335x.c b/drivers/usb

[PATCH 6/9] usb: musb: core: properly setup the HW before registering it to the USB core

Without this patch overriding the USBOTG_ID pin by setting the iddig bit in the USB_MODE register doesn't work because it happens too late to be recognized correctly. Signed-off-by: Lothar Waßmann --- drivers/usb/musb/musb_core.c | 12 +++- 1 file changed, 7 insertions(+), 5 dele

[PATCH 7/9] usb: phy: am335x: setup the gen_phy function pointers _before_ adding the phy

Make sure all parameters are correctly set up before registering the PHY with the USB framework. Signed-off-by: Lothar Waßmann --- drivers/usb/phy/phy-am335x.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy/phy-am335x.c

[PATCH 9/9] usb: musb: musb_am335x: reinstate module loading/unloading support

ag was still set, so that re-loading the module after an unload had no effect. This is also fixed in this patch. Signed-off-by: Lothar Waßmann --- drivers/usb/musb/musb_am335x.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/usb/musb/musb_am

[PATCH 1/9] usb: musb: core: cleanup - remove some useless 'break's from switch statements

Signed-off-by: Lothar Waßmann --- drivers/usb/musb/musb_core.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index b841ee0..8623112 100644 --- a/drivers/usb/musb/musb_core.c +++ b/drivers/usb/musb/musb_core.c @@ -680,7

[PATCH 2/9] usb: phy: am335x: group the #includes by subdirs

Signed-off-by: Lothar Waßmann --- drivers/usb/phy/phy-am335x.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy/phy-am335x.c index b70e055..91c71ab 100644 --- a/drivers/usb/phy/phy-am335x.c +++ b/drivers/usb/phy/phy

[PATCH 0/9] usb: musb: several bugfixes for the musb driver

The first three patches do some source code cleanup in the files that are modified in the subsequent patches. Patch 4 carries the proper fix reported in commit: 7adb5c876e9c ("usb: musb: Fix panic upon musb_am335x module removal") Patch 6 makes the USBOTG_ID pin override via the USB_MODE

[PATCH 5/9] usb: musb: print error message with dev_err() instead of dev_dbg()

Signed-off-by: Lothar Waßmann --- drivers/usb/musb/musb_core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 8623112..f867b44 100644 --- a/drivers/usb/musb/musb_core.c +++ b/drivers/usb/musb/musb_core.c

[PATCH 4/9] usb: phy: am335x-control: prevent module from being unloaded when in use

This patch fixes the real cause of the crash that was "fixed" by commit 7adb5c876e9c usb: musb: Fix panic upon musb_am335x module removal Signed-off-by: Lothar Waßmann --- drivers/usb/phy/phy-am335x-control.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/u

[PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown()

This patch makes it possible to use the musb driver with HW that requires external regulators or clocks. Signed-off-by: Lothar Waßmann --- drivers/usb/phy/phy-am335x.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy/phy-am335x.c index

Re: [PATCH 0/9] usb: musb: several bugfixes for the musb driver

Hi, Felipe Balbi wrote: > Hi, > > On Fri, Jul 18, 2014 at 01:16:36PM -0300, Ezequiel Garcia wrote: > > Hi Lothar, > > > > On 18 Jul 11:31 AM, Lothar Waßmann wrote: > > > The first three patches do some source code cleanup in the files that > >

Re: [PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown()

Hi, > On Fri, Jul 18, 2014 at 11:31:29AM +0200, Lothar Waßmann wrote: > > This patch makes it possible to use the musb driver with HW that > > requires external regulators or clocks. > > can you provide an example of such HW ? Are you not using the internal > PHYs ? >

Re: [PATCH 9/9] usb: musb: musb_am335x: reinstate module loading/unloading support

Hi, Felipe Balbi wrote: > On Fri, Jul 18, 2014 at 11:31:30AM +0200, Lothar Waßmann wrote: > > There is no need to throw the baby out with the bath due to a bad > > failure analysis. The commit: > > 7adb5c876e9c usb: musb: Fix panic upon musb_am335x module removal > >

Re: [PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown()

Hi, Felipe Balbi wrote: > Hi,, > > On Mon, Jul 21, 2014 at 10:03:07AM +0200, Lothar Waßmann wrote: > > Hi, > > > > > On Fri, Jul 18, 2014 at 11:31:29AM +0200, Lothar Waßmann wrote: > > > > This patch makes it possible to use the musb driver with HW th