[PATCH net-next 02/19] net: usb: aqc111: Add bind and empty unbind callbacks

From: Dmitry Bezrukov Initialize net_device_ops structure Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c

[PATCH net-next 01/19] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE

From: Dmitry Bezrukov Initialize usb_driver structure skeleton Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/Kconfig | 12 +++ drivers/net/usb/Makefile | 1 + drivers/net/usb/aqc111.c | 52 3 files

[PATCH net-next 00/19] Add support for Aquantia AQtion USB to 5/2.5GbE devices

This patchset introduces support for new multigig ethernet to USB dongle, developed jointly by Aquantia (Phy) and ASIX (USB MAC). The driver has similar structure with other ASIX MAC drivers (AX88179), but with a number of important differences: - Driver supports both direct Phy and custom firmwar

[PATCH net-next 08/19] net: usb: aqc111: Implement TX data path

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 73 drivers/net/usb/aqc111.h | 22 +++ 2 files changed, 95 insertions(+) diff --git a/drivers/net/usb/aqc111.c b

[PATCH net-next 17/19] net: usb: aqc111: Initialize ethtool_ops structure

From: Dmitry Bezrukov Implement get_drvinfo, set/get_msglevel, get_link callbacks Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers

[PATCH net-next 03/19] net: usb: aqc111: Add implementation of read and write commands

From: Dmitry Bezrukov Read/write command register defines and functions Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 124 +++ drivers/net/usb/aqc111.h | 19 2 files changed, 143 insertions

[PATCH net-next 07/19] net: usb: aqc111: Add support for getting and setting of MAC address

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 51 drivers/net/usb/aqc111.h | 1 + 2 files changed, 52 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb

[PATCH net-next 13/19] net: usb: aqc111: Add support for TSO

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 3 +++ drivers/net/usb/aqc111.h | 6 -- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index 6efd9a9ad44e

[PATCH net-next 16/19] net: usb: aqc111: Add RX VLAN filtering support

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 90 drivers/net/usb/aqc111.h | 2 +- 2 files changed, 91 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b

[PATCH net-next 06/19] net: usb: aqc111: Introduce link management

From: Dmitry Bezrukov Add full hardware initialization sequence and link configuration logic Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 330 +++ drivers/net/usb/aqc111.h | 51 2 files

[PATCH net-next 18/19] net: usb: aqc111: Implement get/set_link_ksettings callbacks

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 133 +++ 1 file changed, 133 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index ade2b60b4811

[PATCH net-next 19/19] net: usb: aqc111: Add support for wake on LAN by MAGIC packet

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 203 +++ drivers/net/usb/aqc111.h | 11 +++ 2 files changed, 214 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb

[PATCH net-next 05/19] net: usb: aqc111: Introduce PHY access

Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 93 drivers/net/usb/aqc111.h | 70 2 files changed, 163 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index

[PATCH net-next 15/19] net: usb: aqc111: Add support for VLAN_CTAG_TX/RX offload

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 14 ++ drivers/net/usb/aqc111.h | 7 ++- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index

[PATCH net-next 12/19] net: usb: aqc111: Add support for enable/disable checksum offload

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 45 - drivers/net/usb/aqc111.h | 1 + 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers

[PATCH net-next 09/19] net: usb: aqc111: Implement RX data path

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 100 +++ drivers/net/usb/aqc111.h | 39 ++ 2 files changed, 139 insertions(+) diff --git a/drivers/net/usb/aqc111.c b

[PATCH net-next 14/19] net: usb: aqc111: Implement set_rx_mode callback

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 72 drivers/net/usb/aqc111.h | 4 +++ 2 files changed, 71 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/aqc111.c b

[PATCH net-next 10/19] net: usb: aqc111: Add checksum offload support

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 38 ++ drivers/net/usb/aqc111.h | 23 +-- 2 files changed, 59 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb

[PATCH net-next 11/19] net: usb: aqc111: Add support for changing MTU

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 63 +++- 1 file changed, 62 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index

[PATCH net-next 04/19] net: usb: aqc111: Various callbacks implementation

From: Dmitry Bezrukov Reset, stop callbacks, driver unbind callback. More register defines required for these callbacks. Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 48 ++ drivers/net/usb/aqc111.h | 101

Re: [PATCH net-next 00/19] Add support for Aquantia AQtion USB to 5/2.5GbE devices

Hi Andrew, > Nice patch set, well broken up, easy to review. > Thanks a lot for your detailed review, your comments are really useful! I'll respond to some of your comments separately. Regards, Igor

Re: [PATCH net-next 05/19] net: usb: aqc111: Introduce PHY access

Hi Andrew, >> >> +struct aqc111_data *aqc111_data = (struct aqc111_data *)dev->data[0]; > > Having to do this cast all the time is quiet ugly. It seems like some > other usb_net drivers use netdev_priv(). As I see most of usb usbnet based devices use the same theme with accessing private d

Re: [PATCH net-next 06/19] net: usb: aqc111: Introduce link management

Hi Andrew, >> aqc111_read_fw_version(dev, aqc111_data); >> +aqc111_data->autoneg = AUTONEG_ENABLE; >> +aqc111_data->advertised_speed = (usb_speed == USB_SPEED_SUPER) ? >> + SPEED_5000 : SPEED_1000; > > USB 3 has a raw bandwidth of 5Gbps. But it is

Re: [PATCH net-next 06/19] net: usb: aqc111: Introduce link management

Hi Andrew, > Hi Igor, Dmitry > > Please could you explain why you decided to not use drivers/net/phy? > The previous patch introduced basically what you need to export a > standard Linux MDIO bus. From that you can use a standard Linux PHY > driver. Thats again because of this product has tight

Re: [PATCH net-next 08/19] net: usb: aqc111: Implement TX data path

>> +skb_push(skb, AQ_TX_HEADER_SIZE); >> +cpu_to_le64s(&tx_hdr); > > Is that portable? tx_hdr is a structure of 2x u32 bitfields. What > endian have you tested that one? > You are right, this is wrong for BE hardware. We don't have such a hardware to check unfortunately. Think its bet

Re: [PATCH net-next 14/19] net: usb: aqc111: Implement set_rx_mode callback

Hi Andrew, >> +{ >> +struct usbnet *dev = netdev_priv(net); >> +struct aqc111_data *aqc111_data = (struct aqc111_data *)dev->data[0]; > >> +u8 *m_filter = ((u8 *)dev->data) + 12; > > Please could you explain is. Oh, that was a legacy code, the idea is it used spare area in dev->data

Re: [PATCH net-next 19/19] net: usb: aqc111: Add support for wake on LAN by MAGIC packet

Hi Andrew, >> +if (aqc111_data->dpa) { >> +aqc111_set_phy_speed(dev, AUTONEG_DISABLE, SPEED_100); > > I don't think that works. You should leave AUTONEG on, but only > advertise SPEED_100 and trigger auto-neg. If you force it to 100, > there is no guarantee the pee

Re: [PATCH net-next 05/19] net: usb: aqc111: Introduce PHY access

Hi Andrew, + struct aqc111_data *aqc111_data = (struct aqc111_data *)dev->data[0]; >>> >>> Having to do this cast all the time is quiet ugly. It seems like some >>> other usb_net drivers use netdev_priv(). >> >> As I see most of usb usbnet based devices use the same theme with accessing >>

Re: [PATCH net-next 05/19] net: usb: aqc111: Introduce PHY access

Hi Oliver, >> +aqc111_read_cmd(dev, AQ_ACCESS_MAC, AQ_FW_VER_MAJOR, >> +1, 1, &aqc111_data->fw_ver.major); >> +aqc111_read_cmd(dev, AQ_ACCESS_MAC, AQ_FW_VER_MINOR, >> +1, 1, &aqc111_data->fw_ver.minor); >> +aqc111_read_cmd(dev, AQ_ACCESS_MAC, AQ_

Re: [PATCH net-next 00/19] Add support for Aquantia AQtion USB to 5/2.5GbE devices

On 08.10.2018 17:21, Oliver Neukum wrote: >> The code of this driver is based on original ASIX sources and was extended >> by Aquantia for 5G multigig support. > > Thank you for the driver. It is good to see drivers for cool hardware. > Unfortunately there have been a few issues I have tried t

Re: [PATCH net-next 07/19] net: usb: aqc111: Add support for getting and setting of MAC address

Hi Andrew, >> +if (ret < 0) >> +goto out; >> + >> +memcpy(dev->net->dev_addr, buf, ETH_ALEN); >> +memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN); > > Is this really the permanent address? If i call aqc111_set_mac_addr() > followed by aqc111_get_mac() i still get

Re: [PATCH net-next 05/19] net: usb: aqc111: Introduce PHY access

On 10.10.2018 03:58, Andrew Lunn wrote: > > I just discovered driver_priv. > > https://elixir.bootlin.com/linux/v4.19-rc7/source/include/linux/usb/usbnet.h#L33 > > It would be good to use that, to avoid the casts. Looks good to me, thanks. Regards, Igor

[PATCH v2 net-next 02/21] net: usb: aqc111: Add bind and empty unbind callbacks

From: Dmitry Bezrukov Initialize net_device_ops structure Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c

[PATCH v2 net-next 00/21] Add support for Aquantia AQtion USB to 5/2.5GbE devices

This patchset introduces support for new multigig ethernet to USB dongle, developed jointly by Aquantia (Phy) and ASIX (USB MAC). The driver has similar structure with other ASIX MAC drivers (AX88179), but with a number of important differences: - Driver supports both direct Phy and custom firmwar

[PATCH v2 net-next 03/21] net: usb: aqc111: Add implementation of read and write commands

From: Dmitry Bezrukov Read/write command register defines and functions Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 92 drivers/net/usb/aqc111.h | 18 ++ 2 files changed, 110 insertions

[PATCH v2 net-next 01/21] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE

From: Dmitry Bezrukov Initialize usb_driver structure skeleton Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/Kconfig | 12 drivers/net/usb/Makefile | 1 + drivers/net/usb/aqc111.c | 41 + 3 files changed

[PATCH v2 net-next 09/21] net: usb: aqc111: Implement RX data path

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 103 +++ drivers/net/usb/aqc111.h | 15 +++ 2 files changed, 118 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net

[PATCH v2 net-next 10/21] net: usb: aqc111: Add checksum offload support

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 38 ++ drivers/net/usb/aqc111.h | 16 ++-- 2 files changed, 52 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/aqc111.c

[PATCH v2 net-next 13/21] net: usb: aqc111: Add support for TSO

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 4 drivers/net/usb/aqc111.h | 8 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index

[PATCH v2 net-next 11/21] net: usb: aqc111: Add support for changing MTU

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 60 +++- 1 file changed, 59 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index

[PATCH v2 net-next 14/21] net: usb: aqc111: Implement set_rx_mode callback

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 72 drivers/net/usb/aqc111.h | 4 +++ 2 files changed, 71 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/aqc111.c b

[PATCH v2 net-next 21/21] net: usb: aqc111: Extend cdc_ether blacklist

From: Dmitry Bezrukov Added Aquantia and ASIX device IDs to prevent loading cdc_ether for these devices. Our firmware reports CDC configuration simultaneously with vendor specific. Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/cdc_ether.c | 23

[PATCH v2 net-next 04/21] net: usb: aqc111: Various callbacks implementation

From: Dmitry Bezrukov Reset, stop callbacks, driver unbind callback. More register defines required for these callbacks. Add helpers to read/write 16bit values Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 76

[PATCH v2 net-next 19/21] net: usb: aqc111: Add support for wake on LAN by MAGIC packet

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 215 +++ drivers/net/usb/aqc111.h | 12 +++ 2 files changed, 227 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb

[PATCH v2 net-next 16/21] net: usb: aqc111: Add RX VLAN filtering support

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 89 drivers/net/usb/aqc111.h | 2 +- 2 files changed, 90 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b

[PATCH v2 net-next 20/21] net: usb: aqc111: Add ASIX's HW ids

From: Dmitry Bezrukov It enables driver for ASIX products which are also based on aqc111/112U chips. Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers

[PATCH v2 net-next 05/21] net: usb: aqc111: Introduce PHY access

agreement. Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 109 +++ drivers/net/usb/aqc111.h | 44 +++ 2 files changed, 153 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net

[PATCH v2 net-next 17/21] net: usb: aqc111: Initialize ethtool_ops structure

From: Dmitry Bezrukov Implement get_drvinfo, set/get_msglevel, get_link callbacks Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net

[PATCH v2 net-next 06/21] net: usb: aqc111: Introduce link management

From: Dmitry Bezrukov Add full hardware initialization sequence and link configuration logic Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 312 +++ drivers/net/usb/aqc111.h | 45 +++ 2 files changed

[PATCH v2 net-next 15/21] net: usb: aqc111: Add support for VLAN_CTAG_TX/RX offload

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 17 + drivers/net/usb/aqc111.h | 12 +++- 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c

[PATCH v2 net-next 18/21] net: usb: aqc111: Implement get/set_link_ksettings callbacks

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 124 +++ 1 file changed, 124 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index b3160b0320eb

[PATCH v2 net-next 08/21] net: usb: aqc111: Implement TX data path

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 72 drivers/net/usb/aqc111.h | 8 ++ 2 files changed, 80 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net

[PATCH v2 net-next 07/21] net: usb: aqc111: Add support for getting and setting of MAC address

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 47 +++ drivers/net/usb/aqc111.h | 1 + 2 files changed, 48 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb

[PATCH v2 net-next 12/21] net: usb: aqc111: Add support for enable/disable checksum offload

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 45 - drivers/net/usb/aqc111.h | 1 + 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers

Re: [PATCH v2 net-next 06/21] net: usb: aqc111: Introduce link management

>> >> Add full hardware initialization sequence and link configuration logic > > Hi Igor > > I'm still not convinced the PHY driver should be embedded in the MAC > driver, rather than using phylink. > > If i remember correctly, it was because the MAC is involved in > determining if the link is u

Re: [PATCH v2 net-next 18/21] net: usb: aqc111: Implement get/set_link_ksettings callbacks

>> +if (usb_speed == USB_SPEED_SUPER) { >> +ethtool_link_ksettings_add_link_mode(elk, supported, >> + 2500baseT_Full); >> +ethtool_link_ksettings_add_link_mode(elk, supported, >> +

Re: [PATCH v2 net-next 19/21] net: usb: aqc111: Add support for wake on LAN by MAGIC packet

>> + >> +if (aqc111_data->dpa) { >> +aqc111_set_phy_speed(dev, AUTONEG_ENABLE, SPEED_100); > > So this is better, you leave auto-neg enabled. But you really should > be taking the link partners capabilities into account. We've considered that, but then thought abo

Re: [PATCH v2 net-next 06/21] net: usb: aqc111: Introduce link management

Hi Andrew, Florian, >>> >>> So the point is that MAC firmware is managing SERDES and system interface >>> link. >> >> Linux can manage that SERDES link between the MAC and the PHY. There >> are two ways this can go: >> >> 1) You use phylib. When the PHY reports link, the adjust_link callback >>

[PATCH v3 net-next 02/21] net: usb: aqc111: Add bind and empty unbind callbacks

From: Dmitry Bezrukov Initialize net_device_ops structure Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c

[PATCH v3 net-next 03/21] net: usb: aqc111: Add implementation of read and write commands

From: Dmitry Bezrukov Read/write command register defines and functions Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 92 drivers/net/usb/aqc111.h | 18 2 files changed, 110 insertions(+) create

[PATCH v3 net-next 01/21] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE

From: Dmitry Bezrukov Initialize usb_driver structure skeleton Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/Kconfig | 12 ++ drivers/net/usb/Makefile | 1 + drivers/net/usb/aqc111.c | 48 3 files changed

[PATCH v3 net-next 00/21] Add support for Aquantia AQtion USB to 5/2.5GbE devices

This patchset introduces support for new multigig ethernet to USB dongle, developed jointly by Aquantia (Phy) and ASIX (USB MAC). The driver has similar structure with other ASIX MAC drivers (AX88179), but with a number of important differences: - Driver supports both direct Phy and custom firmwar

[PATCH v3 net-next 21/21] net: usb: aqc111: Extend cdc_ether blacklist

From: Dmitry Bezrukov Added Aquantia and ASIX device IDs to prevent loading cdc_ether for these devices. Our firmware reports CDC configuration simultaneously with vendor specific. Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/cdc_ether.c | 26

[PATCH v3 net-next 06/21] net: usb: aqc111: Introduce link management

From: Dmitry Bezrukov Add full hardware initialization sequence and link configuration logic Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 235 +++ drivers/net/usb/aqc111.h | 13 +++ 2 files changed, 248

[PATCH v3 net-next 04/21] net: usb: aqc111: Various callbacks implementation

From: Dmitry Bezrukov Reset, stop callbacks, driver unbind callback. More register defines required for these callbacks. Add helpers to read/write 16bit values Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 76

[PATCH v3 net-next 18/21] net: usb: aqc111: Implement get/set_link_ksettings callbacks

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 124 +++ 1 file changed, 124 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index 2028db453df9..d96f8d4fb7a0

[PATCH v3 net-next 14/21] net: usb: aqc111: Implement set_rx_mode callback

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 72 +--- drivers/net/usb/aqc111.h | 4 +++ 2 files changed, 71 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/aqc111.c b/drivers

[PATCH v3 net-next 19/21] net: usb: aqc111: Add support for wake on LAN by MAGIC packet

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 180 +++ drivers/net/usb/aqc111.h | 12 +++ 2 files changed, 192 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111

[PATCH v3 net-next 16/21] net: usb: aqc111: Add RX VLAN filtering support

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 89 drivers/net/usb/aqc111.h | 2 +- 2 files changed, 90 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net

[PATCH v3 net-next 07/21] net: usb: aqc111: Add support for getting and setting of MAC address

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 47 drivers/net/usb/aqc111.h | 1 + 2 files changed, 48 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c

[PATCH v3 net-next 13/21] net: usb: aqc111: Add support for TSO

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 4 drivers/net/usb/aqc111.h | 8 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index

[PATCH v3 net-next 08/21] net: usb: aqc111: Implement TX data path

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 72 drivers/net/usb/aqc111.h | 8 + 2 files changed, 80 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111

[PATCH v3 net-next 09/21] net: usb: aqc111: Implement RX data path

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 103 +++ drivers/net/usb/aqc111.h | 15 ++ 2 files changed, 118 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb

[PATCH v3 net-next 05/21] net: usb: aqc111: Introduce PHY access

From: Dmitry Bezrukov Add helpers to write 32bit values. Implement PHY power up/down sequences. AQC111, PHY is being controlled via vendor command interface. Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 65

[PATCH v3 net-next 10/21] net: usb: aqc111: Add checksum offload support

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 38 ++ drivers/net/usb/aqc111.h | 16 ++-- 2 files changed, 52 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/aqc111.c

[PATCH v3 net-next 11/21] net: usb: aqc111: Add support for changing MTU

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 60 +++- 1 file changed, 59 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index 2a322391896c

[PATCH v3 net-next 15/21] net: usb: aqc111: Add support for VLAN_CTAG_TX/RX offload

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 17 + drivers/net/usb/aqc111.h | 12 +++- 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c

[PATCH v3 net-next 17/21] net: usb: aqc111: Initialize ethtool_ops structure

From: Dmitry Bezrukov Implement get_drvinfo, set/get_msglevel, get_link callbacks Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net

[PATCH v3 net-next 20/21] net: usb: aqc111: Add ASIX's HW ids

From: Dmitry Bezrukov It enables driver for ASIX products which are also based on aqc111/112U chips. Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers

[PATCH v3 net-next 12/21] net: usb: aqc111: Add support for enable/disable checksum offload

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 45 +++- drivers/net/usb/aqc111.h | 1 + 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net

Re: [PATCH v3 net-next 13/21] net: usb: aqc111: Add support for TSO

Hi David, On 22.11.2018 22:17, David Miller wrote: > From: Igor Russkikh > Date: Wed, 21 Nov 2018 10:13:48 + > >> @@ -832,6 +832,10 @@ static struct sk_buff *aqc111_tx_fixup(struct usbnet >> *dev, struct sk_buff *skb, >> /*Length of actual data*/

[PATCH v4 net-next 00/21] Add support for Aquantia AQtion USB to 5/2.5GbE devices

This patchset introduces support for new multigig ethernet to USB dongle, developed jointly by Aquantia (Phy) and ASIX (USB MAC). The driver has similar structure with other ASIX MAC drivers (AX88179), but with a number of important differences: - Driver supports both direct Phy and custom firmwar

[PATCH v4 net-next 05/21] net: usb: aqc111: Introduce PHY access

From: Dmitry Bezrukov Add helpers to write 32bit values. Implement PHY power up/down sequences. AQC111, PHY is being controlled via vendor command interface. Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 65

[PATCH v4 net-next 04/21] net: usb: aqc111: Various callbacks implementation

From: Dmitry Bezrukov Reset, stop callbacks, driver unbind callback. More register defines required for these callbacks. Add helpers to read/write 16bit values Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 76

[PATCH v4 net-next 03/21] net: usb: aqc111: Add implementation of read and write commands

From: Dmitry Bezrukov Read/write command register defines and functions Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 92 drivers/net/usb/aqc111.h | 18 2 files changed, 110 insertions(+) create

[PATCH v4 net-next 10/21] net: usb: aqc111: Add checksum offload support

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 38 ++ drivers/net/usb/aqc111.h | 16 ++-- 2 files changed, 52 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/aqc111.c

[PATCH v4 net-next 12/21] net: usb: aqc111: Add support for enable/disable checksum offload

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 45 +++- drivers/net/usb/aqc111.h | 1 + 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net

[PATCH v4 net-next 13/21] net: usb: aqc111: Add support for TSO

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 6 ++ drivers/net/usb/aqc111.h | 8 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index

[PATCH v4 net-next 07/21] net: usb: aqc111: Add support for getting and setting of MAC address

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 47 drivers/net/usb/aqc111.h | 1 + 2 files changed, 48 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c

[PATCH v4 net-next 01/21] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE

From: Dmitry Bezrukov Initialize usb_driver structure skeleton Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/Kconfig | 12 ++ drivers/net/usb/Makefile | 1 + drivers/net/usb/aqc111.c | 48 3 files changed

[PATCH v4 net-next 09/21] net: usb: aqc111: Implement RX data path

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 102 +++ drivers/net/usb/aqc111.h | 15 ++ 2 files changed, 117 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb

[PATCH v4 net-next 06/21] net: usb: aqc111: Introduce link management

From: Dmitry Bezrukov Add full hardware initialization sequence and link configuration logic Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 235 +++ drivers/net/usb/aqc111.h | 13 +++ 2 files changed, 248

[PATCH v4 net-next 02/21] net: usb: aqc111: Add bind and empty unbind callbacks

From: Dmitry Bezrukov Initialize net_device_ops structure Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c

[PATCH v4 net-next 16/21] net: usb: aqc111: Add RX VLAN filtering support

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 89 drivers/net/usb/aqc111.h | 2 +- 2 files changed, 90 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net

[PATCH v4 net-next 21/21] net: usb: aqc111: Extend cdc_ether blacklist

From: Dmitry Bezrukov Added Aquantia and ASIX device IDs to prevent loading cdc_ether for these devices. Our firmware reports CDC configuration simultaneously with vendor specific. Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/cdc_ether.c | 26

[PATCH v4 net-next 11/21] net: usb: aqc111: Add support for changing MTU

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 60 +++- 1 file changed, 59 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index 1c8812e082bf

[PATCH v4 net-next 20/21] net: usb: aqc111: Add ASIX's HW ids

From: Dmitry Bezrukov It enables driver for ASIX products which are also based on aqc111/112U chips. Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers

[PATCH v4 net-next 15/21] net: usb: aqc111: Add support for VLAN_CTAG_TX/RX offload

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 17 + drivers/net/usb/aqc111.h | 12 +++- 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c

[PATCH v4 net-next 19/21] net: usb: aqc111: Add support for wake on LAN by MAGIC packet

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 180 +++ drivers/net/usb/aqc111.h | 12 +++ 2 files changed, 192 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111

[PATCH v4 net-next 14/21] net: usb: aqc111: Implement set_rx_mode callback

From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 72 +--- drivers/net/usb/aqc111.h | 4 +++ 2 files changed, 71 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/aqc111.c b/drivers

  1   2   >