Hi David, On 22.11.2018 22:17, David Miller wrote: > From: Igor Russkikh <igor.russk...@aquantia.com> > Date: Wed, 21 Nov 2018 10:13:48 +0000 > >> @@ -832,6 +832,10 @@ static struct sk_buff *aqc111_tx_fixup(struct usbnet >> *dev, struct sk_buff *skb, >> /*Length of actual data*/ >> tx_desc |= skb->len & AQ_TX_DESC_LEN_MASK; >> >> + /* TSO MSS */ >> + tx_desc |= ((u64)(skb_shinfo(skb)->gso_size & AQ_TX_DESC_MSS_MASK)) << >> + AQ_TX_DESC_MSS_SHIFT; > ... >> +#define AQ_TX_DESC_MSS_MASK 0x7FFF > > This implies a GSO size limit, which you need to advertise properly in > netdevice->gso_max_size.
Right, will do this. Thanks for your other comments as well, will fix in v4. > Also, where is the TSO feature flag being set to actually enable the > stack sending your GSO frames? Thats the same patch: /* Feature. ********************************************/ #define AQ_SUPPORT_FEATURE (NETIF_F_SG | NETIF_F_IP_CSUM |\ - NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM) + NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM |\ + NETIF_F_TSO) #define AQ_SUPPORT_HW_FEATURE (NETIF_F_SG | NETIF_F_IP_CSUM |\ - NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM) + NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM |\ + NETIF_F_TSO) Regards, Igor
