>> + if (usb_speed == USB_SPEED_SUPER) {
>> + ethtool_link_ksettings_add_link_mode(elk, supported,
>> + 2500baseT_Full);
>> + ethtool_link_ksettings_add_link_mode(elk, supported,
>> + 5000baseT_Full);
>> + }
>
> Hi Igor
>
> We discussed this with the first version of the patches. I think you
> should add a comment explaining why 2.5G and 5G is disabled unless
> Super speed is available.
Right, I've explained that to you but forgot to add a comment here.
>> + if (aqc111_data->autoneg)
>> + bitmap_copy(elk->link_modes.advertising,
>> + elk->link_modes.supported,
>> + __ETHTOOL_LINK_MODE_MASK_NBITS);
>
> linkmode_copy(). It is quite new, so you probably don't know about it.
Ok,
Regards,
Igor
