Re: [PATCH] usb: renesas_usbhs: make usbhs_write32() static

2016-06-22 Thread Felipe Balbi
Hi, Mathieu Malaterre writes: > On Tue, Jun 21, 2016 at 7:52 PM, Ben Dooks wrote: >> The usbhs_write32 function is not used outside of the rcar3.c >> file, so fix the following sparse warning by making it static: >> >> drivers/usb/renesas_usbhs/rcar3.c:26:6: warning: symbol 'usbhs_write32' was

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-22 Thread Felipe Balbi
Hi, Roger Quadros writes: > For the real use case, some Carplay platforms need it. Carplay does *NOT* rely on OTG. Apple has its own proprietary and closed specification which is not OTG-compliant. >>> >>> Yes, it is not OTG-compliant

Re: [PATCH 1/3] usb: gadget: f_fs: handle control requests not directed to interface or endpoint

2016-06-22 Thread Felipe Balbi
Hi, Felix Hädicke writes: > Introduces a new FunctionFS descriptor flag named > FUNCTIONFS_ALL_CTRL_RECIP. When this flag is enabled, control requests, > which are not explicitly directed to an interface or endpoint, can be > handled. > > This allows FunctionFS userspace drivers to process non-s

Re: [PATCH 2/3] usb: gadget: composite: ability for USB functions to process control requests in config 0

2016-06-22 Thread Felipe Balbi
Hi, Felix Hädicke writes: > It can sometimes be necessary for gadget drivers to process non-standard > control requests, which host devices can send without having sent > USB_REQ_SET_CONFIGURATION. got an example? -- balbi signature.asc Description: PGP signature

Re: Re: [PATCH 1/3] usb: gadget: f_fs: handle control requests not directed to interface or endpoint

2016-06-22 Thread Felipe Balbi
Hi, "Felix Hädicke" writes: >> > Introduces a new FunctionFS descriptor flag named >> > FUNCTIONFS_ALL_CTRL_RECIP. When this flag is enabled, control requests, >> > which are not explicitly directed to an interface or endpoint, can be >> > handled. >> > >> > This allows FunctionFS userspace driv

Re: Re: [PATCH 1/3] usb: gadget: f_fs: handle control requests not directed to interface or endpoint

2016-06-22 Thread Felipe Balbi
Hi again, Felipe Balbi writes: > [ Unknown signature status ] > > Hi, > > "Felix Hädicke" writes: >>> > Introduces a new FunctionFS descriptor flag named >>> > FUNCTIONFS_ALL_CTRL_RECIP. When this flag is enabled, control requests, >>&

Re: Re: [PATCH 1/3] usb: gadget: f_fs: handle control requests not directed to interface or endpoint

2016-06-22 Thread Felipe Balbi
Hi, "Felix Hädicke" writes: >> This is actually not for a f_accessory replacement. The control >> requests are sent when the device is in any other gadget mode, for >> sending metadata and to trigger switching to Open Accessory Gadget >> Mode. >> >> The Accessory mode itself can be handled very

Re: [PATCH 1/1] usb: dwc3: st: Inform the reset framework that our reset line may be shared

2016-06-28 Thread Felipe Balbi
reset lines. > > Signed-off-by: Lee Jones > --- > Felipe, > > I'd like to send this patch (amonst others) to the -rcs today if possible. > > Would you be kind enough to Ack it, so I can do so please? okay, back from vacations. Here you go: Acked-by: Felipe B

Re: [PATCH] usb: gadget: rndis: free response queue during REMOTE_NDIS_RESET_MSG

2016-06-29 Thread Felipe Balbi
Amit Pundir writes: > From: xerox_lin Please sanitize name here. Then resend. thanks -- balbi signature.asc Description: PGP signature

RE: [PATCH 0/2] usb: renesas_usbhs: fix issues on specific situations

2016-06-29 Thread Felipe Balbi
Yoshihiro Shimoda writes: > Hi Felipe, > > Would you review this patch set? both in my queue. -- balbi signature.asc Description: PGP signature

Re: [PATCH v12 2/4] gadget: Support for the usb charger framework

2016-06-29 Thread Felipe Balbi
Hi, Baolin Wang writes: >> Baolin Wang writes: >>> For supporting the usb charger, it adds the usb_charger_init() and >>> usb_charger_exit() functions for usb charger initialization and exit. >>> >>> It will report to the usb charger when the gadget state is changed, >>> then the usb charger ca

Re: [PATCH v12 2/4] gadget: Support for the usb charger framework

2016-06-29 Thread Felipe Balbi
Hi, Baolin Wang writes: > For supporting the usb charger, it adds the usb_charger_init() and > usb_charger_exit() functions for usb charger initialization and exit. > > It will report to the usb charger when the gadget state is changed, > then the usb charger can do the power

Re: [PATCH v12 2/4] gadget: Support for the usb charger framework

2016-06-29 Thread Felipe Balbi
Hi, Baolin Wang writes: >>> For supporting the usb charger, it adds the usb_charger_init() and >>> usb_charger_exit() functions for usb charger initialization and exit. >>> >>> It will report to the usb charger when the gadget state is changed, >>> then the usb charger can do

Re: [PATCH v12 2/4] gadget: Support for the usb charger framework

2016-06-29 Thread Felipe Balbi
Hi, Baolin Wang writes: > For supporting the usb charger, it adds the usb_charger_init() and > usb_charger_exit() functions for usb charger initialization and exit. > > It will report to the usb charger when the gadget state is changed, > then the usb char

[GIT PULL] usb patches for v4.8

2016-06-29 Thread Felipe Balbi
when stopping gadget dwc3: gadget: Implement the suspend entry event handler Ben Dooks (1): usb: renesas_usbhs: make usbhs_write32() static Colin Ian King (1): usb: gadget: bdc: fix spelling mistake: "allocted" -> "allocated" Dan Carpenter (1): us

Re: [GIT PULL] usb patches for v4.8

2016-06-30 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: > On Wed, Jun 29, 2016 at 04:11:31PM +0300, Felipe Balbi wrote: >> >> Hi Greg, >> >> here's the big pull request for gadget API and related UDC drivers. >> >> Nothing really scary lately. Patches have been in l

Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-06-30 Thread Felipe Balbi
Hi, Roger Quadros writes: > NOP_USB_XCEIV is used not only by gadget drivers but by > host drivers as well e.g. EHCI_OMAP. > > commit 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core") > made it so that NOP_USB_XCEIV can't be built-in if USB_GADGET is 'm'. > But this prevents EH

Re: [PATCH v14 1/4] usb: gadget: Introduce the usb charger framework

2016-06-30 Thread Felipe Balbi
Hi, Baolin Wang writes: > +static ssize_t charger_state_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct usb_charger *uchger = dev_to_uchger(dev); > + int cnt; > + > + switch (uchger

Re: [GIT PULL] usb patches for v4.8

2016-06-30 Thread Felipe Balbi
Hi, Roger Quadros writes: here's the big pull request for gadget API and related UDC drivers. Nothing really scary lately. Patches have been in linux-next for a while without outstanding reports. Let me know if you want any changes, but things seem to be calming >>>

Re: [GIT PULL] usb patches for v4.8

2016-06-30 Thread Felipe Balbi
Hi, Roger Quadros writes: >>> Roger Quadros writes: >>> here's the big pull request for gadget API and related UDC drivers. >>> >>> Nothing really scary lately. Patches have been in linux-next for a while >>> without outstanding reports. >>> >>> Let me know if you want a

Re: [PATCH] usb: dwc3: host: Fix broken XHCI host

2016-06-30 Thread Felipe Balbi
-for-v4.8' of > git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next") > Signed-off-by: Roger Quadros looks good to me. Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-07-01 Thread Felipe Balbi
Hi, Roger Quadros writes: >>> NOP_USB_XCEIV is used not only by gadget drivers but by >>> host drivers as well e.g. EHCI_OMAP. >>> >>> commit 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core") >>> made it so that NOP_USB_XCEIV can't be built-in if USB_GADGET is 'm'. >>> But this

Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-07-01 Thread Felipe Balbi
Hi, Roger Quadros writes: > NOP_USB_XCEIV is used not only by gadget drivers but by > host drivers as well e.g. EHCI_OMAP. > > commit 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core") > made it so that NOP_USB_XCEIV can't be built-in if USB_GADGET is 'm'. >>

Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-07-01 Thread Felipe Balbi
Hi, Roger Quadros writes: >>> NOP_USB_XCEIV is used not only by gadget drivers but by >>> host drivers as well e.g. EHCI_OMAP. >>> >>> commit 5a8d651a2bde ("usb: gadget: move gadget API functions to >>> udc-core") >>> made it so that NOP_USB_XCEIV can't be built-in if US

[RFC] usb: phy: generic: get rid of VBUS handling

2016-07-01 Thread Felipe Balbi
Hi Robert, your commit 7acc9973e3c4 ("usb: phy: generic: add vbus support") added GPIO-based VBUS handling for phy-generic.c, but that ends up calling usb_gadget_vbus_connect() which forces NOP to depend on the gadget API. I was grepping around and couldn't find any users for that VBUS gpio _and

Re: [RFC] usb: phy: generic: get rid of VBUS handling

2016-07-01 Thread Felipe Balbi
Hi, Robert Jarzmik writes: >> your commit 7acc9973e3c4 ("usb: phy: generic: add vbus support") added >> GPIO-based VBUS handling for phy-generic.c, but that ends up calling >> usb_gadget_vbus_connect() which forces NOP to depend on the gadget API. >> >> I was grepping around and couldn't find an

Re: [RFC] usb: phy: generic: get rid of VBUS handling

2016-07-04 Thread Felipe Balbi
Hi, Robert Jarzmik writes: >>> - amend the drivers (for my part I have pxa27x_udc.c and probably >>> pxa25x_udc.c) >>> to subscribe to the notifier, and in the action function call either >>> usb_gadget_vbus_connect() or usb_gadget_vbus_disconnect(). >>> >>> Would that kind of approach solve

Re: [PATCH 06/16] mfd: omap-usb-host: cleanup clock management code

2012-11-21 Thread Felipe Balbi
Hi, On Thu, Nov 15, 2012 at 04:34:04PM +0200, Roger Quadros wrote: > All ports have similarly named port clocks so we can > bunch them into a port data structure and use for loop > to enable/disable the clocks. > > Signed-off-by: Roger Quadros > --- > drivers/mfd/omap-usb-host.c | 208 > +

Re: [PATCH 07/16] mfd: omap_usb_host: Avoid creating copy of platform_data

2012-11-21 Thread Felipe Balbi
> platform data in probe. > > Signed-off-by: Roger Quadros This looks ok: Acked-by: Felipe Balbi > --- > drivers/mfd/omap-usb-host.c | 34 ++ > 1 files changed, 10 insertions(+), 24 deletions(-) > > diff --git a/drivers/mfd/omap-u

Re: [PATCH 08/16] mfd: omap-usb-host: know about number of ports from revision register

2012-11-21 Thread Felipe Balbi
On Thu, Nov 15, 2012 at 04:34:06PM +0200, Roger Quadros wrote: > prevents getting clocks that don't exist on the platform. > > Signed-off-by: Roger Quadros > --- > drivers/mfd/omap-usb-host.c | 47 > --- > 1 files changed, 35 insertions(+), 12 deletions

Re: [PATCH 09/16] mfd: omap-usb-host: override number of ports from platform data

2012-11-21 Thread Felipe Balbi
On Thu, Nov 15, 2012 at 04:34:07PM +0200, Roger Quadros wrote: > For some platforms e.g. OMAP5, we cannot rely on USBHOST revision > to determine the number of ports available. In such cases we have you need to make it clear *why* we can't. Imagine someone reading this 5 years from now... he'll be

Re: [PATCH 10/16] mfd: omap-usb-host: Intialize all available ports

2012-11-21 Thread Felipe Balbi
On Thu, Nov 15, 2012 at 04:34:08PM +0200, Roger Quadros wrote: > OMAPs till date can have upto 3 ports. We need to initialize s/upto/up to/ > the port mode in HOSTCONFIG register for all of them. why *all* of them ? Isn't it enough to initialize only the ones we're going to use ? If not, why ?

Re: [PATCH 11/16] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode

2012-11-21 Thread Felipe Balbi
Hi, On Thu, Nov 15, 2012 at 04:34:09PM +0200, Roger Quadros wrote: > Enable the optional HSIC clocks (60MHz and 480MHz) for the ports > that are configured in HSIC mode. > > Signed-off-by: Roger Quadros > --- > drivers/mfd/omap-usb-host.c | 56 +- > 1 f

Re: [PATCH 13/16] mfd: omap-usb-host: Get rid of unnecessary spinlock

2012-11-21 Thread Felipe Balbi
Hi, On Thu, Nov 15, 2012 at 04:34:11PM +0200, Roger Quadros wrote: > We don't really need a spinlock here, so get rid of it. can you prove it ? what if an IRQ happens right after disabling clocks on ->runtime_suspend() but before it returns ? Will this not cause a problem for you ? (note that I

Re: [PATCH 14/16] mfd: omap-usb-host: Support an auxiliary clock per port

2012-11-21 Thread Felipe Balbi
On Thu, Nov 15, 2012 at 04:34:12PM +0200, Roger Quadros wrote: > Boards like Panda require an auxiliary clock to clock the PHY > that is connected to one of the USB ports. This patch enables > board support code to provide the name and the rate of such > a clock for each of the USB ports. omap-usb

Re: [PATCH 15/16] ARM: OMAP4: omap4panda: Don't enable USB PHY clock from board

2012-11-21 Thread Felipe Balbi
On Thu, Nov 15, 2012 at 04:34:13PM +0200, Roger Quadros wrote: > Instead of enabling the USB PHY clock in the board file we > provide the PHY clock details to the driver via board platform > data so that driver code can manage the clock. > > Signed-off-by: Roger Quadros this patch is ok-ish. But

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-21 Thread Felipe Balbi
On Thu, Nov 15, 2012 at 04:34:14PM +0200, Roger Quadros wrote: > From: Andy Green > > This patch changes the management of the two GPIO for > "hub reset" (actually controls enable of ULPI PHY and hub reset) and > "hub power" (controls power to hub + eth). looks like this should be done by the hu

Re: [PATCH 02/16] mfd: omap-usb-tll: Clean up clock handling

2012-11-21 Thread Felipe Balbi
Hi, On Wed, Nov 21, 2012 at 02:36:48PM +0200, Roger Quadros wrote: > >>break; > >>default: > >> - dev_err(dev, "TLL version failed\n"); > >> - ret = -ENODEV; > >> - goto err_ioremap; > >> + tll->nch = DEFAULT_TLL_CHANNEL_COUNT; > >> + de

Re: [PATCH 04/16] mfd: omap-usb-tll: Move port clock handling out of runtime ops

2012-11-21 Thread Felipe Balbi
Hi, On Wed, Nov 21, 2012 at 02:45:46PM +0200, Roger Quadros wrote: > >>spin_unlock_irqrestore(&tll->lock, flags); > >> > >> - return 0; > >> + return i; > >> } > >> +EXPORT_SYMBOL_GPL(omap_tll_enable); > >> > >> -static int usbtll_runtime_suspend(struct device *dev) > >> +int omap_tll_d

Re: [PATCH 05/16] mfd: omap-usb-tll: Add OMAP5 revision and HSIC support

2012-11-21 Thread Felipe Balbi
Hi, On Wed, Nov 21, 2012 at 02:49:41PM +0200, Roger Quadros wrote: > On 11/21/2012 02:12 PM, Felipe Balbi wrote: > > On Thu, Nov 15, 2012 at 04:34:03PM +0200, Roger Quadros wrote: > >> The TLL module on OMAP5 has 3 channels. > >> HSIC mode requires the TLL channel to

Re: [PATCH v1] USB: musb: defer probe if transceiver is not ready

2012-11-21 Thread Felipe Balbi
9624] musb-omap2430 musb-omap2430: musb core is not yet ready > [ 19.246765] twl4030_usb twl4030_usb: Initialized TWL4030 USB module > [ 19.254516] driver: 'twl4030_usb': driver_bound: bound to device > 'twl4030_usb' > [ 19.263580] bus: 'platform

Re: [PATCH v1] USB: musb: defer probe if transceiver is not ready

2012-11-21 Thread Felipe Balbi
Hi, On Wed, Nov 21, 2012 at 05:51:05PM +0100, Sebastian Andrzej Siewior wrote: > On Wed, Nov 21, 2012 at 10:36:37PM +0800, Ming Lei wrote: > > On Wed, Nov 21, 2012 at 10:09 PM, Felipe Balbi wrote: > > >> status = musb_platform_init(musb); > > >> -

Re: [PATCH 02/16] mfd: omap-usb-tll: Clean up clock handling

2012-11-21 Thread Felipe Balbi
Hi, On Wed, Nov 21, 2012 at 05:39:57PM +0200, Roger Quadros wrote: > On 11/21/2012 04:03 PM, Felipe Balbi wrote: > > Hi, > > > > On Wed, Nov 21, 2012 at 02:36:48PM +0200, Roger Quadros wrote: > >>>> break; > >>>>

Re: [PATCH 08/16] mfd: omap-usb-host: know about number of ports from revision register

2012-11-21 Thread Felipe Balbi
Hi, On Wed, Nov 21, 2012 at 04:45:27PM +0200, Roger Quadros wrote: > >> + switch (omap->usbhs_rev) { > >> + case OMAP_USBHS_REV1: > >> + omap->nports = 3; > >> + break; > >> + case OMAP_USBHS_REV2: > >> + omap->nports = 2; > >> + break; > >> + default: > >>

Re: [PATCH 09/16] mfd: omap-usb-host: override number of ports from platform data

2012-11-21 Thread Felipe Balbi
Hi, On Wed, Nov 21, 2012 at 04:50:42PM +0200, Roger Quadros wrote: > On 11/21/2012 03:45 PM, Felipe Balbi wrote: > > On Thu, Nov 15, 2012 at 04:34:07PM +0200, Roger Quadros wrote: > >> For some platforms e.g. OMAP5, we cannot rely on USBHOST revision > >> to de

Re: [PATCH 10/16] mfd: omap-usb-host: Intialize all available ports

2012-11-21 Thread Felipe Balbi
hi, On Wed, Nov 21, 2012 at 05:47:06PM +0200, Roger Quadros wrote: > On 11/21/2012 03:52 PM, Felipe Balbi wrote: > > On Thu, Nov 15, 2012 at 04:34:08PM +0200, Roger Quadros wrote: > >> OMAPs till date can have upto 3 ports. We need to initialize > > > > s/upto/up

Re: [PATCH 13/16] mfd: omap-usb-host: Get rid of unnecessary spinlock

2012-11-21 Thread Felipe Balbi
Hi, On Wed, Nov 21, 2012 at 05:55:19PM +0200, Roger Quadros wrote: > On 11/21/2012 03:57 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Nov 15, 2012 at 04:34:11PM +0200, Roger Quadros wrote: > >> We don't really need a spinlock here, so get rid of it. > &g

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-21 Thread Felipe Balbi
Hi, On Wed, Nov 21, 2012 at 06:07:57PM +0200, Roger Quadros wrote: > On 11/21/2012 05:32 PM, Alan Stern wrote: > > On Wed, 21 Nov 2012, Roger Quadros wrote: > > > >> On 11/21/2012 04:52 PM, Alan Stern wrote: > >>> On Wed, 21 Nov 2012, Felipe Balbi wrote: >

Re: [PATCH v1] USB: musb: defer probe if transceiver is not ready

2012-11-21 Thread Felipe Balbi
WL4030 USB module > > [ 19.254516] driver: 'twl4030_usb': driver_bound: bound to device > > 'twl4030_usb' > > [ 19.263580] bus: 'platform': really_probe: bound device twl4030_usb to > > driver twl4030_usb > > > Cc: Sebastian Andrzej Siewi

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-22 Thread Felipe Balbi
Hi, On Thu, Nov 22, 2012 at 05:00:45PM +0200, Roger Quadros wrote: > On 11/22/2012 03:56 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Nov 22, 2012 at 09:49:05PM +0800, Andy Green wrote: > >>> Again it sounds like something that should be done at the hub dri

Re: [PATCH] UVC: use GFP_ATOMIC under spin lock.

2012-11-22 Thread Felipe Balbi
On Thu, Nov 22, 2012 at 09:09:57AM +0100, walter harms wrote: > > > Am 19.11.2012 22:34, schrieb Cyril Roelandt: > > Found using the following semantic patch: > > > > @@ > > @@ > > spin_lock_irqsave(...); > > ... when != spin_unlock_irqrestore(...); > > * GFP_KERNEL > > > > > > Signed-off-by:

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-22 Thread Felipe Balbi
Hi, On Thu, Nov 22, 2012 at 09:49:05PM +0800, Andy Green wrote: > >Again it sounds like something that should be done at the hub driver > >level. I mean using the GPIO (for reset) and Power Regulator. > > > >not implementing the regulator part itself, but using it. > > If you mean change the regu

Re: [PATCH v1] USB: musb: defer probe if transceiver is not ready

2012-11-22 Thread Felipe Balbi
On Thu, Nov 22, 2012 at 09:23:22AM +0800, Ming Lei wrote: > On Thu, Nov 22, 2012 at 12:51 AM, Sebastian Andrzej Siewior > wrote: > > On Wed, Nov 21, 2012 at 10:36:37PM +0800, Ming Lei wrote: > >> On Wed, Nov 21, 2012 at 10:09 PM, Felipe Balbi wrote: > >> >>

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-22 Thread Felipe Balbi
Hi, On Thu, Nov 22, 2012 at 09:13:16AM +0800, Andy Green wrote: > On 11/22/12 03:54, the mail apparently from Felipe Balbi included: > >Hi, > > > >On Wed, Nov 21, 2012 at 06:07:57PM +0200, Roger Quadros wrote: > >>On 11/21/2012 05:32 PM, Alan Stern wrote: > >

Re: [PATCH v1] USB: musb: defer probe if transceiver is not ready

2012-11-22 Thread Felipe Balbi
On Thu, Nov 22, 2012 at 10:20:02AM +0100, Sebastian Andrzej Siewior wrote: > On Thu, Nov 22, 2012 at 07:56:44AM +0200, Felipe Balbi wrote: > > > > /* dma address for sync dma */ > > > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 1

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-22 Thread Felipe Balbi
Hi, On Thu, Nov 22, 2012 at 01:32:25PM -0500, Alan Stern wrote: > On Thu, 22 Nov 2012, Felipe Balbi wrote: > > > Hi, > > Hello. > > > > This is an interesting problem. How should we handle devices which > > > live on a discoverable bus but whose power i

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-22 Thread Felipe Balbi
Hi, On Thu, Nov 22, 2012 at 12:36:43PM -0500, Alan Stern wrote: > On Thu, 22 Nov 2012, Felipe Balbi wrote: > > > > If you mean change the regulator managing code from living in > > > omap-hsusb to ehci-hcd, it sounds like a good idea. > > > > I mean that dri

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-23 Thread Felipe Balbi
Hi, On Thu, Nov 22, 2012 at 09:35:06PM -0500, Alan Stern wrote: > On Thu, 22 Nov 2012, Felipe Balbi wrote: > > > > The latter, more or less. For example, maybe we can tell usbcore > > > somehow that regulator X is in control of a device attached to host > > > co

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-23 Thread Felipe Balbi
On Fri, Nov 23, 2012 at 12:23:52PM +0200, Roger Quadros wrote: > On 11/22/2012 06:12 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Nov 22, 2012 at 05:00:45PM +0200, Roger Quadros wrote: > >> On 11/22/2012 03:56 PM, Felipe Balbi wrote: > >>> Hi, >

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-26 Thread Felipe Balbi
Hi, On Fri, Nov 23, 2012 at 11:27:34AM -0500, Alan Stern wrote: > On Fri, 23 Nov 2012, Felipe Balbi wrote: > > > > And maybe the same sort of scheme could be used for clocks, although I > > > don't know how to do it in a generic way that will work on all >

Re: [PATCH 01/27] usb: gadget: mv_udc: use udc_start and udc_stop functions

2012-11-26 Thread Felipe Balbi
Hi, On Mon, Nov 26, 2012 at 06:39:36AM -0800, Greg KH wrote: > On Sun, Nov 25, 2012 at 11:43:14PM -0500, Chao Xie wrote: > > From: Chao Xie > > > > This patches converts the driver into the new style start/stop > > interface. As a result the driver no longer uses the static > > global the_conrol

Re: [PATCH 06/16] mfd: omap-usb-host: cleanup clock management code

2012-11-26 Thread Felipe Balbi
Hi, On Mon, Nov 26, 2012 at 05:14:45PM +0200, Roger Quadros wrote: > Felipe, > > On 11/21/2012 03:39 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Nov 15, 2012 at 04:34:04PM +0200, Roger Quadros wrote: > >> All ports have similarly named port clocks so we

Re: [PATCH 01/27] usb: gadget: mv_udc: use udc_start and udc_stop functions

2012-11-26 Thread Felipe Balbi
Hi, On Mon, Nov 26, 2012 at 10:42:32AM -0800, Greg KH wrote: > On Mon, Nov 26, 2012 at 04:34:31PM +0200, Felipe Balbi wrote: > > Hi, > > > > On Mon, Nov 26, 2012 at 06:39:36AM -0800, Greg KH wrote: > > > On Sun, Nov 25, 2012 at 11:43:14PM -0500, Chao Xie

Re: [PATCH] cppi_dma: mark cppi_controller_create() and cppi_pool_init() as '__devinit'

2012-11-26 Thread Felipe Balbi
Hi, On Mon, Nov 26, 2012 at 10:14:30PM +0300, Sergei Shtylyov wrote: > Hello. > > On 11/12/2012 09:01 PM, Sergei Shtylyov wrote: > > > This patch fixes the following: > > > WARNING: vmlinux.o(.devinit.text+0x24ac): Section mismatch in reference > > from the function dma_controller_create() to

Re: [PATCH 10/16] mfd: omap-usb-host: Intialize all available ports

2012-11-27 Thread Felipe Balbi
Hi, On Tue, Nov 27, 2012 at 02:10:50PM +0200, Roger Quadros wrote: > > in fact, I would convert this construct into a switch which would look > > like: > > > > reg &= ~(OMAP4_P1_MODE_MASK << i * 2); > > > > switch (port_mode[i]) { > > case OMAP4_P1_MODE_TLL: > > reg |= OMAP4_P1_MODE_TLL << i

Re: [PATCH 00/16] OMAP USB Host cleanup

2012-11-27 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 04:42:47PM +0200, Roger Quadros wrote: > On 11/20/2012 01:22 AM, Kevin Hilman wrote: > > Roger Quadros writes: > > > >> Kevin, > >> > >> On 11/16/2012 10:08 PM, Kevin Hilman wrote: > >>> Roger Quadros writes: > >>> > Hi, > > This patchset addresses the foll

Re: [PATCH 1/2] USB: musb: fix failure path

2012-11-29 Thread Felipe Balbi
Hi, On Wed, Nov 28, 2012 at 08:34:25AM +0800, Ming Lei wrote: > On Wed, Nov 28, 2012 at 1:23 AM, Greg Kroah-Hartman > wrote: > > On Tue, Nov 27, 2012 at 11:48:41AM +0800, Ming Lei wrote: > >> Hi, > >> > >> On Thu, Nov 22, 2012 at 10:35 AM, Ming Lei wrote: > >> > In the fail1~fail5 failure path,

Re: [V2 PATCH 00/27] mv-usb fix and enhancement patches

2012-11-30 Thread Felipe Balbi
Hi, On Tue, Nov 27, 2012 at 10:05:59PM -0500, Chao Xie wrote: > The patches are divied into 4 parts > 1. bug fixes > usb: gadget: mv_udc: use udc_start and udc_stop functions > usb: gadget: mv_udc: use devm_xxx for probe > usb: gadget: mv_udc: fix the clk APIs > usb: otg: mv_otg: use devm_

Re: [PATCH] usb: musb: Enable DMA Mode1 for device mode RX in ux500 platform

2012-11-30 Thread Felipe Balbi
Hi, On Fri, Nov 30, 2012 at 12:02:25PM +0530, Supriya Karanth wrote: > From: supriya karanth > > Handles: > 1) Known transfer length > a) Non multiple of packet size > b) Multiple of packet size > > 2) Unknown transfer lengths > - Short packet indicates end of transfer > > --

Re: [RFC v2] usb/gadget: the start of the configfs interface

2012-11-30 Thread Felipe Balbi
Hi, On Thu, Nov 29, 2012 at 05:43:21PM +0100, Sebastian Andrzej Siewior wrote: > |# modprobe dummy_hcd num=2 > > |# find /sys/kernel/config/ -ls > > | 5570 drwxr-xr-x 3 root root0 Nov 29 17:26 > /sys/kernel/config/ > | 5580 drwxr-xr-x 5 root root0

Re: [PATCH 06/16] usb/gadget: convert source sink and loopback to new function interface

2012-11-30 Thread Felipe Balbi
On Tue, Nov 20, 2012 at 11:53:02PM +0100, Michal Nazarewicz wrote: > > * Felipe Balbi | 2012-11-20 14:14:47 [+0200]: > >> now this looks awfully wrong. Why don't you just expose the modules to > >> userland (in fact they already are) and if user wants to change > &g

Re: [RFC v2] usb/gadget: the start of the configfs interface

2012-11-30 Thread Felipe Balbi
Hi, On Fri, Nov 30, 2012 at 04:07:22PM +0100, Michal Nazarewicz wrote: > On Fri, Nov 30 2012, Felipe Balbi wrote: > > Hi, > > > > On Thu, Nov 29, 2012 at 05:43:21PM +0100, Sebastian Andrzej Siewior wrote: > >> |# modprobe dummy_hcd num=2 > >>

Re: [RFC v2] usb/gadget: the start of the configfs interface

2012-11-30 Thread Felipe Balbi
Hi, On Fri, Nov 30, 2012 at 04:24:43PM +0100, Sebastian Andrzej Siewior wrote: > On 11/30/2012 03:46 PM, Felipe Balbi wrote: > >Hi, > > Hi, > > >On Thu, Nov 29, 2012 at 05:43:21PM +0100, Sebastian Andrzej Siewior wrote: > >>|# modprobe dummy_hcd num=2 > &g

Re: [RFC v2] usb/gadget: the start of the configfs interface

2012-11-30 Thread Felipe Balbi
Hi, On Fri, Nov 30, 2012 at 08:09:38PM +0100, Sebastian Andrzej Siewior wrote: > On 11/30/2012 05:43 PM, Alan Stern wrote: > >By the way, can you name these string attributes > > > > sSerialNumber, sProduct, and sManufacturer (etc.) > > > >instead of > > > > iSerialNumber, iProduct, and iM

Re: [RFC v2] usb/gadget: the start of the configfs interface

2012-11-30 Thread Felipe Balbi
Hi, On Fri, Nov 30, 2012 at 07:40:31PM +0100, Michal Nazarewicz wrote: > On Fri, Nov 30 2012, Felipe Balbi wrote: > > why would you load a function before it's actually needed ? We could > > end up with users who will just load the function and never actually > > ne

[PATCH] usb: dwc3: decrease event buffer size

2012-12-07 Thread Felipe Balbi
that would still be less than 40 events. In order to cope with future versions of the IP which could (or could not) increase the amount of possible events to trigger simultaneously, we're using an arbitrary size of 64 events for our event buffer. We're saving 3840 bytes by doing so. S

Re: [PATCH] usb: renesas_usbhs: mod_host: fixup usbhsh_ureq_free() timing

2012-12-10 Thread Felipe Balbi
Hi, On Sun, Dec 09, 2012 at 09:06:37PM -0800, Kuninori Morimoto wrote: > usbhsh_ureq_free() free ureq which includes ubshs_pkt. > But current driver used usbhs_pkt after freed ureq. > This patch fixup this bug. > Special thanks to Chen > > Reported-by: Chen Gang > Signed-off-by: Kuninori Morimot

Re: [PATCH] usb: musb: Enable DMA Mode1 for device mode RX in ux500 platform

2012-12-10 Thread Felipe Balbi
Hi, On Thu, Dec 06, 2012 at 11:46:45AM +0100, Supriya s KARANTH wrote: > Hi Felipe, > > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Friday, November 30, 2012 7:51 PM > > > > Hi, > > > > On Fri, Nov 30, 2012 at 12:02:25PM +0530, Supriya

Re: [PATCH 06/16] usb/gadget: convert source sink and loopback to new function interface

2012-12-10 Thread Felipe Balbi
Hi, On Mon, Dec 03, 2012 at 12:34:44PM +0100, Sebastian Andrzej Siewior wrote: > On Fri, Nov 30, 2012 at 04:51:16PM +0200, Felipe Balbi wrote: > > On Tue, Nov 20, 2012 at 11:53:02PM +0100, Michal Nazarewicz wrote: > > > > * Felipe Balbi | 2012-11-20 14:14:47 [+0200]: &g

Re: [RFC v5 0/3] configfs integration

2012-12-10 Thread Felipe Balbi
Hi, On Mon, Dec 10, 2012 at 03:25:47PM +0100, Sebastian Andrzej Siewior wrote: > On 12/07/2012 12:34 PM, Andrzej Pietrasiewicz wrote: > >>had old chunks somtimes,. > > > >So what? They were removed as you suggested. Is it the reason to start over? > > No but it makes the review harder. > > >>You

Re: [PATCH 06/16] usb/gadget: convert source sink and loopback to new function interface

2012-12-10 Thread Felipe Balbi
Hi, On Mon, Dec 10, 2012 at 03:29:33PM +0100, Sebastian Andrzej Siewior wrote: > On 12/10/2012 03:12 PM, Felipe Balbi wrote: > >>Okay, just make this crystel clear: > >>You want a sysfs interface to set _all_ parameters and not use the function > >>I > >>in

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-12-10 Thread Felipe Balbi
Hi, On Mon, Dec 10, 2012 at 03:17:34PM +0100, Andrzej Pietrasiewicz wrote: > @Joel in particular: please see my comment in the bottom. > > On Monday, December 10, 2012 12:57 PM I wrote: > > Subject: RE: [RFC][PATCH] fs: configfs: programmatically create config > > groups > > > > Hello Joel, > >

Re: [RFC PATCH 1/5] drivers : introduce device_path api

2012-12-10 Thread Felipe Balbi
Hi, On Mon, Dec 10, 2012 at 11:48:51AM +0200, Roger Quadros wrote: > >>> (or in appropriate order if the above isn't) > >>> That way insmod/rmmod'ing the USB3320C driver would power-up/down the > >>> whole subsystem. > >> > >> Yes, this is where we can think of a generic PHY driver to make sure t

Re: [RFC v2] usb/gadget: the start of the configfs interface

2012-12-10 Thread Felipe Balbi
On Mon, Dec 03, 2012 at 07:27:05PM +0100, Michal Nazarewicz wrote: > > On Fri, Nov 30, 2012 at 07:40:31PM +0100, Michal Nazarewicz wrote: > >> IMO that's actually mute argument since it can be done regardless. You > >> can modprobe the module anyway. > > On F

Re: [PATCH v4 23/23] mfd: omap-usb-host: Don't spam console on clk_set_parent failure

2012-12-10 Thread Felipe Balbi
On Mon, Dec 10, 2012 at 01:31:22PM +0200, Roger Quadros wrote: > On 12/10/2012 01:24 PM, Rajendra Nayak wrote: > > On Monday 10 December 2012 03:50 PM, Roger Quadros wrote: > >> clk_set_parent is expected to fail on OMAP3 platforms. We don't > >> consider that as fatal so don't spam console. > > >

Re: Linux USB file storage gadget with new UDC

2012-12-10 Thread Felipe Balbi
Hi, On Mon, Dec 10, 2012 at 10:39:45AM -0500, Alan Stern wrote: > On Mon, 10 Dec 2012, victor wrote: > > > Hi, > > > > I am working on a new UDC for a new USB chip. The kernel version is > > 3.4.4. When I insmod the new UDC, it is ok. When I insmod the file out of curiosity, do you plan to send

Re: Linux USB file storage gadget with new UDC

2012-12-11 Thread Felipe Balbi
On Tue, Dec 11, 2012 at 10:08:52AM +0800, victor wrote: > > > > > > > > I am working on a new UDC for a new USB chip. The kernel version is > > > > 3.4.4. When I insmod the new UDC, it is ok. When I insmod the file > > > > out of curiosity, do you plan to send kagen2_udc.ko to mainline ? > > > Ye

Re: Linux USB file storage gadget with new UDC

2012-12-11 Thread Felipe Balbi
Hi, On Tue, Dec 11, 2012 at 10:07:51AM +0800, victor wrote: > > > do I insmod the file storage gadget separately? The /dev/mmcblk0 refers > to > > SD card, right? I insmod the sd card driver already. > > > > > > # lsmod > > > kagen2_udc 7262 0 - Live 0xbf02f000 > > > ka2000_sdio 6643 0 - Live 0xbf

Re: [RFC PATCH 1/5] drivers : introduce device_path api

2012-12-11 Thread Felipe Balbi
On Tue, Dec 11, 2012 at 12:01:57PM +0200, Roger Quadros wrote: > On 12/11/2012 11:12 AM, Jassi Brar wrote: > > On Mon, Dec 10, 2012 at 3:18 PM, Roger Quadros wrote: > >> On 12/06/2012 04:34 PM, Jassi Brar wrote: > > Yes, this is where we can think of a generic PHY driver to make sure thy

Re: Linux USB file storage gadget with new UDC

2012-12-12 Thread Felipe Balbi
Hi, On Wed, Dec 12, 2012 at 03:49:48PM +0800, victor wrote: > Hi, > > > > > > > Yes, the devices /dev/mmcblk0 and /dev/mmcblk0p1 exist. The > > > /dev/mmcblk0 can be mounted. The dmesg does not contain other > > > messages. I am not sure the way to use g_file_storage.ko with UDC. > Please > > kin

Re: [PATCH 1/1]linux-usb: optimize to match the Huawei USB storage devices and support new switch command

2012-12-12 Thread Felipe Balbi
Hi, ok, let's start. On Wed, Dec 12, 2012 at 06:20:33PM +0800, fangxiaozhi 00110321 wrote: > From: fangxiaozhi > > 1. To optimize the match rules for the Huawei USB storage devices. Avoid to > load USB storage driver for modem interface with Huawei devices. > 2. Add to support new switch comma

Re: [PATCH 1/1] usb: dwc3: Use devm_kzalloc

2012-12-12 Thread Felipe Balbi
On Wed, Dec 12, 2012 at 04:13:15PM +0530, Sachin Kamat wrote: > devm_kzalloc is device managed and makes error handling and cleanup > simpler. While at it also fixed the return value when platform_device_alloc > failed in probe function. > > Cc: Anton Tikhomirov > Signed-off-by: Sachin Kamat wh

Re: [PATCH 1/1] usb: dwc3: Use devm_kzalloc

2012-12-12 Thread Felipe Balbi
Hi, On Wed, Dec 12, 2012 at 05:08:09PM +0530, Sachin Kamat wrote: > On 12 December 2012 16:51, Felipe Balbi wrote: > > On Wed, Dec 12, 2012 at 04:13:15PM +0530, Sachin Kamat wrote: > >> devm_kzalloc is device managed and makes error handling and cleanup > >> simpler.

Re: [PATCH] usb: gadget: fix switch off blocked in u_serial

2012-12-13 Thread Felipe Balbi
Hi, On Wed, Dec 12, 2012 at 10:13:27PM +0100, Linus Walleij wrote: > On Tue, Nov 27, 2012 at 3:11 PM, Linus Walleij > wrote: > > On Wed, Nov 21, 2012 at 3:33 PM, Linus Walleij > > wrote: > >> On Wed, Nov 14, 2012 at 3:40 PM, Linus Walleij > >> wrote: > >> > >>> From: Haipeng YU > >>> > >>> W

Re: [PATCH v4 00/23] OMAP USB Host cleanup

2012-12-13 Thread Felipe Balbi
Hi, On Thu, Dec 13, 2012 at 12:44:22PM +0200, Roger Quadros wrote: > Hi Samuel & Felipe, > > How can we proceed with this patchset? > > You can use the below pull request. there are patches under arch/arm/ which need Tony's Acked-by, if we get those, then sure, go ahead ;-) -- balbi signatu

Re: [PATCH v3 23/23] mfd: omap-usb-host: Don't spam console on clk_set_parent failure

2012-12-13 Thread Felipe Balbi
On Wed, Dec 05, 2012 at 04:13:46PM +0200, Roger Quadros wrote: > On 12/05/2012 03:42 PM, Sergei Shtylyov wrote: > > Hello. > > > > On 04-12-2012 18:31, Roger Quadros wrote: > > > >> clk_set_parent is expected to fail on OMAP3 platforms. We don't > >> consider that as fatal so don't spam console.

[PATCH] usb: dwc3: gadget: don't redefine 'ret'

2012-12-13 Thread Felipe Balbi
we have an extra 'ret' variable shadowing a previous definition. Remove it. Signed-off-by: Felipe Balbi --- alredy in my branch, will be sent for v3.9 merge window. drivers/usb/dwc3/gadget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/driver

[GIT PULL] USB fixes for v3.8-rc2

2012-12-13 Thread Felipe Balbi
Hi Greg, Here's my first set of fixes for this -rc cycle. Let me know if you want any changes to this pull request. I'm basing it off of Linus' current master as there are no tags yet. If you want to wait until -rc1 is tagged, I can easily rebase. cheers The following changes since commit 6be35

Re: [GIT PULL] USB fixes for v3.8-rc2

2012-12-13 Thread Felipe Balbi
On Thu, Dec 13, 2012 at 10:50:39AM -0800, Greg KH wrote: > On Thu, Dec 13, 2012 at 04:58:36PM +0200, Felipe Balbi wrote: > > Hi Greg, > > > > Here's my first set of fixes for this -rc cycle. Let me > > know if you want any changes to this pull request. > > &

Re: [PATCH 1/1]linux-usb: optimize to match rules in USB storage for Huawei dongles.

2012-12-14 Thread Felipe Balbi
On Fri, Dec 14, 2012 at 10:25:25AM +0800, fangxiaozhi 00110321 wrote: > From: fangxiaozhi > > 1. Add a new macro define for USB storage match rule. > 2. Optimize the match rules with new macro for Huawei USB storage devices, >to avoid to load USB storage driver for the modem interface >

<    1   2   3   4   5   6   7   8   9   10   >