Re: [PATCH 1/1] support new huawei devices in option.c

2013-10-11 Thread Dan Williams
On Fri, 2013-10-11 at 13:57 -0700, gre...@linuxfoundation.org wrote: > On Fri, Oct 11, 2013 at 03:48:21AM +, Fangxiaozhi (Franko) wrote: > > 1. Add new supporting declarations to option.c, to support Huawei new > > devices with new bInterfaceSubClass value. > > Signed-off-by: fangxiaozhi > >

Re: [PATCH] usb: serial: option: blacklist Olivetti Olicard200

2013-10-15 Thread Dan Williams
On Tue, 2013-10-15 at 15:06 +0200, Enrico Mioso wrote: > Interface 6 of this device speaks QMI as per tests done by us. > Credits go to Antonella for providing the hardware. > > Signed-off-by: Enrico Mioso > Signed-off-by: Antonella Pellizzari Tested-by: Dan Williams > di

Re: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support

2013-10-15 Thread Dan Williams
Pellizzari Good find. For the record, mine has: PX1522E16X 1 [Oct 15 2010 02:00:00] ctl (1.4) wds (1.8) dms (1.3) nas (1.2) qos (1.2) wms (1.1) pds (1.4) auth (1.0) voice (1.0) cat2 (1.1) Tested-by: Dan Wi

Re: [PATCH v2 4/5] usb: xhci: change enumeration scheme to 'new scheme' by default

2013-10-17 Thread Dan Williams
On Wed, Oct 16, 2013 at 3:58 PM, Sarah Sharp wrote: > Hi Dan, > > I'm attempting to put my queue together for usb-next, and this patch > doesn't apply, due to conflicts in the USB core. Can you rebase this > patchset on top of my for-usb-next-queue branch, and resend the last two > patches? The

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 mbim?

2013-10-23 Thread Dan Williams
On Wed, 2013-10-23 at 22:56 +0200, Thomas Schäfer wrote: > Hi, > > I have some news about this device. Under Windows 8.1 (6.3)(testversion) > with these IDs: > > USB\VID_12D1&PID_1F16&REV_0102&MI_00 > USB\VID_12D1&PID_1F16&MI_00 > > USB\Class_02&SubClass_0e&Prot_00 > USB\Class_02&SubClass_0e >

[RFC PATCH 02/15] usbcore: introduce usb_domain for tracking port-connector relationships

2013-10-24 Thread Dan Williams
mon rountines in usb-platform.c. [1] ACPI 5.0 Section 6.1.8 _PLD (Physical Device Location) Signed-off-by: Dan Williams --- drivers/usb/core/Kconfig|4 + drivers/usb/core/Makefile |1 drivers/usb/core/hcd-pci.c | 17 +++- drivers/usb/core/hcd.c |2 dri

[RFC PATCH 00/15] rework port power control

2013-10-24 Thread Dan Williams
erride whether the port is hotplug capable, or usbcore.noacpi to turn it all off). --- Dan Williams (15): usb: xhci: fix memleak on module removal usbcore: introduce usb_domain for tracking port-connector relationships usbcore: add sysfs linkage for connector peers PM / R

[RFC PATCH 03/15] usbcore: add sysfs linkage for connector peers

2013-10-24 Thread Dan Williams
Use the "connector" association information provided by platform firmware to create links between peer ports in a connector. Signed-off-by: Dan Williams --- drivers/usb/core/usb-platform.c | 51 +-- 1 files changed, 49 insertions(+), 2 deletion

[RFC PATCH 01/15] usb: xhci: fix memleak on module removal

2013-10-24 Thread Dan Williams
hared_hcd being set to trigger usb_remove_hcd() to be called. Signed-off-by: Dan Williams --- drivers/usb/host/xhci.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 4265b48856f6..0ea11724c5d1 100644 --- a/drivers

[RFC PATCH 04/15] PM / Runtime: Allow drivers to intercept pm qos flag changes

2013-10-24 Thread Dan Williams
: Greg Kroah-Hartman Cc: Alan Stern Cc: Sarah Sharp Signed-off-by: Dan Williams --- Documentation/ABI/testing/sysfs-devices-power | 21 +++ Documentation/power/pm_qos_interface.txt | 15 drivers/base/power/qos.c | 48

[RFC PATCH 05/15] usbcore: port power policy / prep for usb_port as usb_device parent

2013-10-24 Thread Dan Williams
spend 0 disable hotplug | offsuspend 0 Signed-off-by: Dan Williams --- drivers/usb/core/port.c | 73 --- 1 files changed, 43 insertions(+), 30 deletions(-) diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c index 237b91bb2079..259ed86f56

[RFC PATCH 13/15] usbcore: show port power policy

2013-10-24 Thread Dan Williams
pm_qos_no_power_off + connect_type + peer port constraints. Signed-off-by: Dan Williams --- drivers/usb/core/port.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c index 71fbedaf8a93..6073b4521d03 100644 --- a

[RFC PATCH 09/15] usbcore: convert khubd to a workqueue and flush khubd on port power off

2013-10-24 Thread Dan Williams
the conversions to the async pm_runtime_put interfaces. Cc: Greg Kroah-Hartman Cc: Alan Stern Cc: Sarah Sharp Signed-off-by: Dan Williams --- drivers/usb/core/hub.c | 118 --- drivers/usb/core/hub.h |3 - drivers/usb/core/port.c | 30

[RFC PATCH 14/15] usbcore: add usbcore.noacpi

2013-10-24 Thread Dan Williams
Port power management places a lot of trust in the firmware api tables. Set this flag if it turns out that trust was misplaced. Signed-off-by: Dan Williams --- Documentation/kernel-parameters.txt |4 drivers/usb/core/usb-acpi.c |7 +++ 2 files changed, 11 insertions

[RFC PATCH 08/15] usbcore: kill ->is_power_on and ->did_runtime_put

2013-10-24 Thread Dan Williams
) only ever re-enables ports that should otherwise be powered Yes, this is still racy, but no worse than the current solution, synchronization to come. Cc: Sarah Sharp Signed-off-by: Dan Williams --- drivers/usb/core/hub.c | 95 --- drivers/usb/core

[RFC PATCH 10/15] usbcore: cleanup hub_port_connect_change and hub_power_on

2013-10-24 Thread Dan Williams
Before adding another hub->ports[port1 - 1] invocation just convert to local port_dev. Signed-off-by: Dan Williams --- drivers/usb/core/hub.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 3324cf5fd

[RFC PATCH 06/15] usbcore: make usb_port a proper parent of a usb_device

2013-10-24 Thread Dan Williams
| intf | +---^---+ | +---+---+ | port | +---^---+ | +---+---+ |device | +---+ Cc: Greg Kroah-Hartman Cc: Alan Stern Signed-off-by: Dan Williams --- drivers/usb/core/hub.c | 16 +--- drivers/usb/core/usb.c | 14 +++

[RFC PATCH 12/15] usbcore: allow the connect_type of ports to be changed

2013-10-24 Thread Dan Williams
hotplug ports maintain power awaiting hotplug events. Allow userspace to override this disctinction on a per port basis. Signed-off-by: Dan Williams --- drivers/usb/core/port.c | 32 +- drivers/usb/core/usb-platform.c | 42

[RFC PATCH 15/15] checkpatch: allow list_for_each helper macros

2013-10-24 Thread Dan Williams
Cc: Joe Perches Cc: Andy Whitcroft Signed-off-by: Dan Williams --- scripts/checkpatch.pl |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 66cad506b8a2..efaf92a43c2f 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkp

[RFC PATCH 11/15] usbcore: power down peer port on endpoint connect

2013-10-24 Thread Dan Williams
device sleep | on suspend 0 device wake | on active child device disconnect | on suspend 0 peer connect | offsuspend 0 peer disconnect | on suspend 0 disable hotplug | offsuspend 0 Signed-off-by: Dan Williams --- drivers/usb/core

[RFC PATCH 07/15] usbcore: pm_runtime honor children

2013-10-24 Thread Dan Williams
Now that ports are in the hierarchy above endpoints we can take advantage of the automatic power management of the device tree. There is now no need to power manage the hub in usb_port_runtime_{suspend|resume} Signed-off-by: Dan Williams --- drivers/usb/core/hub.c |2 -- drivers/usb/core

Re: [RFC PATCH 04/15] PM / Runtime: Allow drivers to intercept pm qos flag changes

2013-10-24 Thread Dan Williams
[ adding Rafael ] On Thu, Oct 24, 2013 at 12:35 AM, Dan Williams wrote: > ...because struct dev_pm_ops is too clean and uniform. > > USB port power management needs to manage ports that are colocated in a > given connector. If we power down a connector we need to arrange for > t

Re: [RFC PATCH 15/15] checkpatch: allow list_for_each helper macros

2013-10-24 Thread Dan Williams
[ adding Andy and Joe ] On Thu, Oct 24, 2013 at 12:36 AM, Dan Williams wrote: > Permit list_for_each redifinitions like: > > #define for_each_connector_peer(peer, port, c) \ >list_for_each_entry(peer, &(c)->ports, node) \ >if (port != peer) > >

Re: [RFC PATCH 00/15] rework port power control

2013-10-24 Thread Dan Williams
Hi Alan, thanks for taking a look. On Thu, Oct 24, 2013 at 10:25 AM, Alan Stern wrote: > On Thu, 24 Oct 2013, Dan Williams wrote: > >> Summary: >> Address the following issues for port power control: >> 1/ Port power policy needs 'connector' awareness. >>

Re: [RFC PATCH 04/15] PM / Runtime: Allow drivers to intercept pm qos flag changes

2013-10-24 Thread Dan Williams
Hi Rafael, sorry about the email mix up. On Thu, Oct 24, 2013 at 4:08 PM, Rafael J. Wysocki wrote: >> > + >> > +What: /sys/devices/.../power/pm_qos_no_notify_flags >> > +Date: October 2013 >> > +Contact: Dan Williams >> >

Re: [RFC PATCH 15/15] checkpatch: allow list_for_each helper macros

2013-10-24 Thread Dan Williams
On Thu, Oct 24, 2013 at 9:48 PM, Paul Zimmerman wrote: >> From: Joe Perches [mailto:j...@perches.com] >> Sent: Thursday, October 24, 2013 9:34 PM >> >> On Fri, 2013-10-25 at 03:52 +, Paul Zimmerman wrote: >> > > From: Dan Williams >> >

Re: [RFC PATCH 00/15] rework port power control

2013-10-25 Thread Dan Williams
On Fri, Oct 25, 2013 at 8:23 AM, Alan Stern wrote: > On Thu, 24 Oct 2013, Dan Williams wrote: > >> >> Details: >> >> 1/ Port power policy needs 'connector' awareness. >> >> >> >>It is a recipe for unintended device disco

Re: [RFC PATCH 00/15] rework port power control

2013-10-25 Thread Dan Williams
on. I wanted to at least have a working implementation that tackled the peer disconnect case, I did not expect 15 patches to fall out of that. However, after talking through this I think it can be abbreviated. > On Fri, 25 Oct 2013, Dan Williams wrote: > >> >> > Why treat "compani

Re: [RFC PATCH 00/15] rework port power control

2013-10-28 Thread Dan Williams
On Sat, Oct 26, 2013 at 7:40 AM, Alan Stern wrote: > On Fri, 25 Oct 2013, Dan Williams wrote: >> > This patch set makes a large number of significant changes to important >> > and subtle aspects of the USB stack. It would be a lot easier to >> > discuss in piece

Re: [RFC PATCH 00/15] rework port power control

2013-10-29 Thread Dan Williams
On Tue, Oct 29, 2013 at 8:05 AM, Alan Stern wrote: > On Mon, 28 Oct 2013, Dan Williams wrote: > >> > In fact, the reason for calling usb_autopm_get_interface was to prevent >> > the hub from being suspended while we change the port's power state. >> > S

Re: [RFC] Revert "sierra_net: keep status interrupt URB active"

2013-11-04 Thread Dan Williams
On Fri, 2013-11-01 at 13:53 +0100, Bjørn Mork wrote: > This reverts commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf. > > It's not easy to create a driver for all the various firmware > bugs out there. > > This change caused regressions for a number of devices, which > started to fail link detecti

Re: [RFC] Revert "sierra_net: keep status interrupt URB active"

2013-11-08 Thread Dan Williams
On Mon, 2013-11-04 at 14:27 -0600, Dan Williams wrote: > On Fri, 2013-11-01 at 13:53 +0100, Bjørn Mork wrote: > > This reverts commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf. > > > > It's not easy to create a driver for all the various firmware > > bugs out th

Re: [RFC] Revert "sierra_net: keep status interrupt URB active"

2013-11-08 Thread Dan Williams
On Fri, 2013-11-08 at 21:44 +0100, Bjørn Mork wrote: > Dan Williams writes: > > On Mon, 2013-11-04 at 14:27 -0600, Dan Williams wrote: > >> On Fri, 2013-11-01 at 13:53 +0100, Bjørn Mork wrote: > >> > This reverts commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf. &

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Dan Williams
On Mon, 2013-11-11 at 15:43 +0100, Bjørn Mork wrote: > Gustavo Zacarias writes: > > > With minicom on /dev/cdc-wdm0 after patching qmi_wwan it seems to be > > responsive to AT commands so yes it seems we are dealing with ECM here. > > I'll send a followup patch to include qmi_wwan. This is a bit

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Dan Williams
On Mon, 2013-11-11 at 18:03 +0100, Bjørn Mork wrote: > Dan Williams writes: > > On Mon, 2013-11-11 at 15:43 +0100, Bjørn Mork wrote: > > > >> Maybe run a small discussion on the ModemManager list first? This would > >> be the first non-QMI device ther

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Dan Williams
On Mon, 2013-11-11 at 18:27 +0100, Bjørn Mork wrote: > Gustavo Zacarias writes: > > On 11/11/2013 01:10 PM, Dan Williams wrote: > > > >> This is a bit confusing... so you added the device to qmi_wwan, and now > >> one of the AT ports works (cdc-wdm0) and the net

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Dan Williams
On Mon, 2013-11-11 at 18:41 +0100, Bjørn Mork wrote: > Dan Williams writes: > > On Mon, 2013-11-11 at 18:03 +0100, Bjørn Mork wrote: > >> Dan Williams writes: > >> > On Mon, 2013-11-11 at 15:43 +0100, Bjørn Mork wrote: > >> > > >> >> Ma

Re: [RFC] Revert "sierra_net: keep status interrupt URB active"

2013-11-12 Thread Dan Williams
On Fri, 2013-11-08 at 15:29 -0600, Dan Williams wrote: > On Fri, 2013-11-08 at 21:44 +0100, Bjørn Mork wrote: > > Dan Williams writes: > > > On Mon, 2013-11-04 at 14:27 -0600, Dan Williams wrote: > > >> On Fri, 2013-11-01 at 13:53 +0100, Bjørn Mork wrote

Re: [RFC] Revert "sierra_net: keep status interrupt URB active"

2013-11-12 Thread Dan Williams
On Tue, 2013-11-12 at 10:25 -0600, Dan Williams wrote: > On Fri, 2013-11-08 at 15:29 -0600, Dan Williams wrote: > > On Fri, 2013-11-08 at 21:44 +0100, Bjørn Mork wrote: > > > Dan Williams writes: > > > > On Mon, 2013-11-04 at 14:27 -0600, Dan Williams wrote: > &

Re: [PATCH] usbnet: fix status interrupt urb handling

2013-11-12 Thread Dan Williams
sync message response). > > To be able to receive further interrupts, the interrupt urb needs to be > re-submitted, so this patch removes the bogus check for netif_running(). > > Cc: sta...@vger.kernel.org > Signed-off-by: Felix Fietkau Tested-by: Dan Williams > --- &g

Re: [RFC PATCH 00/15] rework port power control

2013-11-12 Thread Dan Williams
On Tue, Nov 12, 2013 at 3:10 PM, Sarah Sharp wrote: > On Mon, Oct 28, 2013 at 06:49:37PM -0700, Dan Williams wrote: >> On Sat, Oct 26, 2013 at 7:40 AM, Alan Stern >> wrote: >> > On Fri, 25 Oct 2013, Dan Williams wrote: >> >> > This patch set makes a

[PATCH v2 01/14] USB: use ->reset_resume for port power recovery

2013-11-22 Thread Dan Williams
ge change events as individual ports resume. ->power_is_on will be removed in a subsequent patch. Signed-off-by: Dan Williams --- drivers/usb/core/hub.c | 22 +- drivers/usb/core/hub.h | 16 +--- drivers/usb/core/port.c | 29 +-

[PATCH v2 00/14] fixup and rework port power control

2013-11-22 Thread Dan Williams
Summary: 1/ Half the size of v1 [1], drop peer port power control for now 2/ Make port power control more robust by reusing the existing "reset-resume" implementation for connection recovery. First off, this set diverges significantly from the initial RFC [1]. It frontloads the fixes to the to

[PATCH v2 02/14] USB: synchronize port poweroff and khubd

2013-11-22 Thread Dan Williams
When khubd has evaluated a poweroff bit it needs to guarantee that the powered on state stays stable for the duration of its evaluation. So, hold a pm_runtime reference and synchronize the state of port while evaluating the port status/change registers. Signed-off-by: Dan Williams --- drivers

[PATCH v2 06/14] USB: centralize usb port power policy

2013-11-22 Thread Dan Williams
powered 3/ changing the meaning of the usb_port runtime suspended state. 4/ add new constraints peer-port-power-state and connect_type Signed-off-by: Dan Williams --- drivers/usb/core/hub.c | 16 +++- drivers/usb/core/hub.h |7 +++ drivers/usb/core/port.c | 22

[PATCH v2 03/14] USB: kill ->power_is_on flag and usb_hub_set_port_power() wrapper

2013-11-22 Thread Dan Williams
st hub->poweroff_bits are always the current policy. Signed-off-by: Dan Williams --- drivers/usb/core/hub.c | 61 +-- drivers/usb/core/hub.h |6 ++--- drivers/usb/core/port.c |5 ++-- 3 files changed, 16 insertions(+), 56 deletions(-) diff --git a/dr

[PATCH v2 07/14] USB: make usb_ports proper parents of their child usb_devices

2013-11-22 Thread Dan Williams
|device | +---+ Signed-off-by: Dan Williams --- drivers/usb/core/hub.c | 60 +++ drivers/usb/core/hub.h |2 -- drivers/usb/core/port.c |9 --- drivers/usb/core/usb.c |9 +-- 4 files changed, 21 insertions(+

[PATCH v2 08/14] USB: show port power state

2013-11-22 Thread Dan Williams
suspend/resume cycle echo 1 > $PORT//power/persist 'off': port power is off Reading this file makes an attempt to settle in-flight pm_runtime transitions. Signed-off-by: Dan Williams --- Documentation/ABI/testing/sysfs-bus-usb | 19 ++ drivers/usb/core/po

[PATCH v2 09/14] PM / Runtime: hold device active during device_wakeup_{enable|disable}

2013-11-22 Thread Dan Williams
Signed-off-by: Dan Williams --- drivers/base/power/wakeup.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c index 2d56f4113ae7..f784804137e7 100644 --- a/drivers/base/power/wakeup.c +++ b/drivers/base/power

[PATCH v2 05/14] USB: allow hubs to runtime suspend after all ports are powered off

2013-11-22 Thread Dan Williams
Ports are kept powered on while they have a wakeup enabled child. If all ports are off it means that wakeup has been disabled on all child devices. As a consequence we can suspend the hub once all ports are powered off. Signed-off-by: Dan Williams --- drivers/usb/core/hub.c | 24

[PATCH v2 14/14] USB: Documentation for USB port power off mechanisms

2013-11-22 Thread Dan Williams
From: Lan Tianyu Describe the mechanisms for controlling port power policy and discovering the port power state. Signed-off-by: Lan Tianyu [sarah: wordsmithing] Signed-off-by: Sarah Sharp [djbw: updates for device model, hotplug, and rework changes] Signed-off-by: Dan Williams

[PATCH v2 10/14] USB: notify pm_runtime on change to ->persist_enabled

2013-11-22 Thread Dan Williams
When this setting is changed it may require the parent port to keep power on, or allow it to turn power off. In any event we want pm_runtime to re-evaluate. Signed-off-by: Dan Williams --- drivers/usb/core/sysfs.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a

[PATCH v2 04/14] USB: kill unnecessary C_PORT_CONNECTION and broken C_PORT_ENABLE manipulations

2013-11-22 Thread Dan Williams
]: USB2.0 Specification Section 11.24.2.7.2.2 Signed-off-by: Dan Williams --- drivers/usb/core/port.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c index 48011263ce35..3dbd4d653b15 100644 --- a/drivers/usb/core/port.c +++ b

[PATCH v2 12/14] USB: convert khubd to a workqueue

2013-11-22 Thread Dan Williams
ait to flush the workqueue until after the urb has been killed, and we know that kick_khubd() will not be called again. The kref for the usb_hub is also removed since we can flush the workqueue and do not need to hold a reference while the hub object while is being processed. Signed-off-by:

[PATCH v2 11/14] USB: add connect_type == hotplug as a port poweroff constraint

2013-11-22 Thread Dan Williams
Now that userspace can discover the constraints keeping a port powered, require it to explicitly disable hotplug capability before powering off a port. This makes the 'connect_type' attribute writable, and must be set to 'hardwired' before a port is a candidate for poweroff.

[PATCH v2 13/14] USB: ratelimit port power transitions

2013-11-22 Thread Dan Williams
without an intervening recovery results in the endpoint device failing to reconnect. Force an autosuspend timeout and a recovery of the port before allowing power to be removed again. Signed-off-by: Dan Williams --- drivers/usb/core/hub.h |1 + drivers/usb/core/port.c | 23 ++

[resend PATCH 0/2] xhci "new scheme" enumeration

2013-11-22 Thread Dan Williams
Same as before [1], just rebased for collisions on top of xhci.git/for-usb-next [1]: http://marc.info/?l=linux-usb&m=138446498904406&w=2 --- Dan Williams (2): usb: xhci: change enumeration scheme to 'new scheme' by default xhci: clarify logging in xhci_setup_dev

[resend PATCH 1/2] usb: xhci: change enumeration scheme to 'new scheme' by default

2013-11-22 Thread Dan Williams
bMaxPacketSize0= 9 which results in the discovery process looping until falling back to 'old scheme' enumeration. Acked-by: Alan Stern Reported-by: David Moore Suggested-by: Sarah Sharp Signed-off-by: Dan Williams --- drivers/usb/core/hub.c | 46

[resend PATCH 2/2] xhci: clarify logging in xhci_setup_device

2013-11-22 Thread Dan Williams
Specify whether we are only performing the context setup portion of the 'address device' command, or the full operation issuing 'SetAddress' on the wire. Signed-off-by: Dan Williams --- drivers/usb/host/xhci.c | 22 -- 1 files changed, 12 inserti

Re: [PATCH v2 09/14] PM / Runtime: hold device active during device_wakeup_{enable|disable}

2013-11-22 Thread Dan Williams
On Fri, Nov 22, 2013 at 7:50 AM, Rafael J. Wysocki wrote: > On 11/22/2013 10:08 AM, Dan Williams wrote: >> >> usbcore blocks powering off hub ports while a downstream source is >> wakeup enabled. Once wakeup is disabled usbcore can try again to turn >> off the par

Re: [PATCH v2 11/14] USB: add connect_type == hotplug as a port poweroff constraint

2013-11-22 Thread Dan Williams
On Fri, Nov 22, 2013 at 2:41 AM, Oliver Neukum wrote: > On Fri, 2013-11-22 at 01:08 -0800, Dan Williams wrote: >> Now that userspace can discover the constraints keeping a port powered, >> require >> it to explicitly disable hotplug capability before powering off a por

Re: [PATCH v2 06/14] USB: centralize usb port power policy

2013-11-22 Thread Dan Williams
On Fri, Nov 22, 2013 at 2:39 AM, Oliver Neukum wrote: > On Fri, 2013-11-22 at 01:07 -0800, Dan Williams wrote: >> Move all port power policy evaluation to usb_port_runtime_suspend(). >> Makes it clearer what blocks port power off and is preparation for >> follow on chan

Re: [PATCH v2 14/14] USB: Documentation for USB port power off mechanisms

2013-11-22 Thread Dan Williams
On Fri, Nov 22, 2013 at 2:46 AM, Oliver Neukum wrote: > On Fri, 2013-11-22 at 01:08 -0800, Dan Williams wrote: >> From: Lan Tianyu >> >> Describe the mechanisms for controlling port power policy and >> discovering the port power state. > >> + power/pm_qos

Re: [PATCH v2 04/14] USB: kill unnecessary C_PORT_CONNECTION and broken C_PORT_ENABLE manipulations

2013-11-22 Thread Dan Williams
On Fri, Nov 22, 2013 at 12:44 PM, Paul Zimmerman wrote: >> From: linux-usb-ow...@vger.kernel.org >> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Dan Williams >> Sent: Friday, November 22, 2013 1:08 AM >> >> C_PORT_CONNECTION changes are now handled and clea

Re: [PATCH v2 09/14] PM / Runtime: hold device active during device_wakeup_{enable|disable}

2013-11-22 Thread Dan Williams
On Fri, Nov 22, 2013 at 4:06 PM, Rafael J. Wysocki wrote: > On 11/22/2013 8:29 PM, Dan Williams wrote: >> >> On Fri, Nov 22, 2013 at 7:50 AM, Rafael J. Wysocki >> wrote: >>> >>> On 11/22/2013 10:08 AM, Dan Williams wrote: >>>> >>>>

Re: [PATCH v2 09/14] PM / Runtime: hold device active during device_wakeup_{enable|disable}

2013-11-22 Thread Dan Williams
On Fri, Nov 22, 2013 at 4:27 PM, Rafael J. Wysocki wrote: > On 11/23/2013 1:16 AM, Dan Williams wrote: >> >> On Fri, Nov 22, 2013 at 4:06 PM, Rafael J. Wysocki >> wrote: >>> >>> On 11/22/2013 8:29 PM, Dan Williams wrote: >>>> >>>>

Re: [PATCH v2 06/14] USB: centralize usb port power policy

2013-11-25 Thread Dan Williams
On Mon, Nov 25, 2013 at 3:33 AM, Oliver Neukum wrote: > On Fri, 2013-11-22 at 12:18 -0800, Dan Williams wrote: >> On Fri, Nov 22, 2013 at 2:39 AM, Oliver Neukum wrote: >> > On Fri, 2013-11-22 at 01:07 -0800, Dan Williams wrote: >> >> Move all p

Re: [PATCH v2 00/14] fixup and rework port power control

2013-11-25 Thread Dan Williams
On Fri, Nov 22, 2013 at 2:12 PM, Alan Stern wrote: > On Fri, 22 Nov 2013, Dan Williams wrote: > >> Summary: >> 1/ Half the size of v1 [1], drop peer port power control for now >> 2/ Make port power control more robust by reusing the existing >>"reset-re

Re: [PATCH v2 06/14] USB: centralize usb port power policy

2013-11-26 Thread Dan Williams
On Tue, Nov 26, 2013 at 11:40 AM, Oliver Neukum wrote: > On Mon, 2013-11-25 at 11:05 -0800, Dan Williams wrote: >> On Mon, Nov 25, 2013 at 3:33 AM, Oliver Neukum wrote: >> > On Fri, 2013-11-22 at 12:18 -0800, Dan Williams wrote: >> >> On Fri, Nov 22, 2013 at

Re: [PATCH] USB: qcaux: add Pantech vendor class match

2012-09-20 Thread Dan Williams
hing, adding support for the P4200. Yeah, this looks right. I just reverified that the UM190 follows the same pattern; WMC on 0xFE and DIAG on 0xFF. I don't know for sure that NMEA is 0xFD, but the UM190 *does* have a 0xFD descriptor as interface #3. Acked-by: Dan Williams > Cc: > C

Re: BEEMO(OPTION) alias PANTECH P4200 LTE-Modem

2012-09-20 Thread Dan Williams
On Wed, 2012-09-19 at 20:45 +0200, Bjørn Mork wrote: > Thomas Schäfer writes: > > > I collected some additional information about this device. > > > > The windows-view: > > http://www.cis.uni-muenchen.de/~thomas/pantech-p4200-usb.png > > > > and the usbsnoop-logfile: > > http://www.cis.uni-muench

Re: BEEMO(OPTION) alias PANTECH P4200 LTE-Modem

2012-09-20 Thread Dan Williams
On Thu, 2012-09-20 at 19:55 +0200, Thomas Schäfer wrote: > One mysterious thing: > > at&v at /dev/ttyACM via minicom > > crashs/resets the modem. Sounds like a firmware bug. I've heard of this on one or two other occasions. Clearly nobody on that firmware team put the device through a conforma

Re: Re:3G/4G modem Wireless U600

2012-10-10 Thread Dan Williams
On Wed, 2012-10-10 at 23:46 +0200, Thomas Schäfer wrote: > Am Mittwoch, 10. Oktober 2012 um 21:02:02 schrieb United Seabears Corp.: > > Hi there: > > > > I am seeking assistance with a USB Wimax modem for Sprint/Virgin Mobile > > to be used on a laptop with Kubuntu 12.04 and/or 12.10. The modem is

Re: [PATCH 0/4] USB: sierra: memory-leak fixes for v3.7

2012-10-24 Thread Dan Williams
On Wed, 2012-10-24 at 19:24 +0200, Johan Hovold wrote: > This is an updated series of fixes rebased on the interface-data memory leak > discovered by Lennart. > > One of the reasons that I missed it was that the interface data was allocated > in probe rather than attach, which in itself is a bug a

Re: qmi-wwan & cdc-wdm & cdc-ether interaction for Novatel devices

2012-10-24 Thread Dan Williams
(sorry, forgot to send to linux-usb@..., adding now) On Wed, 2012-10-24 at 13:25 -0500, Dan Williams wrote: > Hi Bjorn, > > The Novatel USB 551L and E362 actually have cdc-ether interfaces which > speak QMI. That's not really handled by our architecture at the moment. > I

[PATCH] qmi_wwan/cdc_ether: move Novatel 551 and E362 to qmi_wwan

2012-10-24 Thread Dan Williams
both QMI and ethernet simultaneously. Signed-off-by: Dan Williams Cc: sta...@vger.kernel.org --- Greg: CC-ed to linux-usb@ for visibility but should probably go through davem diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index a03de71..d012982 100644 --- a/drivers/net

Re: (BUG) qmi-wwan bug

2012-10-29 Thread Dan Williams
On Fri, 2012-10-26 at 10:08 -0400, Shawn J. Goff wrote: > On 10/26/2012 02:16 AM, Bjørn Mork wrote: > > "Shawn J. Goff" writes: > >> After the failure happens, I can see from USB traces (and this is with > >> an external USB sniffer) ARP requests going out and nothing coming in > >> - > >> so it s

[PATCH] option: add Novatel E362 and Dell Wireless 5800 USB IDs

2012-11-08 Thread Dan Williams
The Dell 5800 appears to be a simple rebrand of the Novatel E362. Signed-off-by: Dan Williams Cc: sta...@vger.kernel.org --- drivers/usb/serial/option.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 5dee7d6..c25d3fd

[PATCH] option: add Alcatel X220/X500D USB IDs

2012-11-08 Thread Dan Williams
Signed-off-by: Dan Williams Cc: sta...@vger.kernel.org --- drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index c25d3fd..edc64bb 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c

[PATCH] qmi_wwan/cdc_ether: add Dell Wireless 5800 (Novatel E362) USB IDs

2012-11-08 Thread Dan Williams
The Dell Wireless 5800 appears to be a Novatel E362 rebrand. Signed-off-by: Dan Williams Cc: sta...@vger.kernel.org --- Greg: CC-ed to linux-usb@ for visibility but should go through davem drivers/net/usb/cdc_ether.c | 15 +++ drivers/net/usb/qmi_wwan.c | 14 ++ 2

[PATCH] cdc-acm: implement TIOCSSERIAL to avoid blocking close(2)

2012-11-08 Thread Dan Williams
sired. Implement the standard mechanism to adjust closing_wait and let applications handle it how they want to. See also 02303f73373aa1da19dbec510ec5a4e2576f9610 for usb_wwan.c. Signed-off-by: Dan Williams Cc: sta...@vger.kernel.org --- drivers/usb/class/cdc-acm.c

Re: Piggy-backing new hardware using old usb-serial

2013-03-28 Thread Dan Williams
On Wed, 2013-03-27 at 16:13 -0700, Greg KH wrote: > On Wed, Mar 27, 2013 at 09:28:11PM +0100, Wesley W. Terpstra wrote: > > On Wed, 2013-03-27 at 13:06 -0700, Greg KH wrote: > > > > Our current prototypes borrow the Sierra VID > > > And the USB-IF might revoke your vendor id, if they find you shipp

Re: Piggy-backing new hardware using old usb-serial

2013-03-28 Thread Dan Williams
On Thu, 2013-03-28 at 15:58 +0100, Wesley W. Terpstra wrote: > On Thu, 2013-03-28 at 09:39 -0500, Dan Williams wrote: > > Greg's right, there's no reason not to use cdc-acm if you want to do > > that, since not all cdc-acm devices are modems. If you get a USBIF > &g

[PATCH 1/2 v3] usbnet: allow status interrupt URB to always be active

2013-03-28 Thread Dan Williams
have stopped it. The URB is still killed and re-submitted for suspend/resume, as before, with the same refcount it had at suspend. Signed-off-by: Dan Williams --- diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 51f3192..6431a03 100644 --- a/drivers/net/usb/usbnet.c +++ b/driver

[PATCH 2/2 v3] sierra_net: keep status interrupt URB active

2013-03-28 Thread Dan Williams
dication can be received even if the netdev is closed, which is the case right after device insertion. Signed-off-by: Dan Williams --- diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c index 79ab243..c707225 100644 --- a/drivers/net/usb/sierra_net.c +++ b/drivers/net/u

Re: [PATCH 1/2 v3] usbnet: allow status interrupt URB to always be active

2013-04-01 Thread Dan Williams
On Sat, 2013-03-30 at 22:11 +0800, Ming Lei wrote: > On Fri, Mar 29, 2013 at 12:30 AM, Dan Williams wrote: > > > > Some drivers (sierra_net) need the status interrupt URB > > active even when the device is closed, because they receive > > custom indications from

[PATCH 1/2 v4] usbnet: allow status interrupt URB to always be active

2013-04-09 Thread Dan Williams
have stopped it. The URB is still killed and re-submitted for suspend/resume, as before, with the same refcount it had at suspend. Signed-off-by: Dan Williams --- drivers/net/usb/usbnet.c | 79 ++ include/linux/usb/usbnet.h | 5 +++ 2 files change

[PATCH 2/2 v4] sierra_net: keep status interrupt URB active

2013-04-09 Thread Dan Williams
dication can be received even if the netdev is closed, which is the case right after device insertion. Signed-off-by: Dan Williams --- drivers/net/usb/sierra_net.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/drivers/net/usb/sierra_

Re: [PATCH 1/2 v4] usbnet: allow status interrupt URB to always be active

2013-04-10 Thread Dan Williams
On Wed, 2013-04-10 at 09:23 +0200, Oliver Neukum wrote: > On Tuesday 09 April 2013 18:02:27 Dan Williams wrote: > > Some drivers (sierra_net) need the status interrupt URB > > active even when the device is closed, because they receive > > custom indications from firmwa

Re: [PATCH 1/2 v4] usbnet: allow status interrupt URB to always be active

2013-04-10 Thread Dan Williams
On Wed, 2013-04-10 at 15:06 +0200, Oliver Neukum wrote: > On Wednesday 10 April 2013 07:49:11 Dan Williams wrote: > > On Wed, 2013-04-10 at 09:23 +0200, Oliver Neukum wrote: > > > On Tuesday 09 April 2013 18:02:27 Dan Williams wrote: > > > > > +/* Submit th

Re: [PATCH 1/2 v4] usbnet: allow status interrupt URB to always be active

2013-04-10 Thread Dan Williams
On Wed, 2013-04-10 at 15:29 +0200, Oliver Neukum wrote: > On Wednesday 10 April 2013 08:18:57 Dan Williams wrote: > > On Wed, 2013-04-10 at 15:06 +0200, Oliver Neukum wrote: > > > On Wednesday 10 April 2013 07:49:11 Dan Williams wrote: > > > > On Wed, 2013-04-10 at 09

Re: [PATCH 2/2 v4] sierra_net: keep status interrupt URB active

2013-04-10 Thread Dan Williams
On Wed, 2013-04-10 at 09:15 +0200, Oliver Neukum wrote: > On Tuesday 09 April 2013 18:05:51 Dan Williams wrote: > > The driver and firmware sync up through SYNC messages, and the > > firmware's affirmative reply to these SYNC messages appears to be the > > "Res

Re: [PATCH 1/2 v4] usbnet: allow status interrupt URB to always be active

2013-04-10 Thread Dan Williams
On Wed, 2013-04-10 at 15:58 +0200, Oliver Neukum wrote: > On Wednesday 10 April 2013 08:54:43 Dan Williams wrote: > > > The refcounting is very good. Just don't mess around with "force" > > > > That's easy to do if the helpers aren't used for susp

[PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-10 Thread Dan Williams
have stopped it. The URB is still killed and re-submitted for suspend/resume, as before, with the same refcount it had at suspend. Signed-off-by: Dan Williams --- drivers/net/usb/usbnet.c | 79 ++ include/linux/usb/usbnet.h | 5 +++ 2 files change

[PATCH 2/2 v5] sierra_net: keep status interrupt URB active

2013-04-10 Thread Dan Williams
dication can be received even if the netdev is closed, which is the case right after device insertion. Signed-off-by: Dan Williams --- drivers/net/usb/sierra_net.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/drivers/net/usb/sierra_

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-11 Thread Dan Williams
On Thu, 2013-04-11 at 10:31 +0800, Ming Lei wrote: > On Thu, Apr 11, 2013 at 4:30 AM, Dan Williams wrote: > > Some drivers (sierra_net) need the status interrupt URB > > active even when the device is closed, because they receive > > custom indications from firmware. Add

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-15 Thread Dan Williams
On Wed, 2013-04-10 at 15:30 -0500, Dan Williams wrote: > Some drivers (sierra_net) need the status interrupt URB > active even when the device is closed, because they receive > custom indications from firmware. Add functions to refcount > the status interrupt URB submit/kill opera

Re: [PATCH net,stable 0/3] qmi_wwan: working around 3 serious firmware bugs

2013-04-19 Thread Dan Williams
hould apply cleanly to net/master, net-next/master and > > stable/linux-3.8.y > > Series applied and queued up for -stable, thanks! You're fast :) But in any case: Tested-by: Dan Williams Tested on Gobi 1K (known not to exhibit the raw-ip bug), Novatel E362, and Pantech UML29

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-24 Thread Dan Williams
On Fri, 2013-04-19 at 10:25 +0200, Oliver Neukum wrote: > On Thursday 18 April 2013 11:51:25 Ming Lei wrote: > > On Wed, Apr 17, 2013 at 2:55 PM, Oliver Neukum wrote: > > > > > If we have a function for starting a status URB we want to use it whenever > > > it applies, that is also when we need to

[PATCH 1/2 v5 RESEND] usbnet: allow status interrupt URB to always be active

2013-04-29 Thread Dan Williams
have stopped it. The URB is still killed and re-submitted for suspend/resume, as before, with the same refcount it had at suspend. Signed-off-by: Dan Williams --- NOTE: Oliver already ACK-ed this series, but Ming disagreed about the mem_flags argument to usbnet_status_start() and consensus seems far

<    1   2   3   4   5   6   7   >