On Wed, 2012-09-19 at 22:02 +0200, Bjørn Mork wrote:
> The three Pantech devices UML190 (106c:3716), UML290 (106c:3718) and
> P4200 (106c:3721) all use the same subclasses to identify vendor
> specific functions. Replace the existing device specific entries
> with generic vendor matching, adding support for the P4200.
Yeah, this looks right. I just reverified that the UM190 follows the
same pattern; WMC on 0xFE and DIAG on 0xFF. I don't know for sure that
NMEA is 0xFD, but the UM190 *does* have a 0xFD descriptor as interface
#3.
Acked-by: Dan Williams <d...@redhat.com>
> Cc: <sta...@vger.kernel.org>
> Cc: Thomas Schäfer <tschae...@t-online.de>
> Cc: Dan Williams <d...@redhat.com>
> Signed-off-by: Bjørn Mork <bj...@mork.no>
> ---
> drivers/usb/serial/qcaux.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/usb/serial/qcaux.c b/drivers/usb/serial/qcaux.c
> index a4edc7e..9b1b96f 100644
> --- a/drivers/usb/serial/qcaux.c
> +++ b/drivers/usb/serial/qcaux.c
> @@ -36,8 +36,6 @@
> #define UTSTARCOM_PRODUCT_UM175_V1 0x3712
> #define UTSTARCOM_PRODUCT_UM175_V2 0x3714
> #define UTSTARCOM_PRODUCT_UM175_ALLTEL 0x3715
> -#define PANTECH_PRODUCT_UML190_VZW 0x3716
> -#define PANTECH_PRODUCT_UML290_VZW 0x3718
>
> /* CMOTECH devices */
> #define CMOTECH_VENDOR_ID 0x16d8
> @@ -68,11 +66,9 @@ static struct usb_device_id id_table[] = {
> { USB_DEVICE_AND_INTERFACE_INFO(LG_VENDOR_ID, LG_PRODUCT_VX4400_6000,
> 0xff, 0xff, 0x00) },
> { USB_DEVICE_AND_INTERFACE_INFO(SANYO_VENDOR_ID,
> SANYO_PRODUCT_KATANA_LX, 0xff, 0xff, 0x00) },
> { USB_DEVICE_AND_INTERFACE_INFO(SAMSUNG_VENDOR_ID,
> SAMSUNG_PRODUCT_U520, 0xff, 0x00, 0x00) },
> - { USB_DEVICE_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID,
> PANTECH_PRODUCT_UML190_VZW, 0xff, 0xff, 0xff) },
> - { USB_DEVICE_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID,
> PANTECH_PRODUCT_UML190_VZW, 0xff, 0xfe, 0xff) },
> - { USB_DEVICE_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID,
> PANTECH_PRODUCT_UML290_VZW, 0xff, 0xfd, 0xff) }, /* NMEA */
> - { USB_DEVICE_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID,
> PANTECH_PRODUCT_UML290_VZW, 0xff, 0xfe, 0xff) }, /* WMC */
> - { USB_DEVICE_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID,
> PANTECH_PRODUCT_UML290_VZW, 0xff, 0xff, 0xff) }, /* DIAG */
> + { USB_VENDOR_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID, 0xff, 0xfd, 0xff)
> }, /* NMEA */
> + { USB_VENDOR_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID, 0xff, 0xfe, 0xff)
> }, /* WMC */
> + { USB_VENDOR_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID, 0xff, 0xff, 0xff)
> }, /* DIAG */
> { },
> };
> MODULE_DEVICE_TABLE(usb, id_table);
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
