Hi Peter,
Have you ever tried disabling auto-pm? Did things go smoothly if auto-pm is
disabled?
I always disable usb auto-pm in below way.
# echo on | tee /sys/bus/usb/devices/*/power/control
# echo on > /sys/bus/pci/devices//power/control
Thanks,
Baolu
On 12/05/2015 06:59 PM, Peter Wu wrote:
On 12/06/2015 09:47 PM, Geyslan G. Bem wrote:
> This patch fixes a 'quirk_usb_handoff_xhci()' branch return that was not
> unmapping correctly.
>
> Coccinelle: scripts/coccinelle/free/iounmap.cocci
>
> Signed-off-by: Geyslan G. Bem
> ---
> drivers/usb/host/pci-quirks.c | 3 ++-
> 1 file change
On Mon, Dec 07, 2015 at 05:11:50PM +0800, Lu Baolu wrote:
> Hi Peter,
>
> Have you ever tried disabling auto-pm? Did things go smoothly if auto-pm is
> disabled?
>
> I always disable usb auto-pm in below way.
>
> # echo on | tee /sys/bus/usb/devices/*/power/control
> # echo on > /sys/bus/pci/de
Hi Felipe,
I am going back on this subject (again :) )
On mar., oct. 20 2015, Gregory CLEMENT
wrote:
> Hi Felipe,
>
> On lun., oct. 05 2015, Felipe Balbi wrote:
>
>
>>> So after many tests on different devices, 200ms is enough for most of
>>> them, but for one, 2000ms (2s) was needed!
>>
On Wed, Dec 2, 2015 at 9:43 PM, Geyslan G. Bem wrote:
> Replace dma_pool_alloc and memset with a single call to dma_pool_zalloc.
>
> Caught by coccinelle.
I would mention which script was used, but other than that:
Acked-by: Peter Senna Tschudin
>
> Signed-off-by: Geyslan G. Bem
> ---
> driver
On Wed, Dec 2, 2015 at 10:45 PM, Geyslan G. Bem wrote:
> Get rid of bool explicit comparisons.
>
> Caught by Coccinelle.
I would mention the path to the .cocci script, but other than that:
Acked-by: Peter Senna Tschudin
>
> Signed-off-by: Geyslan G. Bem
> ---
> drivers/usb/host/fhci-tds.c | 2
On Wed, Dec 2, 2015 at 11:18 PM, Geyslan G. Bem wrote:
> Replace BUG() with BUG_ON().
>
> Caught by coccinelle.
I would mention the path to the .cocci script, but other than that:
Acked-by: Peter Senna Tschudin
>
> Signed-off-by: Geyslan G. Bem
> ---
> drivers/usb/host/oxu210hp-hcd.c | 8 +++--
On Thu, Dec 3, 2015 at 12:25 AM, Geyslan G. Bem wrote:
> When assigning bool use true instead of 1. If declaring it as static and
> it's false there's no need to initialize it, since static variables are
> zeroed by default.
>
> Caught by coccinelle.
>
> Signed-off-by: Geyslan G. Bem
Acked-by: Pe
2015-12-07 6:30 GMT-03:00 Lu Baolu :
>
>
> On 12/06/2015 09:47 PM, Geyslan G. Bem wrote:
>> This patch fixes a 'quirk_usb_handoff_xhci()' branch return that was not
>> unmapping correctly.
>>
>> Coccinelle: scripts/coccinelle/free/iounmap.cocci
>>
>> Signed-off-by: Geyslan G. Bem
>> ---
>> drive
When receiving GINTSTS_GINNAKEFF or GINTSTS_GOUTNAKEFF interrupt,
DCTL will be overwritten with DCTL_CGOUTNAK or DCTL_CGNPINNAK values.
Instead of overwriting it, write only needed bits.
It could cause an issue if GINTSTS_GINNAKEFF or GINTSTS_GOUTNAKEFF
interrupt is received after dwc2 disabled pu
On 12/07/2015 05:37 PM, Peter Wu wrote:
> On Mon, Dec 07, 2015 at 05:11:50PM +0800, Lu Baolu wrote:
>> Hi Peter,
>>
>> Have you ever tried disabling auto-pm? Did things go smoothly if auto-pm is
>> disabled?
>>
>> I always disable usb auto-pm in below way.
>>
>> # echo on | tee /sys/bus/usb/devi
On Mon, Dec 07, 2015 at 07:08:50PM +0800, Lu Baolu wrote:
>
>
> On 12/07/2015 05:37 PM, Peter Wu wrote:
> > On Mon, Dec 07, 2015 at 05:11:50PM +0800, Lu Baolu wrote:
> >> Hi Peter,
> >>
> >> Have you ever tried disabling auto-pm? Did things go smoothly if auto-pm
> >> is disabled?
> >>
> >> I al
Hello.
On 12/07/2015 12:30 PM, Lu Baolu wrote:
This patch fixes a 'quirk_usb_handoff_xhci()' branch return that was not
unmapping correctly.
Coccinelle: scripts/coccinelle/free/iounmap.cocci
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/pci-quirks.c | 3 ++-
1 file changed, 2 insert
Hi,
On Mon, Dec 07, 2015 at 10:24:22AM +0900, Chanwoo Choi wrote:
> Hi,
>
> On 2015년 12월 04일 17:51, Heikki Krogerus wrote:
> > Hi,
> >
> >> I do never want to add some specific funtcion for only this driver.
> >> I think is not appropriate way.
> >> - intel_usb_mux_unregister
> >> - intel_usb_mu
The Marvell BG4CT STB board has board level vbus control through gpio.
This patch adds the vbus regulator control to support this board.
Signed-off-by: Jisheng Zhang
---
drivers/usb/host/xhci-plat.c | 39 ++-
drivers/usb/host/xhci.h | 2 ++
2 files chang
The Marvell BG4CT has xhci controller. This controller has two phys:
one for usb2 and another for usb3. BG4CT boards have board level vbus
control through gpio.
I plan to add the xhci support in two steps: first of all, add generic
PHY and vbus regulator control support to the xhci-plat driver. Th
Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the
usb_phy for usb3, but it attached the usb_phy to incorrect hcd. The
xhci->shared_hcd is the hcd for usb3, this patch fixes this issue
by attach the usb_phy to the xhci->shared_hcd.
Signed-off-by: Jisheng Zhang
---
drivers/usb/
Commit 4718c1774051 ("usb: host: xhci-plat: add clock support") adds
optional clk support, but it forgets to prepare/disable and
enable/unprepare the clk in the resume/suspend path. This path fixes
this issue by adding missing clk related calls.
Signed-off-by: Jisheng Zhang
Fixes: 4718c1774051 ("
Marvell BG4CT SoC needs two phy: one for usb2 and another for usb3. Add
the calls to retrieve generic PHY to xhci plat in order to support this.
Signed-off-by: Jisheng Zhang
---
drivers/usb/host/xhci-plat.c | 87 ++--
1 file changed, 75 insertions(+), 12 d
Commit 63589e92c2d9 ("clk: Ignore error and NULL pointers passed to
clk_{unprepare, disable}()") allows NULL or error pointer to be passed
unconditionally.
This patch is to simplify probe error and remove code paths.
Signed-off-by: Jisheng Zhang
---
drivers/usb/host/xhci-plat.c | 6 ++
1 fi
Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the
usb_phy for usb3, but it forgets to shutdown/init the usb_phy in the
suspend/resume path. This patch fixes this issue by adding missing
usb_phy related calls.
Signed-off-by: Jisheng Zhang
---
drivers/usb/host/xhci-plat.c | 5 +
Sorting the headers in alphabetic order will help to reduce the conflict
when adding new headers later.
Signed-off-by: Jisheng Zhang
---
drivers/usb/host/xhci-plat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.
Hi,
Well the amount of data is very small, about 16 floats plus a header in the
message. Lets round it up to 128 bytes. That means 128000 bytes per second for
a 1000Hz frequency (which the device can give). 128000 bytes per second is a
lot less than the 480 Mbps that USB 2 gives. That's what's
On Mon, Dec 07, 2015 at 01:50:37PM +, Jose Colmenares wrote:
> Hi,
>
> Well the amount of data is very small, about 16 floats plus a header in the
> message. Lets round it up to 128 bytes. That means 128000 bytes per second
> for a 1000Hz frequency (which the device can give). 128000 bytes p
On 12/02/2015 07:14 PM, Rogan Dawes wrote:
On Wed, Dec 02, 2015 at 06:00:21PM +0100, Krzysztof Opasiak wrote:
On 12/02/2015 01:29 PM, Rogan Dawes wrote:
As mentioned originally, I'm trying to come up with an IP KVM, as inexpensively
as possible. Realising that the approach that I am follow
On Mon, Dec 07, 2015 at 04:12:22PM +0100, Krzysztof Opasiak wrote:
> >
> >Is there any chance in getting a look at your code?
> >
>
> Sorry for my late response but I was on a sickness leave and didn't
> have access to my company email.
>
> Yah, sure. I have just pushed the code to github:
>
> h
On Sun, 6 Dec 2015, Steinar H. Gunderson wrote:
> On Sun, Dec 06, 2015 at 01:06:08AM +0100, Steinar H. Gunderson wrote:
> > I'll try to update your patch with the other suggestions tomorrow. Thanks!
>
> Here we are. Lightly tested, I believe all comments should be addressed.
This looks quite goo
* Kishon Vijay Abraham I [151206 23:03]:
> On Tuesday 01 December 2015 11:07 AM, Tony Lindgren wrote:
> > We currently can't unload omap2430 MUSB platform glue driver module and
> > this cause issues for fixing the MUSB code further. The reason we can't
> > remove omap2430 is because it uses the P
When an interface is brought up which was previously suspended (via
runtime PM), it would hang. This happens because napi_disable is called
before napi_enable.
Solve this by avoiding napi_disable before the device is fully up.
While at it, remove WORK_ENABLE check from rtl8152_open (introduced wi
Michael:
Here at last is the final version of the patch, or something very close
to it. This should be applied on top of the other EHCI patches, but
not the quick-and-dirty fix, which it replaces.
Please test it and let me know the results.
Alan Stern
Index: usb-4.3/drivers/usb/host/ehci.h
Hi,
Gregory CLEMENT writes:
> Hi Felipe,
>
> I am going back on this subject (again :) )
>
> On mar., oct. 20 2015, Gregory CLEMENT
> wrote:
>
>> Hi Felipe,
>>
>> On lun., oct. 05 2015, Felipe Balbi wrote:
>>
>>
So after many tests on different devices, 200ms is enough for most of
I have a USB Lenovo ThinkPad Keyboard with TrackPoint (vendor:product
17ef:6009), and a ThinkPad Yoga 12 (Broadwell version) with OneLink Pro
dock. If I plug the keyboard/mouse directly into the laptop,
it works fine. If I plug it into the dock, the keyboard works fine;
however, the mouse works for
Hi,
Josh Triplett writes:
> I have a USB Lenovo ThinkPad Keyboard with TrackPoint (vendor:product
> 17ef:6009), and a ThinkPad Yoga 12 (Broadwell version) with OneLink Pro
> dock. If I plug the keyboard/mouse directly into the laptop,
> it works fine. If I plug it into the dock, the keyboard wor
On Mon, Dec 07, 2015 at 02:29:39PM -0600, Felipe Balbi wrote:
>
> Hi,
>
> Josh Triplett writes:
> > I have a USB Lenovo ThinkPad Keyboard with TrackPoint (vendor:product
> > 17ef:6009), and a ThinkPad Yoga 12 (Broadwell version) with OneLink Pro
> > dock. If I plug the keyboard/mouse directly in
Hi,
Josh Triplett writes:
>> > Looking at the sysfs path for the input device as shown in dmesg,
>> > /sys/devices/pci\:00/\:00\:14.0/usb2/2-3/2-3.1/2-3.1.2/2-3.1.2\:1.1/supports_autosuspend
>> > did say "1". However, the device didn't actually appear to have
>> > autosuspend *enabled*.
On Mon, Dec 07, 2015 at 03:03:40PM -0600, Felipe Balbi wrote:
> Josh Triplett writes:
> >> > Looking at the sysfs path for the input device as shown in dmesg,
> >> > /sys/devices/pci\:00/\:00\:14.0/usb2/2-3/2-3.1/2-3.1.2/2-3.1.2\:1.1/supports_autosuspend
> >> > did say "1". However, the d
Hi,
Josh Triplett writes:
> On Mon, Dec 07, 2015 at 03:03:40PM -0600, Felipe Balbi wrote:
>> Josh Triplett writes:
>> >> > Looking at the sysfs path for the input device as shown in dmesg,
>> >> > /sys/devices/pci\:00/\:00\:14.0/usb2/2-3/2-3.1/2-3.1.2/2-3.1.2\:1.1/supports_autosuspend
>
On Mon, 7 Dec 2015, Josh Triplett wrote:
> The following files appear under the power directory when plugged in via
> the dock:
>
> ~$ head
> /sys/devices/pci:00/:00:14.0/usb2/2-3/2-3.1/2-3.1.2/2-3.1.2:1.1/power/*
> ==>
> /sys/devices/pci:00/:00:14.0/usb2/2-3/2-3.1/2-3.1.2/2-3.1
On Mon, 7 Dec 2015, Felipe Balbi wrote:
> if those are not enabled, then the device doesn't have pm_runtime
> callbacks, see:
>
> int dpm_sysfs_add(struct device *dev)
> {
> int rc;
>
> rc = sysfs_create_group(&dev->kobj, &pm_attr_group);
> if (rc)
> return rc;
>
On Mon, Dec 07, 2015 at 03:45:23PM -0600, Felipe Balbi wrote:
>
> Hi,
>
> Josh Triplett writes:
> > On Mon, Dec 07, 2015 at 03:03:40PM -0600, Felipe Balbi wrote:
> >> Josh Triplett writes:
> >> >> > Looking at the sysfs path for the input device as shown in dmesg,
> >> >> > /sys/devices/pci
On Mon, Dec 07, 2015 at 05:02:34PM -0500, Alan Stern wrote:
> On Mon, 7 Dec 2015, Josh Triplett wrote:
>
> > The following files appear under the power directory when plugged in via
> > the dock:
> >
> > ~$ head
> > /sys/devices/pci:00/:00:14.0/usb2/2-3/2-3.1/2-3.1.2/2-3.1.2:1.1/power/*
The xhci->quirks member is overwritten in xhci_gen_setup() with the
quirks given through the module load parameter. Without this patch the
usb3-lpm-capable quirk will be over written before it gets used. This
patch moves the quirks code to the xhci_plat_quirks() callback function
which gets called
These patches are needed to make the Broadcom XHCI controller work. We
will submit support for the controller later.
changes sinve v1:
* I removed the bcma-hcd specific patches for now.
Hauke Mehrtens (1):
usb: xhci: plat: fix adding usb3-lpm-capable quirk
Rafał Miłecki (1):
usb: xhci: add
From: Rafał Miłecki
This fixes problem with controller seeing devices only in some small
percentage of cold boots.
This quirk is also added to the platform data so we can activate it
when we register our platform driver.
Signed-off-by: Rafał Miłecki
Signed-off-by: Hauke Mehrtens
---
drivers/u
Hi,
Hauke Mehrtens writes:
> From: Rafał Miłecki
>
> This fixes problem with controller seeing devices only in some small
> percentage of cold boots.
> This quirk is also added to the platform data so we can activate it
> when we register our platform driver.
it would've been nicer if you coul
Hi Hauke,
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on next-20151207]
[cannot apply to v4.4-rc4]
url:
https://github.com/0day-ci/linux/commits/Hauke-Mehrtens/usb-xhci-plat-fix-adding-usb3-lpm-capable-quirk/20151208-063433
base: https://git.kernel.org/pub/scm
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 12/07/2015 11:39 PM, Felipe Balbi wrote:
>
> Hi,
>
> Hauke Mehrtens writes:
>> From: Rafał Miłecki
>>
>> This fixes problem with controller seeing devices only in some
>> small percentage of cold boots. This quirk is also added to the
>> plat
On 12/07/2015 11:43 PM, kbuild test robot wrote:
> Hi Hauke,
>
> [auto build test WARNING on usb/usb-testing]
> [also build test WARNING on next-20151207]
> [cannot apply to v4.4-rc4]
>
> url:
> https://github.com/0day-ci/linux/commits/Hauke-Mehrtens/usb-xhci-plat-fix
On Mon, Dec 07, 2015 at 10:45:55AM -0500, Alan Stern wrote:
>> Here we are. Lightly tested, I believe all comments should be addressed.
> This looks quite good. I have only a couple of comments.
Excellent. I'm sorry we've needed so many rounds; this is what happens when
you pick up someone else's
Hi,
Hauke Mehrtens writes:
>> it would've been nicer if you could add an erratum ID number for
>> future reference together with a more verbose discussion of the
>> problem. You're not describing what the problem is and that's
>> important.
>
> I do not have access to the documentation for this
This patch fixes a 'quirk_usb_handoff_xhci()' branch return that
was not unmapping correctly.
Coccinelle: scripts/coccinelle/free/iounmap.cocci
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/pci-quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/
2015-12-07 8:37 GMT-03:00 Sergei Shtylyov :
> Hello.
>
> On 12/07/2015 12:30 PM, Lu Baolu wrote:
>
>>> This patch fixes a 'quirk_usb_handoff_xhci()' branch return that was not
>>> unmapping correctly.
>>>
>>> Coccinelle: scripts/coccinelle/free/iounmap.cocci
>>>
>>> Signed-off-by: Geyslan G. Bem
>
Remove mach/irq.h from the list of included headers, there is no
compilation dependency on this include file, and the change is needed
to prevent a compilation failure, when mach/irq.h is removed.
Additionally remove other unneeded includes and sort out their order.
Signed-off-by: Vladimir Zapols
Remove mach/irq.h from the list of included headers, there is no
compilation dependency on this include file, the change is needed
to prevent a compilation failure, when mach/irq.h is removed.
Additionally remove other unneeded includes.
Signed-off-by: Vladimir Zapolskiy
---
drivers/usb/host/oh
Hi,
On 2015년 12월 07일 21:52, Heikki Krogerus wrote:
> Hi,
>
> On Mon, Dec 07, 2015 at 10:24:22AM +0900, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2015년 12월 04일 17:51, Heikki Krogerus wrote:
>>> Hi,
>>>
I do never want to add some specific funtcion for only this driver.
I think is not appropria
Hi all,
There is a known issue that the USB code can't handle USB HUB's
external pins well, in that case, it may cause some onboard
USB HUBs can't work since their PHY's clock or reset pin needs to
operate.
The user reported this issue at below:
http://www.spinics.net/lists/linux-usb/msg131502.ht
Current USB HUB driver lacks of platform interfaces to configure
external signal on HUB chip, eg, the PHY input clock and gpio reset
pin for HUB, these kinds of HUBs are usually soldered at the board,
and they are not hot-plug USB devices.
With this patch, the user can configure the HUB's pins at
The current dts describes USB HUB's property at USB controller's
entry, it is improper. Fix it by using a generic USB HUB entry.
Signed-off-by: Peter Chen
---
arch/arm/boot/dts/imx6qdl-udoo.dtsi | 25 ++---
1 file changed, 6 insertions(+), 19 deletions(-)
diff --git a/arch/a
Add dt-binding documentation for generic onboard USB HUB.
Signed-off-by: Peter Chen
---
.../bindings/usb/generic-onboard-hub.txt | 28 ++
1 file changed, 28 insertions(+)
create mode 100644
Documentation/devicetree/bindings/usb/generic-onboard-hub.txt
diff --git
On Mon, Dec 7, 2015 at 11:37 PM, Peter Chen wrote:
> Add dt-binding documentation for generic onboard USB HUB.
>
> Signed-off-by: Peter Chen
> ---
> .../bindings/usb/generic-onboard-hub.txt | 28
> ++
> 1 file changed, 28 insertions(+)
> create mode 100644
> Docu
Hi,
Peter Chen writes:
> diff --git a/drivers/usb/misc/Makefile b/drivers/usb/misc/Makefile
> index 45fd4ac..da52e9a 100644
> --- a/drivers/usb/misc/Makefile
> +++ b/drivers/usb/misc/Makefile
> @@ -29,3 +29,4 @@ obj-$(CONFIG_USB_CHAOSKEY) += chaoskey.o
>
> obj-$(CONFIG_USB_SISUSBVGA)
Hi Peter,
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.4-rc4 next-20151207]
url:
https://github.com/0day-ci/linux/commits/Peter-Chen/USB-add-generic-onboard-USB-HUB-driver/20151208-094428
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb
Peter Wu [mailto:pe...@lekensteyn.nl]
> Sent: Tuesday, December 08, 2015 12:59 AM
[...]
> + if (tp->netdev->flags & IFF_UP) {
Maybe you could just replace the checking of netif_running(tp->netdev) with
this.
Excuse me. I have a question. Before the open() is finished, the
ne
If musb_init_controller fails at musb_platform_init, we have already
called pm_runtime_irq_safe for musb and that causes the pm runtime count
to be enabled for parent before the parent has completed initialization.
This causes pm to stop working as on unload nothing gets idled.
This issue can be r
Hi,
this short series adds generic, and soc-specific r8a7792 and r8a7793 compat
strings to the Renesas USBHS driver. The intention is to provide a complete
set of compat strings for known R-Car SoCs.
Simon Horman (2):
usb: renesas_usbhs: add fallback compatibility string
usb: renesas_usbhs: a
Add fallback compatibility string.
This is in keeping with the fallback scheme being adopted wherever
appropriate for drivers for Renesas SoCs.
Signed-off-by: Simon Horman
---
Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 ++--
drivers/usb/renesas_usbhs/common.c
Simply document new compatibility string.
As a previous patch adds a generic R-Car Gen2 compatibility string
there appears to be no need for a driver updates.
Also add names for SoCs.
Signed-off-by: Simon Horman
---
Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 10 ++
1 file
Jose Colmenares wrote:
> 128000 bytes per second for a 1000Hz frequency (which the device
> can give). 128000 bytes per second is a lot less than the 480 Mbps
> that USB 2 gives. That's what's killing me.
I don't think you have written that you have a particular latency
requirement, but Greg seems
Hi Simon
> Add fallback compatibility string.
> This is in keeping with the fallback scheme being adopted wherever
> appropriate for drivers for Renesas SoCs.
>
> Signed-off-by: Simon Horman
> ---
(snip)
> + {
> + .compatible = "renesas,usbhs",
> + .data = (void *)US
On Tue, Dec 08, 2015 at 09:37:48AM +0800, Peter Chen wrote:
> Current USB HUB driver lacks of platform interfaces to configure
> external signal on HUB chip, eg, the PHY input clock and gpio reset
> pin for HUB, these kinds of HUBs are usually soldered at the board,
> and they are not hot-plug USB
On Tue, Dec 08, 2015 at 06:05:51AM +, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > Add fallback compatibility string.
> > This is in keeping with the fallback scheme being adopted wherever
> > appropriate for drivers for Renesas SoCs.
> >
> > Signed-off-by: Simon Horman
> > ---
> (snip)
> >
71 matches
Mail list logo
