On Wed, Aug 27, 2014 at 12:20 PM, Daniel Mack wrote:
> On 08/27/2014 06:08 AM, Jassi Brar wrote:
>> On Wed, Aug 27, 2014 at 3:23 AM, Daniel Mack wrote:
>
>>> + uac2->p_interval = (1 << (ep_desc->bInterval - 1)) * factor;
>>> + req_len = rate / uac2->p_interval;
>>>
>>
On 08/27/2014 09:07 AM, Jassi Brar wrote:
> On Wed, Aug 27, 2014 at 12:20 PM, Daniel Mack wrote:
>> Hmm? The first USB_XFERS packets will only contain zeros, and we're only
>> preparing those here. For every successive packet, the length is
>> recalculated and the audio material is copied in acco
On 08/27/2014 09:15 AM, Daniel Mack wrote:
> On 08/27/2014 09:07 AM, Jassi Brar wrote:
>> On Wed, Aug 27, 2014 at 12:20 PM, Daniel Mack wrote:
>
>>> Hmm? The first USB_XFERS packets will only contain zeros, and we're only
>>> preparing those here. For every successive packet, the length is
>>> re
On Wed, Aug 27, 2014 at 12:45 PM, Daniel Mack wrote:
> On 08/27/2014 09:07 AM, Jassi Brar wrote:
>> On Wed, Aug 27, 2014 at 12:20 PM, Daniel Mack wrote:
>
>>> Hmm? The first USB_XFERS packets will only contain zeros, and we're only
>>> preparing those here. For every successive packet, the length
On Wed, Aug 27, 2014 at 3:23 AM, Daniel Mack wrote:
> @@ -1099,11 +1139,31 @@ afunc_set_alt(struct usb_function *fn, unsigned intf,
> unsigned alt)
> prm = &uac2->c_prm;
> config_ep_by_speed(gadget, fn, ep);
> agdev->as_out_alt = alt;
> +
On 08/27/2014 09:28 AM, Jassi Brar wrote:
> On Wed, Aug 27, 2014 at 12:45 PM, Daniel Mack wrote:
>> On 08/27/2014 09:07 AM, Jassi Brar wrote:
>>> On Wed, Aug 27, 2014 at 12:20 PM, Daniel Mack wrote:
>>
Hmm? The first USB_XFERS packets will only contain zeros, and we're only
preparing th
On 08/27/2014 09:35 AM, Jassi Brar wrote:
> On Wed, Aug 27, 2014 at 3:23 AM, Daniel Mack wrote:
>> + uac2->p_residue = 0;
>> } else {
>> dev_err(dev, "%s:%d Error!\n", __func__, __LINE__);
>> return -EINVAL;
>> @@ -1128,7 +1188,7 @@ afunc_set_
Hi,
this is v4 of the f_uac2 timing fixup series.
Changes from v4:
* Fix buffer setup in afunc_set_alt()
Changes from v3:
* add another patch (3/5) to introduce agdev_to_uac2_opts()
which is also needed in 5/5
* patch 5/5 only:
move from a pre-calcul
Restructure some code to make it easier to read.
While at it, return -ENOMEM instead of -EINVAL if
usb_ep_alloc_request() fails, and omit the logging in such cases
(the mm core will complain loud enough).
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 39 +++--
In afunc_bind() and afunc_set_alt(), &uac2->pdev.dev are used multiple
times. Adding a short-hand for them makes lines shorter so we can
remove some line wraps.
No functional change.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 29 +++--
1 file c
Add a simple container_of() wrapper to get a struct f_uac2_opts from a
struct struct audio_dev. Use it in two places where it is currently
open-coded.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
The UAC2 function driver currently responds to all packets at all times
with wMaxPacketSize packets. That results in way too fast audio
playback as the function driver (which is in fact supposed to define
the audio stream pace) delivers as fast as it can.
Fix this by sizing each packet correctly w
With packet sizes other than 512, payloads in the packets may wrap
around the ALSA dma buffer partially, which leads to memory corruption
and audible clicks and pops in the audio stream at the moment, because
there is no boundary check before the memcpy().
In preparation to an implementation for s
On Tue, 2014-08-26 at 10:47 -0400, Alan Stern wrote:
> On Mon, 25 Aug 2014, Oliver Neukum wrote:
> > Just set US_FL_NEEDS_CAP16. If READ CAPACITY(16) fails in that case,
> > it is clear that something is wrong. It must be set or READ CAPACITY(10)
> > alone would be taken as giving a valid answer.
dwc3 driver is using the new Exynos5 SoC series USB DRD PHY driver
(PHY_EXYNOS5_USBDRD which selects GENERIC_PHY) as can be seen by
looking at the following commits:
7a4cf0fde054 ("ARM: dts: Update DWC3 usb controller to use new
phy driver for exynos5250")
f070267b5fc1 ("ARM: dts: Enable su
On Wed, Aug 27, 2014 at 1:15 PM, Daniel Mack wrote:
> Hi,
>
> this is v4 of the f_uac2 timing fixup series.
>
> Changes from v4:
>
> * Fix buffer setup in afunc_set_alt()
>
> Changes from v3:
>
> * add another patch (3/5) to introduce agdev_to_uac2_opts()
> which is also
Ping
I have got also a problem with a usb sdcard reader (without power cut
during suspend)
[ 1073.606668] PM: Entering mem sleep
[ 1073.606742] Suspending console(s) (use no_console_suspend to debug)
[ 1073.607146] sd 1:0:0:0: [sda] Synchronizing SCSI cache
[ 1073.639076] sd 1:0:0:0: [sda] Stoppi
On 08/27/2014 10:38 AM, Jassi Brar wrote:
> On Wed, Aug 27, 2014 at 1:15 PM, Daniel Mack wrote:
>> Daniel Mack (5):
>> usb: gadget: f_uac2: restructure some code in afunc_set_alt()
>> usb: gadget: f_uac2: add short-hand for 'dev'
>> usb: gadget: f_uac2: introduce agdev_to_uac2_opts
>> usb
From: Yegor Yefremov
Using $(PWD) breaks builds when make was invoked from outside
of the kernel tree.
Signed-off-by: Yegor Yefremov
---
drivers/usb/gadget/Makefile |2 +-
drivers/usb/gadget/function/Makefile |4 ++--
drivers/usb/gadget/legacy/Makefile |6 +++---
3 files
On 08/04/2014 05:07 PM, Alan Stern wrote:
> On Mon, 4 Aug 2014, Roger Quadros wrote:
>
>> If user specifies that USB autosuspend must be disabled by module
>> parameter "usbcore.autosuspend=-1" then we must prevent
>> autosuspend of USB hub devices as well.
>>
>> commit 596d789a211d introduced in
On 08/26/2014 09:55 PM, Greg Kroah-Hartman wrote:
> On Tue, Aug 26, 2014 at 09:35:32AM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 08/25/2014 08:14 PM, Greg Kroah-Hartman wrote:
>>> On Mon, Aug 25, 2014 at 12:21:56PM +0200, Hans de Goede wrote:
This is a bit bigger hammer then I would like to
On 08/21/2014 01:06 AM, Joseph Salisbury wrote:
> On 08/19/2014 08:17 AM, Mathias Nyman wrote:
>> When we manually need to move the TR dequeue pointer we need to set the
>> correct cycle bit as well. Previously we used the trb pointer from the
>> last event received as a base, but this was changed
If user specifies that USB autosuspend must be disabled by module
parameter "usbcore.autosuspend=-1" then we must prevent
autosuspend of USB hub devices as well.
commit 596d789a211d introduced in v3.8 changed the original behaivour
and stopped respecting the usbcore.autosuspend parameter for hubs.
On Wednesday, August 27, 2014 4:53 PM, Bartlomiej Zolnierkiewicz wrote:
>
> dwc3 driver is using the new Exynos5 SoC series USB DRD PHY driver
> (PHY_EXYNOS5_USBDRD which selects GENERIC_PHY) as can be seen by
> looking at the following commits:
>
> 7a4cf0fde054 ("ARM: dts: Update DWC3 usb cont
Defining the vendor and the product id should be enough to discriminate
the device.
The reason for this patch is that there is a missmatch betweed the
modalias showed by sysfs and the modalias generated by file2alias.
One expects the programming interface in uppercase and the other
generates it i
All USB peripheral controller drivers called completion routines
directly. This patch moves the completion call from drivers to
usb_gadget_giveback_request(), in order to have a place where common
functionality can be added.
All places in drivers/usb/ matching "[-.]complete(" were replaced with a
This adds LED triggers for USB host and device. First patch refactors
UDC drivers as requested by Felipe Balbi, second patch adds the LED
triggers.
Changes from v2:
- host/gadget triggers merged to a single file in usb/common/
- udc drivers refactored so that LED trigger works for all of them
Cha
With this patch, USB activity can be signaled by blinking a LED. There
are two triggers, one for activity on USB host and one for USB gadget.
Both trigger should work with all host/device controllers. Tested only
with musb.
Signed-off-by: Michal Sojka
---
drivers/usb/Kconfig
On 14-08-27 04:40 AM, Matthieu CASTET wrote:
Ping
I have got also a problem with a usb sdcard reader (without power cut
during suspend)
[ 1073.606668] PM: Entering mem sleep
[ 1073.606742] Suspending console(s) (use no_console_suspend to debug)
[ 1073.607146] sd 1:0:0:0: [sda] Synchronizing SCS
On 08/26/2014 06:47 PM, Ricardo Ribalda Delgado wrote:
> While testing a usb gadget I managed to crash completely the host
> computer. This was due to a NULL pointer derefence.
>
> This patch avoids the crash although the kernel still outputs some
> warnings.
>
> Without this patch, kernels from
At least I have seen the issue on Debian 3.14 and 3.16. Is your patch
going to be backported to linux-stable? The computer crashes very very
badly
On Wed, Aug 27, 2014 at 4:25 PM, Mathias Nyman wrote:
> On 08/26/2014 06:47 PM, Ricardo Ribalda Delgado wrote:
>> While testing a usb gadget I managed
On 08/27/2014 07:07 AM, Mathias Nyman wrote:
> On 08/21/2014 01:06 AM, Joseph Salisbury wrote:
>> On 08/19/2014 08:17 AM, Mathias Nyman wrote:
>>> When we manually need to move the TR dequeue pointer we need to set the
>>> correct cycle bit as well. Previously we used the trb pointer from the
>>> l
On Wed, 27 Aug 2014, Daniel Mack wrote:
> The UAC2 function driver currently responds to all packets at all times
> with wMaxPacketSize packets. That results in way too fast audio
> playback as the function driver (which is in fact supposed to define
> the audio stream pace) delivers as fast as it
On Wed, 27 Aug 2014, Gavin Guo wrote:
> > Still, why not use the BIOS setting to disable EHCI?
>
> It's hardware enablement policy. By default, we can't change the BIOS
> setting to make the bug disappear until we find out the bug is due to
> BIOS's bug. Add kernel parameters is the temporary sol
On Wed, 27 Aug 2014, Oliver Neukum wrote:
> > I don't think we want to add another SCSI flag to say that READ
> > CAPACITY(10) is unreliable.
>
> Why not? It would only be friendly to tell the upper layer
> of a malfunction if we know about it.
To what end? What will the upper layer do with thi
On Wed, 27 Aug 2014, Matthieu CASTET wrote:
> Ping
>
> I have got also a problem with a usb sdcard reader (without power cut
> during suspend)
> > > The usb storage driver call scsi_report_bus_reset after device reset,
> > > but because of commit dfcf7775 <4>, we don't ignore unit attention if
>
On Wed, 27 Aug 2014, Douglas Gilbert wrote:
> The unit attention doesn't look like a problem, it
> looks correct. If the system is unable to detect
> removable media being changed while the system is
> suspended, then
>
> If the media has a unique identifier, then this unit
> attention at wa
On Wed, 27 Aug 2014, Michal Sojka wrote:
> All USB peripheral controller drivers called completion routines
> directly. This patch moves the completion call from drivers to
> usb_gadget_giveback_request(), in order to have a place where common
> functionality can be added.
>
> All places in drive
On 08/27/2014 05:14 PM, Ricardo Ribalda Delgado wrote:
> At least I have seen the issue on Debian 3.14 and 3.16. Is your patch
> going to be backported to linux-stable? The computer crashes very very
> badly
>
Yes, it is, but it might need some additional work as it won't apply cleanly on
older
UVC video node is a TX device from the point of view of the gadget,
so we cannot rely on the video struct being filled with zeros, because
VFL_DIR_TX is actually 1.
Suggested-by: Sylwester Nawrocki
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/function/f_uvc.c | 1 +
1 file change
Hi Xuebing,
> Would you mind to share how did you run the test for both
> Playback/Capture? What host version are you using, as different Host
> enumerates (sends sequences of USB_REQ_SET_INTERFACE request differently)?
sure, on client side (BBB) I have a jackd on top alsa running and
connected
W dniu 18.08.2014 o 21:45, Laurent Pinchart pisze:
Hi Andrzej,
Thank you for the patches. The series looks good, I only had a few comments.
I have rebased the patches on top of my UVC gadget branch, addressed my
comments (the modified patches are marked as such in the commit message) and
pushed
Hello
Is somebody using/supporting g_webcam?
The only reference userland server is uvc-gadget from
http://git.ideasonboard.org/?p=uvc-gadget.git;a=summary ?
I have an industrial fpga camera that speaks v4l2, my plan is to
export it as an uvc camera via usb3380 as a debug interface.
Thanks!
--
Perhaps we could apply both patches to current tree and backport mine
to older kernels?
On Wed, Aug 27, 2014 at 5:27 PM, Mathias Nyman wrote:
> On 08/27/2014 05:14 PM, Ricardo Ribalda Delgado wrote:
>> At least I have seen the issue on Debian 3.14 and 3.16. Is your patch
>> going to be backported
On Mon, Aug 25, 2014 at 11:48 AM, Stephen Warren wrote:
> On 08/18/2014 11:08 AM, Andrew Bresticker wrote:
>
>> diff --git a/include/dt-bindings/mailbox/tegra-xusb-mailbox.h
>> b/include/dt-bindings/mailbox/tegra-xusb-mailbox.h
>
>
>> +#define TEGRA_XUSB_MBOX_CHAN_HOST 0
>> +#define TEGRA_XUS
On 08/27/2014 10:36 AM, Andrew Bresticker wrote:
On Mon, Aug 25, 2014 at 12:12 PM, Stephen Warren wrote:
On 08/18/2014 11:08 AM, Andrew Bresticker wrote:
- #phy-cells: Should be 1. The specifier is the index of the PHY to
reference.
See for the list of valid
values.
+- mboxes: Must co
On Mon, Aug 25, 2014 at 12:22 PM, Stephen Warren wrote:
> On 08/18/2014 11:08 AM, Andrew Bresticker wrote:
>>
>> In addition to the PCIe and SATA PHYs, the XUSB pad controller also
>> supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single
>> PCIe or SATA lane and is mapped to one o
On Mon, Aug 25, 2014 at 12:12 PM, Stephen Warren wrote:
> On 08/18/2014 11:08 AM, Andrew Bresticker wrote:
>> - #phy-cells: Should be 1. The specifier is the index of the PHY to
>> reference.
>> See for the list of valid
>> values.
>> +- mboxes: Must contain an entry for the XUSB PHY mailbo
On 08/27/2014 04:18 PM, Alan Stern wrote:
> On Wed, 27 Aug 2014, Daniel Mack wrote:
>> +/*
>> + * Whenever there are more bytes in the accumulator than we
>> + * need to add one more sample frame, increase this packet's
>> + * size and decrease the a
Hi Alan,
On Wed, Aug 27, 2014 at 10:38 PM, Alan Stern wrote:
> On Wed, 27 Aug 2014, Gavin Guo wrote:
>
>> > Still, why not use the BIOS setting to disable EHCI?
>>
>> It's hardware enablement policy. By default, we can't change the BIOS
>> setting to make the bug disappear until we find out the b
Hi,
this is v6 of the f_uac2 timing fixup series.
Changes from v5:
* Pre-calculate some more variables so we have to do their
computation at runtime for each frame
Changes from v4:
* Fix buffer setup in afunc_set_alt()
Changes from v3:
* add another patch (3
The UAC2 function driver currently responds to all packets at all times
with wMaxPacketSize packets. That results in way too fast audio
playback as the function driver (which is in fact supposed to define
the audio stream pace) delivers as fast as it can.
Fix this by sizing each packet correctly w
In afunc_bind() and afunc_set_alt(), &uac2->pdev.dev are used multiple
times. Adding a short-hand for them makes lines shorter so we can
remove some line wraps.
No functional change.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 29 +++--
1 file c
With packet sizes other than 512, payloads in the packets may wrap
around the ALSA dma buffer partially, which leads to memory corruption
and audible clicks and pops in the audio stream at the moment, because
there is no boundary check before the memcpy().
In preparation to an implementation for s
Add a simple container_of() wrapper to get a struct f_uac2_opts from a
struct struct audio_dev. Use it in two places where it is currently
open-coded.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
Restructure some code to make it easier to read.
While at it, return -ENOMEM instead of -EINVAL if
usb_ep_alloc_request() fails, and omit the logging in such cases
(the mm core will complain loud enough).
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 39 +++--
2cab81d794db4e5fe919c4e1d624ea7] xhci: unit
> test ring enqueue/dequeue routines
> git bisect good fb6fa3e625e1e453aea9eeb97d58bee30e1c0781 # 00:00 60+
> 0 xhci: v1.0 scatterlist enqueue support (td-fragment rework)
> git bisect bad 66e8dfa4e0d9600dedc08adcaac83c378b65351b # 00:00 0-
> 1
On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren wrote:
> On 08/18/2014 11:08 AM, Andrew Bresticker wrote:
>>
>> The Tegra xHCI controller's firmware communicates requests to the host
>> processor through a mailbox interface. While there is only a single
>> communication channel, messages sent by
On 08/27/2014 11:38 AM, Andrew Bresticker wrote:
On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren wrote:
On 08/18/2014 11:08 AM, Andrew Bresticker wrote:
The Tegra xHCI controller's firmware communicates requests to the host
processor through a mailbox interface. While there is only a single
On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren wrote:
> On 08/27/2014 11:38 AM, Andrew Bresticker wrote:
>>
>> On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren
>> wrote:
>>>
>>> On 08/18/2014 11:08 AM, Andrew Bresticker wrote:
+static int tegra_xusb_mbox_probe(struct platform_device *
Hi Baltlomiej,
On Wed, Aug 27, 2014 at 1:22 PM, Bartlomiej Zolnierkiewicz
wrote:
> dwc3 driver is using the new Exynos5 SoC series USB DRD PHY driver
> (PHY_EXYNOS5_USBDRD which selects GENERIC_PHY) as can be seen by
> looking at the following commits:
>
> 7a4cf0fde054 ("ARM: dts: Update DWC3
On 08/27/2014 12:13 PM, Andrew Bresticker wrote:
On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren wrote:
On 08/27/2014 11:38 AM, Andrew Bresticker wrote:
On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren
wrote:
On 08/18/2014 11:08 AM, Andrew Bresticker wrote:
+static int tegra_xusb_mbox_p
Hi,
On Mon, Aug 25, 2014 at 04:49:12PM +0800, Li Jun wrote:
> As Felipe suggested, dequeue the cdev->req before free its buffer.
>
> Suggested-by: Felipe Balbi
> Signed-off-by: Li Jun
please read Documentation/SubmittingPatches. Your commit log does not
make sense. You need to explain why the
On Tue, Aug 26, 2014 at 10:55:18AM +0800, Peter Chen wrote:
> Add compatible string for imx6sx-usbphy.
>
> Signed-off-by: Peter Chen
do I need to take this one as well or will DT folks take care of patch 2 ?
--
balbi
signature.asc
Description: Digital signature
On Fri, Aug 22, 2014 at 03:20:00PM +0530, Kiran Kumar Raparthy wrote:
> From: Todd Poynor
>
> usb: otg: Temporarily hold wakeupsource on charger and disconnect events
>
> Allow other parts of the system to react to the charger connect/disconnect
> event without allowing the system to suspend bef
Hi,
On Mon, Aug 25, 2014 at 11:16:28AM +0200, Robert Baldyga wrote:
> This patch introduces ioctl named FUNCTIONFS_ENDPOINT_DESC, which
> returns endpoint descriptor to userspace. It works only if function
> is active.
>
> Signed-off-by: Robert Baldyga
> Acked-by: Michal Nazarewicz
> ---
> dri
On Wed, Aug 27, 2014 at 01:31:24PM +0300, Roger Quadros wrote:
> On 08/04/2014 05:07 PM, Alan Stern wrote:
> > On Mon, 4 Aug 2014, Roger Quadros wrote:
> >
> >> If user specifies that USB autosuspend must be disabled by module
> >> parameter "usbcore.autosuspend=-1" then we must prevent
> >> autos
> From: James Bottomley
> Did you try read capacity 16 on it? What happened? (the AS2105 rejects
> read capacity 16, so there's no reliable way to deduce the capacity of
> drives over 2TB).
OK, I had to track down which package contains sg_readcap.
The adapter that fails gives this output:
On Wed, Aug 20, 2014 at 01:30:40PM +0800, Peter Chen wrote:
> On Tue, Aug 19, 2014 at 09:02:54PM +, Paul Zimmerman wrote:
> > > From: linux-usb-ow...@vger.kernel.org
> > > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Peter Chen
> > > Sent: Tuesday, August 19, 2014 7:26 AM
> > >
> > >
Hi,
On Fri, Aug 22, 2014 at 06:59:00PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> This patch series removes the old Samsung USB PHY drivers that
> got replaced by the new ones using the generic PHY layer.
>
> Depends on:
> - v3.17-rc1 branch of Linus' kernel
>
> Changes since v1 (https:/
On Wed, Aug 27, 2014 at 03:11:10PM +0300, Roger Quadros wrote:
> If user specifies that USB autosuspend must be disabled by module
> parameter "usbcore.autosuspend=-1" then we must prevent
> autosuspend of USB hub devices as well.
>
> commit 596d789a211d introduced in v3.8 changed the original beh
What I find interesting is that Windows (at least, Windows 7
Professional) seems to be able to handle the deficient adapter. What
I'd like to do is log the disk commands during the mounting sequence,
preferably at both the SCSI and USB layers. Then at least we'll know
exactly what the driver is d
Hi,
On Fri, Aug 22, 2014 at 06:59:05PM +0200, Bartlomiej Zolnierkiewicz wrote:
> drivers/usb/phy/phy-samsung-usb[2,3] drivers got replaced by
> drivers/phy/phy-samsung-usb[2,3] ones and the old common Samsung
> USB PHY code is no longer used.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz
> Acked-
On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote:
> Defining the vendor and the product id should be enough to discriminate
> the device.
>
> The reason for this patch is that there is a missmatch betweed the
> modalias showed by sysfs and the modalias generated by file2alia
On 27 August 2014 23:08, Andrew Bresticker wrote:
> On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren
> wrote:
>> I'm not even sure if it's appropriate for the low-level mailbox driver to
>> know about the semantics of the message, rather than simply sending them on
>> to the client driver? Perh
On Wed, Aug 27, 2014 at 03:03:45PM +0200, Michal Sojka wrote:
> With this patch, USB activity can be signaled by blinking a LED. There
> are two triggers, one for activity on USB host and one for USB gadget.
>
> Both trigger should work with all host/device controllers. Tested only
> with musb.
>
Hi,
On Wed, Aug 27, 2014 at 11:42:25PM +0530, Vivek Gautam wrote:
> On Wed, Aug 27, 2014 at 1:22 PM, Bartlomiej Zolnierkiewicz
> wrote:
> > dwc3 driver is using the new Exynos5 SoC series USB DRD PHY driver
> > (PHY_EXYNOS5_USBDRD which selects GENERIC_PHY) as can be seen by
> > looking at the fo
On Wed, Aug 27, 2014 at 12:27:51PM -0700, Greg Kroah-Hartman wrote:
> On Wed, Aug 27, 2014 at 03:03:45PM +0200, Michal Sojka wrote:
> > With this patch, USB activity can be signaled by blinking a LED. There
> > are two triggers, one for activity on USB host and one for USB gadget.
> >
> > Both tri
Hi,
On Tue, Aug 26, 2014 at 03:30:32PM +0800, Peter Chen wrote:
> On Mon, Aug 25, 2014 at 11:27:47AM -0400, Alan Stern wrote:
> > On Mon, 25 Aug 2014, Peter Chen wrote:
> >
> > > Hi Felipe & Alan,
> > >
> > > It is the follow-up for:
> > > http://www.spinics.net/lists/linux-usb/msg112193.html
>
Hello Greg
On Wed, Aug 27, 2014 at 9:25 PM, Greg Kroah-Hartman
wrote:
> On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote:
>> Defining the vendor and the product id should be enough to discriminate
>> the device.
>>
>> The reason for this patch is that there is a missmat
On Wed, 2014-08-27 at 15:21 -0400, Dale R. Worley wrote:
> > From: James Bottomley
>
> > Did you try read capacity 16 on it? What happened? (the AS2105 rejects
> > read capacity 16, so there's no reliable way to deduce the capacity of
> > drives over 2TB).
>
> OK, I had to track down which pac
On Wed, 27 Aug 2014, Dale R. Worley wrote:
> What I find interesting is that Windows (at least, Windows 7
> Professional) seems to be able to handle the deficient adapter.
So does Linux. The difference is that Windows believes the values in
the partition table in preference to what the hardware
On Wed, Aug 27 2014, Michal Sojka wrote:
> All USB peripheral controller drivers called completion routines
> directly. This patch moves the completion call from drivers to
> usb_gadget_giveback_request(), in order to have a place where common
> functionality can be added.
>
> All places in drivers
On Wed, Aug 27, 2014 at 03:03:44PM +0200, Michal Sojka wrote:
> All USB peripheral controller drivers called completion routines
> directly. This patch moves the completion call from drivers to
> usb_gadget_giveback_request(), in order to have a place where common
> functionality can be added.
>
>
On Wed, 27 Aug 2014, Felipe Balbi wrote:
> > Hi Alan & Felipe,
> >
> > During the changing UDC drivers process, I find we can't simply move
> > usb_gadget_disconnect to usb_gadget_driver.disconnect, some UDC
> > drivers (like dwc3) will be no chance to set software pullup bit
> > (dp control alwa
On Wed, Aug 27, 2014 at 09:39:43PM +0200, Ricardo Ribalda Delgado wrote:
> Hello Greg
>
>
>
>
>
> On Wed, Aug 27, 2014 at 9:25 PM, Greg Kroah-Hartman
> wrote:
> > On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote:
> >> Defining the vendor and the product id should be eno
On Wed, Aug 27, 2014 at 04:20:25PM -0400, Alan Stern wrote:
> On Wed, 27 Aug 2014, Felipe Balbi wrote:
>
> > > Hi Alan & Felipe,
> > >
> > > During the changing UDC drivers process, I find we can't simply move
> > > usb_gadget_disconnect to usb_gadget_driver.disconnect, some UDC
> > > drivers (li
In the next commit, we will want the usb-common module to be composed of
two object files. Since Kbuild cannot "append" another object to an
existing one, we need to rename usb-common.c to something
else (common.c) and create usb-common.o by linking the wanted objects
together. Currently, usb-commo
With this patch, USB activity can be signaled by blinking a LED. There
are two triggers, one for activity on USB host and one for USB gadget.
Both trigger should work with all host/device controllers. Tested only
with musb.
Signed-off-by: Michal Sojka
---
drivers/usb/Kconfig | 11
All USB peripheral controller drivers called completion routines
directly. This patch moves the completion call from drivers to
usb_gadget_giveback_request(), in order to have a place where common
functionality can be added.
All places in drivers/usb/ matching "[-.]complete(" were replaced with a
This adds LED triggers for USB host and device. First patch refactors
UDC drivers as requested by Felipe Balbi, second is a preparation for
the third, which adds the LED triggers.
Changes from v3:
- usb_gadget_giveback_request() moved outside of CONFIG_HAS_DMA
conditioned block.
- Added kernel-d
On Wed, Aug 27, 2014 at 12:23:39PM -0700, Greg KH wrote:
> On Wed, Aug 27, 2014 at 03:11:10PM +0300, Roger Quadros wrote:
> > If user specifies that USB autosuspend must be disabled by module
> > parameter "usbcore.autosuspend=-1" then we must prevent
> > autosuspend of USB hub devices as well.
> >
Hello Greg
>>
>> Not many drivers define the pci interface and there is no other driver
>> that has the same vendor and product id. Therefore I see no hurt in
>> adding both patches, one to make the driver broader, and another to
>> fix pci-sysfs.
>>
>> Also, the change on pci-sysfs might affect
On Wed, 27 Aug 2014, Michal Sojka wrote:
> +/**
> + * usb_gadget_giveback_request - give the request back to the gadget layer
> + * Context: in_interrupt()
> + *
> + * This is called by device controller drivers in order to return the
> + * completed request back to the gadget layer.
> + */
> +voi
Since commit [ac8dde11: “Add flags to descriptors block”] functionfs
supports a new, more powerful and extensible, descriptor format.
Since ffs-test is probably the first thing users of the functionfs
interface see when they start writing functionfs user space daemons,
convert it to use the new for
From: Yang Wei
While loading g_mass_storage module, the following warning
is triggered.
WARNING: at drivers/usb/gadget/composite.c:
usb_composite_setup_continue: Unexpected call
Modules linked in: fat vfat minix nls_cp437 nls_iso8859_1 g_mass_storage
[<800179cc>] (unwind_backtrace+0x0/0x104) fro
The structure can be used with user space tools that use the new
functionfs description format, for example as follows:
static const struct {
struct usb_functionfs_descs_head_v2 header;
__le32 fs_count;
__le32 hs_count;
struct {
…
} fs_desc;
Apparently I've slept over 3.17 merge window, so I guess this is
for 3.18. Rebased on top of balbi/usb.git next.
Michal Nazarewicz (4):
usb: gadget: f_fs: add usb_functionfs_descs_head_v2 structure
tools: ffs-test: convert to new descriptor format
tools: ffs-test: add compatibility code for
If ffs-test is used with a kernel prior to 3.14, which do not
support the new descriptors format, it will fail when trying to
write the descriptors. Add a function that converts the new
descriptors to the legacy ones and use it to retry writing the
descriptors using the legacy format.
Also add “-
Flatten the start_transfer function by reversing the if condition and
returning early out of the function if everything went fine. It makes
the function look less complicated, at least to me, and easier to
understand.
Signed-off-by: Michal Nazarewicz
---
drivers/usb/gadget/function/f_mass_stora
1 - 100 of 127 matches
Mail list logo
