Re: [PATCH v2][ 3/8] usb: chipidea: usbmisc: Add USB Host support for i.MX25/i.MX35 CPUs

2014-03-12 Thread Peter Chen
On Tue, Mar 11, 2014 at 11:54:59AM +0100, Denis Carikli wrote: > Signed-off-by: Denis Carikli > --- Add something at commit log please. > Changelog v1->v2: > - converted two remaining defines to BIT() > - Removed a variable declaration that was not used in usbmisc_imx25_init > --- > drivers/usb

Re: [PATCH] xhci: extend quirk for Renesas cards

2014-03-12 Thread Igor Gnatenko
On Tue, 2014-03-11 at 18:50 +0200, Mathias Nyman wrote: > On 03/11/2014 04:54 PM, Anatoly C.K. wrote: > > Igor do not have this card. > > > > [root@fedora-20 ~]# lspci -vmnnd 1912: > > Device: 03:00.0 > > Class: USB controller [0c03] > > Vendor: Renesas Technology Corp. [1912] > > Dev

[PATCH v2] xhci: extend quirk for Renesas cards

2014-03-12 Thread Igor Gnatenko
After suspend another Renesas PCI-X USB 3.0 card doesn't work. [root@fedora-20 ~]# lspci -vmnnd 1912: Device: 03:00.0 Class: USB controller [0c03] Vendor: Renesas Technology Corp. [1912] Device: uPD720202 USB 3.0 Host Controller [0015] SVendor:Renesas Technology Corp. [1912] SDevice:

[PATCH 3/3] usb: chipidea: debug: add debug file for controller registers dump.

2014-03-12 Thread Li Jun
This patch adds below registers dump for debug: - USBINTR - USBSTS - USBMODE - USBCMD - PORTSC - OTGSC Signed-off-by: Li Jun --- drivers/usb/chipidea/debug.c | 49 ++ 1 file changed, 49 insertions(+) diff --git a/drivers/usb/chipidea/debug.c b/drivers/u

[PATCH 2/3] usb: chipidea: export interrupt enable and status register read functions.

2014-03-12 Thread Li Jun
This patch moves usb interrupt enable and status register read functions from udc driver to core driver to use them in all ci drivers. Signed-off-by: Li Jun --- drivers/usb/chipidea/ci.h |4 drivers/usb/chipidea/core.c | 20 drivers/usb/chipidea/udc.c | 20 --

[PATCH 1/3] usb: chipidea: operate on otgsc register in a general way

2014-03-12 Thread Li Jun
From: Li Jun Use a more general way to read and write otgsc register. Signed-off-by: Li Jun --- drivers/usb/chipidea/core.c | 19 + drivers/usb/chipidea/otg.c | 48 +++ drivers/usb/chipidea/otg.h | 19 +++-- drivers/us

Re: [PATCH v3 05/13] usb: chipidea: udc: driver update for OTG HNP.

2014-03-12 Thread Peter Chen
On Thu, Feb 27, 2014 at 07:38:23AM +0800, Li Jun wrote: > Add b_hnp_enable request handling and enable gadget->is_otg > > Signed-off-by: Li Jun > --- > drivers/usb/chipidea/udc.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/chipidea/udc.c b/

Re: [PATCH v3 05/13] usb: chipidea: udc: driver update for OTG HNP.

2014-03-12 Thread Li Jun
On Wed, Mar 12, 2014 at 03:01:15PM +0800, Peter Chen wrote: > On Thu, Feb 27, 2014 at 07:38:23AM +0800, Li Jun wrote: > > Add b_hnp_enable request handling and enable gadget->is_otg > > > > Signed-off-by: Li Jun > > --- > > drivers/usb/chipidea/udc.c | 11 ++- > > 1 file changed, 10 in

Re: [PATCH v3 10/13] usb: chipidea: add sys inputs for OTG fsm input.

2014-03-12 Thread Li Jun
On Thu, Mar 06, 2014 at 12:44:16PM +0800, Peter Chen wrote: > On Thu, Feb 27, 2014 at 07:38:28AM +0800, Li Jun wrote: > > This patch adds sys input to control and show OTG fsm inputs by application, > > user can do host and preipheral role switch by change these inputs. > > > > Signed-off-by: Li J

Re: [PATCH 1/3] usb: chipidea: operate on otgsc register in a general way

2014-03-12 Thread Peter Chen
On Wed, Mar 12, 2014 at 02:32:39PM +0800, Li Jun wrote: > From: Li Jun > > Use a more general way to read and write otgsc register. > > Signed-off-by: Li Jun > --- > drivers/usb/chipidea/core.c | 19 + > drivers/usb/chipidea/otg.c | 48 > ++

Re: [PATCH 2/3] usb: chipidea: export interrupt enable and status register read functions.

2014-03-12 Thread Peter Chen
On Wed, Mar 12, 2014 at 02:32:40PM +0800, Li Jun wrote: > This patch moves usb interrupt enable and status register read functions > from udc driver to core driver to use them in all ci drivers. > > Signed-off-by: Li Jun > --- > drivers/usb/chipidea/ci.h |4 > drivers/usb/chipidea/cor

Re: [PATCH 3/3] usb: chipidea: debug: add debug file for controller registers dump.

2014-03-12 Thread Peter Chen
On Wed, Mar 12, 2014 at 02:32:41PM +0800, Li Jun wrote: > This patch adds below registers dump for debug: > - USBINTR > - USBSTS > - USBMODE > - USBCMD > - PORTSC > - OTGSC > > Signed-off-by: Li Jun > --- > drivers/usb/chipidea/debug.c | 49 > ++ > 1 fi

Re: [PATCH v3 05/13] usb: chipidea: udc: driver update for OTG HNP.

2014-03-12 Thread Peter Chen
On Wed, Mar 12, 2014 at 03:12:48PM +0800, Li Jun wrote: > On Wed, Mar 12, 2014 at 03:01:15PM +0800, Peter Chen wrote: > > On Thu, Feb 27, 2014 at 07:38:23AM +0800, Li Jun wrote: > > > Add b_hnp_enable request handling and enable gadget->is_otg > > > > > > Signed-off-by: Li Jun > > > --- > > > dr

Re: [PATCH v3 10/13] usb: chipidea: add sys inputs for OTG fsm input.

2014-03-12 Thread Peter Chen
On Wed, Mar 12, 2014 at 04:03:34PM +0800, Li Jun wrote: > On Thu, Mar 06, 2014 at 12:44:16PM +0800, Peter Chen wrote: > > On Thu, Feb 27, 2014 at 07:38:28AM +0800, Li Jun wrote: > > > This patch adds sys input to control and show OTG fsm inputs by > > > application, > > > user can do host and prei

[PATCH 0/3] Some update for USB OTG

2014-03-12 Thread Peter Chen
Hi Felipe, The two for fsm, the other one is delete CONFIG_USB_OTG_FSM since it is duplicated with CONFIG_USB_OTG, thanks. Li Jun (1): usb: phy-fsm: update OTG HNP state transition Peter Chen (2): usb: phy: delete CONFIG_USB_OTG_FSM usb: phy-fsm: change "|" to "||" for condition OTG_STATE_

[PATCH 3/3] usb: phy-fsm: change "|" to "||" for condition OTG_STATE_A_WAIT_BCON at statemachine

2014-03-12 Thread Peter Chen
It is should be condition "or" not bit "or". Signed-off-by: Peter Chen --- drivers/usb/phy/phy-fsm-usb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/phy/phy-fsm-usb.c b/drivers/usb/phy/phy-fsm-usb.c index 0021839..bf5c32f 100644 --- a/drivers/usb/phy/phy

[PATCH 2/3] usb: phy-fsm: update OTG HNP state transition

2014-03-12 Thread Peter Chen
From: Li Jun According to:"On-The-Go and Embedded Host Supplement to the USB Revision 2.0 Specification July 27, 2012 Revision 2.0 version 1.1a" - add a_wait_vrise to a_wait_vfall - update condition from a_wait_vrise to a_wait_bcon Signed-off-by: Li Jun --- drivers/usb/phy/phy-fsm-usb.c |6

[PATCH 1/3] usb: phy: delete CONFIG_USB_OTG_FSM

2014-03-12 Thread Peter Chen
We already have CONFIG_USB_OTG which can cover all CONFIG_USB_OTG_FSM does. Cc: Jun Li Cc: Anton Tikhomirov Signed-off-by: Peter Chen --- drivers/usb/phy/Kconfig | 11 +-- drivers/usb/phy/Makefile |2 +- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/usb

[PATCH v3][ 1/9] ARM: dts: mx25: USB block requires only one clock

2014-03-12 Thread Denis Carikli
From: Fabio Estevam Like other imx SoCs only one USB clock is needed on mx25. Signed-off-by: Fabio Estevam --- arch/arm/boot/dts/imx25.dtsi |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index 77bb743..82

[PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.

2014-03-12 Thread Denis Carikli
This converts the Chipidea usbmisc driver to use the standard usb-phy property. It also adapt the dts that uses it. Signed-off-by: Denis Carikli --- arch/arm/boot/dts/imx23.dtsi |2 +- arch/arm/boot/dts/imx27.dtsi |4 ++-- arch/arm/boot/dts/imx28.dtsi |4 ++-- arch

[PATCH v3][ 6/9] ARM: dts: mbimxsd25 baseboard: Add USB support

2014-03-12 Thread Denis Carikli
Signed-off-by: Denis Carikli --- Changelog v1->v2: - With the clock fix patches, the usb gadget also work. So I've set the otg port to otg instead of host. --- .../boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/d

[PATCH v3][ 4/9] usb: chipidea: usbmisc: Add USB Host support for i.MX25/i.MX35 CPUs

2014-03-12 Thread Denis Carikli
This adds the i.MX25 and the i.MX35 support in the ChipIdea usbmisc driver. The i.MX25 and i.MX35 usb controllers are similar enough to be able to use the same code. Signed-off-by: Denis Carikli --- Changelog v2->v3: - Add a commit log Changelog v1->v2: - converted two remaining defines to BIT(

[PATCH v3][ 5/9] ARM: dts: imx25.dtsi: Fix USB support.

2014-03-12 Thread Denis Carikli
From: Fabio Estevam This patch was adapted from the thread named "USB Host support for mx25" on linux-usb@vger.kernel.org Signed-off-by: Denis Carikli --- Changelog v2->v3: - rebased on top of the "usb: chipidea: Use standard usb-phy property." patch. - Fixed the usbphy nodes index and added an

[PATCH v3][ 2/9] ARM: dts: mx35: USB block requires only one clock

2014-03-12 Thread Denis Carikli
From: Fabio Estevam Like other imx SoCs only one USB clock is needed on mx35. Signed-off-by: Fabio Estevam --- arch/arm/boot/dts/imx35.dtsi |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi index e59ccb4..47

[PATCH v3][ 7/9] ARM: dts: i.MX35: Add USB support.

2014-03-12 Thread Denis Carikli
Signed-off-by: Denis Carikli --- Changelog v2->v3: - rebased on top of the "usb: chipidea: Use standard usb-phy property." patch. - Fixed the usbphy nodes index and added and added a reg property. Changelog v1->v2: - The usbphy nodes were made to look like the ones in imx53.dtsi - The patch was r

[PATCH v3][ 9/9] ARM: imx_v4_v5_defconfig: Enable drivers for i.MX25/i.MX35 USB support.

2014-03-12 Thread Denis Carikli
Signed-off-by: Denis Carikli --- Changelog v2->v3: - Extra gadget drivers additions were removed from this patch. Changelog v1->v2: - With the clock fix patches, the usb gadget also work. So I've addeed it to this patch too. - CONFIG_USB_OTG_FSM=y was not needed, so it was removed. --- arch/ar

[PATCH v3][ 8/9] ARM: dts: mbimxsd35 baseboard: Add USB support.

2014-03-12 Thread Denis Carikli
Signed-off-by: Denis Carikli --- Changelog v1->v2: - With the clock fix patches, the usb gadget also work. So I've set the otg port to otg instead of host. - Before I forgott to set dr_mode to host in the usbhost port. That is now fixed. --- .../boot/dts/imx35-eukrea-mbimxsd35-baseboard.dts

Re: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.

2014-03-12 Thread Lothar Waßmann
Hi, Denis Carikli wrote: > This converts the Chipidea usbmisc driver to > use the standard usb-phy property. > [...] > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c > b/drivers/usb/chipidea/ci_hdrc_imx.c > index c00f772..9a74100 100644 > --- a/drivers/usb/chipidea/ci_hdrc_imx.c > +++ b/drivers

RE: [PATCH 3/3] usb: phy-fsm: change "|" to "||" for condition OTG_STATE_A_WAIT_BCON at statemachine

2014-03-12 Thread David Laight
From: Peter Chen > It is should be condition "or" not bit "or". > > Signed-off-by: Peter Chen > --- > drivers/usb/phy/phy-fsm-usb.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/phy/phy-fsm-usb.c b/drivers/usb/phy/phy-fsm-usb.c > index 0021839..bf5c3

RE: [PATCHv2] rebind: Add rebind mechanism for runtime-resume

2014-03-12 Thread Poulain, Loic
Hello Alan, I applied your patch, then reworked mine in order to use usb_unbind_and_rebind_marked_interfaces. It works great with the combination of this two fixes. I even reproduced the btusb runtime-resume hardware issue which is now handled correctly, interfaces are unbind/rebind. I can pro

Re: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.

2014-03-12 Thread Alexander Shiyan
Среда, 12 марта 2014, 11:19 +01:00 от Lothar Waßmann : > Hi, > > Denis Carikli wrote: > > This converts the Chipidea usbmisc driver to > > use the standard usb-phy property. > > > [...] > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c > > b/drivers/usb/chipidea/ci_hdrc_imx.c > > index c00f772

reset_resume() for btusb

2014-03-12 Thread Oliver Neukum
Hi, I still think it makes little sense to support reset_resume() in btusb, but if you really want to, you can try this patch. HTH Oliver >From 3776765dbd08701c30f45c1849691a16c1077cc3 Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Wed, 12 Mar 2014 12:01:13 +0100 Subj

Re: [PATCH v3][ 5/9] ARM: dts: imx25.dtsi: Fix USB support.

2014-03-12 Thread Fabio Estevam
Hi Denis, On Wed, Mar 12, 2014 at 7:01 AM, Denis Carikli wrote: > From: Fabio Estevam > > This patch was adapted from the thread named > "USB Host support for mx25" on linux-usb@vger.kernel.org > As you add me in the From field, you also need to add: Signed-off-by: Fabio Estevam above your Si

Re: musb - high CPU load in DMA mode and dropouts during audio playback

2014-03-12 Thread George Cherian
On 3/12/2014 5:53 AM, Michal Šmucr wrote: Hi George, I did few more tests and have further details for you. This time i modified my build procedure and according to Felipe's hint, I used ti-linux-3.12.y branch from TI repository and also clean 3.14-rc6 kernel, where i subsequently tried additi

Re: [PATCH v3 13/13] Documentation: ABI: usb: chipidea USB OTG HNP sysfs interface description.

2014-03-12 Thread Li Jun
On Thu, Mar 06, 2014 at 12:54:28PM +0800, Peter Chen wrote: > On Thu, Feb 27, 2014 at 07:38:31AM +0800, Li Jun wrote: > > This patch adds sysfs interface description for chipidea USB OTG role switch > > in HNP. > > > > Signed-off-by: Li Jun > > --- > > .../ABI/testing/sysfs-platform-chipidea-usb

Re: MAX3421E: device giving NAKs forever?

2014-03-12 Thread Peter Stuge
David Mosberger wrote: > I couldn't figure out how to force UHCI onto an EHCI chip I suggested removing the ehci_hcd driver. Did that work? > but I did find I had some old IOGEAR USB 1.1 "extenders" (USB-over-CAT5 > cable) and with those, the device does switch into full-speed mode on my > compu

[PATCH net-next 0/2] parameter modification

2014-03-12 Thread Hayes Wang
Add opportunity to change the default setting and reduce the tx/rx buffers. Hayes Wang (2): r8152: add CONFIG_RTL8152_EARLY_AGG_SUPER r8152: reduce the numbers of the bulks drivers/net/usb/Kconfig | 11 +++ drivers/net/usb/r8152.c | 8 2 files changed, 15 insertions(+), 4 d

[PATCH net-next 2/2] r8152: reduce the numbers of the bulks

2014-03-12 Thread Hayes Wang
It is not necessary to have many transfer buffers. Reduce the number from 10 to 4. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 0c43b28..9ff7501 100644 --- a/d

[PATCH net-next 1/2] r8152: add CONFIG_RTL8152_EARLY_AGG_SUPER

2014-03-12 Thread Hayes Wang
For slow CPU, the frequent bulk transfer would cause poor throughput. One solution is to increase the timeout of the aggregation. It let the hw could complete the bulk transfer later and fill more packets into the buffer. Besides, it could reduce the frequency of the bulk transfer efficiently and i

Re: [PATCH 1/3] usb: chipidea: operate on otgsc register in a general way

2014-03-12 Thread Li Jun
On Wed, Mar 12, 2014 at 04:14:31PM +0800, Peter Chen wrote: > On Wed, Mar 12, 2014 at 02:32:39PM +0800, Li Jun wrote: > > From: Li Jun > > > > Use a more general way to read and write otgsc register. > > > > Signed-off-by: Li Jun > > --- > > drivers/usb/chipidea/core.c | 19 +

Re: musb - high CPU load in DMA mode and dropouts during audio playback

2014-03-12 Thread Michal Šmucr
Hi George, On 12.3.2014 12:15, George Cherian wrote: So it looks like, without this patch, hrtimer trick for compensation of early interrupt doesn't work and samples gets garbled during transfers (albeit i don't have HW USB analyzer to prove it). Alternative with fifo checking and workqueue, un

Re: [PATCH net-next 1/2] r8152: add CONFIG_RTL8152_EARLY_AGG_SUPER

2014-03-12 Thread Bjørn Mork
Hayes Wang writes: > + config RTL8152_EARLY_AGG_SUPER > + hex "rx early agg parameter for super speed" > + default 0x0e832981 > + help > + This is the rx early agg parameter for USB super speed. > + > + endmenu How do I as an end user kno

Re: [PATCH v3 07/13] usb: chipidea: add OTG fsm operation functions implemenation.

2014-03-12 Thread Li Jun
On Thu, Mar 06, 2014 at 04:13:10PM +0800, Peter Chen wrote: > On Thu, Mar 06, 2014 at 02:52:17PM +0800, Li Jun wrote: > > On Wed, Mar 05, 2014 at 04:28:14PM +0800, Peter Chen wrote: > > > On Thu, Feb 27, 2014 at 07:38:25AM +0800, Li Jun wrote: > > > > Add OTG HNP and SRP operation functions impleme

Re: [PATCH v3 00/13] Add USB OTG HNP and SRP support on Chipidea usb driver

2014-03-12 Thread Li Jun
On Fri, Mar 07, 2014 at 10:32:30AM +0800, Peter Chen wrote: > On Thu, Feb 27, 2014 at 07:38:18AM +0800, Li Jun wrote: > > From: b47624 > > > > This patchset adds USB OTG HNP and SRP support on chipidea usb driver, > > existing OTG port role swtich function by ID pin status kept unchanged, > > bas

Re: [PATCH v3 09/13] usb: chipidea: OTG HNP and SRP fsm implementation.

2014-03-12 Thread Li Jun
On Thu, Mar 06, 2014 at 12:36:45PM +0800, Peter Chen wrote: > On Thu, Feb 27, 2014 at 07:38:27AM +0800, Li Jun wrote: > > USB OTG interrupt handling and fsm transition according to USB OTG > > and EH 2.0, update otg timer timeout handlers. > > > > Signed-off-by: Li Jun > > --- > > drivers/usb/ch

Re: [PATCH 2/3] usb: phy-fsm: update OTG HNP state transition

2014-03-12 Thread Sergei Shtylyov
Hello. On 12-03-2014 12:56, Peter Chen wrote: From: Li Jun According to:"On-The-Go and Embedded Host Supplement to the USB Revision 2.0 Specification July 27, 2012 Revision 2.0 version 1.1a" - add a_wait_vrise to a_wait_vfall - update condition from a_wait_vrise to a_wait_bcon Signed-off

RE: [PATCHv2] rebind: Add rebind mechanism for runtime-resume

2014-03-12 Thread Alan Stern
On Wed, 12 Mar 2014, Poulain, Loic wrote: > Hello Alan, > > I applied your patch, then reworked mine in order to use > usb_unbind_and_rebind_marked_interfaces. > It works great with the combination of this two fixes. I even reproduced the > btusb runtime-resume > hardware issue which is now ha

[PATCHv3] rebind: Add rebind mechanism for runtime-resume

2014-03-12 Thread Poulain, Loic
Despite the needs_binding flag, the interface rebind was never done for the PM runtime resume. This patch fixes this issue by triggering the rebind in usb runtime resume. The rebind procedure needs to be called with the device lock. However, depending the call path (remote wakeup, local resume), t

Re: MAX3421E: device giving NAKs forever?

2014-03-12 Thread David Mosberger
On Wed, Mar 12, 2014 at 6:21 AM, Peter Stuge wrote: > David Mosberger wrote: >> I couldn't figure out how to force UHCI onto an EHCI chip > > I suggested removing the ehci_hcd driver. Did that work? Nope. UHCI was loaded but it didn't recognize any UHCI-compatible chips so I was left without any

Re: [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval

2014-03-12 Thread Nicolas Ferre
On 12/02/2014 14:03, Nicolas Ferre : > From: Jean-Jacques Hiblot > > When using dt resources retrieval (interrupts and reg properties) there is > no predefined order for these resources in the platform dev resource > table. Also don't expect the number of resource to be always 2. > > Signed-off-

RE: reset_resume() for btusb

2014-03-12 Thread Poulain, Loic
My thought was to fix the usbcore rebind issue (with pm_runtime) to let the core unbind and rebind the device's interfaces for drivers with no reset_resume callback (not only btusb). Implementing the btusb reset_resume seems risky, a patch implementing this callback has been previously reverted du

[PATCH] USB: unbind all interfaces before rebinding any

2014-03-12 Thread Alan Stern
When a driver doesn't have pre_reset, post_reset, or reset_resume methods, the USB core unbinds that driver when its device undergoes a reset or a reset-resume, and then rebinds it afterward. The existing straightforward implementation can lead to problems, because each interface gets unbound and

Re: [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval

2014-03-12 Thread Greg Kroah-Hartman
On Wed, Mar 12, 2014 at 03:57:48PM +0100, Nicolas Ferre wrote: > On 12/02/2014 14:03, Nicolas Ferre : > > From: Jean-Jacques Hiblot > > > > When using dt resources retrieval (interrupts and reg properties) there is > > no predefined order for these resources in the platform dev resource > > table

Re: MAX3421E: device giving NAKs forever?

2014-03-12 Thread Peter Stuge
David Mosberger wrote: > >> I couldn't figure out how to force UHCI onto an EHCI chip > > > > I suggested removing the ehci_hcd driver. Did that work? > > Nope. UHCI was loaded but it didn't recognize any UHCI-compatible > chips so I was left without any USB devices (not even keyboard). Hmmm. Di

Re: [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval

2014-03-12 Thread Nicolas Ferre
On 12/03/2014 16:31, Greg Kroah-Hartman : > On Wed, Mar 12, 2014 at 03:57:48PM +0100, Nicolas Ferre wrote: >> On 12/02/2014 14:03, Nicolas Ferre : >>> From: Jean-Jacques Hiblot >>> >>> When using dt resources retrieval (interrupts and reg properties) there is >>> no predefined order for these reso

[PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval

2014-03-12 Thread Nicolas Ferre
From: Jean-Jacques Hiblot When using dt resources retrieval (interrupts and reg properties) there is no predefined order for these resources in the platform dev resource table. Also don't expect the number of resource to be always 2. Signed-off-by: Jean-Jacques Hiblot Acked-by: Boris BREZILLON

Re: MAX3421E: device giving NAKs forever?

2014-03-12 Thread Alan Stern
On Wed, 12 Mar 2014, Peter Stuge wrote: > David Mosberger wrote: > > >> I couldn't figure out how to force UHCI onto an EHCI chip > > > > > > I suggested removing the ehci_hcd driver. Did that work? > > > > Nope. UHCI was loaded but it didn't recognize any UHCI-compatible > > chips so I was left

Re: [PATCH] xhci: extend quirk for Renesas cards

2014-03-12 Thread Sarah Sharp
On Mon, Mar 10, 2014 at 01:09:04PM +, David Laight wrote: > From: Mathias Nyman > > On 03/09/2014 04:20 PM, Igor Gnatenko wrote: > > > After suspend another Renesas PCI-X USB 3.0 card doesn't work. > > > 03:00.0 USB controller [0c03]: Renesas Technology Corp. uPD720202 USB 3.0 > > > Host Contr

Re: MAX3421E: device giving NAKs forever?

2014-03-12 Thread Peter Stuge
Alan Stern wrote: > > lspci should show the UHCI companion controllers on the PCI bus. > > Peter, David's computer doesn't have any UHCI controllers. > Everything is handled by EHCI, through a hub on the motherboard. > This is the standard design for current Intel systems. Thanks, I understand.

[PATCH net-next 8/9] lg-vl600: Convert uses of __constant_ to

2014-03-12 Thread Joe Perches
The use of __constant_ has been unnecessary for quite awhile now. Make these uses consistent with the rest of the kernel. Signed-off-by: Joe Perches --- drivers/net/usb/lg-vl600.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/lg-vl600.c b/drivers/net/usb/lg

[PATCH net-next 0/9] drivers/net: Convert uses of __constant_ to

2014-03-12 Thread Joe Perches
Joe Perches (9): brocade: Convert uses of __constant_ to e100: Convert uses of __constant_ to igb: Convert uses of __constant_ to igbvf: Convert uses of __constant_ to ixgbe: Convert uses of __constant_ to ixgbevf: Convert uses of __constant_ to xilinx: Convert uses of __constan

Re: [PATCH v3 5/8] ARM: OMAP5: hwmod: Add ocp2scp3 and sata hwmods

2014-03-12 Thread Tony Lindgren
* Roger Quadros [140307 02:18]: > From: Keshava Munegowda > > Create hwmods for ocp2scp3 and sata modules. Paul, does this look OK to you? Regards, Tony > [Roger Q] Clean up. > > CC: Benoit Cousson > CC: Paul Walmsley > CC: Tony Lindgren > Signed-off-by: Balaji T K > Signed-off-by: Rog

Re: [PATCH v2] xhci: extend quirk for Renesas cards

2014-03-12 Thread Sarah Sharp
Mathias, this is fine to apply as-is. Since it's after -rc6, Greg's tree is probably now frozen. Stick this patch in your queue for usb-linus, mark it for stable, and send it off once 3.15-rc1 is out. Igor, please do not add Signed-off-by lines unless the developer explicitly types those words.

[PATCH 4/7] USB: serial: continue to write on errors

2014-03-12 Thread Johan Hovold
Do not discard buffered data and make sure to try to resubmit the write urbs on errors. Currently a recoverable error would lead to more data than necessary being dropped. Also upgrade error messages from debug to error log level. Signed-off-by: Johan Hovold --- drivers/usb/serial/generic.c |

[PATCH 1/7] USB: cypress_m8: fix potential scheduling while atomic

2014-03-12 Thread Johan Hovold
Remove erroneous call to usb_clear_halt which is blocking and cannot be used in interrupt context. This code has possibly never been executed as it would cause an oops if it was. Simply treat a stalled-endpoint error as any other error condition. Cc: stable Signed-off-by: Johan Hovold --- driv

[PATCH 2/7] USB: serial: make bulk_out_size a lower limit

2014-03-12 Thread Johan Hovold
Drivers are allowed to override the default bulk-out buffer size (endpoint maximum packet size) in order to increase throughput, but it does not make much sense to allow buffers smaller than the default. Note that this is already how bulk_in_size is defined. Signed-off-by: Johan Hovold --- driv

[PATCH 6/7] USB: serial: add missing newlines to dev_ messages.

2014-03-12 Thread Johan Hovold
Add missing newlines to dev_ messages. Also make some messages less verbose where appropriate. Signed-off-by: Johan Hovold --- drivers/usb/serial/ch341.c| 6 +++--- drivers/usb/serial/cyberjack.c| 2 +- drivers/usb/serial/cypress_m8.c | 2 +- drivers/usb/serial/iuu_

[PATCH 3/7] USB: serial: continue to read on errors

2014-03-12 Thread Johan Hovold
Make sure to try to resubmit the read urb on errors. Currently a recoverable error would lead to reduced throughput as only one urb will be used until the port is closed and reopened (or resumed or unthrottled). Also upgrade error messages from debug to error log level. Signed-off-by: Johan Hovo

[PATCH 0/7] USB: serial: patches for v3.15

2014-03-12 Thread Johan Hovold
Hi Greg, Here are a few usb-serial patches for v3.15: one bug fix, improved read/write error handling, and some minor fixes and cleanups. Thanks, Johan Johan Hovold (7): USB: cypress_m8: fix potential scheduling while atomic USB: serial: make bulk_out_size a lower limit USB: serial: conti

[PATCH 5/7] USB: serial: add missing braces

2014-03-12 Thread Johan Hovold
Add missing braces to conditional branches and one loop in usb-serial core and generic implementation. Signed-off-by: Johan Hovold --- drivers/usb/serial/generic.c| 11 ++- drivers/usb/serial/usb-serial.c | 8 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/

[PATCH 7/7] USB: keyspan: remove dead debugging code

2014-03-12 Thread Johan Hovold
Remove out-commented and ifdeffed debugging code. Signed-off-by: Johan Hovold --- drivers/usb/serial/keyspan.c | 30 -- 1 file changed, 30 deletions(-) diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c index 265c6776b081..d3acaead5a81 100644 --

Re: usb/serial/io_ti.c broken on BE systems

2014-03-12 Thread Johan Hovold
On Wed, Feb 26, 2014 at 05:01:10PM +0100, Johan Hovold wrote: > On Tue, Feb 25, 2014 at 03:55:07PM +, Ludovic wrote: > > At 1st the driver detected the USB key and set-up the serial ports. But when > > trying to write I got a kernel panic on the router. > > Are you able to get a stack trace?

Re: usbserial_generic, idVendor=1a28, idProduct=6010

2014-03-12 Thread Johan Hovold
On Mon, Feb 24, 2014 at 11:43:35AM +0100, Emanuel Koczwara wrote: > W dniu 24.02.2014 11:25, Johan Hovold pisze: > > > This is likely an ftdi-device. Care to try the patch below? > >Thanks, I'll try. Have you tested the patch I sent? How did it go? As a quick test (which does not require re

Re: [PATCH v2] xhci: extend quirk for Renesas cards

2014-03-12 Thread Igor Gnatenko
On Wed, 2014-03-12 at 10:59 -0700, Sarah Sharp wrote: > Mathias, this is fine to apply as-is. Since it's after -rc6, Greg's > tree is probably now frozen. Stick this patch in your queue for > usb-linus, mark it for stable, and send it off once 3.15-rc1 is out. > > Igor, please do not add Signed

Re: [PATCH net-next 8/9] lg-vl600: Convert uses of __constant_ to

2014-03-12 Thread David Miller
From: Joe Perches Date: Wed, 12 Mar 2014 10:22:37 -0700 > The use of __constant_ has been unnecessary for quite awhile now. > > Make these uses consistent with the rest of the kernel. > > Signed-off-by: Joe Perches Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-us

Re: [PATCH 1/7] USB: cypress_m8: fix potential scheduling while atomic

2014-03-12 Thread Greg Kroah-Hartman
On Wed, Mar 12, 2014 at 07:09:37PM +0100, Johan Hovold wrote: > Remove erroneous call to usb_clear_halt which is blocking and cannot be > used in interrupt context. > > This code has possibly never been executed as it would cause an oops if > it was. Simply treat a stalled-endpoint error as any ot

Re: MAX3421E: device giving NAKs forever?

2014-03-12 Thread David Mosberger
So, quick question to the collective linux-usb wisdom: when I collect a USB trace on my work-computer while running the command: dd if=/dev/zero of=/dev/sdX1 I see the same WRITE_10 commands of 122,880 bytes (240 sectors), but the glaring difference is that each such WRITE_10 command seems to be

Re: MAX3421E: device giving NAKs forever?

2014-03-12 Thread Alan Stern
On Wed, 12 Mar 2014, David Mosberger wrote: > So, quick question to the collective linux-usb wisdom: when I collect > a USB trace on my work-computer while running the command: > > dd if=/dev/zero of=/dev/sdX1 > > I see the same WRITE_10 commands of 122,880 bytes (240 sectors), but > the glarin

Re: MAX3421E: device giving NAKs forever?

2014-03-12 Thread David Mosberger
On Wed, Mar 12, 2014 at 2:53 PM, Alan Stern wrote: > On Wed, 12 Mar 2014, David Mosberger wrote: >> I see the same WRITE_10 commands of 122,880 bytes (240 sectors), but >> the glaring difference is that each such WRITE_10 command seems to be >> followed by ~ 27 READ_10 commands reading 1KB (2 sec

Re: usbserial_generic, idVendor=1a28, idProduct=6010

2014-03-12 Thread Emanuel Koczwara
Hi, Dnia 2014-03-12, śro o godzinie 19:50 +0100, Johan Hovold pisze: > On Mon, Feb 24, 2014 at 11:43:35AM +0100, Emanuel Koczwara wrote: > > W dniu 24.02.2014 11:25, Johan Hovold pisze: > > > > > This is likely an ftdi-device. Care to try the patch below? > > > >Thanks, I'll try. > > Have y

RE: [PATCH 3/3] usb: phy-fsm: change "|" to "||" for condition OTG_STATE_A_WAIT_BCON at statemachine

2014-03-12 Thread Peter Chen
> > From: Peter Chen > > It is should be condition "or" not bit "or". > > > > Signed-off-by: Peter Chen > > --- > > drivers/usb/phy/phy-fsm-usb.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/usb/phy/phy-fsm-usb.c > > b/drivers/usb/phy/phy-fsm-usb

Re: [PATCH 1/3] usb: chipidea: operate on otgsc register in a general way

2014-03-12 Thread Peter Chen
On Wed, Mar 12, 2014 at 07:49:52PM +0800, Li Jun wrote: > On Wed, Mar 12, 2014 at 04:14:31PM +0800, Peter Chen wrote: > > On Wed, Mar 12, 2014 at 02:32:39PM +0800, Li Jun wrote: > > > From: Li Jun > > > > > > Use a more general way to read and write otgsc register. > > > > > > Signed-off-by: Li

RE: [PATCH v3][ 4/9] usb: chipidea: usbmisc: Add USB Host support for i.MX25/i.MX35 CPUs

2014-03-12 Thread Peter Chen
> This adds the i.MX25 and the i.MX35 support in the ChipIdea usbmisc > driver. > > The i.MX25 and i.MX35 usb controllers are similar enough to be able to > use the same code. > > Signed-off-by: Denis Carikli > --- > Changelog v2->v3: > - Add a commit log > > Changelog v1->v2: > - converted t

RE: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.

2014-03-12 Thread Peter Chen
> > It also adapt the dts that uses it. > > Signed-off-by: Denis Carikli > --- > arch/arm/boot/dts/imx23.dtsi |2 +- > arch/arm/boot/dts/imx27.dtsi |4 ++-- > arch/arm/boot/dts/imx28.dtsi |4 ++-- > arch/arm/boot/dts/imx51.dtsi |2 +- > arch/arm/boot/dt

[PATCH net-next v2 0/2] parameter modification

2014-03-12 Thread Hayes Wang
Add opportunity to change the default setting and reduce the tx/rx buffers. v2: modify the patch #1 to let the value readable. Hayes Wang (2): r8152: add RTL8152_EARLY_AGG_TIMEOUT_SUPER r8152: reduce the numbers of the bulks drivers/net/usb/Kconfig | 11 +++ drivers/net/usb/r8152.c

[PATCH net-next v2 1/2] r8152: add RTL8152_EARLY_AGG_TIMEOUT_SUPER

2014-03-12 Thread Hayes Wang
For slow CPU, the frequent bulk transfer would cause poor throughput. One solution is to increase the timeout of the aggregation. It let the hw could complete the bulk transfer later and fill more packets into the buffer. Besides, it could reduce the frequency of the bulk transfer efficiently and i

[PATCH net-next v2 2/2] r8152: reduce the numbers of the bulks

2014-03-12 Thread Hayes Wang
It is not necessary to have many transfer buffers. Reduce the number from 10 to 4. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 293b4d8..1826fcf 100644 --- a/d

RE: [PATCH v3 07/13] usb: chipidea: add OTG fsm operation functions implemenation.

2014-03-12 Thread Peter Chen
> > > Yes, gadget is not linked to OTG fsm, I did not find a better way to > > > get ci here, actually this patchset is adding a otg_fsm *pointer* > > > instead of struct otg_fsm into struct ci_hdrc, directly embed > > > otg_fsm is a big cost since it's also a some big structure. > > > > I think

RE: [PATCH v3 00/13] Add USB OTG HNP and SRP support on Chipidea usb driver

2014-03-12 Thread Peter Chen
> > On Fri, Mar 07, 2014 at 10:32:30AM +0800, Peter Chen wrote: > > On Thu, Feb 27, 2014 at 07:38:18AM +0800, Li Jun wrote: > > > From: b47624 > > > > > > This patchset adds USB OTG HNP and SRP support on chipidea usb > > > driver, existing OTG port role swtich function by ID pin status kept >

RE: [PATCH 2/3] usb: phy-fsm: update OTG HNP state transition

2014-03-12 Thread Peter Chen
> > On 12-03-2014 12:56, Peter Chen wrote: > > > From: Li Jun > > > According to:"On-The-Go and Embedded Host Supplement to the USB > > Revision 2.0 Specification July 27, 2012 Revision 2.0 version 1.1a" > > - add a_wait_vrise to a_wait_vfall > > - update condition from a_wait_vrise to a_wait

Re: reset_resume() for btusb

2014-03-12 Thread Oliver Neukum
On Wed, 2014-03-12 at 15:18 +, Poulain, Loic wrote: > My thought was to fix the usbcore rebind issue (with pm_runtime) > to let the core unbind and rebind the device's interfaces for drivers > with no reset_resume callback (not only btusb). Those functions seem to be independent. Even if you