> > > Yes, gadget is not linked to OTG fsm, I did not find a better way to
> > > get ci here, actually this patchset is adding a otg_fsm *pointer*
> > > instead of struct otg_fsm into struct ci_hdrc, directly embed
> > > otg_fsm is a big cost since it's also a some big structure.
> >
> > I think keep the code easy to read and maintain are important just
> > waste tens of bytes for some controllers. I prefer to use struct than
> > pointer for otg_fsm at struct ci_hdrc.
> >
> 
> OK, I will directly embed it.
> 
> > I checked struct otg_fsm, lots of entries are defined with int, in
> > fact, it doesn't necessary, defined as unsigned xxx:1 is enough.
> >
> 
> That's true, I will create a separated patch for it.
> 

But it needs to change otg_timer_initializer, it can't get bit address.

Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to