Re: xhci and other woes

2014-02-06 Thread renevant
Hello guys, Currently i've done this in xhci-pci.c #define PCI_VENDOR_ID_RENESAS 0x1912 #define PCI_DEVICE_ID_RENESAS_UPD720201 0x0014 if (pdev->vendor == PCI_VENDOR_ID_RENESAS && pdev->device == PCI_DEVICE_ID_RENESAS_UPD720201 &&

Re: [PATCH v3] tools: usb: aio example applications

2014-02-06 Thread Michal Nazarewicz
On Tue, Feb 04 2014, Robert Baldyga wrote: > This code is an example. Don't you think it would be better to keep it > simple? PS. Of course another approach is to use two threads one for ep0 and the other for transfers. Yet another, is to add AIO to ep0 in the kernel. -- Best regards,

RE: [PATCH v3] tools: usb: aio example applications

2014-02-06 Thread David Laight
From: Michal Nazarewicz > On Tue, Feb 04 2014, Robert Baldyga wrote: > > This code is an example. Don't you think it would be better to keep it > > simple? > > PS. Of course another approach is to use two threads one for ep0 and the > other for transfers. Yet another, is to add AIO to ep0 in the

RE: xhci and other woes

2014-02-06 Thread David Laight
From: Sarah> Sharp > On Wed, Feb 05, 2014 at 09:44:20AM +, David Laight wrote: > > From: Mark Lord > > > >> Which means that the controller is obeying the rules, and the software > > > >> is wrong. > > > .. > > > > In this case, the bug has been worked around (not perfectly), but we've > > > >

Re: xhci and other woes

2014-02-06 Thread Hans Petter Selasky
On 02/04/14 20:10, Sarah Sharp wrote: And there's code in the xHCI driver to ignore the second successful event. See ep->last_td_was_short. Yes, this is a slight race condition, and we should wait for the successful event. However, we have not seen any issues with this race condition. Hi, S

[patch] hso: remove some dead code

2014-02-06 Thread Dan Carpenter
It seems like this function was intended to have special handling for urb statuses of -ENOENT and -ECONNRESET. But now it just prints some debugging and returns at the start of the function. I have removed the dead code, it's still in the git history if anyone wants to revive it. Signed-off-by:

[PATCH] net: asix: fix bad header length bug

2014-02-06 Thread Emil Goode
The AX88772B occasionally send rx packets that cross urb boundaries and the remaining partial packet is sent with no header. When the buffer with a partial packet is of less number of octets than the value of hard_header_len the buffer is discarded by the usbnet module. This is causing dropped pack

Re: [PATCH] net: asix: fix bad header length bug

2014-02-06 Thread Igor Gnatenko
On Thu, 2014-02-06 at 13:56 +0100, Emil Goode wrote: > The AX88772B occasionally send rx packets that cross urb boundaries > and the remaining partial packet is sent with no header. > When the buffer with a partial packet is of less number of octets > than the value of hard_header_len the buffer i

[PATCH 1/1] xhci: include renesas controllers in NEC quirk

2014-02-06 Thread renevant
I experienced the following WARN with a Renesas uPD720201 controller : xhci_hcd :02:00.0: WARN Successful completion on short TX: needs XHCI_TRUST Adding the XHCI_NEC_HOST quirk solved the issue. It's possible that this doesn't apply to all Renesas hosts, however it appears they only offi

RE: [PATCH] net: asix: fix bad header length bug

2014-02-06 Thread David Laight
From: Emil Goode > The AX88772B occasionally send rx packets that cross urb boundaries > and the remaining partial packet is sent with no header. > When the buffer with a partial packet is of less number of octets > than the value of hard_header_len the buffer is discarded by the > usbnet module. T

Re: [PATCH v3] tools: usb: aio example applications

2014-02-06 Thread Michal Nazarewicz
On Thu, Feb 06 2014, David Laight wrote: > From: Michal Nazarewicz >> On Tue, Feb 04 2014, Robert Baldyga wrote: >> > This code is an example. Don't you think it would be better to keep it >> > simple? >> >> PS. Of course another approach is to use two threads one for ep0 and the >> other for trans

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-02-06 Thread Tomasz Figa
Hi Vivek, This patch is just adding the PHY driver. I would also like to look at some users of it, to see how this works when put together. For now, please see my comments inline. On 20.01.2014 14:42, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new

Re: [PATCH] net: asix: fix bad header length bug

2014-02-06 Thread Emil Goode
Hello David, Thank's for the review. On Thu, Feb 06, 2014 at 01:37:12PM +, David Laight wrote: > From: Emil Goode > > The AX88772B occasionally send rx packets that cross urb boundaries > > and the remaining partial packet is sent with no header. > > When the buffer with a partial packet is o

Re: [PATCH 1/1] xhci: include renesas controllers in NEC quirk

2014-02-06 Thread Greg KH
On Fri, Feb 07, 2014 at 12:23:19AM +1100, renev...@internode.on.net wrote: > I experienced the following WARN with a Renesas uPD720201 controller : > > xhci_hcd :02:00.0: WARN Successful completion on short TX: needs > XHCI_TRUST > > Adding the XHCI_NEC_HOST quirk solved the issue. > > > I

RE: [PATCH] net: asix: fix bad header length bug

2014-02-06 Thread David Laight
From: Igor Gnatenko > On Thu, 2014-02-06 at 13:56 +0100, Emil Goode wrote: > > The AX88772B occasionally send rx packets that cross urb boundaries > > and the remaining partial packet is sent with no header. > > When the buffer with a partial packet is of less number of octets > > than the value of

RE: AX88179_178A USB3 ethernet adapter performance issue

2014-02-06 Thread David Laight
From: Daniel J Blueman > Hi Freddy et al, I've copied this to linux-usb. > I'm experiencing poor network performance using an ASIX AX88179_178A > USB3 to ethernet adapter using any recent linux kernel (eg 3.11), > using an Intel XHCI USB3 controller. There a several problems with the xhci driver

Re: Add for Devices on USB to Serial Device

2014-02-06 Thread Johan Hovold
On Thu, Feb 06, 2014 at 01:07:25AM +0100, Gerd W. wrote: > Dear Sirs > > I´ve an USB to Serial Adapter ,who works under Linux mint 16. > I use it for control Label Printers they connect to Serial. > Please add and set this Driver for Device 067b:2303 Prolific Technology, > Inc. PL2303 Serial Port

Re: xhci and other woes

2014-02-06 Thread Sarah Sharp
On Thu, Feb 06, 2014 at 07:42:33PM +1100, renev...@internode.on.net wrote: > Hello guys, > > Currently i've done this in xhci-pci.c > > #define PCI_VENDOR_ID_RENESAS 0x1912 > #define PCI_DEVICE_ID_RENESAS_UPD720201 0x0014 > > > if (pdev->vendor == PCI_VENDOR_ID_RENESAS && >

Fix? ShuttlePROv2 jog dial reports EV_REL events with absolute position event values

2014-02-06 Thread TheDiveO
I have a ShuttlePRO v2 (Contour Design Inc) that identifies itself as a USB HID. The kernel properly detects its and I can receive events from the device. The ShuttlePRO v2 is a media controller for use with video editing software, et cetera. It has a jog dial for frame-by-frame movement. Next, it

Re: AX88179_178A USB3 ethernet adapter performance issue

2014-02-06 Thread Sarah Sharp
On Thu, Feb 06, 2014 at 03:39:02PM +, David Laight wrote: > From: Daniel J Blueman > > Hi Freddy et al, > > I've copied this to linux-usb. > > > I'm experiencing poor network performance using an ASIX AX88179_178A > > USB3 to ethernet adapter using any recent linux kernel (eg 3.11), > > using

RE: AX88179_178A USB3 ethernet adapter performance issue

2014-02-06 Thread David Laight
From: Sarah Sharp > > I have seem line rate Ge from my ax88179 card, but only with a > > patched kernel. > > David, did you mean you have the same line rate as Daniel? No I meant I've seen it saturate a Ge link (with sufficiently large frames). With very small frames the tx rate gets limited to

[PATCH] usb: musb: Fix obex in g_nokia.ko causing kernel panic

2014-02-06 Thread Ivaylo Dimitrov
From: Felipe Balbi [ 18.606414] [] (__schedule+0x5c/0x50c) from [] (schedule_timeout+0x1f4/0x25c) [ 18.623809] [] (schedule_timeout+0x1f4/0x25c) from [] (wait_for_common+0xc8/0x1ac) [ 18.649291] [] (wait_for_common+0xc8/0x1ac) from [] (omap_i2c_xfer+0x338/0x488) [ 18.674499] [] (omap_i

Re: [PATCH] usb: musb: Fix obex in g_nokia.ko causing kernel panic

2014-02-06 Thread Greg KH
On Thu, Feb 06, 2014 at 09:25:37PM +0200, Ivaylo Dimitrov wrote: > From: Felipe Balbi I can't take a patch that the author doesn't sign off on, sorry. Please wait a week or so so that Felipe can return from vacation. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe

Re: Add for Devices on USB to Serial Device

2014-02-06 Thread Johan Hovold
[ Please make sure to reply to all recipients including the linux-usb list. ] On Thu, Feb 06, 2014 at 08:23:10PM +0100, Gerd W. wrote: > Am 06.02.2014 17:38, schrieb Johan Hovold: > > On Thu, Feb 06, 2014 at 01:07:25AM +0100, Gerd W. wrote: > >> Dear Sirs > >> > >> I´ve an USB to Serial Adapter

Re: [PATCH v4 01/14] usb: assign default peer ports for root hubs

2014-02-06 Thread Alan Stern
On Fri, 31 Jan 2014, Dan Williams wrote: > Assume that the peer of a superspeed port is the port with the same id > on the shared_hcd root hub. This identification scheme is required of > external hubs by the USB3 spec [1]. However, for root hubs, tier mismatch > may be in effect [2]. Tier mism

Re: [PATCH v4 01/14] usb: assign default peer ports for root hubs

2014-02-06 Thread Alan Stern
On Thu, 6 Feb 2014, Alan Stern wrote: > It would also be a good idea to verify that peer->peer is NULL before > doing these assignments. Now I see that you did this in patch 2. Might as well do it in patch 1 instead. > > + spin_lock(&peer_lock); > > + if (peer) { > > + peer->peer

Re: [PATCH v4 03/14] usb: find internal hub tier mismatch via acpi

2014-02-06 Thread Alan Stern
On Fri, 31 Jan 2014, Dan Williams wrote: > ACPI identifies peer ports by setting their 'group_token' and > 'group_position' _PLD data to the same value. If a platform has tier > mismatch [1] , ACPI can override the default, USB3 defined, peer port > association for internal hubs. External hubs f

Re: [PATCH v4 04/14] usb: sysfs link peer ports

2014-02-06 Thread Alan Stern
On Fri, 31 Jan 2014, Dan Williams wrote: > For example: Topic sentence? A reader seeing this could be forgiven for wondering "Example of what?". > usb2/2-1/2-1:1.0/port1/peer => ../../../../usb3/3-1/3-1:1.0/port1 > usb2/2-1/2-1:1.0/port2/peer => ../../../../usb3/3-1/3-1:1.0/port2 > usb2/2-1/2-1

Re: [PATCH v4 05/14] usb: defer suspension of superspeed port while peer is powered

2014-02-06 Thread Alan Stern
On Fri, 31 Jan 2014, Dan Williams wrote: > ClearPortFeature(PORT_POWER) on a usb3 port places the port in either a > DSPORT.Powered-off-detect / DSPORT.Powered-off-reset loop, or the > DSPORT.Powered-off state. There is no way to ensure that RX > terminations will persist in this state, so it is

Re: [PATCH v4 06/14] usb: don't clear FEAT_C_ENABLE on usb_port_runtime_resume failure

2014-02-06 Thread Alan Stern
On Fri, 31 Jan 2014, Dan Williams wrote: > Three reasons: > 1/ It's an invalid operation on usb3 ports > 2/ There's no guarantee of when / if a usb2 port has entered an error >state relative to PORT_POWER request > 3/ The port is active / powered at this point, so khubd will clear it as >a

Re: [PATCH v4 07/14] usb: usb3 ports do not support FEAT_C_ENABLE

2014-02-06 Thread Alan Stern
On Fri, 31 Jan 2014, Dan Williams wrote: > The port pm_runtime implementation unconditionally clears FEAT_C_ENABLE > after clearing PORT_POWER, but the bit is reserved on usb3 hub ports. > We expect khubd to be suspended at this time so we need to clear any > errors for usb2 ports. I'm not sure w

Upgrading just the USB core from 3.7 to tip?

2014-02-06 Thread Devin Heitmueller
Hi there, So I have a problem in the field on kernel 3.7 which is looking more and more like some sort of EHCI scheduler bug (very occasional usb_submit_urb failures in snd-usb-audio wedge the entire USB stack until reboot). Because it's only happening in the field and I cannot repro locally (and

Re: [PATCH v4 09/14] usb: synchronize port poweroff and khubd

2014-02-06 Thread Alan Stern
On Fri, 31 Jan 2014, Dan Williams wrote: > If a port is powered-off, or in the process of being powered-off, prevent > khubd from operating on it. Otherwise, the following sequence of events > leading to an unintended disconnect may occur: > > Events: > (0) > (1) hub 2-2:1.0: hub_resume > (2) h

Re: [PATCH v4 09/14] usb: synchronize port poweroff and khubd

2014-02-06 Thread Alan Stern
On Thu, 6 Feb 2014, Alan Stern wrote: > On Fri, 31 Jan 2014, Dan Williams wrote: > > > If a port is powered-off, or in the process of being powered-off, prevent > > khubd from operating on it. Otherwise, the following sequence of events > > leading to an unintended disconnect may occur: > > > >

Re: Upgrading just the USB core from 3.7 to tip?

2014-02-06 Thread Alan Stern
On Thu, 6 Feb 2014, Devin Heitmueller wrote: > Hi there, > > So I have a problem in the field on kernel 3.7 which is looking more > and more like some sort of EHCI scheduler bug (very occasional > usb_submit_urb failures in snd-usb-audio wedge the entire USB stack > until reboot). Because it's o

Re: [PATCH] net: asix: fix bad header length bug

2014-02-06 Thread Emil Goode
On Thu, Feb 06, 2014 at 03:28:13PM +, David Laight wrote: > From: Igor Gnatenko > > On Thu, 2014-02-06 at 13:56 +0100, Emil Goode wrote: > > > The AX88772B occasionally send rx packets that cross urb boundaries > > > and the remaining partial packet is sent with no header. > > > When the buffer

Re: [PATCH v4 01/14] usb: assign default peer ports for root hubs

2014-02-06 Thread Dan Williams
On Thu, Feb 6, 2014 at 12:07 PM, Alan Stern wrote: > But come to think of it, you don't _really_ depend on the fact that the > USB-2 root hub is registered first. What matters is that the _primary_ > hcd is registered first. > >> + */ >> + if (!hdev->parent) { >> + struct usb

Re: [PATCH v4 01/14] usb: assign default peer ports for root hubs

2014-02-06 Thread Dan Williams
Hi Alan, Thanks for the time and effort on the review, really appreciate it. On Thu, Feb 6, 2014 at 12:07 PM, Alan Stern wrote: > On Fri, 31 Jan 2014, Dan Williams wrote: > >> Assume that the peer of a superspeed port is the port with the same id >> on the shared_hcd root hub. This identificati

Re: Fix? ShuttlePROv2 jog dial reports EV_REL events with absolute position event values

2014-02-06 Thread Greg KH
On Thu, Feb 06, 2014 at 04:53:46PM +, TheDiveO wrote: > I have a ShuttlePRO v2 (Contour Design Inc) that identifies itself as a USB > HID. The kernel properly detects its and I can receive events from the > device. The ShuttlePRO v2 is a media controller for use with video editing > software, e

Re: xhci and other woes

2014-02-06 Thread renevant
Ok it appears I was wrong about the NEC quirk. Here is what i'm seeing at the moment: The ax88179 is only working for me on the Renesas uPD720201 via a USB 3.0 HUB. However for some reason once I use the hub I get : xhci_hcd :02:00.0: WARN Successful completion on short TX: needs XHCI_TRU

Re: [PATCH] usb: chipidea: use dev_get_platdata()

2014-02-06 Thread Jingoo Han
On Friday, February 07, 2014 11:36 AM, Peter Chen wrote: > On Wed, Feb 05, 2014 at 10:30:35AM +0900, Jingoo Han wrote: > > Use the wrapper function for retrieving the platform data instead > > of accessing dev->platform_data directly. This is a cosmetic change > > to make the code simpler and enhan

[PATCH v3 1/1] USB: EHCI: wait more than 3ms until the device enters full-speed idle

2014-02-06 Thread Peter Chen
If the high-speed device does not enter full-speed idle after wakeup on disconnect logic has effected, there will be an unexpected disconnect wakeup interrupt due to the bus is still SE0. Signed-off-by: Peter Chen Hi Alan, If you can't met this issue, it may due to your hardware enables WKDN af

Re: [PATCH] usb: chipidea: use dev_get_platdata()

2014-02-06 Thread Peter Chen
On Fri, Feb 07, 2014 at 01:11:49PM +0900, Jingoo Han wrote: > On Friday, February 07, 2014 11:36 AM, Peter Chen wrote: > > On Wed, Feb 05, 2014 at 10:30:35AM +0900, Jingoo Han wrote: > > > Use the wrapper function for retrieving the platform data instead > > > of accessing dev->platform_data direct

Re: Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device Driver Support

2014-02-06 Thread liujunliang_ljl
Dear Joe : I'm sorry that I reply so late, because I have just spent new chinese year. I will resubmit SR9800 Driver today. Thanks a lot. 2014-02-07 liujunliang_ljl 发件人: Joe Perches 发送时间: 2014-01-28 16:59:38 收件人: liujunliang_ljl 抄送:

Re: [PATCH net] r8152: fix the submission of the interrupt transfer

2014-02-06 Thread David Miller
From: Hayes Wang Date: Thu, 6 Feb 2014 11:55:48 +0800 > The submission of the interrupt transfer should be done after setting > the bit of WORK_ENABLE, otherwise the callback function would have > the opportunity to be returned directly. > > Clear the bit of WORK_ENABLE before killing the interr

Re: [PATCH] usb: chipidea: use dev_get_platdata()

2014-02-06 Thread Peter Chen
On Wed, Feb 05, 2014 at 10:30:35AM +0900, Jingoo Han wrote: > Use the wrapper function for retrieving the platform data instead > of accessing dev->platform_data directly. This is a cosmetic change > to make the code simpler and enhance the readability. > > Signed-off-by: Jingoo Han > --- > driv

Re: [PATCH 1/1] usb: gadget: printer: using gadget_is_otg to check otg support at runtime

2014-02-06 Thread Peter Chen
On Fri, Jan 3, 2014 at 4:45 PM, Peter Chen wrote: > We need to use gadget_is_otg to check if the gadget is really > otg support at runtime, other composite gadget drivers have already > followed this method. > > Signed-off-by: Peter Chen > --- > drivers/usb/gadget/printer.c |2 +- > 1 files

Re: [PATCH 1/1] usb: phy: delete CONFIG_USB_OTG_FSM

2014-02-06 Thread Peter Chen
On Fri, Jan 10, 2014 at 3:54 PM, Peter Chen wrote: > We already have CONFIG_USB_OTG which can cover all CONFIG_USB_OTG_FSM > does. > > Cc: Jun Li > Cc: Anton Tikhomirov > Signed-off-by: Peter Chen > --- > drivers/usb/phy/Kconfig | 11 +-- > drivers/usb/phy/Makefile |2 +- > 2 fi

Re: [PATCH v9 00/12] Add power management support for mxs phy

2014-02-06 Thread Peter Chen
On Mon, Jan 20, 2014 at 2:48 PM, Peter Chen wrote: > > > >> >> Hi Felipe & Shawn, >> >> The serial adds power management support for MXS PHY, it includes: >> >> - Add one PHY API .set_wakeup, and related API implementation at mxs phy >> driver >> - misc changes and bug fixes for mxs phy to support

Re: xhci and other woes

2014-02-06 Thread renevant
ok so the nic died even via the hub now it looks like certain traffic does it. reverting the fragment patch didnt help. argh. On Friday 07 February 2014 13:32:56 renev...@internode.on.net wrote: > Ok it appears I was wrong about the NEC quirk. > > > Here is what i'm seeing at the moment: > >

Re: [PATCH] usb: chipidea: use dev_get_platdata()

2014-02-06 Thread Peter Chen
On Wed, Feb 05, 2014 at 10:30:35AM +0900, Jingoo Han wrote: > Use the wrapper function for retrieving the platform data instead > of accessing dev->platform_data directly. This is a cosmetic change > to make the code simpler and enhance the readability. > > Signed-off-by: Jingoo Han > --- > driv

Re: [patch] hso: remove some dead code

2014-02-06 Thread David Miller
From: Dan Carpenter Date: Thu, 6 Feb 2014 15:53:19 +0300 > It seems like this function was intended to have special handling for > urb statuses of -ENOENT and -ECONNRESET. But now it just prints some > debugging and returns at the start of the function. > > I have removed the dead code, it's st

Re: [PATCH] usb: chipidea: udc: add maximum-speed = full-speed option

2014-02-06 Thread Peter Chen
On Tue, Jan 28, 2014 at 04:28:44PM +0100, Michael Grzeschik wrote: > This patch makes it possible to set the chipidea udc into full-speed only > mode. > It is set by the oftree property "maximum-speed = full-speed". > > Signed-off-by: Michael Grzeschik > Signed-off-by: Marc Kleine-Budde > --- >

Re: [PATCH 1/1] usb: gadget: printer: using gadget_is_otg to check otg support at runtime

2014-02-06 Thread Greg KH
On Fri, Feb 07, 2014 at 01:47:18PM +0800, Peter Chen wrote: > On Fri, Jan 3, 2014 at 4:45 PM, Peter Chen wrote: > > We need to use gadget_is_otg to check if the gadget is really > > otg support at runtime, other composite gadget drivers have already > > followed this method. > > > > Signed-off-by:

[PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support

2014-02-06 Thread liujunliang_ljl
From: Liu Junliang Signed-off-by: Liu Junliang --- drivers/net/usb/Kconfig | 16 + drivers/net/usb/Makefile |1 + drivers/net/usb/sr9800.c | 874 ++ drivers/net/usb/sr9800.h | 202 +++ 4 files changed, 1093 insertions(+) create mode