On Thu, Feb 06, 2014 at 07:42:33PM +1100, renev...@internode.on.net wrote: > Hello guys, > > Currently i've done this in xhci-pci.c > > #define PCI_VENDOR_ID_RENESAS 0x1912 > #define PCI_DEVICE_ID_RENESAS_UPD720201 0x0014 > > > if (pdev->vendor == PCI_VENDOR_ID_RENESAS && > pdev->device == PCI_DEVICE_ID_RENESAS_UPD720201 && > pdev->revision == 0x3) > xhci->quirks |= XHCI_NEC_HOST; > > > The warnings are gone.
Which warnings are gone? > Perhaps this quirk needs to apply to all Renesas controllers ? This addition > i've made obviously specifically matches the card I've got but the NEC match > in xhci-pci.c obviously isn't matching the Renesas vendor ID only NEC. > > > if (pdev->vendor == PCI_VENDOR_ID_NEC) > xhci->quirks |= XHCI_NEC_HOST; > > > Maybe this needs an && PCI_VENDOR_ID_RENESAS The only thing this quirk does is submit a command to get the NEC firmware version, and then print it out. It should have no impact on host controller behavior. So, what warnings disappeared when you turned this quirk on? Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
