On Fri, 31 Jan 2014, Dan Williams wrote: > Three reasons: > 1/ It's an invalid operation on usb3 ports > 2/ There's no guarantee of when / if a usb2 port has entered an error > state relative to PORT_POWER request > 3/ The port is active / powered at this point, so khubd will clear it as > a matter of course > > Signed-off-by: Dan Williams <dan.j.willi...@intel.com> > --- > drivers/usb/core/port.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c > index 2227379be652..32290b8d4f8f 100644 > --- a/drivers/usb/core/port.c > +++ b/drivers/usb/core/port.c > @@ -105,7 +105,6 @@ static int usb_port_runtime_resume(struct device *dev) > if (retval < 0)
The comment just above this code says that retval is ignored. Maybe you could move that part of the comment after the dev_dbg line? > dev_dbg(&port_dev->dev, "can't get reconnection after > setting port power on, status %d\n", > retval); > - usb_clear_port_feature(hdev, port1, USB_PORT_FEAT_C_ENABLE); > retval = 0; > } Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
