From: Dan Carpenter
Date: Wed, 13 Nov 2013 10:42:34 +0300
> This is harmless but cdc_ncm_setup() returns negative error codes
> truncated to u8 values. There is only one caller and treats all
> non-zero returns as errors but doesn't store the the return code. So
> the code works correctly but i
On Wed, 2013-11-13 at 17:11 -0500, Alan Stern wrote:
> On Thu, 14 Nov 2013, Greg KH wrote:
>
> > On Wed, Nov 13, 2013 at 06:13:06PM +0100, oli...@neukum.org wrote:
> > > From: Oliver Neukum
> > >
> > > To allow a full switch to dynamic debugging make the
> > > debug parameter conditional on defi
On Thu, 2013-11-14 at 10:03 +0800, wangbiao wrote:
> From: wang, biao
> Date: Mon, 11 Nov 2013 10:23:40 +0800
> Subject: [PATCH] usbnet: fix race condition caused spinlock bad magic issue
>
> there is race between usbnet_terminate_urbs and usbnet_bh.
> for example:
> cpu 0
These functions used to return negative errror codes but now they return
ERR_PTRs.
Signed-off-by: Dan Carpenter
diff --git a/drivers/usb/gadget/u_ether.h b/drivers/usb/gadget/u_ether.h
index fb23d1f..a32b41e 100644
--- a/drivers/usb/gadget/u_ether.h
+++ b/drivers/usb/gadget/u_ether.h
@@ -106,7 +
On 11/14/2013 09:42 AM, Dan Carpenter wrote:
> These functions used to return negative errror codes but now they return
> ERR_PTRs.
>
> Signed-off-by: Dan Carpenter
Acked-by: Sebastian Andrzej Siewior
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body
From: Oliver Neukum
This makes sure the header files are all there
Signed-off-by: Oliver Neukum
---
drivers/usb/host/uhci-debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/uhci-debug.c b/drivers/usb/host/uhci-debug.c
index 8e239cd..fddf9ba 100644
From: Oliver Neukum
No need for conditional compilation here.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/uhci-hcd.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
index e3b1a4c..8631862 100644
--- a/drive
From: Oliver Neukum
To allow a full switch to dynamic debugging make the
debug parameter conditional on defined(DEBUF) || defined(DYNAMIC_DEBUG)
Signed-off-by: Oliver Neukum
---
drivers/usb/host/uhci-hcd.c | 48 +++--
1 file changed, 29 insertions(+), 19
Oliver Neukum writes:
> On Thu, 2013-11-14 at 10:03 +0800, wangbiao wrote:
>> From: wang, biao
>> Date: Mon, 11 Nov 2013 10:23:40 +0800
>> Subject: [PATCH] usbnet: fix race condition caused spinlock bad magic issue
>>
>> there is race between usbnet_terminate_urbs and usbnet_bh.
>> for example:
> From: Oliver Neukum
>
> To allow a full switch to dynamic debugging make the
> debug parameter conditional on defined(DEBUF) || defined(DYNAMIC_DEBUG)
This version still contains ugly (and unnecessary) #if in the code.
...
Both debug and errbuf are 0 so this would be compiled out:
> +#if def
On Thu, Nov 14, 2013 at 12:09:46AM -0200, Fabio Estevam wrote:
> @@ -107,10 +108,22 @@ static int ci_hdrc_imx_probe(struct platform_device
> *pdev)
> return ret;
> }
>
> + data->clk_phy = devm_clk_get(&pdev->dev, "phy");
> + if (IS_ERR(data->clk_phy)) {
> +
> From: Sarah Sharp
> On Wed, Nov 13, 2013 at 12:28:09PM -, David Laight wrote:
> > If URB_ZERO_PACKET is set on a transfer that is an integral number
> > of maximum length packets (1k for USB3 bulk) then an additional
> > zero length fragment must be sent.
> >
> > Merge together the functions
From: Fabio Estevam
When using external USB PHY or USB hub, it is common that they require a clock
input.
Add a 'clk_phy' clock, so that it can be retrieved from the device tree and
enabled in the driver, so that the clock can properly drive the external
USB phy/hub.
Tested on a imx6q-udoo bo
On Thu, Nov 14, 2013 at 7:56 AM, Russell King - ARM Linux
wrote:
> On Thu, Nov 14, 2013 at 12:09:46AM -0200, Fabio Estevam wrote:
>> @@ -107,10 +108,22 @@ static int ci_hdrc_imx_probe(struct platform_device
>> *pdev)
>> return ret;
>> }
>>
>> + data->clk_phy = devm_clk_get
From: Oliver Neukum
This is a step in the conversion to only use dynamic
debugging.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/fusbh200-hcd.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200-hcd.c
index 70d2b01..15067
From: Oliver Neukum
It has become unnecessary by #define trickery
Signed-off-by: Oliver Neukum
---
drivers/usb/host/uhci-hcd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
index 8631862..d6e2814 100644
--- a/drivers/usb/host/uhc
On Thu, Nov 14, 2013 at 08:47:40AM -0200, Fabio Estevam wrote:
> From: Fabio Estevam
>
> When using external USB PHY or USB hub, it is common that they require a clock
> input.
>
> Add a 'clk_phy' clock, so that it can be retrieved from the device tree and
> enabled in the driver, so that the cloc
On Thu, Nov 14, 2013 at 08:47:40AM -0200, Fabio Estevam wrote:
> From: Fabio Estevam
>
> When using external USB PHY or USB hub, it is common that they require a clock
> input.
If it is an external USB PHY, the clock entry should be added at phy node.
If it is a USB HUB's reset/clock pin, there
On Mon, Nov 11, 2013 at 12:45 PM, Alexander Shiyan wrote:
>> Hi Alexander,
>>
>> On Sunday, November 10, 2013 03:18 PM, Alexander Shiyan wrote:
>> > This adds i.MX27 and i.MX31 as the next user of the usbmisc driver.
>> >
>> > Signed-off-by: Alexander Shiyan
>> > ---
>> > drivers/usb/chipidea/us
On Sun, Nov 10, 2013 at 3:18 PM, Alexander Shiyan wrote:
> This adds i.MX51 as the next user of the usbmisc driver.
> Since the functional is similar i.MX53, we just rename the
> definitions and add an alias for the new CPU.
>
> Signed-off-by: Alexander Shiyan
> ---
> drivers/usb/chipidea/usbmis
Hi Michael,
On Thu, Nov 14, 2013 at 9:18 AM, Michael Grzeschik wrote:
> NACK! We have the phy framework for this. If you are unsure you can use the
> nop phy here as in mx53.dtsi.
>
> usbphy0: usbphy@0 {
> compatible = "usb-nop-xceiv";
> clocks = <&clks 12
Hello,
I'm using Greg's linux-usb/next on mx28-evk with mxs-defconfig. I
switched on OTG support and ether gadget and compiled it into the kernel.
During every boot when the ether gadget is loaded the IRQ of the usb0
fires and nobody cares:
> [3.336843] ci_hdrc ci_hdrc.0: ChipIdea HDRC found
Hi Marc,
On Thu, Nov 14, 2013 at 10:46 AM, Marc Kleine-Budde wrote:
> Hello,
>
> I'm using Greg's linux-usb/next on mx28-evk with mxs-defconfig. I
> switched on OTG support and ether gadget and compiled it into the kernel.
>
> During every boot when the ether gadget is loaded the IRQ of the usb0
>
> Drivers don't have to implement anything special if they want to use
> their runtime routines for system suspend. All they have to do is set
> the .suspend and .resume method pointers to point to their
> runtime_suspend and runtime_resume routines.
>
>> In the case were drivers needs there run
> > [3.497987] using random self ethernet address
> > [3.503321] using random host ethernet address
> > [3.510076] g_ether gadget: Ethernet Gadget, version: Memorial Day
> 2008
> > [3.516749] g_ether gadget: g_ether ready
> > [4.842006] irq 237: nobody cared (try booting with
On 11/14/2013 02:17 PM, Fabio Estevam wrote:
> Hi Marc,
>
> On Thu, Nov 14, 2013 at 10:46 AM, Marc Kleine-Budde
> wrote:
>> Hello,
>>
>> I'm using Greg's linux-usb/next on mx28-evk with mxs-defconfig. I
>> switched on OTG support and ether gadget and compiled it into the kernel.
>>
>> During eve
On 11/14/2013 02:45 PM, Peter Chen wrote:
>
>
>>> [3.497987] using random self ethernet address
>>> [3.503321] using random host ethernet address
>>> [3.510076] g_ether gadget: Ethernet Gadget, version: Memorial Day
>> 2008
>>> [3.516749] g_ether gadget: g_ether ready
>>> [4.
> >
> > What your otg port looks like? It is a Micro-B-Female port?
> > If ID pin is low, it will be considered as host role, when you
> > connect to another machine's host port, both sides are host, it can't
> > be enumerated.
>
> Yes, I know, both sides are in the host role. Granted my fault,
>
> That's not even correct. It prevents the runtime PM framework from being
> used to suspend devices during system suspend and that's on purpose. The
> reason why is that we don't want asynchronous runtime suspends to happen
> during system suspend and race with the suspend process.
>
>> Remove
hi all:
I have some questions:
1. if I need to capture all the data host capture from bus, usb mon
binary can reach this goal?
2. if #1 is Yes. from usb mon text I need
a. compile kernel with usbmon support
b. access /dev/usbmonx
c. feed the binary file to wireshark.
in b), shall we
From: Oliver Neukum
With dynamic debugging the selection is done in user space
Signed-off-by: Oliver Neukum
---
drivers/usb/host/ohci-hub.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/host/ohci-hub.c b/drivers/usb/host/ohci-hub.c
index 61705a7..953821e 1
From: Oliver Neukum
With the introduction of dynamic debugging it has become redundant.
Collapse it with ohci_dbg()
Signed-off-by: Oliver Neukum
---
drivers/usb/host/ohci-hcd.c | 4 ++--
drivers/usb/host/ohci-q.c | 8
drivers/usb/host/ohci.h | 2 --
3 files changed, 6 insertions
From: Oliver Neukum
Just remove the conditional compilation.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/ohci-hcd.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
index 501ecea..de0e3e4 100644
--- a/drivers/usb/host/ohci
From: Oliver Neukum
Conditional compilation for debugging is removed in favor of
dynamic debugging. To do so
1. the support for debugfs is always compiled
2. the support for the ancient print_urb debugging aid is removed
Signed-off-by: Oliver Neukum
---
drivers/usb/host/ohci-dbg.c | 70 +-
From: Oliver Neukum
With the new dbg_status() the interrupt handler doesn't need
conditional compilation
Signed-off-by: Oliver Neukum
---
drivers/usb/host/ehci-hcd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
From: Oliver Neukum
The decision about what is interesting is done in user space
when dynamic debugging is used.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/ehci-hub.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/e
From: Oliver Neukum
Rewrite it so that the status is evaluated only if the
printk is actually executed.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/ehci-dbg.c | 51 +
1 file changed, 24 insertions(+), 27 deletions(-)
diff --git a/drivers/usb/h
From: Oliver Neukum
Always compile in the debugfs support
---
drivers/usb/host/fotg210-hcd.c | 8
drivers/usb/host/fotg210.h | 8
2 files changed, 16 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
index 55486bd..3af0533 100644
---
From: Oliver Neukum
Simply remove the conditional compilation and remove
the empty stubs.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/fotg210-hcd.c | 47 --
1 file changed, 47 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/
From: Oliver Neukum
The expensive evaluation should be done only if a message is
actually to be printed.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/fotg210-hcd.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb
From: Oliver Neukum
These helpers are used only during setup of a HCD.
A small overhead is no problem.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/fusbh200-hcd.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200
From: Oliver Neukum
Rewrite for little overhead so that it can be used
in interrupt handlers for dynamic debugging
Signed-off-by: Oliver Neukum
---
drivers/usb/host/fusbh200-hcd.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/host/fusbh200-hcd
From: Oliver Neukum
This gets rid of conditional compilation.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/fusbh200-hcd.c | 31 ---
drivers/usb/host/fusbh200.h | 8
2 files changed, 39 deletions(-)
diff --git a/drivers/usb/host/fusbh200-hcd.c b/d
From: Oliver Neukum
This is a step in the conversion to only use dynamic
debugging.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/fusbh200-hcd.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200-hcd.c
index 70d2b01..15067
From: Oliver Neukum
The decision what is interesting is made in user space.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/fotg210-hcd.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
index 4acb6a
From: Oliver Neukum
This allows removal of much conditional compilation.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/fusbh200-hcd.c | 17 ++---
drivers/usb/host/fusbh200.h | 4
2 files changed, 2 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/host/fusbh200
From: Oliver Neukum
The decision what is interesting is shifted to user space by
dynamic debugging.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/fotg210-hcd.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb
From: Oliver Neukum
It has become unnecessary by #define trickery
Signed-off-by: Oliver Neukum
---
drivers/usb/host/uhci-hcd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
index 8631862..d6e2814 100644
--- a/drivers/usb/host/uhc
From: Oliver Neukum
In the drivers that no longer need it, it is removed.
It is removed from the Makefile. Drivers not fully converted
to dynamic debug have it shifted down into the individual
drivers.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/Makefile | 2 --
drivers/usb/host/eh
From: Oliver Neukum
For dynamic debug the overhead for evaluating parameters must
be sacrificed only if the message is actually printed
Signed-off-by: Oliver Neukum
---
drivers/usb/host/fotg210-hcd.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/hos
From: Oliver Neukum
With dynamic debugging this log level is no longer supported.
The decision which messages are interesting is done in user space.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/fusbh200-hcd.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --
From: Oliver Neukum
This makes sure the header files are all there
Signed-off-by: Oliver Neukum
---
drivers/usb/host/uhci-debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/uhci-debug.c b/drivers/usb/host/uhci-debug.c
index 8e239cd..fddf9ba 100644
From: Oliver Neukum
To allow a full switch to dynamic debugging make the
debug parameter conditional on defined(DEBUF) || defined(DYNAMIC_DEBUG)
Signed-off-by: Oliver Neukum
---
drivers/usb/host/uhci-hcd.c | 48 +++--
1 file changed, 29 insertions(+), 19
From: Oliver Neukum
No need for conditional compilation here.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/uhci-hcd.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
index e3b1a4c..8631862 100644
--- a/drive
On 11/14/2013 09:33 AM, vichy wrote:
1. if I need to capture all the data host capture from bus, usb mon
binary can reach this goal?
2. if #1 is Yes. from usb mon text I need
a. compile kernel with usbmon support
b. access /dev/usbmonx
c. feed the binary file to wireshark.
Wit
hi alan:
2013/11/14 Alan Ott :
> On 11/14/2013 09:33 AM, vichy wrote:
>>
>> 1. if I need to capture all the data host capture from bus, usb mon
>> binary can reach this goal?
>> 2. if #1 is Yes. from usb mon text I need
>> a. compile kernel with usbmon support
>> b. access /dev/usbmonx
On 11/14/2013 09:52 AM, vichy wrote:
hi alan:
2013/11/14 Alan Ott :
On 11/14/2013 09:33 AM, vichy wrote:
1. if I need to capture all the data host capture from bus, usb mon
binary can reach this goal?
2. if #1 is Yes. from usb mon text I need
a. compile kernel with usbmon support
hi alan ott:
2013/11/14 Alan Ott :
> On 11/14/2013 09:52 AM, vichy wrote:
>>
>> hi alan:
>>
>> 2013/11/14 Alan Ott :
>>>
>>> On 11/14/2013 09:33 AM, vichy wrote:
1. if I need to capture all the data host capture from bus, usb mon
binary can reach this goal?
2. if #1 is Yes. from
On 11/14/2013 10:04 AM, vichy wrote:
hi alan ott:
2013/11/14 Alan Ott :
On 11/14/2013 09:52 AM, vichy wrote:
hi alan:
2013/11/14 Alan Ott :
On 11/14/2013 09:33 AM, vichy wrote:
1. if I need to capture all the data host capture from bus, usb mon
binary can reach this goal?
2. if #1 is Yes. fr
On Thu, 14 Nov 2013, vichy wrote:
> hi all:
> I have some questions:
> 1. if I need to capture all the data host capture from bus, usb mon
> binary can reach this goal?
Yes.
> 2. if #1 is Yes. from usb mon text I need
> a. compile kernel with usbmon support
> b. access /dev/usbmonx
>
On Thu, 14 Nov 2013, Peter Chen wrote:
> On Thu, Nov 14, 2013 at 08:47:40AM -0200, Fabio Estevam wrote:
> > From: Fabio Estevam
> >
> > When using external USB PHY or USB hub, it is common that they require a
> > clock
> > input.
>
> If it is an external USB PHY, the clock entry should be adde
On Thu, 14 Nov 2013, Ulf Hansson wrote:
> > If you want a driver to do the same thing for runtime PM and system
> > suspend/resume, point its .suspend_late() and .runtime_suspend() to the
> > same routine and analogously for .runtime_resume() and .resume_early()
> > (that may not work for PCI, tho
On Thu, 14 Nov 2013, Ulf Hansson wrote:
> > The reason for doing things the way they are is to avoid races between
> > system PM callbacks and runtime PM callbacks. We don't want to have a
> > runtime_resume routine powering up a device at the same time as a
> > suspend routine is powering it dow
When using an external USB hub, it is common that they require a clock input.
Add a 'clk_usb' clock, so that it can be retrieved from the device tree and
enabled in the driver, so that the clock can properly drive the external
USB hub.
Tested on a imx6q-udoo board, that connects via USBH1 to a
On 14 November 2013 16:59, Alan Stern wrote:
> On Thu, 14 Nov 2013, Ulf Hansson wrote:
>
>> > The reason for doing things the way they are is to avoid races between
>> > system PM callbacks and runtime PM callbacks. We don't want to have a
>> > runtime_resume routine powering up a device at the s
On Thu, 14 Nov 2013 oli...@neukum.org wrote:
> From: Oliver Neukum
>
> Conditional compilation for debugging is removed in favor of
> dynamic debugging. To do so
>
> 1. the support for debugfs is always compiled
> 2. the support for the ancient print_urb debugging aid is removed
>
> Signed-off
hi Alan
2013/11/14 Alan Stern :
> On Thu, 14 Nov 2013, vichy wrote:
>
>> hi all:
>> I have some questions:
>> 1. if I need to capture all the data host capture from bus, usb mon
>> binary can reach this goal?
>
> Yes.
>
>> 2. if #1 is Yes. from usb mon text I need
>> a. compile kernel with us
Hi Fabio,
On Thu, Nov 14, 2013 at 02:12:25PM -0200, Fabio Estevam wrote:
> When using an external USB hub, it is common that they require a clock input.
>
> Add a 'clk_usb' clock, so that it can be retrieved from the device tree and
> enabled in the driver, so that the clock can properly drive t
On Thu, 14 Nov 2013 oli...@neukum.org wrote:
> From: Oliver Neukum
>
> The decision about what is interesting is done in user space
> when dynamic debugging is used.
>
> Signed-off-by: Oliver Neukum
> ---
> drivers/usb/host/ehci-hub.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-
On Thu, 14 Nov 2013 oli...@neukum.org wrote:
> From: Oliver Neukum
>
> With dynamic debugging the selection is done in user space
>
> Signed-off-by: Oliver Neukum
> ---
> drivers/usb/host/ohci-hub.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host
On Thu, 14 Nov 2013 oli...@neukum.org wrote:
> From: Oliver Neukum
>
> With the new dbg_status() the interrupt handler doesn't need
> conditional compilation
>
> Signed-off-by: Oliver Neukum
> ---
> drivers/usb/host/ehci-hcd.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> di
On Thu, 14 Nov 2013 oli...@neukum.org wrote:
> From: Oliver Neukum
>
> Rewrite it so that the status is evaluated only if the
> printk is actually executed.
>
> Signed-off-by: Oliver Neukum
How come you don't make the same change to dbg_intr_buf and
dbg_command_buf?
> @@ -867,7 +864,7 @@ sta
Hi Michael,
On 11/14/2013 02:53 PM, Michael Grzeschik wrote:
Hi Fabio,
On Thu, Nov 14, 2013 at 02:12:25PM -0200, Fabio Estevam wrote:
When using an external USB hub, it is common that they require a clock input.
Add a 'clk_usb' clock, so that it can be retrieved from the device tree and
enabl
On Fri, 15 Nov 2013, vichy wrote:
> hi Alan
>
> 2013/11/14 Alan Stern :
> > On Thu, 14 Nov 2013, vichy wrote:
> >
> >> hi all:
> >> I have some questions:
> >> 1. if I need to capture all the data host capture from bus, usb mon
> >> binary can reach this goal?
> >
> > Yes.
> >
> >> 2. if #1 is Ye
On Thu, Nov 14, 2013 at 03:00:25PM -0200, Fabio Estevam wrote:
> Hi Michael,
>
> On 11/14/2013 02:53 PM, Michael Grzeschik wrote:
> >Hi Fabio,
> >
> >On Thu, Nov 14, 2013 at 02:12:25PM -0200, Fabio Estevam wrote:
> >>When using an external USB hub, it is common that they require a clock
> >>input
On Thu, Nov 14, 2013 at 3:10 PM, Michael Grzeschik wrote:
> So, what I see is an regular Hub that usually got driven by an external
> Crystal of 24MHz. That the boarddesigner did change that to be driven
> by the SoC clock makes your dependency here. We need an location for this,
> but obviously
On Thu, 14 Nov 2013, Ulf Hansson wrote:
> > Bear in mind that drivers _cannot_ rely on runtime PM to inactivate a
> > device during system suspend. The user can always prevent a device
> > from going into runtime suspend by writing "on" to the
> > /sys/.../power/control file.
>
> Good that you b
On Thu, 14 Nov 2013 oli...@neukum.org wrote:
> From: Oliver Neukum
>
> To allow a full switch to dynamic debugging make the
> debug parameter conditional on defined(DEBUF) || defined(DYNAMIC_DEBUG)
>
> Signed-off-by: Oliver Neukum
> ---
> drivers/usb/host/uhci-hcd.c | 48
> ++
On Thu, 14 Nov 2013 oli...@neukum.org wrote:
> From: Oliver Neukum
>
> It has become unnecessary by #define trickery
>
> Signed-off-by: Oliver Neukum
> ---
> drivers/usb/host/uhci-hcd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/u
I'd prefer this was kept separated out a little bit, as follows:
On Sun, Nov 10, 2013 at 1:18 AM, Alexander Shiyan wrote:
> This adds i.MX51 as the next user of the usbmisc driver.
> Since the functional is similar i.MX53, we just rename the
> definitions and add an alias for the new CPU.
>
> Sig
On Thu, 2013-11-14 at 11:44 -0500, Alan Stern wrote:
> On Thu, 14 Nov 2013 oli...@neukum.org wrote:
>
> > From: Oliver Neukum
> >
> > Conditional compilation for debugging is removed in favor of
> > dynamic debugging. To do so
> >
> > 1. the support for debugfs is always compiled
> > 2. the sup
On Thu, 2013-11-14 at 11:54 -0500, Alan Stern wrote:
> On Thu, 14 Nov 2013 oli...@neukum.org wrote:
>
> > From: Oliver Neukum
> >
> > Rewrite it so that the status is evaluated only if the
> > printk is actually executed.
> >
> > Signed-off-by: Oliver Neukum
>
> How come you don't make the sa
On Thu, 2013-11-14 at 11:59 -0500, Alan Stern wrote:
> On Thu, 14 Nov 2013 oli...@neukum.org wrote:
>
> > From: Oliver Neukum
> >
> > With the new dbg_status() the interrupt handler doesn't need
> > conditional compilation
> >
> > Signed-off-by: Oliver Neukum
> > ---
> > drivers/usb/host/ehci
On Thu, 2013-11-14 at 13:05 -0500, Alan Stern wrote:
> On Thu, 14 Nov 2013 oli...@neukum.org wrote:
>
> > From: Oliver Neukum
> >
> > It has become unnecessary by #define trickery
> >
> > Signed-off-by: Oliver Neukum
> > ---
> > drivers/usb/host/uhci-hcd.c | 2 --
> > 1 file changed, 2 deleti
On Thu, 2013-11-14 at 11:44 -0500, Alan Stern wrote:
> On Thu, 14 Nov 2013 oli...@neukum.org wrote:
>
> > From: Oliver Neukum
> >
> > With dynamic debugging the selection is done in user space
> >
> > Signed-off-by: Oliver Neukum
> > ---
> > drivers/usb/host/ohci-hub.c | 5 +
> > 1 file c
On Thu, 2013-11-14 at 13:04 -0500, Alan Stern wrote:
> On Thu, 14 Nov 2013 oli...@neukum.org wrote:
>
> > From: Oliver Neukum
> >
> > To allow a full switch to dynamic debugging make the
> > debug parameter conditional on defined(DEBUF) || defined(DYNAMIC_DEBUG)
> >
> > Signed-off-by: Oliver Ne
On Thu, 2013-11-14 at 11:49 -0500, Alan Stern wrote:
> On Thu, 14 Nov 2013 oli...@neukum.org wrote:
>
> > From: Oliver Neukum
> >
> > The decision about what is interesting is done in user space
> > when dynamic debugging is used.
> >
> > Signed-off-by: Oliver Neukum
> > ---
> > drivers/usb/h
* Chen Gang [131023 02:57]:
> When CONFIG_NOP_USB_XCEIV is as 'm', usb_nop_xceiv_register() will be
> exported when the related module is loaded. So for built-in source
> code, still need use the empty one.
>
> Or it will can not pass compiling, the related error (for arm, with
> allmodconfig):
On Mon, Nov 11, 2013 at 12:26:54PM -, David Laight wrote:
>
> Section 4.11.7.1 of rev 1.0 of the xhci specification states that a link TRB
> can only occur at a boundary between underlying USB frames (512 bytes for
> 480M).
>
> If this isn't done the USB frames aren't formatted correctly and
On Thu, 14 Nov 2013, Oliver Neukum wrote:
> On Thu, 2013-11-14 at 11:59 -0500, Alan Stern wrote:
> > On Thu, 14 Nov 2013 oli...@neukum.org wrote:
> >
> > > From: Oliver Neukum
> > >
> > > With the new dbg_status() the interrupt handler doesn't need
> > > conditional compilation
> > >
> > > Sig
On Thu, 14 Nov 2013, Oliver Neukum wrote:
> On Thu, 2013-11-14 at 11:54 -0500, Alan Stern wrote:
> > On Thu, 14 Nov 2013 oli...@neukum.org wrote:
> >
> > > From: Oliver Neukum
> > >
> > > Rewrite it so that the status is evaluated only if the
> > > printk is actually executed.
> > >
> > > Sign
Hi Xenia,
Sorry for the really late review on this.
On Mon, Aug 26, 2013 at 11:29:49PM +0300, Xenia Ragiadakou wrote:
> This patch removes the to_pci_dev() conversion performed to generic struct
> device since it is not actually useful (the pointer to the generic device
> can be used directly rat
On Thu, Nov 14, 2013 at 12:31:16PM -0800, Sarah Sharp wrote:
> Hi Xenia,
>
> Sorry for the really late review on this.
>
> On Mon, Aug 26, 2013 at 11:29:49PM +0300, Xenia Ragiadakou wrote:
> > This patch removes the to_pci_dev() conversion performed to generic struct
> > device since it is not ac
Hi Xenia,
This patch doesn't apply any more either, could you resend when you have
time?
Thanks,
Sarah Sharp
On Mon, Sep 09, 2013 at 09:03:08PM +0300, Xenia Ragiadakou wrote:
> The field 'dev_info' in struct xhci_slot_ctx has type __le32 and it needs
> to be converted to CPU byteorder for the co
On 11/14/2013 10:52 PM, Sarah Sharp wrote:
Hi Xenia,
This patch doesn't apply any more either, could you resend when you have
time?
Thanks,
Sarah Sharp
Yes, sure! Do you want me to resend all the patch series or just the
individual patches?
regards,
ksenia
On Mon, Sep 09, 2013 at 09:03:
Applied to for-usb-next-queue. I'll rebase it against Greg's usb-next
branch once 3.13-rc1 is out, and send it off for inclusion for 3.14.
Sarah Sharp
On Mon, Aug 26, 2013 at 11:29:46PM +0300, Xenia Ragiadakou wrote:
> This patch replaces USB_MAXINTERFACES with config->desc.bNumInterface in
> th
Applied to for-usb-next-queue for 3.14.
Sarah Sharp
On Mon, Aug 26, 2013 at 11:29:47PM +0300, Xenia Ragiadakou wrote:
> SCT_FOR_CTX(p) is defined as (((p) << 1) & 0x7) in which case if we want
> to set the stream context type to SCT_SSA_256 i.e 0x7 (although secondary
> stream arrays are not yet
Applied to for-usb-next-queue for 3.14.
Sarah Sharp
On Mon, Aug 26, 2013 at 11:29:48PM +0300, Xenia Ragiadakou wrote:
> This patch removes the unneccessary check 'if (stream_info)' because
> there is already a check few lines above which ensures that stream_info
> is not NULL.
>
> Signed-off-by:
Applied to for-usb-next-queue for 3.14.
Sarah Sharp
On Mon, Sep 09, 2013 at 09:03:06PM +0300, Xenia Ragiadakou wrote:
> The fields 'add_flags' and 'drop_flags' in struct xhci_input_control_ctx
> have type __le32 and need to be converted to CPU byteorder before being
> used to derive the number of
On Thu, Nov 14, 2013 at 11:04:14PM +0200, Xenia Ragiadakou wrote:
> On 11/14/2013 10:52 PM, Sarah Sharp wrote:
> >Hi Xenia,
> >
> >This patch doesn't apply any more either, could you resend when you have
> >time?
> >
> >Thanks,
> >Sarah Sharp
>
> Yes, sure! Do you want me to resend all the patch s
1 - 100 of 128 matches
Mail list logo
