On Thu, 14 Nov 2013 oli...@neukum.org wrote: > From: Oliver Neukum <oneu...@suse.de> > > With dynamic debugging the selection is done in user space > > Signed-off-by: Oliver Neukum <oneu...@suse.de> > --- > drivers/usb/host/ohci-hub.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/usb/host/ohci-hub.c b/drivers/usb/host/ohci-hub.c > index 61705a7..953821e 100644 > --- a/drivers/usb/host/ohci-hub.c > +++ b/drivers/usb/host/ohci-hub.c > @@ -725,10 +725,7 @@ static int ohci_hub_control ( > temp = roothub_portstatus (ohci, wIndex); > put_unaligned_le32(temp, buf); > > -#ifndef OHCI_VERBOSE_DEBUG > - if (*(u16*)(buf+2)) /* only if wPortChange is interesting */ > -#endif > - dbg_port (ohci, "GetStatus", wIndex, temp); > + dbg_port(ohci, "GetStatus", wIndex, temp); > break;
I think it would be better to keep the "if" statement always. We don't care about port status checks when there hasn't been any status change. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
