On Thu, 14 Nov 2013, Oliver Neukum wrote: > On Thu, 2013-11-14 at 11:54 -0500, Alan Stern wrote: > > On Thu, 14 Nov 2013 oli...@neukum.org wrote: > > > > > From: Oliver Neukum <oneu...@suse.de> > > > > > > Rewrite it so that the status is evaluated only if the > > > printk is actually executed. > > > > > > Signed-off-by: Oliver Neukum <oneu...@suse.de> > > > > How come you don't make the same change to dbg_intr_buf and > > dbg_command_buf? > > They are not used from interrupt.
True. However, for the sake of consistency, the three routines should resemble each other. On the other hand, once you eliminate the VERBOSE_DEBUG stuff from ehci_irq(), dbg_status_buf won't be used in interrupt either. So maybe you'd prefer to skip this change entirely. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
