Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Lothar Waßmann
Hi, Peter Chen wrote: > This commit adds runtime and system power management support for > chipidea core. The runtime pm support is controlled by glue > layer, it can be enabled by flag CI_HDRC_SUPPORTS_RUNTIME_PM. > [...] > +#ifdef CONFIG_PM > +static int ci_controller_suspend(struct device *dev

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Peter Chen
On Mon, Oct 14, 2013 at 10:04:58AM +0200, Lothar Waßmann wrote: > Hi, > > Peter Chen wrote: > > This commit adds runtime and system power management support for > > chipidea core. The runtime pm support is controlled by glue > > layer, it can be enabled by flag CI_HDRC_SUPPORTS_RUNTIME_PM. > > >

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Sascha Hauer
On Mon, Oct 14, 2013 at 03:55:48PM +0800, Peter Chen wrote: > On Mon, Oct 14, 2013 at 10:04:58AM +0200, Lothar Waßmann wrote: > > Hi, > > > > Peter Chen wrote: > > > This commit adds runtime and system power management support for > > > chipidea core. The runtime pm support is controlled by glue >

Re: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

2013-10-14 Thread Shawn Guo
On Sat, Oct 12, 2013 at 05:09:36PM +0800, Peter Chen wrote: > After adding IC fixes bits, some PHY bugs are fixed by > IC logic. > > Signed-off-by: Peter Chen > --- > drivers/usb/phy/phy-mxs-usb.c | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/drivers/us

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Peter Chen
On Mon, Oct 14, 2013 at 10:42:16AM +0200, Sascha Hauer wrote: > On Mon, Oct 14, 2013 at 03:55:48PM +0800, Peter Chen wrote: > > On Mon, Oct 14, 2013 at 10:04:58AM +0200, Lothar Waßmann wrote: > > > Hi, > > > > > > Peter Chen wrote: > > > > This commit adds runtime and system power management suppo

Re: [PATCH 1/1] ARM: dts: omap3: Adapt USB OTG to generic PHY framework

2013-10-14 Thread Roger Quadros
Hi Benoit, On 10/10/2013 06:34 PM, Felipe Balbi wrote: > On Mon, Oct 07, 2013 at 04:28:13PM +0300, Roger Quadros wrote: >> The generic PHY framewrok expects different properties than the >> old USB PHY framework. Supply those properties. >> >> Fixes USB OTG port on GAT04 and N900 after the Generic

Re: [PATCH 3/7] drivers: phy: usb3/pipe3: Adapt pipe3 driver to Generic PHY Framework

2013-10-14 Thread Kishon Vijay Abraham I
Hi Roger, On Friday 11 October 2013 08:32 PM, Roger Quadros wrote: > On 09/16/2013 10:37 AM, Roger Quadros wrote: >> On 09/16/2013 06:01 AM, Kishon Vijay Abraham I wrote: >>> On Thursday 12 September 2013 04:49 PM, Roger Quadros wrote: Hi Kishon, On 09/02/2013 06:43 PM, Kishon Vijay

[PATCH 2/2] usb/gadget: storage_common: pass filesem to fsg_store_cdrom

2013-10-14 Thread Andrzej Pietrasiewicz
If cdrom flag is set ro flag is implied. Try setting the ro first, and only if it succeeds set the cdrom flag. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_mass_storage.c |7 - drivers/usb/gadget/storage_common.c | 44 +

Re: [PATCH 09/12] usb: phy-mxs: update binding for adding anatop phandle

2013-10-14 Thread Shawn Guo
On Sat, Oct 12, 2013 at 05:09:43PM +0800, Peter Chen wrote: > Add anatop phandle which is used to access anatop registers to > control PHY's power and other USB operations. > > Signed-off-by: Peter Chen > --- > Documentation/devicetree/bindings/usb/mxs-phy.txt |2 ++ > 1 files changed, 2 ins

[PATCH 0/2] Fixes for mass_storage

2013-10-14 Thread Andrzej Pietrasiewicz
A short series to fix 2 issues: - use strtobool instead of kstrtouint with base 2 for: ro, nofua, cdrom, removable attrs (better fits the context and more flexible to users) - setting a lun to be cdrom implies read-only and succeeds only if the lun is not open Andrzej Pietrasiewicz (2): usb/g

[PATCH 1/2] usb/gadget: storage_common: use strtobool instead of kstrtouint

2013-10-14 Thread Andrzej Pietrasiewicz
strtobool is more flexible for the user and is more appropriate in the context. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/storage_common.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/usb/gadget/st

Re: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

2013-10-14 Thread Peter Chen
On Mon, Oct 14, 2013 at 05:09:55PM +0800, Shawn Guo wrote: > On Sat, Oct 12, 2013 at 05:09:36PM +0800, Peter Chen wrote: > > After adding IC fixes bits, some PHY bugs are fixed by > > IC logic. > > > > Signed-off-by: Peter Chen > > --- > > drivers/usb/phy/phy-mxs-usb.c | 10 ++ > > 1 f

Re: [PATCH 09/12] usb: phy-mxs: update binding for adding anatop phandle

2013-10-14 Thread Peter Chen
On Mon, Oct 14, 2013 at 05:22:07PM +0800, Shawn Guo wrote: > On Sat, Oct 12, 2013 at 05:09:43PM +0800, Peter Chen wrote: > > Add anatop phandle which is used to access anatop registers to > > control PHY's power and other USB operations. > > > > Signed-off-by: Peter Chen > > --- > > Documentatio

Re: [PATCH 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2013-10-14 Thread Kishon Vijay Abraham I
Hi Roger, On Friday 11 October 2013 08:39 PM, Roger Quadros wrote: > Hi, > > On 09/02/2013 06:43 PM, Kishon Vijay Abraham I wrote: >> Adapted dwc3 core to use the Generic PHY Framework. So for init, exit, >> power_on and power_off the following APIs are used phy_init(), phy_exit(), >> phy_power_o

Re: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

2013-10-14 Thread Shawn Guo
On Mon, Oct 14, 2013 at 05:09:56PM +0800, Peter Chen wrote: > Oh, sorry. I forget to put below one to this serial. > Will do at v2 > > http://marc.info/?l=linux-usb&m=137871552016298&w=2 Remember to document the new compatible strings in bindings doc. Shawn -- To unsubscribe from this list: sen

Re: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

2013-10-14 Thread Peter Chen
On Mon, Oct 14, 2013 at 05:29:21PM +0800, Shawn Guo wrote: > On Mon, Oct 14, 2013 at 05:09:56PM +0800, Peter Chen wrote: > > Oh, sorry. I forget to put below one to this serial. > > Will do at v2 > > > > http://marc.info/?l=linux-usb&m=137871552016298&w=2 > > Remember to document the new compatib

Re: [PATCH 3/7] drivers: phy: usb3/pipe3: Adapt pipe3 driver to Generic PHY Framework

2013-10-14 Thread Roger Quadros
Kishon, On 10/14/2013 12:19 PM, Kishon Vijay Abraham I wrote: > Hi Roger, > > On Friday 11 October 2013 08:32 PM, Roger Quadros wrote: >> On 09/16/2013 10:37 AM, Roger Quadros wrote: >>> On 09/16/2013 06:01 AM, Kishon Vijay Abraham I wrote: On Thursday 12 September 2013 04:49 PM, Roger Quadr

Re: [PATCH 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2013-10-14 Thread Roger Quadros
+Vivek On 10/14/2013 12:26 PM, Kishon Vijay Abraham I wrote: > Hi Roger, > > On Friday 11 October 2013 08:39 PM, Roger Quadros wrote: >> Hi, >> >> On 09/02/2013 06:43 PM, Kishon Vijay Abraham I wrote: >>> Adapted dwc3 core to use the Generic PHY Framework. So for init, exit, >>> power_on and powe

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Sascha Hauer
On Mon, Oct 14, 2013 at 05:04:21PM +0800, Peter Chen wrote: > On Mon, Oct 14, 2013 at 10:42:16AM +0200, Sascha Hauer wrote: > > On Mon, Oct 14, 2013 at 03:55:48PM +0800, Peter Chen wrote: > > > On Mon, Oct 14, 2013 at 10:04:58AM +0200, Lothar Waßmann wrote: > > > > Hi, > > > > > > > > Peter Chen w

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Russell King - ARM Linux
On Mon, Oct 14, 2013 at 03:55:48PM +0800, Peter Chen wrote: > On Mon, Oct 14, 2013 at 10:04:58AM +0200, Lothar Waßmann wrote: > > Hi, > > > > Peter Chen wrote: > > > This commit adds runtime and system power management support for > > > chipidea core. The runtime pm support is controlled by glue >

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Russell King - ARM Linux
On Mon, Oct 14, 2013 at 05:04:21PM +0800, Peter Chen wrote: > It is for ARM, but for other platforms, it may not. Wrong. atomic_read() and atomic_set() are defined the same way and have the same lack of atomicity across all architectures. There is nothing special about these over a standard load

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Russell King - ARM Linux
On Sat, Oct 12, 2013 at 05:35:03PM +0800, Peter Chen wrote: > This commit adds runtime and system power management support for > chipidea core. The runtime pm support is controlled by glue > layer, it can be enabled by flag CI_HDRC_SUPPORTS_RUNTIME_PM. Let's look at the locking. 1. Runtime PM. T

Re: Warning when calling radix_tree_insert on 3.12-rc4

2013-10-14 Thread Jan Kara
Hello Sarah, On Fri 11-10-13 15:13:15, Sarah Sharp wrote: > I'm testing out some changes to the xHCI USB host controller driver > (which uses a radix tree when a UAS device is attached to the host), and > I noticed the following warning: > > Oct 11 14:42:08 xanatos kernel: [18165.819014] usb 2-

[PATCH] usb: phy: omap: Add omap-control Support for AM437x

2013-10-14 Thread George Cherian
This adds omap control module support for USBSS in AM437x SoC. Update DT binding information to reflect these changes. Signed-off-by: George Cherian --- Documentation/devicetree/bindings/usb/omap-usb.txt | 2 ++ drivers/usb/phy/phy-omap-control.c | 17 + include/

Re: [PATCH] usb: phy: omap: Add omap-control Support for AM437x

2013-10-14 Thread Roger Quadros
Hi George, On 10/14/2013 03:51 PM, George Cherian wrote: > This adds omap control module support for USBSS in AM437x SoC. > Update DT binding information to reflect these changes. > > Signed-off-by: George Cherian > --- > Documentation/devicetree/bindings/usb/omap-usb.txt | 2 ++ > drivers/usb

[PATCH] usb-storage: add quirk for mandatory READ_CAPACITY_16

2013-10-14 Thread oliver
From: Oliver Neukum Some USB drive enclosures do not correctly report an overflow condition if they hold a drive with a capacity over 2TB and are confronted with a READ_CAPACITY_10. They answer with their capacity modulo 2TB. The generic layer cannot cope with that. It must be told to use READ_CA

[PATCH 0/3] usb: musb bugfixes

2013-10-14 Thread Markus Pargmann
Hi, the series contains two bugfixes and some debugfs file operations for dsps similar to the musb core regdump debugfs file. Regards, Markus Pargmann Markus Pargmann (3): usb: musb: Handle nullpointer usb: musb: Bugfix of_node assignment usb: musb: dsps, debugfs files driv

[PATCH 2/3] usb: musb: Bugfix of_node assignment

2013-10-14 Thread Markus Pargmann
It is not safe to assign the of_node to a device without driver. The device is matched against a list of drivers and the of_node could lead to a DT match with the parent driver. Signed-off-by: Markus Pargmann --- drivers/usb/musb/musb_core.c | 12 +++- drivers/usb/musb/musb_dsps.c | 1 -

[PATCH 3/3] usb: musb: dsps, debugfs files

2013-10-14 Thread Markus Pargmann
debugfs files to show the contents of important dsps registers. Signed-off-by: Markus Pargmann --- drivers/usb/musb/musb_dsps.c | 89 1 file changed, 89 insertions(+) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 189e

[PATCH 1/3] usb: musb: Handle nullpointer

2013-10-14 Thread Markus Pargmann
When the device is connected to a host without a gadget driver, otg->gadget is NULL. Signed-off-by: Markus Pargmann --- drivers/usb/musb/musb_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 18e877f..ba

[RFC] usb: musb: dsps, OTG detection

2013-10-14 Thread Markus Pargmann
The USB Controller does not support ID pin change interrupts. So we have to use a polling function to detect changes of A/B device state (otg_timer). This poll function has to check in several states if a other device type might be connected to the USB port. This check is triggered by manually star

[PATCH v2 1/3] usb: musb: Handle nullpointer

2013-10-14 Thread Markus Pargmann
When the device is connected to a host without a gadget driver, otg->gadget is NULL. Signed-off-by: Markus Pargmann --- drivers/usb/musb/musb_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 18e877f..ba

[PATCH v2 0/3] usb: musb bugfixes

2013-10-14 Thread Markus Pargmann
Hi, the series contains two bugfixes and some debugfs file operations for dsps similar to the musb core regdump debugfs file. v2 removes the dev_info() in patch 3 in dsps_musb_init. Regards, Markus Pargmann Markus Pargmann (3): usb: musb: Handle nullpointer usb: musb: Bugfix of_n

[PATCH v2 2/3] usb: musb: Bugfix of_node assignment

2013-10-14 Thread Markus Pargmann
It is not safe to assign the of_node to a device without driver. The device is matched against a list of drivers and the of_node could lead to a DT match with the parent driver. Signed-off-by: Markus Pargmann --- drivers/usb/musb/musb_core.c | 12 +++- drivers/usb/musb/musb_dsps.c | 1 -

[PATCH v2 3/3] usb: musb: dsps, debugfs files

2013-10-14 Thread Markus Pargmann
debugfs files to show the contents of important dsps registers. Signed-off-by: Markus Pargmann --- drivers/usb/musb/musb_dsps.c | 87 1 file changed, 87 insertions(+) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 189e

Re: [RFC] usb: musb: dsps, OTG detection

2013-10-14 Thread Bin Liu
On Mon, Oct 14, 2013 at 8:35 AM, Markus Pargmann wrote: > The USB Controller does not support ID pin change interrupts. So we have > to use a polling function to detect changes of A/B device state > (otg_timer). This poll function has to check in several states if a > other device type might be co

[PATCH] quirks.c: add one device that cannot deal with suspension

2013-10-14 Thread oliver
From: Oliver Neukum The device is not responsive when resumed, unless it is reset. Signed-off-by: Oliver Neukum CC: sta...@vger.kernel.org --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 5b44cd4..b

Re: [RFC] usb: musb: dsps, OTG detection

2013-10-14 Thread Markus Pargmann
Hi, On Mon, Oct 14, 2013 at 08:54:09AM -0500, Bin Liu wrote: > On Mon, Oct 14, 2013 at 8:35 AM, Markus Pargmann wrote: > > The USB Controller does not support ID pin change interrupts. So we have > > to use a polling function to detect changes of A/B device state > > (otg_timer). This poll functi

[PATCH v3 01/13] usb: phy: msm: Move mach depndend code to platform data

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This patch fix compilation error and is an intermediate step before the addition of DeviceTree support for newer targets. Cc: David Brown Cc: Daniel Walker Cc: Felipe Balbi Cc: Greg Kroah-Hartman Signed-off-by: Ivan T. Ivanov --- arch/arm/mach-msm/board-msm7x30.c |

[PATCH v3 04/13] usb: phy: msm: Remove unnecessarily check for valid regulators.

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Whether regulators are available or not is checked at driver probe. If they are not available driver will refuse to load, so no need to check them again. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 10 -- 1 file changed, 10 deletions(-) d

[PATCH v3 09/13] usb: phy: msm: Remove unused pclk_src_name

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" There are no references to 'pclk_src_name' in plaform code, so it is unused. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 26 +- include/linux/usb/msm_hsusb.h |5 - 2 files changed, 1 insertion(+), 30 deletions(-) d

[PATCH v3 11/13] usb: phy: msm: Remove HSUSB prefix from requlator names

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Prefix did not bring any useful information. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 0bd3ba5..ca2abe6

[PATCH v3 12/13] usb: phy: msm: Properly check core interrupt number

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" IRQ with number 0 is valid case, so check for negative numbers instead. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c in

[PATCH v3 10/13] usb: phy: msm: Switch clock consumer strings

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Replace the USB specific clock names in driver with the more standard 'core' and 'iface' ... names. Cc: David Brown Cc: Stephen Boyd Signed-off-by: Ivan T. Ivanov --- arch/arm/mach-msm/devices-msm7x00.c |4 +- arch/arm/mach-msm/devices-msm7x30.c |8 ++-- arch/a

[PATCH v3 08/13] usb: phy: msm: Drop default usb_dr_mode from platform data.

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" USB DT bindings states: "...In case this attribute isn't passed via DT, USB DRD controllers should default to OTG...", so remove redundand field. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |7 --- include/linux/usb/msm_hsusb.h |3 --- 2 f

[PATCH v3 06/13] usb: phy: msm: Fix WARNING: Prefer seq_puts to seq_printf

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes checkpatch.pl warnings. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 28cab03..46800c0 100644 ---

[PATCH v3 03/13] usb: phy: msm: Migrate to Managed Device Resource allocation

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Move memory, regulators, clocks and irq allocation to devm_* variants. Properly check for valid clk handles. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 192 - 1 file changed, 74 insertions(+), 118 deletions(

[PATCH v3 07/13] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- arch/arm/mach-msm/board-msm7x30.c |2 +- arch/arm/mach-msm/board-qsd8x50.c |2 +- drivers/usb/phy/phy-msm-usb.c | 40 ++--- include/linux/usb/msm_hsusb.h | 19 ++ 4 files

[PATCH v3 05/13] usb: phy: msm: Fix WARNING: quoted string split across lines

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes checkpatch.pl warnings. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 33 +++-- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c inde

[PATCH v3 00/13] usb: phy: msm: Fixes, cleanups and DT support

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, This is third version of MSM OTG clean up patches. v3 -- * In patch 1 - functions for reseting PHY and LINK controller just call platform code if available. * New stuff is: cleaning up unneeded/unused driver state variables * Simplified regulator names. There is n

[PATCH v3 13/13] usb: phy: msm: Add device tree support and binding information

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allows MSM OTG controller to be specified via device tree. Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-hsusb.txt | 58 +++ drivers/usb/phy/phy-msm-usb.c | 59 ++-- 2 files changed, 11

Re: USB regression in v3.12-rc4

2013-10-14 Thread Greg Kroah-Hartman
On Sun, Oct 13, 2013 at 12:46:18AM +0300, Aaro Koskinen wrote: > Hi, > > With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB > (peripheral, g_ether). > > According to git bisect this is caused by: > > 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61 is the first bad commit > commit 9b0a1de3c

[PATCH v3 02/13] usb: phy: msm: Move global regulators variables to driver state

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 82 - include/linux/usb/msm_hsusb.h |3 ++ 2 files changed, 42 insertions(+), 43 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-

usb_control_msg and non-dma buffers

2013-10-14 Thread Guenter Roeck
Hi all, I am getting the following smatch error in drivers/watchdog/pcwd_usb.c: drivers/watchdog/pcwd_usb.c:257 usb_pcwd_send_command() error: doing dma on the stack (buf) This is from a call to usb_control_msg(). Is this a false positive or a real problem that needs to be fixed ? Thanks, Gu

Re: [PATCH 05/11] USB: OHCI: Properly handle ohci-ep93xx suspend

2013-10-14 Thread Olof Johansson
Hi, Greg, [Adding ep93xx maintainers as well] On Wed, Oct 2, 2013 at 3:15 AM, Majunath Goudar wrote: > From: Manjunath Goudar > > Suspend scenario in case of ohci-ep93xx glue was not > properly handled as it was not suspending generic part > of ohci controller. Alan Stern suggested, properly ha

Re: usb_control_msg and non-dma buffers

2013-10-14 Thread Greg Kroah-Hartman
On Mon, Oct 14, 2013 at 08:47:36AM -0700, Guenter Roeck wrote: > Hi all, > > I am getting the following smatch error in drivers/watchdog/pcwd_usb.c: > > drivers/watchdog/pcwd_usb.c:257 usb_pcwd_send_command() error: doing dma on > the stack (buf) > > This is from a call to usb_control_msg(). >

Re: [PATCH] USB: cdc-acm: put delayed_wb to list

2013-10-14 Thread Greg KH
On Tue, Oct 08, 2013 at 05:08:48PM +0800, Xiao Jin wrote: > > From: xiao jin > > If acm_write_start during acm suspend, write acm_wb is backuped > to delayed_wb. When acm resume, the delayed_wb will be started. > This mechanism can only record one write during acm suspend. More > acm write will

Re: [PATCH 1/1] drivers: usb: core: devio.c: Coding style fixes

2013-10-14 Thread Greg KH
On Sat, Oct 12, 2013 at 01:01:34PM +0200, Matthias Beyer wrote: > Whitespace fixes, including: > > - Whitespace after if-keyword > - Spaces to Tabs > > Other coding style fixes: > > - Added braces for if-else blocks where missing When doing coding style cleanups, please only do one thing per pa

Re: [PATCH 1/1] drivers: usb: core: devio.c: Braces around switch (updated)

2013-10-14 Thread Greg KH
On Sat, Oct 12, 2013 at 01:05:35PM +0200, Matthias Beyer wrote: > Added braces around switch statement as the styleguide tells us. > Indented the switch-block for it and split a function call > (driver->unlocked_ioctl() on line 1876) arguments to several lines to > fit the 80-column convention. Th

Re: Warning when calling radix_tree_insert on 3.12-rc4

2013-10-14 Thread Sarah Sharp
On Mon, Oct 14, 2013 at 02:30:34PM +0200, Jan Kara wrote: > Hello Sarah, > > On Fri 11-10-13 15:13:15, Sarah Sharp wrote: > > I'm testing out some changes to the xHCI USB host controller driver > > (which uses a radix tree when a UAS device is attached to the host), and > > I noticed the followi

Re: When USB PHY framework should be used?

2013-10-14 Thread Arokux X
Dear Kishon, On Sat, Oct 12, 2013 at 12:07 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 11 October 2013 10:52 PM, Arokux X wrote: >>> I think you should have a wrapper driver to EHCI/OHCI to handle this reset. >> >> Thank you Kishon and Peter for the quick replies. Is there any good >> e

cuenta Advertencia.

2013-10-14 Thread HELP DESK
Su contraseña caducará en 3 días formulario llenar y enviar de inmediato para validar su dirección de e-mail. Nombre de Usuario: . Contraseña anterior: . Nueva Contraseña: gracias administrador del sistema -- To unsubscribe from this list: send the

Re: Warning when calling radix_tree_insert on 3.12-rc4

2013-10-14 Thread Jan Kara
On Mon 14-10-13 11:17:21, Sarah Sharp wrote: > On Mon, Oct 14, 2013 at 02:30:34PM +0200, Jan Kara wrote: > > Hello Sarah, > > > > On Fri 11-10-13 15:13:15, Sarah Sharp wrote: > > > I'm testing out some changes to the xHCI USB host controller driver > > > (which uses a radix tree when a UAS devic

cuenta Advertencia.

2013-10-14 Thread Postmaster
Su contraseña caducará en 3 días formulario llenar y enviar de inmediato para validar su dirección de e-mail. Nombre de Usuario: . Contraseña anterior: . Nueva Contraseña: gracias administrador del sistema -- To unsubscribe from this list: send the

Re: USB regression in v3.12-rc4

2013-10-14 Thread Felipe Balbi
Hi, On Mon, Oct 14, 2013 at 08:33:56AM -0700, Greg Kroah-Hartman wrote: > On Sun, Oct 13, 2013 at 12:46:18AM +0300, Aaro Koskinen wrote: > > Hi, > > > > With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB > > (peripheral, g_ether). > > > > According to git bisect this is caused by: >

[PATCH v2 2/5] drivers: usb: core: devio.c: Spaces to tabs for proc_control_compat()

2013-10-14 Thread Matthias Beyer
Replaced spaces by tabs for proc_control_compat() function. Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 6a2e567..d15aa51 100644 ---

[PATCH v2 5/5] drivers: usb: core: devio.c: Put arguments on new line

2013-10-14 Thread Matthias Beyer
To fit the 80-cols convention, this patch moves the arguments (the second and third one) for driver->unlocked_ioctl() onto a new line. Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/devio.c b/drive

[PATCH v2 3/5] drivers: usb: core: devio.c: Braces around if-elseif-else

2013-10-14 Thread Matthias Beyer
This patch applies the rules for braces to the if-elseif-else statement in proc_ioctl(). As the kernel styleguide says: If there is at least one multiline block in a if-else branching, we should add braces around all blocks. This includes braces around the switch-statement on the else branch, whic

[PATCH v2 4/5] drivers: usb: core: devio.c: Reindented switch-block

2013-10-14 Thread Matthias Beyer
Reindented the switch-block. Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 56 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index dd8701b..9761a27 100644 --- a/d

Re: [PATCH] usb/hcd: remove unnecessary local_irq_save

2013-10-14 Thread Alan Stern
On Mon, 14 Oct 2013, Michael Opdenacker wrote: > Hi Alan, > > On 10/13/2013 05:35 PM, Alan Stern wrote: > > On Sun, 13 Oct 2013, Michael Opdenacker wrote: > > > >> Remove the use of local_irq_save() and IRQF_DISABLED, no longer needed > >> since > >> interrupt handlers are always run with interr

[PATCH v2 0/5] Coding style fixes

2013-10-14 Thread Matthias Beyer
Actually this is the third reroll of this patchseries, but I just figured out how to place this "v2" thing in the patches... sorry for that! As Greg KH requested: I splitted the coding style fixes into several patches. The replacing of spaces by tabs in proc_reapurbnonblock() and proc_control_co

[PATCH v2 1/5] drivers: usb: core: devio.c: Spaces to tabs for proc_reapurbnonblock()

2013-10-14 Thread Matthias Beyer
Replaced spaces by tabs for proc_reapurbnonblock() function. Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 71dc5d7..6a2e567 100644 --- a/drivers

Re: USB regression in v3.12-rc4

2013-10-14 Thread Greg Kroah-Hartman
On Mon, Oct 14, 2013 at 02:05:39PM -0500, Felipe Balbi wrote: > Hi, > > On Mon, Oct 14, 2013 at 08:33:56AM -0700, Greg Kroah-Hartman wrote: > > On Sun, Oct 13, 2013 at 12:46:18AM +0300, Aaro Koskinen wrote: > > > Hi, > > > > > > With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB > >

Re: Linux USB file storage gadget with new UDC

2013-10-14 Thread Alan Stern
On Mon, 14 Oct 2013, Victor Yeo wrote: > Hi, > > >> Victor, if you can get hold of a USB bus analyzer, you would be able to > >> see directly when the DATA1 packet does or does not get sent. > > > I am in the process of getting a USB bus analyzer. > > >> No -- the problem is that the UDC comple

Re: [PATCH 1/2] usb/gadget: storage_common: use strtobool instead of kstrtouint

2013-10-14 Thread Michal Nazarewicz
On Mon, Oct 14 2013, Andrzej Pietrasiewicz wrote: > strtobool is more flexible for the user and is more appropriate in the > context. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > diff --git a/drivers/usb/gadget/storage_common.c > b/driv

Re: [PATCH 05/11] USB: OHCI: Properly handle ohci-ep93xx suspend

2013-10-14 Thread Alan Stern
On Mon, 14 Oct 2013, Olof Johansson wrote: > Hi, Greg, > > [Adding ep93xx maintainers as well] > > On Wed, Oct 2, 2013 at 3:15 AM, Majunath Goudar > wrote: > > From: Manjunath Goudar > > > > Suspend scenario in case of ohci-ep93xx glue was not > > properly handled as it was not suspending gen

Re: [PATCH 05/11] USB: OHCI: Properly handle ohci-ep93xx suspend

2013-10-14 Thread Greg KH
On Mon, Oct 14, 2013 at 04:34:56PM -0400, Alan Stern wrote: > On Mon, 14 Oct 2013, Olof Johansson wrote: > > > Hi, Greg, > > > > [Adding ep93xx maintainers as well] > > > > On Wed, Oct 2, 2013 at 3:15 AM, Majunath Goudar > > wrote: > > > From: Manjunath Goudar > > > > > > Suspend scenario in

Re: [PATCH 2/2] usb/gadget: storage_common: pass filesem to fsg_store_cdrom

2013-10-14 Thread Michal Nazarewicz
On Mon, Oct 14 2013, Andrzej Pietrasiewicz wrote: > If cdrom flag is set ro flag is implied. Try setting the ro first, and > only if it succeeds set the cdrom flag. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > diff --git a/drivers/usb/ga

Re: [PATCH v6 14/14] usb/gadget: f_mass_storage: add configfs support

2013-10-14 Thread Michal Nazarewicz
On Wed, Oct 09 2013, Andrzej Pietrasiewicz wrote: > From this commit on f_mass_storage is available through configfs. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz Just tiny nit-picking to follow: > diff --git a/drivers/usb/gadget/f_mass_

Re: [RFC] usb: musb: dsps, OTG detection

2013-10-14 Thread Bin Liu
On Mon, Oct 14, 2013 at 10:22 AM, Markus Pargmann wrote: > Hi, > > On Mon, Oct 14, 2013 at 08:54:09AM -0500, Bin Liu wrote: >> On Mon, Oct 14, 2013 at 8:35 AM, Markus Pargmann wrote: >> > The USB Controller does not support ID pin change interrupts. So we have >> > to use a polling function to de

RE: [PATCH 05/11] USB: OHCI: Properly handle ohci-ep93xx suspend

2013-10-14 Thread Alan Stern
On Mon, 14 Oct 2013, Hartley Sweeten wrote: > Alan, > > As an alternative to this patch, I have successfully used the ohci-platform > driver on the ep93xx. This does move a bit of glue code into the ep93xx > core (arch/arm/mach-ep93xx/core.c) but it removes the ohci-ep93xx glue > driver completel

RE: [PATCH 05/11] USB: OHCI: Properly handle ohci-ep93xx suspend

2013-10-14 Thread Hartley Sweeten
On Monday, October 14, 2013 1:35 PM, Alan Stern wrote: > On Mon, 14 Oct 2013, Olof Johansson wrote: > >> Hi, Greg, >> >> [Adding ep93xx maintainers as well] >> >> On Wed, Oct 2, 2013 at 3:15 AM, Majunath Goudar >> wrote: >>> From: Manjunath Goudar >>> >>> Suspend scenario in case of ohci-ep93x

RE: [PATCH 05/11] USB: OHCI: Properly handle ohci-ep93xx suspend

2013-10-14 Thread Hartley Sweeten
On Monday, October 14, 2013 1:50 PM, Alan Stern wrote: > On Mon, 14 Oct 2013, Hartley Sweeten wrote: >> As an alternative to this patch, I have successfully used the ohci-platform >> driver on the ep93xx. This does move a bit of glue code into the ep93xx >> core (arch/arm/mach-ep93xx/core.c) but it

Re: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-14 Thread Ryan Mallon
On 15/10/13 08:35, H Hartley Sweeten wrote: > Convert ep93xx to use the OHCI platform driver and remove the > ohci-ep93xx bus glue driver. > > Signed-off-by: H Hartley Sweeten > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: Ryan Mallon > --- > diff --git a/drivers/usb/host/Kconfig b/drivers/u

RE: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-14 Thread Hartley Sweeten
On Monday, October 14, 2013 3:01 PM, Ryan Mallon wrote: > On 15/10/13 08:35, H Hartley Sweeten wrote: >> Convert ep93xx to use the OHCI platform driver and remove the >> ohci-ep93xx bus glue driver. >> >> Signed-off-by: H Hartley Sweeten >> Cc: Alan Stern >> Cc: Greg Kroah-Hartman >> Cc: Ryan M

Re: [PATCH 0/2] Fixes for mass_storage

2013-10-14 Thread Felipe Balbi
Hi, On Mon, Oct 14, 2013 at 11:21:45AM +0200, Andrzej Pietrasiewicz wrote: > A short series to fix 2 issues: > > - use strtobool instead of kstrtouint with base 2 for: ro, nofua, cdrom, > removable attrs > (better fits the context and more flexible to users) > - setting a lun to be cdrom implies

Re: [PATCH v2 1/3] usb: musb: Handle nullpointer

2013-10-14 Thread Felipe Balbi
On Mon, Oct 14, 2013 at 03:50:37PM +0200, Markus Pargmann wrote: > When the device is connected to a host without a gadget driver, > otg->gadget is NULL. > > Signed-off-by: Markus Pargmann > --- > drivers/usb/musb/musb_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --

Re: [PATCH v2 3/3] usb: musb: dsps, debugfs files

2013-10-14 Thread Felipe Balbi
Hi, On Mon, Oct 14, 2013 at 03:50:39PM +0200, Markus Pargmann wrote: > debugfs files to show the contents of important dsps registers. > > Signed-off-by: Markus Pargmann > --- > drivers/usb/musb/musb_dsps.c | 87 > > 1 file changed, 87 insertions(+)

Re: [PATCH v3 01/13] usb: phy: msm: Move mach depndend code to platform data

2013-10-14 Thread Felipe Balbi
Hi, On Mon, Oct 14, 2013 at 06:24:28PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > This patch fix compilation error and is an intermediate step > before the addition of DeviceTree support for newer targets. > > Cc: David Brown > Cc: Daniel Walker > Cc: Felipe Balbi > Cc: Greg K

Re: [PATCH v3 02/13] usb: phy: msm: Move global regulators variables to driver state

2013-10-14 Thread Felipe Balbi
On Mon, Oct 14, 2013 at 06:24:29PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > Signed-off-by: Ivan T. Ivanov this one looks good. -- balbi signature.asc Description: Digital signature

Re: [PATCH v3 12/13] usb: phy: msm: Properly check core interrupt number

2013-10-14 Thread Felipe Balbi
On Mon, Oct 14, 2013 at 06:24:39PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > IRQ with number 0 is valid case, so check for negative not entirelly correct... IRQ 0 isn't supposed to be used as a linux IRQ number IIRC. > numbers instead. > > Signed-off-by: Ivan T. Ivanov > --- >

Re: [PATCH v3] davinci: fix resources passed to MUSB driver for DM6467

2013-10-14 Thread Felipe Balbi
On Sat, Oct 12, 2013 at 12:15:17AM +0200, Sergei Shtylyov wrote: > Hello. > > On 23-09-2013 23:45, Felipe Balbi wrote: > > After commit 09fc7d22b024692b2fe8a943b246de1af307132b (usb: musb: fix > incorrect > usage of resource pointer), CPPI DMA driver on DaVinci DM6467 can't > d

Re: Need testers for long-standing xHCI clear halt bug

2013-10-14 Thread Sarah Sharp
On Sat, Oct 12, 2013 at 09:25:17AM +0200, Marcus Meissner wrote: > Hi Sarah, > > I built: > > - current kernel git with SUSE config > - libgphoto2 with the clear_halt reenabled > - rebooted > > gphoto2 now hangs on the second try > > - only applied both patches referenced. > I need to whac

[PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-14 Thread H Hartley Sweeten
Convert ep93xx to use the OHCI platform driver and remove the ohci-ep93xx bus glue driver. Signed-off-by: H Hartley Sweeten Cc: Alan Stern Cc: Greg Kroah-Hartman Cc: Ryan Mallon --- arch/arm/mach-ep93xx/clock.c | 2 +- arch/arm/mach-ep93xx/core.c| 45 +- drivers/usb/host/Kcon

[PATCH 2/5] xhci: Set L1 device slot on USB2 LPM enable/disable.

2013-10-14 Thread Sarah Sharp
To enable USB 2.0 Link Power Management (LPM), the xHCI host controller needs the device slot ID to generate the device address used in L1 entry tokens. That information is set in the L1 device slot ID field of the USB 2.0 LPM registers. Currently, the L1 device slot ID is overwritten when the xH

[PATCH 3/5] usb: Don't enable USB 2.0 Link PM by default.

2013-10-14 Thread Sarah Sharp
How it's supposed to work: -- USB 2.0 Link PM is a lower power state that some newer USB 2.0 devices support. USB 3.0 devices certified by the USB-IF are required to support it if they are plugged into a USB 2.0 only port, or a USB 2.0 cable is used. USB 2.0 Link PM requi

[PATCH 5/5] xhci: correct the usage of USB_CTRL_SET_TIMEOUT

2013-10-14 Thread Sarah Sharp
From: xiao jin The usage of USB_CTRL_SET_TIMEOUT in xhci is incorrect. The definition of USB_CTRL_SET_TIMEOUT is 5000ms. The input timeout to wait_for_completion_interruptible_timeout is jiffies. That makes the timeout be longer than what we want, such as 50s in some platform. The patch is to us

[PATCH 4/5] xhci: Enable LPM support only for hardwired or BESL devices

2013-10-14 Thread Sarah Sharp
From: Mathias Nyman Some usb3 devices falsely claim they support usb2 hardware Link PM when connected to a usb2 port. We only trust hardwired devices or devices with the later BESL LPM support to be LPM enabled as default. [Note: Sarah re-worked the original patch to move the code into the USB c

[Pull Request] xHCI bug fixes for 3.12 (Link PM and misc)

2013-10-14 Thread Sarah Sharp
The following changes since commit f4c19b8e165cff1a6607c21f8809441d61cab7ec: USB: serial: option: add support for Inovia SEW858 device (2013-10-11 16:17:51 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git tags/for-usb-linus-2013-10

[PATCH 1/5] usb: Disable USB 2.0 Link PM before device reset.

2013-10-14 Thread Sarah Sharp
Before the USB core resets a device, we need to disable the L1 timeout for the roothub, if USB 2.0 Link PM is enabled. Otherwise the port may transition into L1 in between descriptor fetches, before we know if the USB device descriptors changed. LPM will be re-enabled after the full device descri

  1   2   >