Re: default value of power/wakeup

2015-04-23 Thread Tom Yan
I know. Honestly I never expect it to be fixed. I just want to draw some attention so that people can be aware of this problem (some may be suffering from this without understand what's going on). Though I did filed a bug report on bugzilla some time ago to request making this function a no-op (so

Re: default value of power/wakeup

2015-04-23 Thread Alan Stern
On Thu, 23 Apr 2015, Tom Yan wrote: > I'm not saying that the kernel shouldn't initialize the attributes or > have a default. But it should only set the default when the attribute > is initialized (It doesn't even matter to me whether it's enabled or > disabled). > > It's just there should not be

Re: default value of power/wakeup

2015-04-22 Thread Tom Yan
https://bugs.freedesktop.org/show_bug.cgi?id=90041 Because udev's work would get overrided if there's further manipulation. So if you want your udev rule to work, you have to make sure you run a trigger command after the module is loaded or reloaded. This would happen for all types of devices if th

RE: default value of power/wakeup

2015-04-22 Thread Peter Chen
> > I'm not saying that the kernel shouldn't initialize the attributes or have a > default. > But it should only set the default when the attribute is initialized (It > doesn't > even matter to me whether it's enabled or disabled). > > It's just there should not be further manipulation from t

Re: default value of power/wakeup

2015-04-22 Thread Tom Yan
I'm not saying that the kernel shouldn't initialize the attributes or have a default. But it should only set the default when the attribute is initialized (It doesn't even matter to me whether it's enabled or disabled). It's just there should not be further manipulation from the kernel (e.g. devic

RE: default value of power/wakeup

2015-04-22 Thread Peter Chen
> > > > > > Oh, okay, I didn't realize that. > > > > > > Is there a reasonable way to enable wakeup only when the driver > > > learns that a keyboard is connected? Where would the driver do this? > > > > I don't know if the driver ever "knows" this, as you can pair lots of > > different devices

Re: default value of power/wakeup

2015-04-22 Thread Greg KH
On Wed, Apr 22, 2015 at 02:22:44PM -0400, Alan Stern wrote: > On Wed, 22 Apr 2015, Greg KH wrote: > > > > > But this device isn't always a keyboard. For example, mine works with a > > > > mouse. It's a "universal receiver", you can't know what type of HID > > > > device is plugged into it until

Re: default value of power/wakeup

2015-04-22 Thread Alan Stern
On Wed, 22 Apr 2015, Greg KH wrote: > > > But this device isn't always a keyboard. For example, mine works with a > > > mouse. It's a "universal receiver", you can't know what type of HID > > > device is plugged into it until it connects to it. I don't mind making > > > it auto wakeup, if that

Re: default value of power/wakeup

2015-04-22 Thread Greg KH
On Wed, Apr 22, 2015 at 12:15:36PM -0400, Alan Stern wrote: > On Wed, 22 Apr 2015, Greg KH wrote: > > > > Index: usb-4.0/drivers/hid/hid-logitech-dj.c > > > === > > > --- usb-4.0.orig/drivers/hid/hid-logitech-dj.c > > > +++ usb-4.0/dr

Re: default value of power/wakeup

2015-04-22 Thread Alan Stern
On Wed, 22 Apr 2015, Greg KH wrote: > > Index: usb-4.0/drivers/hid/hid-logitech-dj.c > > === > > --- usb-4.0.orig/drivers/hid/hid-logitech-dj.c > > +++ usb-4.0/drivers/hid/hid-logitech-dj.c > > @@ -990,6 +990,7 @@ static int logi_dj_p

Re: default value of power/wakeup

2015-04-22 Thread Greg KH
On Wed, Apr 22, 2015 at 11:28:29AM -0400, Alan Stern wrote: > On Wed, 22 Apr 2015, Tom Yan wrote: > > > On 21 April 2015 at 23:51, Alan Stern wrote: > > > Anyway, you're suggesting that drivers should never override sysfs > > > attribute values. But there doesn't seem to be any other way to > >

Re: default value of power/wakeup

2015-04-22 Thread Alan Stern
On Wed, 22 Apr 2015, Tom Yan wrote: > On 21 April 2015 at 23:51, Alan Stern wrote: > > Anyway, you're suggesting that drivers should never override sysfs > > attribute values. But there doesn't seem to be any other way to > > implement the kernel's policy that wakeup should be enabled by default

Re: default value of power/wakeup

2015-04-22 Thread Tom Yan
On 21 April 2015 at 23:51, Alan Stern wrote: > Anyway, you're suggesting that drivers should never override sysfs > attribute values. But there doesn't seem to be any other way to > implement the kernel's policy that wakeup should be enabled by default > for all keyboard devices. I just doubt if

Re: default value of power/wakeup

2015-04-21 Thread Alan Stern
On Tue, 21 Apr 2015, Tom Yan wrote: > By blacklisting the hid-generic, I think I can confirm hid-generic is > the module that matters. Though I'm curious how it use the code from > usbhid/hid-core.c because I couldn't find a clue in the short > hid-generic.c. In fact, hid-generic.c contains no ex

Re: default value of power/wakeup

2015-04-21 Thread Alan Stern
On Tue, 21 Apr 2015, Tom Yan wrote: > On 21 April 2015 at 03:44, Alan Stern wrote: > > > The generic driver includes code for enabling wakeup by default, > > Is there a part of code which can shows this? It seems to me that the > usbhid module is loaded for all USB HID devices, so I doubt a bit

Re: default value of power/wakeup

2015-04-21 Thread Tom Yan
By blacklisting the hid-generic, I think I can confirm hid-generic is the module that matters. Though I'm curious how it use the code from usbhid/hid-core.c because I couldn't find a clue in the short hid-generic.c. Anyway I don't know much about coding so it's not really my concern. But I think t

Re: default value of power/wakeup

2015-04-20 Thread Tom Yan
On 21 April 2015 at 03:44, Alan Stern wrote: > The generic driver includes code for enabling wakeup by default, Is there a part of code which can shows this? It seems to me that the usbhid module is loaded for all USB HID devices, so I doubt a bit: [tom@localhost ~]$ journalctl -b -1 | grep hid

Re: default value of power/wakeup

2015-04-20 Thread Alan Stern
On Tue, 21 Apr 2015, Tom Yan wrote: > Yes of course: Okay, the two devices appear to be the same as far as remote wakeup is concerned. The difference lies in the drivers. From your original report: > logitech-djreceiver 0003:046D:C52B.0003: hiddev0,hidraw0: USB HID > v1.11 Device [Logitech USB

Re: default value of power/wakeup

2015-04-20 Thread Tom Yan
Yes of course: Bus 003 Device 002: ID 046d:c52b Logitech, Inc. Unifying Receiver Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass0 bDeviceSubClass 0 bDeviceProtocol 0 bMaxPacketSize0 8

Re: default value of power/wakeup

2015-04-20 Thread Alan Stern
On Tue, 21 Apr 2015, Tom Yan wrote: > Thank you very much for your reply. > > So I tried to see if there's any difference between the two devices. I > can see that the one didn't get enabled by default has an extra > interface with 0 for the two attributes. But does that matter? Because > if it d

Re: default value of power/wakeup

2015-04-20 Thread Tom Yan
Thank you very much for your reply. So I tried to see if there's any difference between the two devices. I can see that the one didn't get enabled by default has an extra interface with 0 for the two attributes. But does that matter? Because if it does, shouldn't the mouse interface prevents the o

Re: default value of power/wakeup

2015-04-20 Thread Alan Stern
On Tue, 21 Apr 2015, Tom Yan wrote: > I have the following two USB wireless mouse/keyboard receivers: > > logitech-djreceiver 0003:046D:C52B.0003: hiddev0,hidraw0: USB HID > v1.11 Device [Logitech USB Receiver] on usb-:00:14.0-13/input2 > hid-generic 0003:046D:C52E.0005: input,hidraw2: USB HI

default value of power/wakeup

2015-04-20 Thread Tom Yan
I have the following two USB wireless mouse/keyboard receivers: logitech-djreceiver 0003:046D:C52B.0003: hiddev0,hidraw0: USB HID v1.11 Device [Logitech USB Receiver] on usb-:00:14.0-13/input2 hid-generic 0003:046D:C52E.0005: input,hidraw2: USB HID v1.11 Keyboard [Logitech USB Receiver] on usb