On 12/09/2013 11:41 PM, Felipe Balbi wrote:
Hi,
On Mon, Dec 09, 2013 at 11:40:33PM +0400, Valentine Barshak wrote:
Use usb_add_phy_dev instead of usb_add_phy, so that devices can
be bound to the phy. This is needed to set up USB phy for
some internal PCI USB host controllers on R-Car Gen2
Use usb_add_phy_dev instead of usb_add_phy, so that devices can
be bound to the phy. This is needed to set up USB phy for
some internal PCI USB host controllers on R-Car Gen2.
Changes from previous version:
* Fixed function names in the commit log
Signed-off-by: Valentine Barshak
---
drivers
On 12/09/2013 04:35 PM, Valentine Barshak wrote:
Use add_phy_dev instead of usb_phy_add, so that devices can
be bound to the phy. This is needed to set up USB phy for
some internal PCI USB host controllers on R-Car Gen2.
Signed-off-by: Valentine Barshak
---
drivers/usb/phy/phy-rcar-gen2
Use add_phy_dev instead of usb_phy_add, so that devices can
be bound to the phy. This is needed to set up USB phy for
some internal PCI USB host controllers on R-Car Gen2.
Signed-off-by: Valentine Barshak
---
drivers/usb/phy/phy-rcar-gen2-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
.
Signed-off-by: Valentine Barshak
---
drivers/usb/core/hcd.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 7527c8e..d3a9bcd 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2589,6 +2589,24 @@ int
def CONFIG_USB_PHY.
Valentine Barshak (2):
usb: hcd: Remove USB phy if needed
usb: hcd: Initialize USB phy if needed
drivers/usb/core/hcd.c | 32 +++-
include/linux/usb/hcd.h | 1 +
2 files changed, 32 insertions(+), 1 deletion(-)
--
1.8.3.1
--
To unsubscribe f
-by: Valentine Barshak
Acked-by: Alan Stern
---
drivers/usb/core/hcd.c | 14 +-
include/linux/usb/hcd.h | 1 +
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 6bffb8c..7527c8e 100644
--- a/drivers/usb/core/hcd.c
++
.
Signed-off-by: Valentine Barshak
Acked-by: Alan Stern
---
drivers/usb/core/hcd.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 7527c8e..649506b 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
-by: Valentine Barshak
Acked-by: Alan Stern
---
drivers/usb/core/hcd.c | 14 +-
include/linux/usb/hcd.h | 1 +
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 6bffb8c..7527c8e 100644
--- a/drivers/usb/core/hcd.c
++
the PCI HC devices, and make the phy-rcar-gen2-usb
driver register USB phy with usb_add_phy_dev() AOT usb_add_phy() callback.
Changes from previous version:
* Used #ifdef CONFIG_USB_PHY instead of introducing new config option.
Valentine Barshak (2):
usb: hcd: Remove USB phy if needed
usb:
On 11/27/2013 01:44 AM, Greg KH wrote:
On Wed, Nov 27, 2013 at 01:31:06AM +0400, Valentine wrote:
On 11/07/2013 03:14 PM, Valentine Barshak wrote:
This adds remove_phy flag to the HCD structure. If the flag is
set and if hcd->phy is valid, the phy is shutdown and released
whenever usb_add_
On 11/07/2013 03:14 PM, Valentine Barshak wrote:
This adds remove_phy flag to the HCD structure. If the flag is
set and if hcd->phy is valid, the phy is shutdown and released
whenever usb_add_hcd fails or usb_hcd_remove is called.
This also adds generic external phy support that allows
the
On 11/20/2013 09:46 PM, Fabio Estevam wrote:
On Wed, Nov 20, 2013 at 3:38 PM, Ulrich Hecht wrote:
From: Valentine Barshak
This adds external USB phy support to USB HCD driver that
allows to find and initialize external USB phy, bound to
the HCD, when the HCD is added.
The usb_add_hcd
On 11/20/2013 09:38 PM, Ulrich Hecht wrote:
Adds USB1 and 2 as hosts and binds them to the USB phy.
Signed-off-by: Ulrich Hecht
---
arch/arm/mach-shmobile/Kconfig | 1 +
arch/arm/mach-shmobile/board-lager.c | 23 +++
2 files changed, 24 insertions(+)
diff --git a
On 11/20/2013 09:38 PM, Ulrich Hecht wrote:
Adds clock for internal PCI host controllers.
Signed-off-by: Ulrich Hecht
---
arch/arm/mach-shmobile/clock-r8a7790.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c
b/arch/arm/mach-shm
On 11/20/2013 09:38 PM, Ulrich Hecht wrote:
Allows binding of PCI USB host controllers to this phy.
Signed-off-by: Ulrich Hecht
---
drivers/usb/phy/phy-rcar-gen2-usb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c
b/drivers/usb/phy
On 11/20/2013 09:38 PM, Ulrich Hecht wrote:
Makes the PCI host controllers come alive.
This is not needed if you use CCLKDEV_DEV_ID in patch 7/9
Thanks,
Val.
Signed-off-by: Ulrich Hecht
---
drivers/pci/host/pci-rcar-gen2.c | 14 ++
1 file changed, 14 insertions(+)
diff --gi
On 11/20/2013 09:37 PM, Ulrich Hecht wrote:
This is a collection of patches developed by Valentine Barshak towards
support of the PCI-attached USB 2.0 host controllers on Lager, with some
glue supplied by me:
- added missing PCI host clock (MSTP703)
- bound PCI USB HCIs to the USB phy
- added
On 11/07/2013 05:06 PM, Peter Chen wrote:
+#ifdef CONFIG_USB_PHY
+ if (!hcd->phy) {
+ struct usb_phy *phy = usb_get_phy_dev(hcd->self.controller,
0);
+
+ if (IS_ERR(phy)) {
+ retval = PTR_ERR(phy);
+ if (retval == -
-by: Valentine Barshak
---
drivers/usb/core/hcd.c | 14 +-
include/linux/usb/hcd.h | 1 +
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index d6a8d23..d939521 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hc
.
Signed-off-by: Valentine Barshak
---
drivers/usb/core/hcd.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index d939521..fd09ec6 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2597,6 +2597,26 @@ int
the PCI HC devices, and make the phy-rcar-gen2-usb
driver register USB phy with usb_add_phy_dev() AOT usb_add_phy() callback.
Changes from previous version:
* Used #ifdef CONFIG_USB_PHY instead of introducing new config option.
Valentine Barshak (2):
usb: hcd: Remove USB phy if needed
usb:
On 11/06/2013 09:04 PM, Felipe Balbi wrote:
Hi,
On Wed, Nov 06, 2013 at 08:43:36PM +0400, Valentine wrote:
On 11/06/2013 07:45 PM, Felipe Balbi wrote:
Hi,
On Wed, Nov 06, 2013 at 12:33:26AM +0400, Valentine Barshak wrote:
This adds remove_phy flag to the HCD structure. If the flag is
set
On 11/06/2013 08:39 PM, Alan Stern wrote:
On Wed, 6 Nov 2013, Felipe Balbi wrote:
Hi,
On Wed, Nov 06, 2013 at 12:33:27AM +0400, Valentine Barshak wrote:
This adds external USB phy support to USB HCD driver that
allows to find and initialize external USB phy, bound to
the HCD when the HCD is
On 11/06/2013 07:45 PM, Felipe Balbi wrote:
Hi,
On Wed, Nov 06, 2013 at 12:33:26AM +0400, Valentine Barshak wrote:
This adds remove_phy flag to the HCD structure. If the flag is
set and if hcd->phy is valid, the phy is shutdown and released
whenever usb_add_hcd fails or usb_hcd_remove
-by: Valentine Barshak
---
drivers/usb/core/hcd.c | 14 +-
include/linux/usb/hcd.h | 1 +
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index d6a8d23..d939521 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hc
.
Signed-off-by: Valentine Barshak
---
drivers/usb/core/hcd.c | 20
drivers/usb/host/Kconfig | 11 +++
2 files changed, 31 insertions(+)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index d939521..da9c4ba 100644
--- a/drivers/usb/core/hcd.c
+++ b
phy device to the PCI HC devices, and make the phy-rcar-gen2-usb
driver register USB phy with usb_add_phy_dev() AOT usb_add_phy() callback.
Valentine Barshak (2):
usb: hcd: Remove USB phy if needed
usb: hcd: Introduce CONFIG_USB_HCD_EXTERNAL_PHY option
drivers/usb/core/hcd.c |
On 11/01/2013 07:55 PM, Alan Stern wrote:
On Fri, 1 Nov 2013, Valentine wrote:
The USB HDC PCI deferred probing could be used on R-Car. But I'm not sure how
to make a particular
PCI USB HDC device attached to a particular PCI host controller on a particular
SoC defer its probing
On 11/01/2013 06:32 PM, Greg KH wrote:
On Fri, Nov 01, 2013 at 05:59:40PM +0400, Valentine wrote:
I'm not sure how this problem should be addressed using USB HCD PCI deferred
probing.
However, at the same time I see that six usb phy drivers use subsys_initcall
and one
uses postcore_ini
On 11/01/2013 06:17 PM, Alan Stern wrote:
On Fri, 1 Nov 2013, Valentine wrote:
You need to tell usb_hcd_pci_probe() to wait for the PHY. That seems
to be the proper solution to your problem.
The difficulty is that you have a discoverable device (the PCI EHCI
controller) which needs to wait
On 10/31/2013 08:54 PM, Alan Stern wrote:
On Thu, 31 Oct 2013, Valentine wrote:
Do you mean to change usb_hcd_pci_probe() to return -EPROBE_DEFER if the phy is
not ready?
Or should I defer the whole PCI subsystem initialization (pci_common_int)?
Greg,
the reason I ask is that it doesn&#
On 10/31/2013 08:12 PM, Ulrich Hecht wrote:
On Thu, Oct 31, 2013 at 12:43 PM, Valentine
wrote:
Please, let me know if you see better options.
How about disregarding the whole PCI aspect? I mean, yes, those are
PCI busses, but they are internal, with a fixed set of devices
attached, and as
On 10/31/2013 03:36 AM, Valentine wrote:
On 10/30/2013 06:12 PM, Greg KH wrote:
On Wed, Oct 30, 2013 at 01:56:25PM +0400, Valentine wrote:
On 10/30/2013 03:57 AM, Greg KH wrote:
On Tue, Oct 29, 2013 at 09:19:09PM +0400, Valentine wrote:
On 10/29/2013 09:00 PM, Laurent Pinchart wrote:
Hi
On 10/30/2013 06:12 PM, Greg KH wrote:
On Wed, Oct 30, 2013 at 01:56:25PM +0400, Valentine wrote:
On 10/30/2013 03:57 AM, Greg KH wrote:
On Tue, Oct 29, 2013 at 09:19:09PM +0400, Valentine wrote:
On 10/29/2013 09:00 PM, Laurent Pinchart wrote:
Hi Valentine,
Thank you for the patch.
On
On 10/30/2013 03:57 AM, Greg KH wrote:
On Tue, Oct 29, 2013 at 09:19:09PM +0400, Valentine wrote:
On 10/29/2013 09:00 PM, Laurent Pinchart wrote:
Hi Valentine,
Thank you for the patch.
On Tuesday 29 October 2013 20:21:06 Valentine Barshak wrote:
USB phy controls USB channels 0 and 2 which
On 10/29/2013 09:00 PM, Laurent Pinchart wrote:
Hi Valentine,
Thank you for the patch.
On Tuesday 29 October 2013 20:21:06 Valentine Barshak wrote:
USB phy controls USB channels 0 and 2 which are shared between
PCI USB host controllers and USBHS/USBSS respectively.
This Initializes USB phy
USB phy controls USB channels 0 and 2 which are shared between
PCI USB host controllers and USBHS/USBSS respectively.
This Initializes USB phy driver earlier because we need it
before PCI USB host controllers are initialized.
Signed-off-by: Valentine Barshak
---
drivers/usb/phy/phy-rcar-gen2
Add missing USB UGCTRL2 register offset.
Signed-off-by: Valentine Barshak
---
drivers/usb/phy/phy-rcar-gen2-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c
b/drivers/usb/phy/phy-rcar-gen2-usb.c
index a99a695..db3ab34 100644
This adds RCAR Gen2 USB phy support. The driver configures
USB channels 0/2 which are shared between PCI USB hosts and
USBHS/USBSS devices. It also controls internal USBHS phy.
Signed-off-by: Valentine Barshak
---
drivers/usb/phy/Kconfig | 13 ++
drivers/usb/phy
On 10/10/2013 07:23 PM, Felipe Balbi wrote:
Hi,
On Thu, Oct 10, 2013 at 02:14:45AM +0400, Valentine Barshak wrote:
This adds RCAR Gen2 USB phy support. The driver configures
USB channels 0/2 which are shared between PCI USB hosts and
USBHS/USBSS devices. It also controls internal USBHS phy
This adds RCAR Gen2 USB phy support. The driver configures
USB channels 0/2 which are shared between PCI USB hosts and
USBHS/USBSS devices. It also controls internal USBHS phy.
Signed-off-by: Valentine Barshak
---
drivers/usb/phy/Kconfig | 13 ++
drivers/usb/phy
This adds USBHS PHY and registers USBHS device if the driver is enabled.
Signed-off-by: Valentine Barshak
Acked-by: Kuninori Morimoto
---
arch/arm/mach-shmobile/board-lager.c | 115 +++
1 file changed, 115 insertions(+)
diff --git a/arch/arm/mach-shmobile/board
This adds USBHS clock support.
Signed-off-by: Valentine Barshak
Acked-by: Kuninori Morimoto
---
arch/arm/mach-shmobile/clock-r8a7790.c | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c
b/arch/arm/mach-shmobile/clock-r8a7790.c
index a64f965..161d44e
renesas_usbhs driver disable USB PHY completely
when it is not needed.
Valentine Barshak (3):
usb: phy: Add RCAR Gen2 USB phy
arm: shmobile: r8a7790: Add USBHS clock support
arm: shmobile: lager: Add USBHS support
arch/arm/mach-shmobile/board-lager.c| 106 ++
arch/arm/mach
On 10/10/2013 01:28 AM, Laurent Pinchart wrote:
Hi Valentine,
On Thursday 10 October 2013 01:21:27 Valentine wrote:
On 10/10/2013 12:32 AM, Laurent Pinchart wrote:
Hi Valentine,
Hi Laurent,
Thank you for the patch.
On Tuesday 08 October 2013 23:43:25 Valentine Barshak wrote:
This adds
On 10/10/2013 12:32 AM, Laurent Pinchart wrote:
Hi Valentine,
Hi Laurent,
Thank you for the patch.
On Tuesday 08 October 2013 23:43:25 Valentine Barshak wrote:
This adds RCAR Gen2 USB phy support. The driver configures
USB channels 0/2 which are shared between PCI USB hosts and
USBHS
This adds RCAR Gen2 USB phy support. The driver configures
USB channels 0/2 which are shared between PCI USB hosts and
USBHS/USBSS devices. It also controls internal USBHS phy.
Signed-off-by: Valentine Barshak
---
drivers/usb/phy/Kconfig | 13 ++
drivers/usb/phy
This adds USBHS clock support.
Signed-off-by: Valentine Barshak
---
arch/arm/mach-shmobile/clock-r8a7790.c | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c
b/arch/arm/mach-shmobile/clock-r8a7790.c
index a64f965..161d44e 100644
--- a/arch/arm/mach
;
* usb_phy_init/shutdown called from usbhs_power_ctrl callback
to allow renesas_usbhs driver disable USB PHY completely
when it is not needed.
Valentine Barshak (3):
usb: phy: Add RCAR Gen2 USB phy
arm: shmobile: r8a7790: Add USBHS clock support
arm: shmobile: lager: Add USBHS support
arch
This adds USBHS PHY and registers USBHS device if the driver is enabled.
Signed-off-by: Valentine Barshak
---
arch/arm/mach-shmobile/board-lager.c | 115 +++
1 file changed, 115 insertions(+)
diff --git a/arch/arm/mach-shmobile/board-lager.c
b/arch/arm/mach
On 10/08/2013 07:31 AM, Kuninori Morimoto wrote:
Hi Valentine
This adds USBHS PHY and registers USBHS device if the driver is enabled.
Signed-off-by: Valentine Barshak
---
(snip)
+/* USBHS */
+#if IS_ENABLED(CONFIG_USB_RENESAS_USBHS_UDC)
+static const struct resource usbhs_resources
On 10/08/2013 07:27 AM, Kuninori Morimoto wrote:
Hi Valentine
Hi Morimoto-san,
Thank you for your patch
Thanks for looking at it.
+/* Setup USB channels */
+static void __rcar_gen2_usb_phy_setup(struct rcar_gen2_usb_phy_priv *priv)
+{
+ u32 val;
+
+ clk_prepare_enable
On 10/08/2013 03:27 AM, Valentine Barshak wrote:
This adds RCAR Gen2 USB phy support. The driver configures
USB channels 0/2, which are shared between PCI USB hosts and
USBHS/USBSS devices. It also controls internal USBHS phy.
[snip]
diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c
b
This adds USBHS clock support.
Signed-off-by: Valentine Barshak
---
arch/arm/mach-shmobile/clock-r8a7790.c | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c
b/arch/arm/mach-shmobile/clock-r8a7790.c
index a64f965..7bb2796 100644
--- a/arch/arm/mach
This adds USBHS PHY and registers USBHS device if the driver is enabled.
Signed-off-by: Valentine Barshak
---
arch/arm/mach-shmobile/board-lager.c | 106 +++
1 file changed, 106 insertions(+)
diff --git a/arch/arm/mach-shmobile/board-lager.c
b/arch/arm/mach
This adds RCAR Gen2 USB phy support. The driver configures
USB channels 0/2, which are shared between PCI USB hosts and
USBHS/USBSS devices. It also controls internal USBHS phy.
Signed-off-by: Valentine Barshak
---
drivers/usb/phy/Kconfig | 13 ++
drivers/usb/phy
phy driver.
Valentine Barshak (3):
usb: phy: Add RCAR Gen2 USB phy
arm: shmobile: r8a7790: Add USBHS clock support
arm: shmobile: lager: Add USBHS support
arch/arm/mach-shmobile/board-lager.c| 106 +
arch/arm/mach-shmobile/clock-r8a7790.c | 4 +
drivers/usb
58 matches
Mail list logo
