Re: [Patch V3 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller

2019-05-23 Thread Nagarjuna Kristam
On 16-05-2019 14:38, Chunfeng Yun wrote: > On Thu, 2019-05-16 at 12:09 +0530, Nagarjuna Kristam wrote: >> This patch adds UDC driver for tegra XUSB 3.0 device mode controller. >> XUSB device mode controller supports SS, HS and FS modes >> >> Based on work by: >> Mark Kuo >> Andrew Bresticke

Re: [PATCH v2] usb: dwc3: move core validation to be after clks enable

2019-05-23 Thread Baruch Siach
Hi Thinh, On Fri, May 24 2019, Thinh Nguyen wrote: > Baruch Siach wrote: >> Hi Jun Li, >> >> On Wed, May 08, 2019 at 10:52:37AM +, Jun Li wrote: >>> From: Jun Li >>> >>> Register access in core validation may hang before the bulk >>> clks are enabled. >> This patch fixes the hang issue for on

Re: [PATCH v2] usb: dwc3: move core validation to be after clks enable

2019-05-23 Thread Thinh Nguyen
Hi Baruch, Baruch Siach wrote: > Hi Jun Li, > > On Wed, May 08, 2019 at 10:52:37AM +, Jun Li wrote: >> From: Jun Li >> >> Register access in core validation may hang before the bulk >> clks are enabled. > This patch fixes the hang issue for on my i.MX8MQ based system. > > Tested-by: Baruch Si

Re: Crash/hung task in usb-storage thread

2019-05-23 Thread Greg KH
On Thu, May 23, 2019 at 01:16:12PM +, Schmid, Carsten wrote: > > > > > > > > 4.14.102 is still old. > > > I agree > > > > > > > > Porting a 5.1 will take a lot of effort. > > > > > > > > Then that implies you have an SoC with a few million lines of code added > > > > to the kernel, right? Noth

Re: Crash/hung task in usb-storage thread

2019-05-23 Thread Alan Stern
On Thu, 23 May 2019, Schmid, Carsten wrote: > Hi USB maintainers, > > we recently have seen a problem with usb-storage when trying to read from a > device. > This happened on a 4.14.86 kernel. > > The kernel's dmesg shows: (log has been submitted via DLT) > 1200.862250 kernel: usb 1-3.1: reset

Re: [usb:usb-linus] BUILD REGRESSION c1a145a3ed9a40f3b6145feb97789e8eb49c5566

2019-05-23 Thread Shuah Khan
On 5/23/19 1:13 AM, Greg Kroah-Hartman wrote: On Thu, May 23, 2019 at 01:58:01AM +0800, kbuild test robot wrote: tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-linus branch HEAD: c1a145a3ed9a40f3b6145feb97789e8eb49c5566 xhci: Use %zu for printing size_t type

Re: [PATCH v2] usb: dwc3: move core validation to be after clks enable

2019-05-23 Thread Baruch Siach
Hi Jun Li, On Wed, May 08, 2019 at 10:52:37AM +, Jun Li wrote: > From: Jun Li > > Register access in core validation may hang before the bulk > clks are enabled. This patch fixes the hang issue for on my i.MX8MQ based system. Tested-by: Baruch Siach However, commit b873e2d0ea1e is meant

AW: Crash/hung task in usb-storage thread

2019-05-23 Thread Schmid, Carsten
> > > > > > 4.14.102 is still old. > > I agree > > > > > > Porting a 5.1 will take a lot of effort. > > > > > > Then that implies you have an SoC with a few million lines of code added > > > to the kernel, right? Nothing we can do here about that mess, you need > > > to go ask for support from the

Re: Crash/hung task in usb-storage thread

2019-05-23 Thread Greg KH
On Thu, May 23, 2019 at 12:30:06PM +, Schmid, Carsten wrote: > > > > Wow that's an old kernel. > > > Indeed. Long running project. > > > > > > > Can you reproduce this on a "clean" 5.1 kernel release? > > > As this is an automotive embedded target, we currently have 4.14.102 as > > > the newe

AW: Crash/hung task in usb-storage thread

2019-05-23 Thread Schmid, Carsten
> > > Wow that's an old kernel. > > Indeed. Long running project. > > > > > Can you reproduce this on a "clean" 5.1 kernel release? > > As this is an automotive embedded target, we currently have 4.14.102 as the > > newest custom kernel. > > 4.14.102 is still old. I agree > > Porting a 5.1 will

Re: Crash/hung task in usb-storage thread

2019-05-23 Thread Greg KH
On Thu, May 23, 2019 at 12:16:59PM +, Schmid, Carsten wrote: > > Wow that's an old kernel. > Indeed. Long running project. > > > Can you reproduce this on a "clean" 5.1 kernel release? > As this is an automotive embedded target, we currently have 4.14.102 as the > newest custom kernel. 4.14.

AW: Crash/hung task in usb-storage thread

2019-05-23 Thread Schmid, Carsten
> Wow that's an old kernel. Indeed. Long running project. > Can you reproduce this on a "clean" 5.1 kernel release? As this is an automotive embedded target, we currently have 4.14.102 as the newest custom kernel. Porting a 5.1 will take a lot of effort. Anyway, thanks for quick response. I'll c

Re: Crash/hung task in usb-storage thread

2019-05-23 Thread Greg KH
On Thu, May 23, 2019 at 11:57:06AM +, Schmid, Carsten wrote: > Hi USB maintainers, > > we recently have seen a problem with usb-storage when trying to read from a > device. > This happened on a 4.14.86 kernel. Wow that's an old kernel. > > The kernel's dmesg shows: (log has been submitted

Crash/hung task in usb-storage thread

2019-05-23 Thread Schmid, Carsten
Hi USB maintainers, we recently have seen a problem with usb-storage when trying to read from a device. This happened on a 4.14.86 kernel. The kernel's dmesg shows: (log has been submitted via DLT) 1200.862250 kernel: usb 1-3.1: reset high-speed USB device number 10 using xhci_hcd 1285.466289 k

Re: [Patch V3 4/8] dt-bindings: usb: Add NVIDIA Tegra XUSB device mode controller binding

2019-05-23 Thread Nagarjuna Kristam
On 23-05-2019 15:43, Thierry Reding wrote: > On Thu, May 16, 2019 at 12:09:28PM +0530, Nagarjuna Kristam wrote: >> Add device-tree binding documentation for the XUSB device mode controller >> present on Tegra210 SoC. This controller supports the USB 3.0 >> specification. >> >> Signed-off-by: Nag

Re: [Patch V3 2/8] phy: tegra: xusb: t210: add usb3 port fake support

2019-05-23 Thread Nagarjuna Kristam
On 23-05-2019 15:31, Thierry Reding wrote: > On Thu, May 16, 2019 at 12:09:26PM +0530, Nagarjuna Kristam wrote: >> On Tegra210, usb2 only otg/peripheral ports dont work in device mode. >> They need an assosciated usb3 port to work in device mode. Identify >> an unused usb3 port and assign it as

Re: [Patch V3 2/8] phy: tegra: xusb: t210: add usb3 port fake support

2019-05-23 Thread Nagarjuna Kristam
On 21-05-2019 08:30, jckuo wrote: > Hi Nagarjuna, > > Please check tegra_xusb_update_usb3_fake_port(). > > Thanks, > > JC > > On 5/16/19 2:39 PM, Nagarjuna Kristam wrote: >> On Tegra210, usb2 only otg/peripheral ports dont work in device mode. >> They need an assosciated usb3 port to work in

Re: [Patch V3 3/8] phy: tegra: xusb: t210: add vbus override support

2019-05-23 Thread Nagarjuna Kristam
On 21-05-2019 10:04, jckuo wrote: > Hi Nagarjuna, > > Please check tegra_phy_xusb_utmi_port_reset(). > > Thanks, > > JC > > On 5/16/19 2:39 PM, Nagarjuna Kristam wrote: >> Tegra XUSB device control driver needs to control vbus override >> during its operations, add API for the support. >> >>

Re: [Patch V3 3/8] phy: tegra: xusb: t210: add vbus override support

2019-05-23 Thread Nagarjuna Kristam
On 23-05-2019 15:33, Thierry Reding wrote: > On Thu, May 16, 2019 at 12:09:27PM +0530, Nagarjuna Kristam wrote: >> Tegra XUSB device control driver needs to control vbus override >> during its operations, add API for the support. >> >> Signed-off-by: Nagarjuna Kristam >> --- >> drivers/phy/teg

Re: [Patch V3 8/8] arm64: defconfig: Enable tegra XUDC driver

2019-05-23 Thread Thierry Reding
On Thu, May 16, 2019 at 12:09:32PM +0530, Nagarjuna Kristam wrote: > Enable support for Nvidia XUSB device mode controller driver. > > Signed-off-by: Nagarjuna Kristam > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/ar

Re: [Patch V3 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller

2019-05-23 Thread Thierry Reding
On Thu, May 16, 2019 at 12:09:31PM +0530, Nagarjuna Kristam wrote: > This patch adds UDC driver for tegra XUSB 3.0 device mode controller. > XUSB device mode controller supports SS, HS and FS modes > > Based on work by: > Mark Kuo > Andrew Bresticker > > Signed-off-by: Nagarjuna Kristam >

Re: [Patch V3 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller

2019-05-23 Thread Thierry Reding
On Thu, May 16, 2019 at 12:09:31PM +0530, Nagarjuna Kristam wrote: > This patch adds UDC driver for tegra XUSB 3.0 device mode controller. > XUSB device mode controller supports SS, HS and FS modes > > Based on work by: > Mark Kuo > Andrew Bresticker > > Signed-off-by: Nagarjuna Kristam >

Re: [Patch V3 5/8] arm64: tegra: Add xudc node for Tegra210

2019-05-23 Thread Thierry Reding
On Thu, May 16, 2019 at 12:09:29PM +0530, Nagarjuna Kristam wrote: > Tegra210 has one XUSB device mode controller, which can be operated > HS and SS modes. Add DT support for XUSB device mode controller. > > Signed-off-by: Nagarjuna Kristam > --- > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 19 +

Re: [Patch V3 4/8] dt-bindings: usb: Add NVIDIA Tegra XUSB device mode controller binding

2019-05-23 Thread Thierry Reding
On Thu, May 16, 2019 at 12:09:28PM +0530, Nagarjuna Kristam wrote: > Add device-tree binding documentation for the XUSB device mode controller > present on Tegra210 SoC. This controller supports the USB 3.0 > specification. > > Signed-off-by: Nagarjuna Kristam > --- > .../devicetree/bindings/usb

Re: [Patch V3 3/8] phy: tegra: xusb: t210: add vbus override support

2019-05-23 Thread Thierry Reding
On Thu, May 16, 2019 at 12:09:27PM +0530, Nagarjuna Kristam wrote: > Tegra XUSB device control driver needs to control vbus override > during its operations, add API for the support. > > Signed-off-by: Nagarjuna Kristam > --- > drivers/phy/tegra/xusb-tegra210.c | 59 > ++

Re: [Patch V3 2/8] phy: tegra: xusb: t210: add usb3 port fake support

2019-05-23 Thread Thierry Reding
On Thu, May 16, 2019 at 12:09:26PM +0530, Nagarjuna Kristam wrote: > On Tegra210, usb2 only otg/peripheral ports dont work in device mode. > They need an assosciated usb3 port to work in device mode. Identify > an unused usb3 port and assign it as a fake USB3 port to USB2 only > port whose mode is

Re: [Patch V3 1/8] phy: tegra: xusb: t210: add XUSB dual mode support

2019-05-23 Thread Thierry Reding
On Thu, May 16, 2019 at 12:09:25PM +0530, Nagarjuna Kristam wrote: > Configure the port capabilities based on usb_dr_mode settings. > > Based on work by JC Kuo . > > Signed-off-by: Nagarjuna Kristam > --- > drivers/phy/tegra/xusb-tegra210.c | 22 +++--- > 1 file changed, 19 inse

Re: [usb:usb-linus] BUILD REGRESSION c1a145a3ed9a40f3b6145feb97789e8eb49c5566

2019-05-23 Thread Greg Kroah-Hartman
On Thu, May 23, 2019 at 01:58:01AM +0800, kbuild test robot wrote: > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > usb-linus > branch HEAD: c1a145a3ed9a40f3b6145feb97789e8eb49c5566 xhci: Use %zu for > printing size_t type > > Regressions in current branch: > >