ehci-dbg prints random memory (# CONFIG_DYNAMIC_DEBUG is not set)

2016-04-12 Thread Rafał Miłecki
Hi, I'm trying to debug some EHCI issue so I enabled debugging by adding ccflags-y := -DDEBUG to the drivers/usb/host/Makefile Some of debugging lines contain random memory, e.g.: ehci-platform ehci-platform.0: .|��`|���5P5@�3�.��*�.|��o It's caused by dbg_status, dbg_cmd and dbg_port calling eh

[PATCHv4 1/3] usb: storage: scsiglue: further describe our 240 sector limit

2016-04-12 Thread Felipe Balbi
Just so we have some sort of documentation as to why we limit our Mass Storage transfers to 240 sectors, let's update the comment to make clearer that devices were found that would choke with larger transfers. While at that, also make sure to clarify that other operating systems have similar, albe

[PATCHv4 0/3] usb: storage: increase limit to 2048 sectors

2016-04-12 Thread Felipe Balbi
here's v4 of the scsiglue limit patch. Changes since v3: - Respect USB_FL_MAX_SECTORS* if they are set for USB3 devices Changes since v2: - Add a patch fixing multi-line comment style - s/limitting/limiting - Remove US_FL_USB3 flag Felipe Balbi (3): usb: storage

[PATCHv4 2/3] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2016-04-12 Thread Felipe Balbi
USB3 devices, because they are much newer, have much less chance of having issues with larger transfers. We still keep a limit because anything above 2048 sectors really rendered negligible speed improvements, so we will simply ignore that. Transferring 1MiB should already give us pretty good perf

[PATCHv4 3/3] usb: storage: fix multi-line comment style

2016-04-12 Thread Felipe Balbi
No functional changes here, just making sure our storage driver uses a consistent multi-line comment style. Signed-off-by: Felipe Balbi --- drivers/usb/storage/alauda.c | 22 ++- drivers/usb/storage/cypress_atacb.c| 34 ++-- drivers/usb/storage/datafab.c | 22 ++- drive

Re: [PATCHv3 2/3] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2016-04-12 Thread Felipe Balbi
Hi, Alan Stern writes: > On Tue, 12 Apr 2016, Felipe Balbi wrote: > >> > I should have noticed this before. If something goes wrong with the >> > 2048-sector limit, this doesn't permit the user to override. Shouldn't >> > the test for USB_SPEED_SUPER go after the other FL_MAX_SECTORS tests?

Re: [RFC] Change bcdUSB in older kernels to return 0x0310 for SuperSpeed

2016-04-12 Thread John Youn
On 4/12/2016 12:18 AM, Bjørn Mork wrote: > John Youn writes: > >> Hi, >> >> I would like to port the following commit from 4.6 to older kernels. >> >> 1a85329171094951956a37acc8abb7e51c1e742e ("usb: gadget: composite: >> Return bcdUSB 0x0310") >> >> https://git.kernel.org/cgit/linux/kernel/git/to

Re: [RFC] Change bcdUSB in older kernels to return 0x0310 for SuperSpeed

2016-04-12 Thread John Youn
On 4/11/2016 11:25 PM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> Hi, >> >> I would like to port the following commit from 4.6 to older kernels. >> >> 1a85329171094951956a37acc8abb7e51c1e742e ("usb: gadget: composite: >> Return bcdUSB 0x0310") >> >> https://git.kernel.org/cgit/linux/ke

ジェームズHartopから

2016-04-12 Thread James Hartop
ジェームズHartopから、 私はあなたとあなたの家族がやっているか、私の手紙が今日健康とあなたの最高の気分でお会いすることを期待しますか?親切にあなたのプライバシーに侵入するための私を許してください。あなたは私達の両方の相互利益になります金融ビジネス関係で信頼することはできますか?私はあなたが私はあなたを伝えることを約午前何に興味を持つであろうことを期待して、あなたの国の国際ビジネス情報から自分の名前と連絡先を得ました。 私はここイギリスでHarlesdenからジェームズ・ウィリアムHartop、北西ロンドン、と思います。私は、UBS銀行、ロンドンのために働きます。私は私達の両方に莫大

ジェームズHartopから、

2016-04-12 Thread james william hartop
ジェームズHartopから、 私はあなたとあなたの家族がやっているか、私の手紙が今日健康とあなたの最高の気分でお会いすることを期待しますか?親切にあなたのプライバシーに侵入するための私を許してください。あなたは私達の両方の相互利益になります金融ビジネス関係で信頼することはできますか?私はあなたが私はあなたを伝えることを約午前何に興味を持つであろうことを期待して、あなたの国の国際ビジネス情報から自分の名前と連絡先を得ました。 私はここイギリスでHarlesdenからジェームズ・ウィリアムHartop、北西ロンドン、と思います。私は、UBS銀行、ロンドンのために働きます。私は私達の両方に莫大

[PATCH] doc: usb: Fix typo in gadget_multi documentation

2016-04-12 Thread Diego Herranz
It tries to "match" drivers for each interface (not "much"). Signed-off-by: Diego Herranz --- Documentation/usb/gadget_multi.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/usb/gadget_multi.txt b/Documentation/usb/gadget_multi.txt index 7d66a86..5faf514 100

Re: [PATCH] usb: host: xhci-plat: add firmware for the R-Car M3-W xHCI controllers

2016-04-12 Thread Kyle McMartin
On Tue, Apr 12, 2016 at 04:28:44PM +0900, Yoshihiro Shimoda wrote: > This patch adds a firmware for the USB 3.0 host controllers of Renesas > R-Car M3-W SoC. > > - This firmware is possible to be used on R-Car H2 and M2. However, >this version causes performance degradation on such SoCs. > -

Re: [PATCH v2 2/2] USB: uas: Add a new NO_REPORT_LUNS quirk

2016-04-12 Thread Alan Stern
On Tue, 12 Apr 2016, Hans de Goede wrote: > Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with > an usb-id of: 0bc2:331a, as these will fail to respond to a > REPORT_LUNS command. > > Cc: sta...@vger.kernel.org > Reported-and-tested-by: David Webb > Signed-off-by: Hans de Goede >

[PATCH net,stable] cdc_mbim: apply "NDP to end" quirk to all Huawei devices

2016-04-12 Thread Bjørn Mork
We now have a positive report of another Huawei device needing this quirk: The ME906s-158 (12d1:15c1). This is an m.2 form factor modem with no obvious relationship to the E3372 (12d1:157d) we already have a quirk entry for. This is reason enough to believe the quirk might be necessary for any nu

Re: XHCI is slow during boot (bios/efi) and leaves many dmesg messages

2016-04-12 Thread Olliver Schinagl
Hey, On 11-04-16 10:22, Felipe Balbi wrote: Hi, Olliver Schinagl writes: Hey all, On 11-04-16 07:12, Felipe Balbi wrote: Hi, Janna Martl writes: On 2016-04-04 9:06:28, Olliver Schinagl wrote: Hi list, I have a Apple Inc. MacBookPro11,1 (with the most recent 'bios': BIOS MBP111.88Z.0138

Re: [PATCHv3 2/3] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2016-04-12 Thread Alan Stern
On Tue, 12 Apr 2016, Felipe Balbi wrote: > > I should have noticed this before. If something goes wrong with the > > 2048-sector limit, this doesn't permit the user to override. Shouldn't > > the test for USB_SPEED_SUPER go after the other FL_MAX_SECTORS tests? > > you mean that a USB3 device

Re: [PATCH] usb: Add driver for UCSI

2016-04-12 Thread Heikki Krogerus
On Tue, Apr 12, 2016 at 06:12:04AM -0700, Greg KH wrote: > On Tue, Apr 12, 2016 at 02:43:36PM +0300, Heikki Krogerus wrote: > > + ucsi.usb_data_role= > > Ick, this isn't the 1990's anymore, please don't use module parameters > for anything that is required for a driver. Make it automatic if at

Re: [PATCH] usb: Add driver for UCSI

2016-04-12 Thread Heikki Krogerus
On Tue, Apr 12, 2016 at 03:10:01PM +0200, Oliver Neukum wrote: > On Tue, 2016-04-12 at 14:43 +0300, Heikki Krogerus wrote: > > > +static int ucsi_init(struct ucsi *ucsi) > > +{ > > + struct ucsi_connector *con; > > + struct ucsi_control ctrl; > > + int ret; > > + int i; > > + > > + atomi

Re: [PATCH] usb: Add driver for UCSI

2016-04-12 Thread Oliver Neukum
On Tue, 2016-04-12 at 14:43 +0300, Heikki Krogerus wrote: > +static int ucsi_init(struct ucsi *ucsi) > +{ > + struct ucsi_connector *con; > + struct ucsi_control ctrl; > + int ret; > + int i; > + > + atomic_set(&ucsi->event_pending, 0); > + init_completion(&ucsi->complete);

Re: [PATCH] usb: Add driver for UCSI

2016-04-12 Thread Greg KH
On Tue, Apr 12, 2016 at 02:43:36PM +0300, Heikki Krogerus wrote: > + ucsi.usb_data_role= Ick, this isn't the 1990's anymore, please don't use module parameters for anything that is required for a driver. Make it automatic if at all possible, and if not, then make it at the least, a per-device

Re: [PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space

2016-04-12 Thread Sergei Shtylyov
Hello. On 4/12/2016 2:10 PM, changbin...@intel.com wrote: From: "Du, Changbin" For DWC3 USB controller, the Global Debug Queue/FIFO Space Available Register(GDBGFIFOSPACE) can be used to dump FIFO/Queue available space. Space needed before (. This can be used to check some special issu

[PATCH] usb: Add driver for UCSI

2016-04-12 Thread Heikki Krogerus
USB Type-C Connector System Software Interface (UCSI) is specification that defines the registers and data structures that can be used to control USB Type-C ports on a system. UCSI is used on several Intel Broxton SoC based platforms. Things that UCSI can be used to control include at least USB Dat

[PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space

2016-04-12 Thread changbin . du
From: "Du, Changbin" For DWC3 USB controller, the Global Debug Queue/FIFO Space Available Register(GDBGFIFOSPACE) can be used to dump FIFO/Queue available space. This can be used to check some special issues, like whether data is successfully copied from memory to fifo when a trb is blocked. Sig

[PATCH v4 0/2] Add a new debugfs entry to dump FIFO/Queue available space

2016-04-12 Thread changbin . du
From: "Du, Changbin" FIFO/Queue available space info can be used to debug dwc3 issues. First we remove unnecessary checking for debugfs api call, then add the new entry. Du, Changbin (2): usb: dwc3: make dwc3_debugfs_init return value be void usb: dwc3: add debugfs node to dump FIFO/Queue av

[PATCH v4 1/2] usb: dwc3: make dwc3_debugfs_init return value be void

2016-04-12 Thread changbin . du
From: "Du, Changbin" Debugfs init failure is not so important. We can continue our job on this failure. Also no break need for debugfs_create_file call failure. Signed-off-by: Du, Changbin --- v4: Do not fail silently, but print error. --- drivers/usb/dwc3/core.c| 10 + drivers/

[PATCH v2 2/2] USB: uas: Add a new NO_REPORT_LUNS quirk

2016-04-12 Thread Hans de Goede
Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with an usb-id of: 0bc2:331a, as these will fail to respond to a REPORT_LUNS command. Cc: sta...@vger.kernel.org Reported-and-tested-by: David Webb Signed-off-by: Hans de Goede --- Changes in v2: -Document new j quirk in Documentation/

[PATCH v2 1/2] USB: uas: Limit qdepth at the scsi-host level

2016-04-12 Thread Hans de Goede
Commit 64d513ac31bd ("scsi: use host wide tags by default") causes the SCSI core to queue more commands then we can handle on devices with multiple LUNs, limit the queue depth at the scsi-host level instead of per slave to fix this. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1315013 Cc:

Re: [PATCH v2 1/2] dt/bindings/usb: Add bindings for PIC32 MUSB driver.

2016-04-12 Thread Purna Chandra Mandal
On 04/11/2016 08:40 PM, Rob Herring wrote: > On Thu, Apr 07, 2016 at 06:02:59PM +0530, Purna Chandra Mandal wrote: >> Document devicetree binding for the USB controller >> and USB Phy found on Microchip PIC32 class devices. >> >> Signed-off-by: Purna Chandra Mandal >> >> --- >> >> Changes in v2:

Re: [PATCH v3] usb: dwc3: fix memory leak of dwc->regset

2016-04-12 Thread Felipe Balbi
Hi, changbin...@intel.com writes: > From: "Du, Changbin" > > dwc->regset is allocated on dwc3_debugfs_init, and should > be released on init failure or dwc3_debugfs_exit. Btw, > The line "dwc->root = NULL" is unnecessary, so remove it. > > Signed-off-by: Du, Changbin > --- I've modifed the pat

[PATCH v3] usb: dwc3: fix memory leak of dwc->regset

2016-04-12 Thread changbin . du
From: "Du, Changbin" dwc->regset is allocated on dwc3_debugfs_init, and should be released on init failure or dwc3_debugfs_exit. Btw, The line "dwc->root = NULL" is unnecessary, so remove it. Signed-off-by: Du, Changbin --- v3: remove unnecessary if(!NULL) for free v2: Title changed; free

[PATCH 3/3] usb: dwc3: gadget: Fix suspend/resume during device mode

2016-04-12 Thread Roger Quadros
Gadget controller might not be always active during system suspend/resume as gadget driver might not have yet been loaded or might have been unloaded prior to system suspend. Check if we're active and only then perform necessary actions during suspend/resume. Signed-off-by: Roger Quadros --- dr

Re: [PATCH v2] usb: dwc3: fix memory leak of dwc->regset

2016-04-12 Thread Felipe Balbi
Hi, changbin...@intel.com writes: > From: "Du, Changbin" > > dwc->regset is allocated on dwc3_debugfs_init, and should > be released on init failure or dwc3_debugfs_exit. Btw, > The line "dwc->root = NULL" is unnecessary, so remove it. > > Signed-off-by: Du, Changbin > --- > v2: > Title chang

Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during dual-role mode

2016-04-12 Thread Roger Quadros
On 12/04/16 11:00, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> On 11/04/16 16:26, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros writes: On 11/04/16 15:23, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> Gadget controller might not be alway

[PATCH v2] usb: dwc3: fix memory leak of dwc->regset

2016-04-12 Thread changbin . du
From: "Du, Changbin" dwc->regset is allocated on dwc3_debugfs_init, and should be released on init failure or dwc3_debugfs_exit. Btw, The line "dwc->root = NULL" is unnecessary, so remove it. Signed-off-by: Du, Changbin --- v2: Title changed; free dwc->regset on failure path. --- drivers/

Re: [PATCH v5 1/2] USB: serial: cp210x: Adding GPIO support for CP2105

2016-04-12 Thread Martyn Welch
On 12/04/16 09:08, Johan Hovold wrote: On Tue, Apr 12, 2016 at 09:01:52AM +0100, Martyn Welch wrote: Johan, Thanks for reviewing the other patch in this series. I haven't seen any feedback regarding this patch, is it still in your queue? It is, and I will get to it. I've managed to gather s

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

2016-04-12 Thread Felipe Balbi
Hi, "Du, Changbin" writes: > Hi, Balbi, > >> > Hmm, I agree from this point. I will combine this patch with other two >> patches >> > (due to their dependency). And I'd like remove the 'dwc->root=NULL' as >> well, >> >> you are creating a dependency that doesn't exist. Please stop that. You >>

Re: [PATCH v5 1/2] USB: serial: cp210x: Adding GPIO support for CP2105

2016-04-12 Thread Johan Hovold
On Tue, Apr 12, 2016 at 09:01:52AM +0100, Martyn Welch wrote: > Johan, > > Thanks for reviewing the other patch in this series. I haven't seen any > feedback regarding this patch, is it still in your queue? It is, and I will get to it. I've managed to gather some review backlog this past month t

Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during dual-role mode

2016-04-12 Thread Felipe Balbi
Hi, Roger Quadros writes: > On 11/04/16 16:26, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >>> On 11/04/16 15:23, Felipe Balbi wrote: Hi, Roger Quadros writes: > Gadget controller might not be always active during suspend/ > resume when we are operat

Re: [PATCH v5 1/2] USB: serial: cp210x: Adding GPIO support for CP2105

2016-04-12 Thread Martyn Welch
Johan, Thanks for reviewing the other patch in this series. I haven't seen any feedback regarding this patch, is it still in your queue? Martyn On 29/03/16 17:47, Martyn Welch wrote: This patch adds support for the GPIO found on the CP2105. Unlike the GPIO provided by some of the other devic

[PATCH] usb: host: xhci-plat: add firmware for the R-Car M3-W xHCI controllers

2016-04-12 Thread Yoshihiro Shimoda
This patch adds a firmware for the USB 3.0 host controllers of Renesas R-Car M3-W SoC. - This firmware is possible to be used on R-Car H2 and M2. However, this version causes performance degradation on such SoCs. - This firmware is impossible to be used on R-Car H3 because data transfer mi

Re: [RFC] Change bcdUSB in older kernels to return 0x0310 for SuperSpeed

2016-04-12 Thread Bjørn Mork
John Youn writes: > Hi, > > I would like to port the following commit from 4.6 to older kernels. > > 1a85329171094951956a37acc8abb7e51c1e742e ("usb: gadget: composite: > Return bcdUSB 0x0310") > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=1a85329171094951956a37acc

Re: [PATCH v5 1/4] leds: core: add generic support for RGB Color LED's

2016-04-12 Thread Jacek Anaszewski
On 04/09/2016 06:01 PM, Pavel Machek wrote: Hi! What's tricky about patterns is that you need to control 3 (or more) leds at a time. Problem you are trying to solve here is ... control of 3 leds, at the same time. So let's solve them together. OK, now I've got your point. So we'd need to hav

RE: [PATCH] usb: host: xhci-plat: add firmware for the R-Car M3 xHCI controllers

2016-04-12 Thread Yoshihiro Shimoda
Hi Geert-san, > -Original Message- > From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com] On > Behalf Of Geert Uytterhoeven > Sent: Tuesday, April 12, 2016 3:55 PM > To: Yoshihiro Shimoda > Cc: linux-firmw...@kernel.org; USB list ; > linux-renesas-...@vger.kernel.org

Re: [PATCH 0/7] usb: host: add support for threaded IRQs

2016-04-12 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: > On Mon, Apr 11, 2016 at 03:44:09PM +0300, Felipe Balbi wrote: >> Hi guys, >> >> this patchset introduces support for threaded IRQs >> for host controllers drivers to use. Right now, only >> XHCI has been converted, but more drivers could >> easily be converted a