Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Felipe Balbi
Hi, On Sat, Sep 27, 2014 at 01:05:46AM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Friday, September 26, 2014 5:54 PM > > > > On Fri, Sep 26, 2014 at 11:18:48PM +, Paul Zimmerman wrote: > > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > > Sent: Frid

RE: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, September 26, 2014 5:54 PM > > On Fri, Sep 26, 2014 at 11:18:48PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Friday, September 26, 2014 2:40 PM > > > > > > On Fri, Sep 26, 2014 at 08:57:19PM +00

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Felipe Balbi
Hi, On Fri, Sep 26, 2014 at 11:18:48PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Friday, September 26, 2014 2:40 PM > > > > On Fri, Sep 26, 2014 at 08:57:19PM +, Paul Zimmerman wrote: > > > > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3

RE: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, September 26, 2014 2:40 PM > > On Fri, Sep 26, 2014 at 08:57:19PM +, Paul Zimmerman wrote: > > > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > > > > index 0fcc0a3..8277065 100644 > > > > --- a/drivers/usb/dwc3/

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Felipe Balbi
Hi, On Fri, Sep 26, 2014 at 08:57:19PM +, Paul Zimmerman wrote: > > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > > > index 0fcc0a3..8277065 100644 > > > --- a/drivers/usb/dwc3/gadget.c > > > +++ b/drivers/usb/dwc3/gadget.c > > > @@ -2635,6 +2635,7 @@ static irqreturn_

[PATCH v4 3/3] ARM: shmobile: henninger: enable USB PHY

2014-09-26 Thread Sergei Shtylyov
Enable USB PHY device for the Henninger board. Signed-off-by: Sergei Shtylyov --- Changes in version 4: - refreshed the patch. Changes in version 3: - refreshed the patch. arch/arm/boot/dts/r8a7791-henninger.dts |4 1 file changed, 4 insertions(+) Index: renesas/arch/arm/boot/dts/r8

[PATCH v4 2/3] ARM: shmobile: koelsch: enable USB PHY

2014-09-26 Thread Sergei Shtylyov
Enable USB PHY device for the Koelsch board. Signed-off-by: Sergei Shtylyov --- Changes in version 4: - refreshed the patch. Changes in version 3: - refreshed the patch. Changes in version 2: - fixed the wrong board name in the changelog; - refreshed the patch. arch/arm/boot/dts/r8a7791-koel

[PATCH v4 1/3] ARM: shmobile: r8a7791: add USB PHY DT support

2014-09-26 Thread Sergei Shtylyov
Define the R8A7791 generic part of the USB PHY device node. It is up to the board file to enable the device. Signed-off-by: Sergei Shtylyov --- Changes in version 4: - refreshed the patch. Changes in version 3: - changed subnodes of the USB PHY node to be per-channel; - changed "renesas,phy-sel

[PATCH v4 0/3] Add USB PHY device tree support for R8A7791/Koelsch/Henninger board

2014-09-26 Thread Sergei Shtylyov
Hello. Here's the set of 3 patches against Simon Horman's 'renesas.git' repo, 'renesas-devel-20140924-v3.17-rc6' tag. Here we add the USB PHY device tree support on the R8A7791/Koelsch/Henninger boards. The patchset requires the USB PHY driver already merged by Kishon and Greg in order to work,

[PATCH v4 2/2] ARM: shmobile: lager: enable USB PHY

2014-09-26 Thread Sergei Shtylyov
Enable USB PHY device for the Lager board. Signed-off-by: Sergei Shtylyov --- Changes in version 4: - refreshed the patch. Changes in version 3: - refreshed the patch. Changes in version 2: - refreshed the patch. arch/arm/boot/dts/r8a7790-lager.dts |4 1 file changed, 4 insertions(

[PATCH v4 1/2] ARM: shmobile: r8a7790: add USB PHY DT support

2014-09-26 Thread Sergei Shtylyov
Define the R8A7790 generic part of the USB PHY device node. It is up to the board file to enable the device. Signed-off-by: Sergei Shtylyov --- Changes in version 4: - refreshed the patch. Changes in version 3: - changed subnodes of the USB PHY node to be per-channel; - changed "renesas,phy-sel

RE: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Paul Zimmerman
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi Sent: Thursday, September 25, 2014 7:51 AM > On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > > index 0fcc0a3

[PATCH v4 0/2] Add USB PHY device tree support for R8A7790/Lager board

2014-09-26 Thread Sergei Shtylyov
Hello. Here's the set of 2 patches against Simon Horman's 'renesas.git' repo, 'renesas-devel-20140924-v3.17-rc6' tag. Here we add the USB PHY device tree support on the R8A7790/Lager reference board. The patchset requires the USB PHY driver already merged by Kishon and Greg in order to work, so

Re: [PATCH net] r8152: fix the carrier off when autoresuming

2014-09-26 Thread David Miller
From: Hayes Wang Date: Tue, 23 Sep 2014 16:31:47 +0800 > netif_carrier_off would be called when autoresuming, even though > the cable is plugged. This causes some applications do relative > actions when detecting the carrier off. Keep the status of the > carrier, and let it be modified when the l

[PATCH v2 1/6] libusbg: Add udc structure

2014-09-26 Thread Krzysztof Opasiak
Add structure to store informations about available udcs instead of using their names as a string. Signed-off-by: Krzysztof Opasiak --- include/usbg/usbg.h | 14 src/usbg.c | 94 +++ 2 files changed, 108 insertions(+) diff --

[PATCH v2 5/6] libusbg: Allow to get gadget enabled on given UDC

2014-09-26 Thread Krzysztof Opasiak
Add usbg_get_udc_gadget() which allows user to learn which gadget is attached to selected UDC. Signed-off-by: Krzysztof Opasiak --- include/usbg/usbg.h |7 +++ src/usbg.c | 28 2 files changed, 35 insertions(+) diff --git a/include/usbg/usbg.h b/i

[PATCH v2 2/6] libusbg: Replace usbg_get_udcs() with loop

2014-09-26 Thread Krzysztof Opasiak
Library allows to iterate over each gadget using loop. To be consistent with this convention add similar loop for UDCs. Signed-off-by: Krzysztof Opasiak --- include/usbg/usbg.h | 31 --- src/usbg.c | 49 +++-- 2

[PATCH v2 4/6] libusbg: Refresh gadget UDC while each usbg_get_gadget_udc()

2014-09-26 Thread Krzysztof Opasiak
Kernel may decide to detach our gadget in some cases. A good example is when FFS daemon received a SIGSEGV and all descriptors has been closed. To avoid returning false informations to user we have to refresh UDC attribute before returning cached pointer to usbg_udc. Signed-off-by: Krzysztof Opas

[PATCH v2 6/6] libusbg: Add example how to use usbg_udc structure

2014-09-26 Thread Krzysztof Opasiak
This example shows how to learn what udcs are available in system and also how to find out what gadgets are enabled on them. Signed-off-by: Krzysztof Opasiak --- examples/Makefile.am |3 ++- examples/show-udcs.c | 61 ++ 2 files changed, 63 i

[PATCH v2 3/6] libusbg: Rework API to use usbg_udc structure

2014-09-26 Thread Krzysztof Opasiak
Using string as udc identifier provides a lot of troubles. To be more consistent with rest of API rework it to start using usbg_udc structure instead of using char *. Signed-off-by: Krzysztof Opasiak --- examples/gadget-vid-pid-remove.c | 12 ++--- examples/show-gadgets.c | 15 -

[PATCH v2 0/6] libusbg: Add usbg_udc structure

2014-09-26 Thread Krzysztof Opasiak
Dear Matt, This series adds usbg_udc structure to remove direct udc name usage. Before this series UDC didn't have its own structure. Gadget enable took const char * as parameter. Such approach is inconsisten with rest of API. This series introduce structure usbg_udc as abstraction of UDC. This

[PATCH 10/12] libusbg: Make usbg_lookup_function_type() publicly available

2014-09-26 Thread Krzysztof Opasiak
Users of library may often receive function type as a string. Instead of implementing parsing of such string in each program it would be more convenient to provide such support in library. Signed-off-by: Krzysztof Opasiak --- include/usbg/usbg.h |7 +++ src/usbg.c |2 +- 2 f

[PATCH 03/12] libusbg: doc: Fix typos in doxygen documentation

2014-09-26 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak --- include/usbg/usbg.h | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/include/usbg/usbg.h b/include/usbg/usbg.h index a934a7b..fe0e019 100644 --- a/include/usbg/usbg.h +++ b/include/usbg/usbg.h @@

[PATCH 08/12] libusbg: Allow to set all gadget attrs using one function.

2014-09-26 Thread Krzysztof Opasiak
Having specialized functions for each attribute may be sometime inconvenient to use. Provide also function whihc allows to set attribute selected by parameter. Signed-off-by: Krzysztof Opasiak --- include/usbg/usbg.h | 53 + src/usbg.c | 73 ++

[PATCH 00/12] libusbg: Fixes and small API improvements

2014-09-26 Thread Krzysztof Opasiak
Dear Matt, This series fixes a lot of bugs and makes API usage easier. First two commits contains contains a difference between libubsg/libusbg and kopasiak/libusbg repository. List of fixed issues: - doxygen typos - Off-by-one error in usbg_get_function_type_str() - remove unused variables - Al

[PATCH 01/12] libusbg: Return USBG_ERROR_PATH_TOO_LONG error when it happens

2014-09-26 Thread Krzysztof Opasiak
From: Philippe De Swert Signed-off-by: Philippe De Swert Acked-by: Krzysztof Opasiak Signed-off-by: Krzysztof Opasiak Update commit message. Signed-off-by: Krzysztof Opasiak --- src/usbg.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/usbg.c b/src/usbg.c ind

[PATCH 12/12] libusbg: Don't print errno when it has not been directly set

2014-09-26 Thread Krzysztof Opasiak
Replace ERRORNO() macro with ERROR(). Difference betwen them is that ERRORNO() prints also standard error string based on errno value. This variable should not be accessed when called function doesn't directly set it. Signed-off-by: Krzysztof Opasiak --- src/usbg.c |8 1 file change

[PATCH 05/12] libusbg: fix: Remove unused variables

2014-09-26 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak --- src/usbg.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/usbg.c b/src/usbg.c index f12a4b3..9c9b51f 100644 --- a/src/usbg.c +++ b/src/usbg.c @@ -3125,7 +3125,6 @@ static int usbg_export_gadget_prep(usbg_gadget *g, co

[PATCH 06/12] libusbg: Always add '\0' at end of string

2014-09-26 Thread Krzysztof Opasiak
strncpy() may not append trailing '\0' so let's append it always at end of string to avoid getting into troubles. Signed-off-by: Krzysztof Opasiak --- src/usbg.c | 72 ++-- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/s

[PATCH 09/12] libusbg: Return suitable error codes instead of -1

2014-09-26 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak --- src/usbg.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/usbg.c b/src/usbg.c index cd2179e..4d74a0d 100644 --- a/src/usbg.c +++ b/src/usbg.c @@ -316,18 +316,15 @@ static int usbg_lookup_function_type(const char *name)

[PATCH 02/12] libusbg: fix: reverse comparsion to fix error

2014-09-26 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak --- src/usbg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/usbg.c b/src/usbg.c index bbba689..d2ec246 100644 --- a/src/usbg.c +++ b/src/usbg.c @@ -2058,7 +2058,7 @@ int usbg_create_config(usbg_gadget *g, int id, const char *label,

[PATCH 04/12] libusbg: Fix off-by-one error.

2014-09-26 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak --- src/usbg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/usbg.c b/src/usbg.c index d2ec246..f12a4b3 100644 --- a/src/usbg.c +++ b/src/usbg.c @@ -319,7 +319,7 @@ static int usbg_lookup_function_type(const char *name) const const

[PATCH 11/12] libusbg: Add own name to AUTHORS file.

2014-09-26 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak --- AUTHORS |2 ++ 1 file changed, 2 insertions(+) diff --git a/AUTHORS b/AUTHORS index f9b069c..6fea705 100644 --- a/AUTHORS +++ b/AUTHORS @@ -1 +1,3 @@ Matt Porter +Krzysztof Opasiak + -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubsc

[PATCH 07/12] libusbg: Simplify getting names form library structures

2014-09-26 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak Changes since v1: Fix show-gadgets example: get attributes before dereferencing them Reported-by: Philippe De Swert Signed-off-by: Krzysztof Opasiak --- examples/show-gadgets.c | 42 include/usbg/usbg.h | 70 +++

Re: g_mass_storage & READ_CAPACITY(16)

2014-09-26 Thread Felipe Balbi
Hi, On Fri, Sep 26, 2014 at 11:15:03AM -0500, Felipe Balbi wrote: > On Fri, Sep 26, 2014 at 12:06:00PM -0400, Alan Stern wrote: > > > Any hints will be appreciated. > > > > We could implement READ CAPACITY(16) if necessary. But since we don't > > implement READ(16) or WRITE(16), it seems rather

Re: g_mass_storage & READ_CAPACITY(16)

2014-09-26 Thread Felipe Balbi
On Fri, Sep 26, 2014 at 12:06:00PM -0400, Alan Stern wrote: > > Any hints will be appreciated. > > We could implement READ CAPACITY(16) if necessary. But since we don't > implement READ(16) or WRITE(16), it seems rather pointless. > > Are you certain you are interpreting the USBCV output correc

Re: g_mass_storage & READ_CAPACITY(16)

2014-09-26 Thread Alan Stern
On Fri, 26 Sep 2014, Felipe Balbi wrote: > Hi Alan, > > it seems like newer versions of USB20CV will fail us on the MSC tests > unless we support READ_CAPACITY(16). How is that possible? The USB Mass-Storage Class spec doesn't require the device to support any particular set of SCSI commands.

Re: g_mass_storage bug ?

2014-09-26 Thread Felipe Balbi
On Thu, Sep 25, 2014 at 06:12:51PM -0500, Felipe Balbi wrote: > Hi, > > On Thu, Sep 25, 2014 at 09:57:59PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > > > > On Thu, Sep 25, 2014 at 07:08:12PM +, Paul Zimmerman wrote: > > > > > From: Alan Stern [mailto:st.

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-26 Thread Felipe Balbi
Hi, On Fri, Sep 26, 2014 at 09:20:54AM +0200, Arnd Bergmann wrote: > On Thursday 25 September 2014 19:39:34 Felipe Balbi wrote: > > > > > > why would a glue layer need to access registers from the core ? That > > > sounds very odd. I haven't seen that and will, definitely, NACK such a > > > patch

g_mass_storage & READ_CAPACITY(16)

2014-09-26 Thread Felipe Balbi
Hi Alan, it seems like newer versions of USB20CV will fail us on the MSC tests unless we support READ_CAPACITY(16). There is one detail though, looking at the sniffer, CBW comes as: 55 53 42 43 43 59 45 4C 00 00 00 00 00 00 0A 2F 00 00 00 00 00 00 00 80 00 00 00 00 00 00 00 so SCSI cmd opcode i

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Felipe Balbi
Hi, On Fri, Sep 26, 2014 at 09:35:21AM -0500, Felipe Balbi wrote: > This is just because I don't have access to the HW myself, so I can't > verify your patches. One thing I can tell you, with my testing/next, > dwc3 is really stable. I have every test passing except for Halt > Endpoint which I'm d

Re: [PATCH 1/2] USB: EHCI: add portpower callback and override

2014-09-26 Thread Alan Stern
On Fri, 26 Sep 2014, Michael Grzeschik wrote: > The current EHCI implementation is prepared to toggle the > PORT_POWER bit to enable or disable a USB-Port. In some > cases this port power can not be toggled by the PORT_POWER > bit but instead i.e. by an external GPIO. > This patch adds an callback

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Felipe Balbi
On Fri, Sep 26, 2014 at 04:50:26PM +0800, Huang Rui wrote: > On Thu, Sep 25, 2014 at 09:50:32AM -0500, Felipe Balbi wrote: > > Hi, > > > > On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > index b0f4d52..6138c5d 10

Re: [RFC PATCH 4/4] usb: dwc3: introduce dual role switch function with debugfs

2014-09-26 Thread Felipe Balbi
Hi, On Fri, Sep 26, 2014 at 05:22:09PM +0800, Huang Rui wrote: > > What you need here is something to talk to usbcore and udc-core and > > orchestrate the mode change through usb_add_hcd()/usb_add_gadget_udc() > > and their counterparts. > > > > George Cherian is already working on a version of t

[PATCH 2/2] usb: chipidea: add portpower override for host and use it

2014-09-26 Thread Michael Grzeschik
This patch adds an external portpower override callback. It can be used by the ehci-hub to toggle the PORT_POWER by the registered regulator. That is needed when an external GPIO is used instead of the default PORT_POWER bit. Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/host.c | 69

[PATCH 0/2] Add portpower callback to ehci-hub

2014-09-26 Thread Michael Grzeschik
This series adds an portpower callback that can be triggered additionaly to the PORT_POWER ehci bit. With that we are able to toggle an external registered regulator i.e. fixed GPIO. The first user is the chipidea-host to toggle the regulator. This series is based on v3.17-rc6. Thanks, Michael

[PATCH 1/2] USB: EHCI: add portpower callback and override

2014-09-26 Thread Michael Grzeschik
The current EHCI implementation is prepared to toggle the PORT_POWER bit to enable or disable a USB-Port. In some cases this port power can not be toggled by the PORT_POWER bit but instead i.e. by an external GPIO. This patch adds an callback to be triggered as well. The host needs to assign a capa

Re: [PATCH 5/6] HID: hid-sensor-hub: use mfd_add_hotplug_devices helper

2014-09-26 Thread Jiri Kosina
On Fri, 26 Sep 2014, Johan Hovold wrote: > Use mfd_add_hotplug_devices helper to register the subdevices. > > Compile-only tested. > > Signed-off-by: Johan Hovold As I expect this to be going through MFD tree together with the rest of the patchset Acked-by: Jiri Kosina > --- > driv

[PATCH 1/6] mfd: viperboard: fix platform-device id collision

2014-09-26 Thread Johan Hovold
Allow more than one viperboard to be connected by registering with PLATFORM_DEVID_AUTO instead of PLATFORM_DEVID_NONE. The subdevices are currently registered with PLATFORM_DEVID_NONE, which will cause a name collision on the platform bus when a second viperboard is plugged in: viperboard 1-2.4:1

[PATCH 5/6] HID: hid-sensor-hub: use mfd_add_hotplug_devices helper

2014-09-26 Thread Johan Hovold
Use mfd_add_hotplug_devices helper to register the subdevices. Compile-only tested. Signed-off-by: Johan Hovold --- drivers/hid/hid-sensor-hub.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c index 2ac25760

[PATCH 3/6] mfd: core: add helper function to register hotplug devices

2014-09-26 Thread Johan Hovold
Hot-pluggable multi-function devices should always be registered with PLATFORM_DEVID_AUTO to avoid name collisions on the platform bus. This helper also hides the memory map and irq parameters, which aren't used by hot-pluggable (e.g. USB-based) devices. Signed-off-by: Johan Hovold --- include/l

[PATCH 4/6] mfd: use mfd_add_hotplug_devices helper

2014-09-26 Thread Johan Hovold
Use mfd_add_hotplug_devices helper to register the subdevices. Signed-off-by: Johan Hovold --- drivers/mfd/rtsx_usb.c | 4 ++-- drivers/mfd/viperboard.c | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/rtsx_usb.c b/drivers/mfd/rtsx_usb.c index 78073e4b87e4.

[PATCH 2/6] mfd: rtsx_usb: fix platform device-id collision

2014-09-26 Thread Johan Hovold
Hot-pluggable multi-function devices should use PLATFORM_DEVID_AUTO to avoid name collisions on the platform bus. This driver currently uses the USB-device address as an id. This makes name collisions unlikely, but it could still happen if two devices are connected to separate buses and gets assig

[PATCH 6/6] mfd: core: fix platform-device id generation

2014-09-26 Thread Johan Hovold
Make sure to always honour multi-function devices registered with PLATFORM_DEVID_NONE (-1) or PLATFORM_DEVID_AUTO (-2) as id base. In this case it does not make sense to append the cell id to the mfd-id base and potentially change the requested behaviour. Specifically this will allow multi-functio

[PATCH 0/6] mfd: fix platform-device id collisions

2014-09-26 Thread Johan Hovold
Hot-pluggable multi-function devices should always be registered with PLATFORM_DEVID_AUTO to avoid name collisions on the platform bus. This series fix the two mfd drivers that currently fail to get this right, and also adds a new helper function to assist any future driver authors. Included is a

Re: [RFC PATCH 1/4] usb: dwc3: add AMD NL support

2014-09-26 Thread Huang Rui
On Fri, Sep 26, 2014 at 12:26:05AM -0500, Felipe Balbi wrote: > Hi, > > On Fri, Sep 26, 2014 at 12:53:21PM +0800, Huang Rui wrote: > > On Thu, Sep 25, 2014 at 09:53:55AM -0500, Felipe Balbi wrote: > > > On Thu, Sep 25, 2014 at 03:21:44PM +0800, Huang Rui wrote: > > > > Add PCI device ID of AMD NL.

Re: [RFC PATCH 4/4] usb: dwc3: introduce dual role switch function with debugfs

2014-09-26 Thread Huang Rui
On Thu, Sep 25, 2014 at 09:53:20AM -0500, Felipe Balbi wrote: > Hi, > > On Thu, Sep 25, 2014 at 03:21:47PM +0800, Huang Rui wrote: > > This patch implemented a feature to dynamic switch to host or device > > role under debugfs for some physical limitation that unable to > > leverage connector A/B

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-26 Thread Huang Rui
On Thu, Sep 25, 2014 at 09:50:32AM -0500, Felipe Balbi wrote: > Hi, > > On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > index b0f4d52..6138c5d 100644 > > --- a/drivers/usb/dwc3/core.c > > +++ b/drivers/usb/dwc3/core.

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-26 Thread Arnd Bergmann
On Thursday 25 September 2014 19:39:34 Felipe Balbi wrote: > > > > why would a glue layer need to access registers from the core ? That > > sounds very odd. I haven't seen that and will, definitely, NACK such a > > patch > > > > can you further describe why you think a glue layer might need to a

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-26 Thread Arnd Bergmann
On Friday 26 September 2014 08:23:40 Peter Chen wrote: > In current chipidea structure, the parent (glue layer) driver will not be > used for dma, udc/host driver uses dma mask from child (core layer), at core > layer we will do: > > > pdev->dev.dma_mask = dev->dma_mask; /* this device is