On Fri, 26 Sep 2014, Michael Grzeschik wrote: > The current EHCI implementation is prepared to toggle the > PORT_POWER bit to enable or disable a USB-Port. In some > cases this port power can not be toggled by the PORT_POWER > bit but instead i.e. by an external GPIO. > This patch adds an callback to be triggered as well. > The host needs to assign a capable portpower callback.
The idea is reasonable enough, I suppose (but where does this stop? Before you know it, every function normally carried out by the host controller will actually be handled by a platform-specific piece of hardware!) The implementation leaves something to be desired. Instead of keeping the current port-power code in ehci-hcd inline, as it is, you should define a default callback routine to do the work. Then the override can replace the default callback. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
