"len" comes from the USB transfer and it's probably correct. The thing
is that we already have similar checks like:
if (data[i] >= serial->num_ports) {
So adding a sanity test here matches the rest of the code and is a good
idea.
Signed-off-by: Dan Carpenter
---
v2: No change. Rebased
We can remove the "if (urb->actual_length) {" check because checking for
"while (i < urb->actual_length) {" is sufficient. This lets us pull the
code in one indent level.
Signed-off-by: Dan Carpenter
---
v2: do some additional whitespace tweaks suggested by Sergei Shtylyov.
diff --git a/drivers
I have changed my footer settings..
Thanks for informing..
-Puneet
On Thu, 2013-04-04 at 19:30 +0530, Greg KH wrote:
> On Thu, Apr 04, 2013 at 10:07:06AM +0530, Puneet Sharma wrote:
> > Hello,
> >
> > I want to test USB keyboard for XHCI in u-boot and to do that i need the
> > Interrupt transfe
On Thu, Apr 04, 2013 at 12:29:25PM -0700, Sarah Sharp wrote:
> Someone else is already working on a patch to fix part of this:
>
> http://marc.info/?l=linux-usb&m=136509667003716&w=2
>
> Please coordinate with them.
>
> Also, two people trying to solve the same simple bug and using almost
> exac
Hi
>Here's the set of 4 patches against the Simon Horman's 'renesas.git' repo,
> 'renesas-next-20130404v2' tag and the 2 Ether patches I've reposted yesterday.
> It was created to fix the shortcomings in the R8A7779/Marzen USB platform code
> and R8A7779 USB common PHY driver, and so spans bo
On Fri, Apr 05, 2013 at 03:10:38AM +0400, Sergei Shtylyov wrote:
> Since we're now going to setup the USBPCTRL0 register using the USB PHY
> device's
> platform data, we now need a way to pass those platform data from the board
> file
> to the device which is situated in setup-r8a7779.c -- and wh
On Fri, Apr 05, 2013 at 03:05:14AM +0400, Sergei Shtylyov wrote:
> The memory region that is used by the driver overlaps EHCI and OHCI register
> regions for absolutely no reason now -- fix it by adding offset of 0x800 to
> the base address, changing the register #define's accordingly. This has ex
On Fri, Apr 05, 2013 at 03:03:55AM +0400, Sergei Shtylyov wrote:
> Now that the EHCI internal buffer setup is done by the platform code, we can
> remove such code from this driver as it never really belonged here. We also
> no longer need the 2nd memory region now (2nd EHCI controller is simply
On Thu, 4 Apr 2013 11:26:16 -0700
Greg KH wrote:
>
> usbview predates both sysfs and libusb, it used only the usbfs 'devices'
> file when it was created (way back in 1999 or so). That's why it
> doesn't use those apis.
>
> My long-term goal is to merge usbview into usbutils, which does use
> l
Set the USBPCTRL0 register from the passed platform data in rcar_usb_phy_init();
don't reset it to 0 in rcar_usb_phy_shutdown() anymore as that does not make
sense. Also, don't allow the driver's probe to succeed when the platform data
are not supplied with a device.
Signed-off-by: Sergei Shtyl
Since we're now going to setup the USBPCTRL0 register using the USB PHY device's
platform data, we now need a way to pass those platform data from the board file
to the device which is situated in setup-r8a7779.c -- and what I'm suggesting is
r8a7779_add_usb_phy_device() that will register USB PHY
Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong since this
register contains board-specific USB ports configuration and so its value should
be somehow passed via the platform data. Add file with
the USBPCTRL0 bit #define's and 'struct rcar_phy_platform_data' containing the
v
The memory region that is used by the driver overlaps EHCI and OHCI register
regions for absolutely no reason now -- fix it by adding offset of 0x800 to
the base address, changing the register #define's accordingly. This has extra
positive effect that we now can use devm_ioremap_resource().
Signe
Now that the EHCI internal buffer setup is done by the platform code, we can
remove such code from this driver as it never really belonged here. We also
no longer need the 2nd memory region now (2nd EHCI controller is simply missing
in e.g. R8A7778 SoC).
Signed-off-by: Sergei Shtylyov
---
ar
Setup the EHCI internal buffer (before EHCI driver has a chance to touch the
registers) using the init() method in 'struct usb_ehci_pdata'.
Signed-off-by: Sergei Shtylyov
---
arch/arm/mach-shmobile/setup-r8a7779.c | 16
1 file changed, 16 insertions(+)
Index: renesas/arch/ar
(Please CC as I am not subscribed.)
Dear Linux USB folks,
using Debian Wheezy/testing with Linux 3.2.39-2 and
uswsusp 1.0+20110509-3, I see the following problem similar to the one
described in some Ubuntu forum from 2009 [1] or a question from 2012 to
Ask Ubuntu [2].
Running `pm-hibernate` an
Sometimes there is a need to initialize some non-standard registers mapped to
the EHCI region before accessing the standard EHCI registers. Add the init()
method to the 'ehci-platform' platform data for this purpose.
Suggested-by: Kuninori Morimoto
Signed-off-by: Sergei Shtylyov
---
drivers/u
Hello.
Here's the set of 4 patches against the Simon Horman's 'renesas.git' repo,
'renesas-next-20130404v2' tag and the 2 Ether patches I've reposted yesterday.
It was created to fix the shortcomings in the R8A7779/Marzen USB platform code
and R8A7779 USB common PHY driver, and so spans both ar
I wanted to mark this solved send a brief note of thanks.
After a month (off and on) of troubleshooting, your insightful questions helped
to narrow in on the problem and helped me to ultimately determine that it was a
line discipline (somehow) attached to the this ttyACM device each time it was
> -Original Message-
> From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com]
> Sent: Thursday, April 04, 2013 12:29 PM
> To: Vladimir Murzin
> Cc: linux-usb@vger.kernel.org; gre...@suse.de; dse...@gmail.com; Aguirre
> Rodriguez, Sergio A
> Subject: Re: [PATCH] xhci: fix list access befor
When CONFIG_XHCI_HCD_DEBUGGING is activated, the XHCI driver can dump
device and input contexts to the console. The endpoint contexts in that
dump are labeled "Endpoint N Context", where N is DCI - 1... this is
very confusing, especially for people who are not that familiar with
the XHCI specificat
tty_port_tty_get might return a tty which is NULL. But it is
dereferenced unconditionally in edge_send. Stop dereferencing that by
sending usb_serial_port pointer around.
Signed-off-by: Jiri Slaby
Cc: Johan Hovold
Cc: linux-usb@vger.kernel.org
---
drivers/usb/serial/io_ti.c | 9 -
1 fil
On Thu, Apr 04, 2013 at 12:50:03PM -0700, David Cohen wrote:
> On 04/04/2013 12:31 PM, Sarah Sharp wrote:
> >On Thu, Apr 04, 2013 at 10:32:13AM -0700, Sergio Aguirre wrote:
> >>+ INIT_LIST_HEAD(&xhci->lpm_failed_devs);
> >>+ INIT_LIST_HEAD(&xhci->cancel_cmd_list);
> >>+
> >>page_size = xhci
The musb struct is currently allocated along with the hcd, which makes
it difficult to build a driver that only acts as gadget device.
Fix this by allocation musb directly, and keep the hcd around as pointer.
struct hc_driver musb_hc_driver can now also be static to musb_host.c,
and the macro mus
The functionality meant to be represented by this symbol will be
re-added later, but for now, USB_GADGET_MUSB_HDRC is in fact unused and
can be dropped.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/Kconfig | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/usb/gadget/Kconfig
This patch re-introduces the bits that are necessary to use the musb
controller in host mode.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_core.c | 5 +
drivers/usb/musb/musb_host.c | 21 +
drivers/usb/musb/musb_host.h | 8
3 files changed, 34 insertion
Let the function declarations live in the header file the belong to,
which makes it cleaner when they're stubbed out later.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_core.h | 17 -
drivers/usb/musb/musb_gadget.h | 17 +++--
drivers/usb/musb/musb_host.h
This makes building the actual object files optional to the selected
mode, which saves users who know which kind of USB mode support they
need some binary size.
Unimplemented functions are stubbed out with static inline functions.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/Kconfig |
Hi all,
here are some patches to separate the HCD and gadget part of the musb
driver so they can be deselected in Kconfig. They also make the driver
keep track of the configured port mode that is set from DT, so the
actual runtime configuration can be selected dynamically.
One thing that is still
Initialize the host and gagdet subsystems of the musb driver only when
the appropriate mode is selected from platform data, or device-tree
information, respectively.
Refuse to start the gadget part if the port is in host-only mode.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_core.c |
With the hcd is now a direct member of struct musb, we can now simply
eliminate the musb_to_hcd() macro. There aren't that many users left
anyway, as some where already fixed up when parts were factored out to
musb_host.c
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_core.c| 4 ++--
d
On 04/04/2013 12:31 PM, Sarah Sharp wrote:
On Thu, Apr 04, 2013 at 10:32:13AM -0700, Sergio Aguirre wrote:
+ INIT_LIST_HEAD(&xhci->lpm_failed_devs);
+ INIT_LIST_HEAD(&xhci->cancel_cmd_list);
+
page_size = xhci_readl(xhci, &xhci->op_regs->page_size);
xhci_dbg(xhci, "Su
On Thursday 04 April 2013, Felipe Balbi wrote:
> On Thu, Apr 04, 2013 at 01:42:18PM -0400, Alan Stern wrote:
> > > > diff --git a/drivers/usb/misc/sisusbvga/Kconfig
> > > > b/drivers/usb/misc/sisusbvga/Kconfig
> > > > index 30ea7ca..0d03a52 100644
> > > > --- a/drivers/usb/misc/sisusbvga/Kconfig
>
On Thu, Apr 04, 2013 at 10:32:13AM -0700, Sergio Aguirre wrote:
> + INIT_LIST_HEAD(&xhci->lpm_failed_devs);
> + INIT_LIST_HEAD(&xhci->cancel_cmd_list);
> +
> page_size = xhci_readl(xhci, &xhci->op_regs->page_size);
> xhci_dbg(xhci, "Supported page size register = 0x%x\n", page_s
Someone else is already working on a patch to fix part of this:
http://marc.info/?l=linux-usb&m=136509667003716&w=2
Please coordinate with them.
Also, two people trying to solve the same simple bug and using almost
exactly the same commit messages seems like too much of a coincidence.
Are you wo
On Thu, Apr 04, 2013 at 10:10:10PM +0300, Dan Carpenter wrote:
> > + if (buf[0] == 'P' && buf[1] == 'H' && buf[2] == 'Y' &&
> > + buf[3] == 'S' && buf[4] == 'D' &&
> > + buf[5] == 'E' && buf[6] == 'S' && /*isspace(buf[7])*/
> > + buf[7] == ' ') {
On Thu, Apr 04, 2013 at 04:03:04PM +0200, Stefan Reif wrote:
> + switch (status) {
> + case -ENOENT:
> + /* fall through */
> + case -ECONNRESET:
If two case statements are right next to each other then they don't
need a "fall through" commen
Hi,
merci beaucoup to everyone for your work...
Le 04/04/13 20:35, Pete Batard a écrit :
On 2013.04.04 09:27, nico wrote:
Making all in libusb
CC libusb_1_0_la-core.lo
core.c:1755:30: warning: use of logical '&&' with constant operand
Thanks for the report, and the test.
This is now fi
This one could probably have been broken into separate patches.
> + if (buf[0] == 'P' && buf[1] == 'H' && buf[2] == 'Y' &&
> + buf[3] == 'S' && buf[4] == 'D' &&
> + buf[5] == 'E' && buf[6] == 'S' && /*isspace(buf[7])*/
> + buf[7] == ' ')
On 04/04/13 00:22, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20130403:
>
on x86_64, when CONFIG_BUG is not enabled:
CC [M] drivers/usb/gadget/configfs.o
drivers/usb/gadget/configfs.c: In function 'config_usb_cfg_unlink':
drivers/usb/gadget/configfs.c:442:2: error: implicit declara
On 2013.04.04 09:27, nico wrote:
Making all in libusb
CC libusb_1_0_la-core.lo
core.c:1755:30: warning: use of logical '&&' with constant operand
Thanks for the report, and the test.
This is now fixed in RC3, along with a couple minor issues.
The new RC is available from:
http://sourcef
On Thu, Apr 04, 2013 at 04:13:20PM +0200, Stefan Tauner wrote:
> Hi,
>
> I discovered that the optional strings and their indices of interface
> descriptors are not exported in debugfs when I was looking at usbview's
> source (https://github.com/gregkh/usbview/issues/5).
>
> I am not sure yet if
Hi,
On Thu, Apr 04, 2013 at 01:42:18PM -0400, Alan Stern wrote:
> > > diff --git a/drivers/usb/misc/sisusbvga/Kconfig
> > > b/drivers/usb/misc/sisusbvga/Kconfig
> > > index 30ea7ca..0d03a52 100644
> > > --- a/drivers/usb/misc/sisusbvga/Kconfig
> > > +++ b/drivers/usb/misc/sisusbvga/Kconfig
> > >
On 04/04/2013 07:01 AM, Venu Byravarasu wrote:
>> -Original Message-
>> From: Stephen Warren [mailto:swar...@wwwdotorg.org]
>> Sent: Thursday, April 04, 2013 12:47 AM
>> To: Venu Byravarasu
>> Cc: gre...@linuxfoundation.org; ba...@ti.com;
>> st...@rowland.harvard.edu; linux-te...@vger.kerne
On Thu, 4 Apr 2013, Felipe Balbi wrote:
> Hi,
>
> On Thu, Apr 04, 2013 at 05:57:24PM +0200, Florian Fainelli wrote:
> > diff --git a/drivers/usb/misc/sisusbvga/Kconfig
> > b/drivers/usb/misc/sisusbvga/Kconfig
> > index 30ea7ca..0d03a52 100644
> > --- a/drivers/usb/misc/sisusbvga/Kconfig
> > +++
On Thu, 4 Apr 2013, Yegor Yefremov wrote:
> I reworked my test script, so that I can tell timeout from wrong
> string. I have two cases now. On my am335x based system I get timeout
> with 3.2 kernel and errors like here
> (http://www.newit.co.uk/forum/index.php?topic=313.0) for 3.8.
>
> On x86 I
Hi Sergio,
On 04/04/2013 10:32 AM, Sergio Aguirre wrote:
It is possible that we fail on xhci_mem_init, just before doing
the INIT_LIST_HEAD, and calling xhci_mem_cleanup.
Problem is that, the list_for_each_entry_safe macro, assumes
list heads are initialized (not NULL), and dereferences their '
It is possible that we fail on xhci_mem_init, just before doing
the INIT_LIST_HEAD, and calling xhci_mem_cleanup.
Problem is that, the list_for_each_entry_safe macro, assumes
list heads are initialized (not NULL), and dereferences their 'next'
pointer, causing a kernel panic if this is not yet ini
Hi David,
Thanks for the review.
> -Original Message-
> From: Cohen, David A
> Sent: Thursday, April 04, 2013 10:03 AM
> To: Aguirre Rodriguez, Sergio A
> Cc: linux-usb@vger.kernel.org; Sarah Sharp; Kanigeri, Hari K
> Subject: Re: [PATCH v2] xhci: prevent from potential null pointer
> der
Hi,
On Thu, Apr 04, 2013 at 05:57:24PM +0200, Florian Fainelli wrote:
> diff --git a/drivers/usb/misc/sisusbvga/Kconfig
> b/drivers/usb/misc/sisusbvga/Kconfig
> index 30ea7ca..0d03a52 100644
> --- a/drivers/usb/misc/sisusbvga/Kconfig
> +++ b/drivers/usb/misc/sisusbvga/Kconfig
> @@ -1,7 +1,7 @@
>
> -Original Message-
> From: Bjørn Mork [mailto:bj...@mork.no]
> Sent: Thursday, April 04, 2013 10:01 AM
> To: Sarah Sharp
> Cc: Aguirre Rodriguez, Sergio A; linux-usb@vger.kernel.org
> Subject: Re: [PATCH] xhci: prevent from potential null pointer dereference
> on failed init
>
> Sarah Sh
On Thu, 4 Apr 2013, Florian Fainelli wrote:
>
> These 5 patches contain my Kconfig cleanup on which I based the removal
> of the USB_ARCH_HAS_* patches. They have been suggested by Alan Stern
> as part of an earlier conversations.
>
> Let me know what you think about it so I can post subsequent
Sarah Sharp writes:
> Thanks for catching this! However, the inline comment is a bit much for
> a simple NULL pointer check. Can you remove the comment and resubmit
> this patch?
And maybe handle failure to initialize cancel_cmd_list as well? It has
the same problem.
But wouldn't it be better
On Thursday 04 April 2013 19:49:26 Felipe Balbi wrote:
> On Thu, Apr 04, 2013 at 04:52:15PM +0200, Laurent Pinchart wrote:
> > > Laurent/Ming Lei
> > >
> > > > Since the uvc_video_complete() callback handler called from
> > > > interrupt
> > > > context, video post processing or memcpy
Hi Sergio,
On 04/04/2013 09:57 AM, Sergio Aguirre wrote:
It is possible that we fail on xhci_mem_init, just before doing
the INIT_LIST_HEAD, and calling xhci_mem_cleanup.
Problem is that, the list_for_each_entry_safe macro, dereferences next
assuming is not NULL (which is the case for a uniniti
It is possible that we fail on xhci_mem_init, just before doing
the INIT_LIST_HEAD, and calling xhci_mem_cleanup.
Problem is that, the list_for_each_entry_safe macro, dereferences next
assuming is not NULL (which is the case for a uninitialized list).
Let's protect from that.
Signed-off-by: Serg
> -Original Message-
> From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com]
> Sent: Thursday, April 04, 2013 9:33 AM
> To: Aguirre Rodriguez, Sergio A
> Cc: linux-usb@vger.kernel.org
> Subject: Re: [PATCH] xhci: prevent from potential null pointer dereference
> on failed init
>
> Hi Se
Hi,
On Thu, Apr 04, 2013 at 04:52:15PM +0200, Laurent Pinchart wrote:
> > Laurent/Ming Lei
> >
> > > Since the uvc_video_complete() callback handler called from interrupt
> > > context, video post processing or memcpy can be deferred to tasklet or
> > > bottom half, rather than doing
Commits
9574323 xHCI: test USB2 software LPM
b92cc66 xHCI: add aborting command ring function
introduce useful functions which involves lists manipulations.
If for whatever reason we fall into fail path in xhci_mem_init() we
may access the lists in xhci_mem_cleanup() before they ge
* Roger Quadros [130404 00:39]:
> On 04/04/2013 02:42 AM, Tony Lindgren wrote:
> >> --- a/arch/arm/mach-omap2/cclock44xx_data.c
> >> +++ b/arch/arm/mach-omap2/cclock44xx_data.c
> >> @@ -27,6 +27,7 @@
> >> #include
> >> #include
> >> #include
> >> +#include
> >>
> >> #include "soc.h"
> >>
On Thu, Apr 04, 2013 at 01:02:45PM +0530, Vivek Gautam wrote:
> On Thu, Apr 4, 2013 at 12:40 PM, Felipe Balbi wrote:
> > On Thu, Apr 04, 2013 at 10:34:57AM +0530, Vivek Gautam wrote:
> >> Hi Sarah,
> >>
> >>
> >> On Wed, Apr 3, 2013 at 10:57 PM, Sarah Sharp
> >> wrote:
> >> > Question: Do you sti
* Rajendra Nayak [130403 22:25]:
> On Thursday 04 April 2013 05:12 AM, Tony Lindgren wrote:
> >
> > How about just add a minimal drivers/clk/omap/clk-xyz.c that takes
> > the configuration from DT and is based on the binding we already have in
> > Documentation/devicetree/bindings/clock/clock-bin
Hi Sergio,
Thanks for catching this! However, the inline comment is a bit much for
a simple NULL pointer check. Can you remove the comment and resubmit
this patch?
Thanks,
Sarah Sharp
On Wed, Apr 03, 2013 at 03:52:07PM -0700, Sergio Aguirre wrote:
> It is possible that we fail on xhci_mem_init
This patch removes the various depends on USB_OHCI_HCD from the OHCI HCD
drivers and enclose them within an if USB_OHCI_HCD / endif block. The
Octeon OHCI HCD driver has been moved around to remain in this block.
Acked-by: Alan Stern
Signed-off-by: Florian Fainelli
---
Changes in v3:
- added Ala
Thist patch removes the depends on USB_EHCI_HCD that the various USB
EHCI HCD drivers use and encloses every driver within an if USB_EHCI_HCD
/ endif block. The EHCI HCD platform and Octeon drivers have been moved
around to remain enclosed within this block.
Signed-off-by: Florian Fainelli
---
Ch
Just like the OHCI counter part we just can remove the architecture
specific symbols which prevent these configuration symbols from being
selected by platforms/architectures requiring it. The original
implementation did not scale at all since it required each and every
single architecture to be add
This patch removes the depends on USB from all config symbols in
drivers/usb/host/Kconfig and replace that with an if USB / endif block
as suggested by Alan Stern. Some source ... Kconfig lines have been
shuffled around to permit a better regroupment of the Kconfig files
depending on "config USB" i
This patch encloses all symbols depending on USB_XHCI_HCD within an if
USB_XHCI_HCD / endif block.
Acked-by: Alan Stern
Signed-off-by: Florian Fainelli
---
Changes in v3:
- added Alan's Acked-by tag
drivers/usb/host/Kconfig |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff -
These 5 patches contain my Kconfig cleanup on which I based the removal
of the USB_ARCH_HAS_* patches. They have been suggested by Alan Stern
as part of an earlier conversations.
Let me know what you think about it so I can post subsequent work based
on it.
Thanks! Fainelli (5):
USB: regroup a
Hi Alan,
On Thursday 28 March 2013 10:45:27 Alan Stern wrote:
> On Thu, 28 Mar 2013, Laurent Pinchart wrote:
> > The camera fails to start video streaming after having been autosuspend.
> > Add a new quirk to selectively disable autosuspend for devices that
> > don't support it.
> >
> > Signed-of
Hi,
I discovered that the optional strings and their indices of interface
descriptors are not exported in debugfs when I was looking at usbview's
source (https://github.com/gregkh/usbview/issues/5).
I am not sure yet if they are cached (e.g. in rawdescriptors in struct
usb_device or even more con
Hi Ravi,
On Friday 29 March 2013 14:14:35 B, Ravi wrote:
> Laurent/Ming Lei
>
> > Since the uvc_video_complete() callback handler called from interrupt
> > context, video post processing or memcpy can be deferred to tasklet or
> > bottom half, rather than doing it in interrupt context
On Thu, 4 Apr 2013, Felipe Balbi wrote:
> > >> Some subsystems handle this issue by calling pm_runtime_get_sync()
> > >> before probing a driver and pm_runtime_put_sync() after unbinding the
> > >> driver. If the driver is runtime-PM-enabled, it then does its own
> > >> put_sync near the end of i
From: Kurt Kanzenbach
Reformat function stub_recv_cmd_unlink() to improve readability.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Stefan Reif
---
drivers/staging/usbip/stub_rx.c | 98 -
1 file changed, 49 insertions(+), 49 deletions(-)
diff --git a/
replace numbers in code by ascii text constants as suggested
by Dan Carpenter:
http://driverdev.linuxdriverproject.org/pipermail/devel/2013-February/035907.html
Signed-off-by: Stefan Reif
---
drivers/staging/usbip/userspace/libsrc/names.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Kurt Kanzenbach
Enumerations for one comment makes no sense.
This is why this should be removed.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Stefan Reif
---
drivers/staging/usbip/stub_dev.c | 2 +-
drivers/staging/usbip/stub_rx.c | 2 +-
drivers/staging/usbip/vhci_rx.c | 2 +-
3 fil
Code cleanup for the usbip driver.
- delete unused code
- improve readability
- improve usability of the command line tools
Kurt and I did this work together.
Kurt Kanzenbach (10):
staging: usbip: reformat function stub_recv_cmd_unlink()
staging: usbip: removed enumeration of comments
s
re-indent funtion "pickup_urb_and_free_priv" to improve readability.
Signed-off-by: Stefan Reif
---
drivers/staging/usbip/vhci_rx.c | 54 ++---
1 file changed, 29 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/usbip/vhci_rx.c b/drivers/staging/us
From: Kurt Kanzenbach
This for loop is not needed, since STUB_BUSID_OTHER is defined as 0.
In Addition added a comment if STUB_BUSID_OTHER changes sometime.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Stefan Reif
---
drivers/staging/usbip/stub_main.c | 8
1 file changed, 4 insertio
From: Kurt Kanzenbach
The `usbip list -l' command shows your local usb-devices.
Example:
$ usbip list -l
$ Local USB devices
$ =
$ - busid 1-1 (13fe:1d00)
$ 1-1:1.0 -> usb-storage
$
$ - busid 1-2 (0409:55aa)
$ 1-2:1.0 -> hub
However this list command doesn
From: Kurt Kanzenbach
Since no usbip_name function is used in usbipd, it's not
necessary to parse "usb.ids" file at startup.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Stefan Reif
---
drivers/staging/usbip/userspace/src/usbipd.c | 4
1 file changed, 4 deletions(-)
diff --git a/driver
From: Kurt Kanzenbach
In each if-else case "return" is called. This is why
these if-else-statements are useless. Removing them
improves understanding and readability.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Stefan Reif
---
drivers/staging/usbip/stub_main.c | 26 +
From: Kurt Kanzenbach
The command `usbip attach' uses --host for specifing
the remote host, while `usbip list' uses --remote.
This is confusing and this patch adapts this.
In Addition changed the manpage and README accordingly.
Before:
$ usbip attach --host -b
$ usbip list --remote
Now:
$
Remove broken preprocessor macro "hardware". It is unused and it
references an element (pdev in vhci_hcd) that does not exist.
Signed-off-by: Stefan Reif
---
drivers/staging/usbip/vhci.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/usbip/vhci.h b/drivers/staging/usbip/vhci.
From: Kurt Kanzenbach
Since the names.c/names.h are taken from another project, some
functions which names.c provides aren't used by usbipd.
This patch fixes:
- removed useless comments
- unified debug/error messages by using the macros
provided by usbip_common.h
- removed unnused code
The
From: Kurt Kanzenbach
This patch simplified "stub_device_free" cleanup function:
- changed return type to void, since the return value is
not checked anywhere
- kfree is NULL-safe, so removed if statement
- deleted debug-message
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Stefan Reif
-
Fix an indent.
Signed-off-by: Stefan Reif
---
drivers/staging/usbip/usbip_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/usbip_common.c
b/drivers/staging/usbip/usbip_common.c
index 539fa57..7b97df6 100644
--- a/drivers/staging/usbip/usbip_comm
Call freeaddrinfo when connect/listen fails.
Call usbip_host_driver_close on error.
Signed-off-by: Stefan Reif
---
drivers/staging/usbip/userspace/src/usbip_network.c | 4 ++--
drivers/staging/usbip/userspace/src/usbipd.c| 7 ++-
2 files changed, 8 insertions(+), 3 deletions(-)
diff
From: Kurt Kanzenbach
In each errorcase spin_unlock_irq is called and -EINVAL is returned.
To simplify that I created a label called "err" doing that.
On Success count will be returned.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Stefan Reif
---
drivers/staging/usbip/stub_dev.c | 22 +++
On Thu, Apr 04, 2013 at 10:07:06AM +0530, Puneet Sharma wrote:
> Hello,
>
> I want to test USB keyboard for XHCI in u-boot and to do that i need the
> Interrupt transfer code in XHCI controller driver in u-boot. If
> possible, can you help me to give that piece of code or can you help me
> to figu
Hello.
On 04-04-2013 10:33, Dan Carpenter wrote:
We can remove the "if (urb->actual_length) {" check because checking for
"while (i < urb->actual_length) {" is sufficient. This lets us pull the
code in one indent level.
Signed-off-by: Dan Carpenter
diff --git a/drivers/usb/serial/keyspa
> -Original Message-
> From: Stephen Warren [mailto:swar...@wwwdotorg.org]
> Sent: Thursday, April 04, 2013 12:47 AM
> To: Venu Byravarasu
> Cc: gre...@linuxfoundation.org; ba...@ti.com;
> st...@rowland.harvard.edu; linux-te...@vger.kernel.org; linux-
> u...@vger.kernel.org; linux-ker...@vg
On Wed, Apr 3, 2013 at 12:16 PM, Yegor Yefremov
wrote:
> On Wed, Apr 3, 2013 at 9:12 AM, Yegor Yefremov
> wrote:
>> On Tue, Apr 2, 2013 at 4:36 PM, Alan Stern wrote:
>>> On Tue, 2 Apr 2013, Yegor Yefremov wrote:
>>>
On Tue, Apr 2, 2013 at 4:14 PM, Alan Stern
wrote:
> On Tue, 2 A
> -Original Message-
> From: Stephen Warren [mailto:swar...@wwwdotorg.org]
> Sent: Thursday, April 04, 2013 1:06 AM
> To: Venu Byravarasu
> Cc: gre...@linuxfoundation.org; ba...@ti.com;
> st...@rowland.harvard.edu; linux-te...@vger.kernel.org; linux-
> u...@vger.kernel.org; linux-ker...@vge
> -Original Message-
> From: linux-tegra-ow...@vger.kernel.org [mailto:linux-tegra-
> ow...@vger.kernel.org] On Behalf Of Stephen Warren
> Sent: Thursday, April 04, 2013 12:38 AM
> To: Venu Byravarasu
> Cc: gre...@linuxfoundation.org; ba...@ti.com;
> st...@rowland.harvard.edu; linux-te...@v
correcting misleading subject line.
was (Re: MUSB regression in linux next at least for pandboard)
On 04/04/2013 02:36 PM, Roger Quadros wrote:
> Hi,
>
> On 02/07/2013 04:10 PM, Grazvydas Ignotas wrote:
>> On Thu, Feb 7, 2013 at 11:16 AM, Roger Quadros wrote:
>>
>>> It seems the beagleboard pro
Hi,
On 02/07/2013 04:10 PM, Grazvydas Ignotas wrote:
> On Thu, Feb 7, 2013 at 11:16 AM, Roger Quadros wrote:
>
>> It seems the beagleboard problem is related to OMAP silicon errata [1].
>> Apparently, remote wakeup as well as host issued wakeup break omap-ehci and
>> have
>> nothing to do with
Dnia Środa, 3 Kwietnia 2013 21:33 Greg KH
napisał(a)
> On Wed, Apr 03, 2013 at 09:02:50PM +0200, Tomasz Miś wrote:
> > Dnia Środa, 3 Kwietnia 2013 20:26 Greg KH napisał(a)
> > >
> > > A: No.
> > > Q: Should I include quotations after my reply?
> > >
> > > http://daringfireball.net/2007/07/on_t
Hi,
On Thursday 04 April 2013 04:11 PM, Sylwester Nawrocki wrote:
Hi,
On 04/04/2013 11:21 AM, Kishon Vijay Abraham I wrote:
On Thursday 04 April 2013 03:16 AM, Sylwester Nawrocki wrote:
On 04/03/2013 02:53 PM, Kishon Vijay Abraham I wrote:
+4. Getting a reference to the PHY
+
+Before the c
Hi,
On 04/04/2013 11:21 AM, Kishon Vijay Abraham I wrote:
> On Thursday 04 April 2013 03:16 AM, Sylwester Nawrocki wrote:
>> On 04/03/2013 02:53 PM, Kishon Vijay Abraham I wrote:
>>> +4. Getting a reference to the PHY
>>> +
>>> +Before the controller can make use of the PHY, it has to get a
>>> r
1 - 100 of 119 matches
Mail list logo
