On Thu, Apr 04, 2013 at 12:50:03PM -0700, David Cohen wrote:
> On 04/04/2013 12:31 PM, Sarah Sharp wrote:
> >On Thu, Apr 04, 2013 at 10:32:13AM -0700, Sergio Aguirre wrote:
> >>+ INIT_LIST_HEAD(&xhci->lpm_failed_devs);
> >>+ INIT_LIST_HEAD(&xhci->cancel_cmd_list);
> >>+
> >> page_size = xhci_readl(xhci, &xhci->op_regs->page_size);
> >> xhci_dbg(xhci, "Supported page size register = 0x%x\n", page_size);
> >> for (i = 0; i < 16; i++) {
> >>@@ -2333,7 +2336,6 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
> >> xhci->cmd_ring = xhci_ring_alloc(xhci, 1, 1, TYPE_COMMAND, flags);
> >> if (!xhci->cmd_ring)
> >> goto fail;
> >>- INIT_LIST_HEAD(&xhci->cancel_cmd_list);
> >> xhci_dbg(xhci, "Allocated command ring at %p\n", xhci->cmd_ring);
> >> xhci_dbg(xhci, "First segment DMA is 0x%llx\n",
> >> (unsigned long long)xhci->cmd_ring->first_seg->dma);
> >>@@ -2444,8 +2446,6 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
> >> if (xhci_setup_port_arrays(xhci, flags))
> >> goto fail;
> >>- INIT_LIST_HEAD(&xhci->lpm_failed_devs);
> >>-
> >Please don't remove newlines in bug fix patches. Try again?
>
> Isn't it going to have 2 consecutive empty lines otherwise?
Oh, yes, you're right, the initial patch does show that. Why did you
trim newlines in your reply? That was what confused me.
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
