Re: [RFC PATCH 8/9] um: Implement kernel side of SECCOMP based process handling

2024-10-26 Thread Tiwei Bie
On 2024/10/26 20:56, Johannes Berg wrote: > On Sat, 2024-10-26 at 13:04 +0200, Benjamin Berg wrote: +#include >>> >>> Hmm. If this works, why do we have UML_CONFIG_64BIT? For ASM stuff? >> >> So, I just had a quick look. It seems that before commit a95b37e20db9 >> ("kbuild: get out of

Re: [RFC PATCH 8/9] um: Implement kernel side of SECCOMP based process handling

2024-10-26 Thread Johannes Berg
On Sat, 2024-10-26 at 13:04 +0200, Benjamin Berg wrote: > > > > > > +#include > > > > Hmm. If this works, why do we have UML_CONFIG_64BIT? For ASM stuff? > > So, I just had a quick look. It seems that before commit a95b37e20db9 > ("kbuild: get out of ") doing > this would have caused compilat

Re: [RFC PATCH 8/9] um: Implement kernel side of SECCOMP based process handling

2024-10-26 Thread Benjamin Berg
Hi, On Thu, 2024-10-10 at 14:12 +0200, Johannes Berg wrote: > > +++ b/arch/um/os-Linux/skas/process.c > > @@ -1,9 +1,11 @@ > >   // SPDX-License-Identifier: GPL-2.0 > >   /* > > + * Copyright (C) 2021 Benjamin Berg > >    * Copyright (C) 2015 Thomas Meyer (tho...@m3y3r.de) > >    * Copyright (C)

Re: [RFC PATCH 8/9] um: Implement kernel side of SECCOMP based process handling

2024-10-10 Thread Benjamin Berg
On Thu, 2024-10-10 at 14:12 +0200, Johannes Berg wrote: > On Wed, 2024-09-25 at 22:32 +0200, Benjamin Berg wrote: > > > > + /* > > +* If in seccomp mode, install the SECCOMP filter and > > trigger a syscall. > > +* Otherwise set PTRACE_TRACEME and do a SIGSTOP. > > +*/ > > + if (in

Re: [RFC PATCH 8/9] um: Implement kernel side of SECCOMP based process handling

2024-10-10 Thread Johannes Berg
On Wed, 2024-09-25 at 22:32 +0200, Benjamin Berg wrote: > > + /* > + * If in seccomp mode, install the SECCOMP filter and trigger a syscall. > + * Otherwise set PTRACE_TRACEME and do a SIGSTOP. > + */ > + if (init_data.seccomp) { > + struct sock_filter filter[] =