Hi,
On Thu, 2024-10-10 at 14:12 +0200, Johannes Berg wrote:
> > +++ b/arch/um/os-Linux/skas/process.c
> > @@ -1,9 +1,11 @@
> > // SPDX-License-Identifier: GPL-2.0
> > /*
> > + * Copyright (C) 2021 Benjamin Berg <benja...@sipsolutions.net>
> > * Copyright (C) 2015 Thomas Meyer (tho...@m3y3r.de)
> > * Copyright (C) 2002- 2007 Jeff Dike
> > (jdike@{addtoit,linux.intel}.com)
> > */
> >
> > +#include <linux/kconfig.h>
>
> Hmm. If this works, why do we have UML_CONFIG_64BIT? For ASM stuff?
So, I just had a quick look. It seems that before commit a95b37e20db9
("kbuild: get <linux/compiler_types.h> out of <linux/kconfig.h>") doing
this would have caused compilation errors.
With that change, there shouldn't be a reason for the various
UML_CONFIG_* macros anymore. It should be safe to include
linux/kconfig.h (and if we are not allowed to do that, we could still
use generated/autoconf.h).
Maybe we should see this as a cleanup opportunity?
Benjamin
