On 2024/10/26 20:56, Johannes Berg wrote:
> On Sat, 2024-10-26 at 13:04 +0200, Benjamin Berg wrote:
>>>>
>>>> +#include <linux/kconfig.h>
>>>
>>> Hmm. If this works, why do we have UML_CONFIG_64BIT? For ASM stuff?
>>
>> So, I just had a quick look. It seems that before commit a95b37e20db9
>> ("kbuild: get <linux/compiler_types.h> out of <linux/kconfig.h>") doing
>> this would have caused compilation errors.
>
> And that commit was pretty much done for the exact same reason!
>
>> With that change, there shouldn't be a reason for the various
>> UML_CONFIG_* macros anymore. It should be safe to include
>> linux/kconfig.h (and if we are not allowed to do that, we could still
>> use generated/autoconf.h).
>>
>> Maybe we should see this as a cleanup opportunity?
>
> Sounds good to me! That also gives us IS_ENABLED() which can be a nice
> cleanup opportunity too :-)
+1, I also like this idea! :)
Regards,
Tiwei
