Re: [PATCH] mpt2sas: Fall back to 64 bit coherent mask if 64 bit DMA / 32 bit coherent mask not supported

2015-05-13 Thread Arnd Bergmann
On Wednesday 13 May 2015 08:23:41 Brian King wrote: > On 05/13/2015 03:10 AM, Arnd Bergmann wrote: > > On Tuesday 12 May 2015 18:24:43 Brian King wrote: > >> > >> Commit 5fb1bf8aaa832e1e9ca3198de7bbecb8eff7db9c broke 64 bit DMA for > >> mpt2sas on Power. >

[PATCH] [RESEND] SCSI: initio: remove duplicate module device table

2015-05-19 Thread Arnd Bergmann
built-in: drivers/scsi/initio.c:131:29: warning: 'i91u_pci_devices' defined but not used [-Wunused-variable] This removes the extraneous table and the warning. Signed-off-by: Arnd Bergmann Fixes: 72d39fea901 ("[SCSI] initio: Convert into a real Linux driver and update

Re: [PATCH] scsi: debug: fix type mismatch warning for sg_pcopy_from_buffer

2015-05-20 Thread Arnd Bergmann
On Wednesday 20 May 2015 12:53:29 Andrew Morton wrote: > On Tue, 19 May 2015 23:22:39 +0200 Arnd Bergmann wrote: > > > > I can't decide if this is actually a good idea, or if we should rather drop > > the sg_pcopy_from_buffer() patch. Maybe someone else sees a better

Re: [PATCH] scsi: debug: fix type mismatch warning for sg_pcopy_from_buffer

2015-05-21 Thread Arnd Bergmann
t also make the code simpler > > Signed-off-by: Dave Gordon > --- Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] scsi: NCR5380: no longer mark irq probing as __init

2016-10-11 Thread Arnd Bergmann
t and __initdata annotations. Fixes: a8cfbcaec0c1 ("scsi: g_NCR5380: Stop using scsi_module.c") Signed-off-by: Arnd Bergmann --- drivers/scsi/NCR5380.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c index 7053de5bd46

[PATCH] lpfc: use %zd format string for size_t

2016-10-17 Thread Arnd Bergmann
{aka const unsigned int}' [-Werror=format=] 'size_t' is always the same width as 'long' in the kernel, but the compiler doesn't know that. The %z modifier is what the standard expects to be used here, and this shuts up the warning. Fixes: 679053c651fb ("scsi: lpf

[PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency

2016-10-18 Thread Arnd Bergmann
his adds a Kconfig dependency. Fixes: 04c40f82ccc5 ("scsi: g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio drivers") Signed-off-by: Arnd Bergmann --- drivers/scsi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfi

Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex

2016-10-20 Thread Arnd Bergmann
On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote: > Semaphores are going away in the future, so replace the semaphore > sync_request_sem with the a mutex lock. timeout_msecs is not used > for the lock sync_request_sem, so remove the timed locking too. > > Signed-off-by: Binoy Jayan

Re: [PATCH 2/2] scsi: smartpqi: Replace semaphore lun_reset_sem with mutex

2016-10-20 Thread Arnd Bergmann
On Thursday, October 20, 2016 2:24:02 PM CEST Binoy Jayan wrote: > Semaphores are going away in the future, so replace the semaphore > lun_reset_sem with the a mutex lock. > > Signed-off-by: Binoy Jayan > Reviewed-by: Arnd Bergmann -- To unsubscribe from this list: send the li

Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex

2016-10-20 Thread Arnd Bergmann
On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote: > - sema_init(&ctrl_info->sync_request_sem, > - PQI_RESERVED_IO_SLOTS_SYNCHRONOUS_REQUESTS); > + mutex_init(&ctrl_info->sync_request_mutex); > Looking at this again, I see that PQI_RESERVED_IO_SLOTS_SYNCHRO

[PATCH] sd: fix uninitialized variable access in error handling

2016-10-21 Thread Arnd Bergmann
nitialized] This sets it to zero, which has the desired effect of leaving the sd_zbc_read_zones successfully with sdkp->zone_blocks = 0. Fixes: 89d947561077 ("sd: Implement support for ZBC devices") Signed-off-by: Arnd Bergmann --- drivers/scsi/sd_zbc.c | 4 +++- 1 file changed, 3 in

Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex

2016-10-24 Thread Arnd Bergmann
On Monday, October 24, 2016 3:34:27 PM CEST Binoy Jayan wrote: > Hi Arnd > > On 20 October 2016 at 14:36, Arnd Bergmann wrote: > > On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote: > >> Semaphores are going away in the future, so replace the semaphore &g

[PATCH] advansys: fix build warning for PCI=n

2016-10-24 Thread Arnd Bergmann
/advansys.c:10928:6: note: ‘share_irq’ was declared here This cannot happen in practice because the hardware in question only exists for PCI, but changing the code to just error out here is better for consistency and avoids the warning. Signed-off-by: Arnd Bergmann --- drivers/scsi/advansys.c | 3 +++ 1

[PATCH] mvsas: fix command_active typo

2016-11-16 Thread Arnd Bergmann
632aae8b66 ("[SCSI] mvsas: Add new macros and functions") Signed-off-by: Arnd Bergmann --- drivers/scsi/mvsas/mv_94xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/mvsas/mv_94xx.c b/drivers/scsi/mvsas/mv_94xx.c index 4c57d9abce7b..7de5d8d75480 10064

[PATCH] bfa: turn bfa_mem_{kva,dma}_setup into inline functions

2016-11-16 Thread Arnd Bergmann
kes them much more readable and avoids the warnings. Signed-off-by: Arnd Bergmann --- drivers/scsi/bfa/bfa_ioc.h | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/bfa/bfa_ioc.h b/drivers/scsi/bfa/bfa_ioc.h index 523fb02109b6..c27e

Re: [PATCH] libfc: fix seconds_since_last_reset miscalculation

2016-11-16 Thread Arnd Bergmann
On Tuesday, November 15, 2016 4:05:31 PM CET Johannes Thumshirn wrote: > On Tue, Nov 15, 2016 at 02:50:17PM +, Bart Van Assche wrote: > > On Tue, 2016-11-15 at 10:18 +0100, Johannes Thumshirn wrote: > > > On Tue, Nov 08, 2016 at 03:04:43PM +, Bart Van Assche wrote: > > > > I think the above

Re: [PATCH v2] libfc: fix seconds_since_last_reset miscalculation

2016-11-17 Thread Arnd Bergmann
r kernel 4.8-rc1. > > Fixes: 540eb1eef ('scsi: libfc: fix seconds_since_last_reset calculation') > Signed-off-by: Johannes Thumshirn > Acked-by: Arnd Bergmann I actually made the same patch today and was going to send it out after getting my other patches to build clean

[PATCH] isci: avoid array subscript warning

2016-11-18 Thread Arnd Bergmann
values for enum scis_sds_remote_node_context_states here. Anyway, checking for an array overflow can't harm and it makes the warning go away. Signed-off-by: Arnd Bergmann --- drivers/scsi/isci/remote_node_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/isci/remote_node_context.c

[PATCH] scsi: hpsa: fix uninitialized variable access

2016-11-22 Thread Arnd Bergmann
'3' for legacy HBA devices") Signed-off-by: Arnd Bergmann --- I did not try hard to figure out what the correct behavior should be, so please treat this as a bugreport that might contain the right fix. --- drivers/scsi/hpsa.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH] scsi: hpsa: fix uninitialized variable access

2016-11-22 Thread Arnd Bergmann
On Tuesday, November 22, 2016 3:47:09 PM CET Hannes Reinecke wrote: > index 05f7782..ee6f852 100644 > --- a/drivers/scsi/hpsa.c > +++ b/drivers/scsi/hpsa.c > @@ -2031,7 +2031,7 @@ static struct hpsa_scsi_dev_t > *lookup_hpsa_scsi_dev(struct ctlr_info *h, > > static int hpsa_slave_alloc(struct scs

Re: [PATCH] hpsa: fix uninitialized variable

2016-11-22 Thread Arnd Bergmann
nction [-Werror=maybe-uninitialized] > > The patch that caused this is marked for stable backports, > so this one has to be backported on top as well. > > Fixes: 4eb307f7b18d ("scsi: hpsa: use bus '3' for legacy HBA devices") > > Signed-off-by: Hanne

[PATCH] scsi: qedi: select UIO

2017-01-10 Thread Arnd Bergmann
x27; This adds a compile-time dependency. Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.") Signed-off-by: Arnd Bergmann --- drivers/scsi/qedi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/qedi/Kconfig b/drivers/scsi/qedi/

[PATCH] scsi: aacraid: avoid open-coded upper_32_bits

2017-02-07 Thread Arnd Bergmann
s changes the driver to use the predefined macros consistently, including one correct but open-coded upper_32_bits() instance. Fixes: d1ef4da8487f ("scsi: aacraid: added support for init_struct_8") Fixes: 423400e64d37 ("scsi: aacraid: Include HBA direct interface") Signed-off-by:

[PATCH] scsi: megaraid_sas: handle dma_addr_t right on 32-bit

2017-02-14 Thread Arnd Bergmann
ror=int-to-pointer-cast] It's better to not pretend that the dma address is a pointer and instead use a dma_addr_t consistently. Fixes: 33203bc4d61b ("scsi: megaraid_sas: NVME fast path io support") Signed-off-by: Arnd Bergmann --- drivers/scsi/megaraid/megaraid_sas_fusion.c |

[PATCH] smartpqi: fix time handling

2017-02-17 Thread Arnd Bergmann
ced that even though the driver uses time64_t for storing seconds, it gets them from the old 32-bit struct timeval. To address this, we can simplify the code by calling ktime_get_real_seconds() directly. Fixes: 6c223761eb54 ("smartpqi: initial commit of Microsemi smartpqi driver"

[PATCH] scsi: lpfc: use proper format string for dma_addr_t

2017-02-27 Thread Arnd Bergmann
' [-Werror=format=] drivers/scsi/lpfc/lpfc_logmsg.h:52:52: error: format '%llu' expects argument of type 'long long unsigned int', but argument 12 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=] printk has a special "%pad" format string that p

[PATCH] scsi: lpfc: use div_u64 for 64-bit division

2017-02-27 Thread Arnd Bergmann
Fixes: 2b65e18202fd ("scsi: lpfc: NVME Target: Add debugfs support") Signed-off-by: Arnd Bergmann --- drivers/scsi/lpfc/lpfc_debugfs.c | 64 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/dr

[PATCH] scsi: qedi: fix build error without DEBUG_FS

2017-03-02 Thread Arnd Bergmann
ic namespace, as "do_not_recover" is a really bad name for a kernel-wide global identifier when it is used only in one driver. Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.") Signed-off-by: Arnd Bergmann --- drivers/scsi/qedi/qedi_d

[PATCH] [v2] scsi: qedi: fix build error without DEBUG_FS

2017-03-02 Thread Arnd Bergmann
ic namespace, as "do_not_recover" is a really bad name for a kernel-wide global identifier when it is used only in one driver. Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.") Reviewed-by: Johannes Thumshirn Signed-off-by: Arnd Berg

Re: [PATCH] scsi: qedi: fix build error without DEBUG_FS

2017-03-02 Thread Arnd Bergmann
On Thu, Mar 2, 2017 at 1:10 PM, Arnd Bergmann wrote: > > - QEDI_INFO(qedi_dbg, QEDI_LOG_DEBUGFS, "do_not_recover=%d\n", > - do_not_recover); > + QEDI_INFO(qedi_dbg, QEDI_LOG_DEBUGFS, "qedi_do_not_recover=%d\n", > +

Re: [PATCH v4 2/4] arm64: Remove the clock and PHY reference from the APM X-Gene SoC AHCI SATA Host controller dts node.

2014-07-29 Thread Arnd Bergmann
On Tuesday 29 July 2014 12:24:50 Suman Tripathi wrote: > This patch removes all clocks and PHY references from the APM X-Gene > SoC AHCI SATA host controller and PHY DTS nodes. The clock and PHY > are no longer needed as they are handled by the firmware. By removing > only the reference is not enou

Re: [PATCH v6 2/2] arm64: Remove the clock and PHY reference from the APM X-Gene SoC AHCI SATA Host controller dts node.

2014-08-09 Thread Arnd Bergmann
On Friday 08 August 2014, Suman Tripathi wrote: > This patch removes all clocks and PHY references from the APM X-Gene > SoC AHCI SATA host controller and PHY DTS nodes. The clock and PHY > are no longer needed as they are handled by the firmware. By removing > only the reference is not enough as a

Re: [PATCH] scsi: ips.c: use 64-bit time types

2014-10-08 Thread Arnd Bergmann
On Wednesday 08 October 2014 23:14:08 Ebru Akagunduz wrote: > This patch changes 32-bit time types to 64-bit in > ips.c > > time_t can only represent signed 32-bit dates but > the driver should represent dates that are after > January 2038. > > Use time64_t type instead of time_t. > > Signed-off

Re: [PATCH] scsi: ips.c: use 64-bit time types

2014-10-08 Thread Arnd Bergmann
On Wednesday 08 October 2014 13:44:55 James Bottomley wrote: > > diff --git a/drivers/scsi/ips.h b/drivers/scsi/ips.h > > index 45b9566..ff2a0b3 100644 > > --- a/drivers/scsi/ips.h > > +++ b/drivers/scsi/ips.h > > @@ -1054,7 +1054,7 @@ typedef struct ips_ha { > > uint8_tactive; > >

Re: [PATCH] scsi: ips.c: use 64-bit time types

2014-10-09 Thread Arnd Bergmann
On Thursday 09 October 2014 06:40:26 James Bottomley wrote: > On Wed, 2014-10-08 at 22:58 +0200, Arnd Bergmann wrote: > > On Wednesday 08 October 2014 13:44:55 James Bottomley wrote: > > > > diff --git a/drivers/scsi/ips.h b/drivers/scsi/ips.h > > > > index 45b9

Re: [PATCH] scsi: ips.c: use 64-bit time types

2014-10-09 Thread Arnd Bergmann
On Thursday 09 October 2014 08:13:14 James Bottomley wrote: > On Thu, 2014-10-09 at 16:29 +0200, Arnd Bergmann wrote: > > On Thursday 09 October 2014 06:40:26 James Bottomley wrote: > > > On Wed, 2014-10-08 at 22:58 +0200, Arnd Bergmann wrote: > > > > On Wednesday

[PATCH] target/cxgbit: add INET dependency

2016-02-29 Thread Arnd Bergmann
This adds a Kconfig dependency to ensure we can't enable this driver without the complete network stack it needs. Signed-off-by: Arnd Bergmann Fixes: b7ca3321e114 ("cxgbit: add Kconfig and Makefile") --- drivers/target/iscsi/cxgbit/Kconfig | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] target/cxgbit: add INET dependency

2016-03-01 Thread Arnd Bergmann
On Monday 29 February 2016 21:28:28 Nicholas A. Bellinger wrote: > > diff --git a/drivers/target/iscsi/cxgbit/Kconfig > > b/drivers/target/iscsi/cxgbit/Kconfig > > index cf335b4dbb4e..ce6f5cca315d 100644 > > --- a/drivers/target/iscsi/cxgbit/Kconfig > > +++ b/drivers/target/iscsi/cxgbit/Kconfig >

[PATCH 08/14] scsi: mvumi: use __maybe_unused to hide pm functions

2016-03-02 Thread Arnd Bergmann
me' defined but not used [-Werror=unused-function] This adds __maybe_unused annotations so the compiler knows it can silently drop them instead of warning, while avoiding the addition of another #ifdef. Signed-off-by: Arnd Bergmann --- drivers/scsi/mvumi.c | 4 ++-- 1 file changed, 2 insert

[PATCH 00/14] drivers: use __maybe_unused to hide pm functions

2016-03-02 Thread Arnd Bergmann
meone rand into the problem on x86. There are no dependencies between the patches, so I'd appreciate subsystem maintainers to put them directly into their git trees. Arnd Arnd Bergmann (14): pinctrl: at91: use __maybe_unused to hide pm functions irqchip: st: use __maybe_unus

Re: [PATCH v9 3/3] add support for DWC UFS Host Controller

2016-03-02 Thread Arnd Bergmann
On Wednesday 02 March 2016 16:46:47 Joao Pinto wrote: > On 2/19/2016 3:03 PM, Arnd Bergmann wrote: > > On Thursday 18 February 2016 17:20:27 Joao Pinto wrote: > >> diff --git a/Documentation/devicetree/bindings/ufs/ufs-dwc.txt > >> b/Documentation/devicetree/bindings/

Re: [PATCH v9 3/3] add support for DWC UFS Host Controller

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 11:39:05 Joao Pinto wrote: > Hi Arnd, > > On 3/2/2016 7:55 PM, Arnd Bergmann wrote: > > On Wednesday 02 March 2016 16:46:47 Joao Pinto wrote: > >> On 2/19/2016 3:03 PM, Arnd Bergmann wrote: > >>> On Thursday 18 February 2016 1

Re: [PATCH v9 3/3] add support for DWC UFS Host Controller

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 13:52:39 Joao Pinto wrote: > > config SCSI_UFS_DWC > bool > > config SCSI_UFS_DWC_TC_PLATFORM > tristate "DesignWare platform support using a G210 Test Chip" > depends on SCSI_UFSHCD_PLATFORM > select SCSI_UFS_DWC > ---help--- >

Re: [PATCH v10 2/6] added UFS 2.0 capabilities

2016-03-04 Thread Arnd Bergmann
On Friday 04 March 2016 17:22:15 Joao Pinto wrote: > Adding UFS 2.0 support to the UFS core driver. > > Signed-off-by: Joao Pinto > Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord..

Re: [PATCH v10 3/6] added support for DesignWare Controller

2016-03-04 Thread Arnd Bergmann
On Friday 04 March 2016 17:22:16 Joao Pinto wrote: > This patch has the goal to add support for DesignWare UFS Controller > specific operations. > > Signed-off-by: Joao Pinto > Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-sc

Re: [PATCH v10 4/6] added support for Synopsys G210 Test Chip

2016-03-04 Thread Arnd Bergmann
On Friday 04 March 2016 17:22:17 Joao Pinto wrote: > This patch adds support for Synopsys G210 Test Chip. > > Signed-off-by: Joao Pinto > Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord..

Re: [PATCH v10 5/6] add TC G210 platform driver

2016-03-04 Thread Arnd Bergmann
On Friday 04 March 2016 17:22:18 Joao Pinto wrote: > This patch adds a glue platform driver for the Synopsys G210 Test Chip. > > Signed-off-by: Joao Pinto Looks basically ok, but I think it can be simplified a little: > +/** > + * struct ufs_hba_dwc_vops - UFS DWC specific variant operations >

Re: [PATCH v10 6/6] add TC G210 pci driver

2016-03-04 Thread Arnd Bergmann
On Friday 04 March 2016 17:22:19 Joao Pinto wrote: > This patch adds a glue pci driver for the Synopsys G210 Test Chip. > > Signed-off-by: Joao Pinto Mostly ok, just a few suggestions: > + > +/* Test Chip type expected values */ > +#define TC_G210_20BIT 20 > +#define TC_G210_40BIT 40 > +#define

Re: [PATCH v10 1/6] fixed typo in ufshcd-pltfrm

2016-03-04 Thread Arnd Bergmann
On Friday 04 March 2016 17:22:14 Joao Pinto wrote: > Fixed typo in ufshcd-pltfrm. > > Signed-off-by: Joao Pinto Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majo

[PATCH] cxgbit: fix dma_addr_t printk format

2016-03-04 Thread Arnd Bergmann
nting an lvalue, so we have to add a cast to u64, which matches the format string on all architectures. Signed-off-by: Arnd Bergmann Fixes: c49aa56e556d ("cxgbit: add cxgbit_ddp.c") --- drivers/target/iscsi/cxgbit/cxgbit_ddp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [PATCH] cxgbit: fix dma_addr_t printk format

2016-03-04 Thread Arnd Bergmann
On Friday 04 March 2016 16:25:07 Joe Perches wrote: > > > > diff --git a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c > > b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c > > index 07e2bc86d0df..d667bc88e21d 100644 > > --- a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c > > +++ b/drivers/target/iscsi/cxgbit/cxg

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-10 Thread Arnd Bergmann
On Wednesday 09 March 2016, yga...@codeaurora.org wrote: > Any userspace application can be a tool. > We already implemented and used a user space application, that sent > queries to the UFS devices in order to get information and descriptors. > Not only ioctl interface is a useful way to interact

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-10 Thread Arnd Bergmann
On Thursday 10 March 2016, Arnd Bergmann wrote: > On Wednesday 09 March 2016, yga...@codeaurora.org wrote: > > Any userspace application can be a tool. > > We already implemented and used a user space application, that sent > > queries to the UFS devices in order to get inform

gcc-6.0 warnings for scsi

2016-03-14 Thread Arnd Bergmann
gcc-6 found a couple of bugs in scsi drivers that are not yet fixed in linux-next. In all three cases, the code is indented in a rather misleading way, but actually correct. I think it would be good to have this fixed in 4.6, but no backports are needed even though the problems have all been aroun

[PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Arnd Bergmann
at the behavior is correct and the indentation is wrong. This fixes the indentation and adds curly braces around the previous if() block for clarity, as that is most likely what caused the code to be misindented in the first place. Signed-off-by: Arnd Bergmann Fixes: 549e55cd2a1b ("[SCSI] lp

[PATCH 3/3] megaraid_sas: add missing curly braces in ioctl handler

2016-03-14 Thread Arnd Bergmann
he warning by adding extra curly braces. Signed-off-by: Arnd Bergmann Fixes: 90dc9d98f01b ("megaraid_sas : MFI MPT linked list corruption fix") --- drivers/scsi/megaraid/megaraid_sas_base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megar

[PATCH 1/3] aacraid: add missing curly braces

2016-03-14 Thread Arnd Bergmann
makes it clear what was intended here. Nothing changes in behavior because in the 'if' block, the sdev->tagged_supported flag is known to be set already. Signed-off-by: Arnd Bergmann Fixes: 6bf3b630d0a7 ("aacraid: SCSI blk tag support") --- drivers/scsi/aacraid/linit.c | 3 ++

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Arnd Bergmann
On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote: > > vports = lpfc_create_vport_work_array(phba); > > - if (vports != NULL) > > + if (vports != NULL) { > > for (i = 0; i <= phba->max_vports && vports[i] != NULL; i++) { > > struct Scsi_Host *s

[PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-15 Thread Arnd Bergmann
n annotated branch. This slightly rearranges the code to move the second if() block into the first one, to avoid the warning while retaining the behavior of the code. Signed-off-by: Arnd Bergmann --- drivers/scsi/qla2xxx/qla_target.c | 16 +--- 1 file changed, 9 insertions(+), 7 del

[PATCH] scsi: fc: use get/put_unaligned64 for wwn access

2016-03-19 Thread Arnd Bergmann
bytes, as the optimized get_unaligned_be64() load can be done in three instructions. The stack usage is now down to 28 bytes from 128 bytes with gcc-5.3 before. Signed-off-by: Arnd Bergmann --- include/scsi/scsi_transport_fc.h | 15 +++ 1 file changed, 3 insertions(+), 12 deletion

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-19 Thread Arnd Bergmann
On Tuesday 15 March 2016 14:49:14 James Bottomley wrote: > On Tue, 2016-03-15 at 22:40 +0100, Arnd Bergmann wrote: > > > > This slightly rearranges the code to move the second if() block > > into the first one, to avoid the warning while retaining the > > behavior of t

Re: UFS V11 patch-set

2016-03-19 Thread Arnd Bergmann
On Friday 18 March 2016 12:52:13 Joao Pinto wrote: > Hi! > > Could you please check the following patch-set in order to evaluate if it is > ready for v4.6? > I think the code is ok now, but the timing apparently didn't work for 4.6. I'd suggest you resend as soon as 4.6-rc1 is out so it can get

[PATCH] scsi: ufs: select CONFIG_NLS

2016-03-19 Thread Arnd Bergmann
his adds a Kconfig 'select' statement to avoid the build error. Signed-off-by: Arnd Bergmann Fixes: b573d484e4ff ("scsi: ufs: add support to read device and string descriptors") --- drivers/scsi/ufs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/

Re: [PATCH] scsi: ufs: select CONFIG_NLS

2016-03-22 Thread Arnd Bergmann
On Tuesday 22 March 2016 07:43:19 James Bottomley wrote: > > diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig > > index 5f4530744e0a..097894a1fab5 100644 > > --- a/drivers/scsi/ufs/Kconfig > > +++ b/drivers/scsi/ufs/Kconfig > > @@ -37,6 +37,7 @@ config SCSI_UFSHCD > > depends

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-16 Thread Arnd Bergmann
d submitted that patch before, but I can't find a version with a proper changelog any more now, so I probably haven't. However, I did all the research to show that it only makes things better on ARM and x86 except in cases where the gcc inliner happens to pick a different set of function

[PATCH] aha1542: probe correct address for isapnp

2016-04-16 Thread Arnd Bergmann
ned-off-by: Arnd Bergmann Fixes: 643a7c43f11e ("aha1542: Stop using scsi_module.c") --- drivers/scsi/aha1542.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index 7db448ec8beb..132c3

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-18 Thread Arnd Bergmann
On Monday 18 April 2016 09:12:41 Josh Poimboeuf wrote: > On Mon, Apr 18, 2016 at 04:07:51PM +0200, Arnd Bergmann wrote: > > On Monday 18 April 2016 08:39:32 Josh Poimboeuf wrote: > > > > > > I agree. So how should we work around the bug in this case? There have >

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-18 Thread Arnd Bergmann
On Monday 18 April 2016 08:39:32 Josh Poimboeuf wrote: > > I agree. So how should we work around the bug in this case? There have > been several suggestions: > > - change wwn_to_u64() to __always_inline > > - change qla2x00_get_host_fabric_name() to skip the unnecessary call to > wwn_to_u64(

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-26 Thread Arnd Bergmann
On Monday 25 April 2016 20:37:31 James Bottomley wrote: > On Mon, 2016-04-25 at 22:40 -0400, Martin K. Petersen wrote: > > > > > > > "Josh" == Josh Poimboeuf writes: > > > > Josh> Can you merge this patch for 4.6? > > > > I am really not a big fan of working around compiler bugs in a device > >

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-26 Thread Arnd Bergmann
On Tuesday 26 April 2016 01:35:16 Christoph Hellwig wrote: > On Tue, Apr 26, 2016 at 09:22:46AM +0200, Arnd Bergmann wrote: > > > Agree, plus, as I've said before, we have 3-4 weeks before we go final, > > > so we still have some time before a decision has to be made. I

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-26 Thread Arnd Bergmann
On Tuesday 26 April 2016 09:06:54 Martin K. Petersen wrote: > >>>>> "Arnd" == Arnd Bergmann writes: > > Arnd> I don't think we can realistically blacklist gcc-4.9.{0,1,2,3}, > Arnd> gcc-5.{0,1,2,3}.* and gcc-6.0 and require everyone to upgrade to &

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-27 Thread Arnd Bergmann
On Wednesday 27 April 2016 13:05:03 Martin Jambor wrote: > On Tue, Apr 26, 2016 at 05:58:20PM +0200, Arnd Bergmann wrote: > > On Tuesday 26 April 2016 09:06:54 Martin K. Petersen wrote: > > > >>>>> "Arnd" == Arnd Bergmann writes: > > > > >

[PATCH, RFT] byteswap: try to avoid __builtin_constant_p gcc bug

2016-04-27 Thread Arnd Bergmann
been able to reproduce the original problem, so I don't know if this patch solves it, but at least it leads to simpler code doing the same thing, so at least there should be no downsides. Please test. Signed-off-by: Arnd Bergmann diff --git a/include/uapi/linux/swab.h b/include/uapi/linux/s

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-28 Thread Arnd Bergmann
On Thursday 28 April 2016 10:58:43 Chris Metcalf wrote: > (Resending as text/plain) > > On 4/27/2016 5:34 PM, Arnd Bergmann wrote: > > This won't help on TILE, which is the one architecture that sets > > ARCH_SUPPORTS_OPTIMIZED_INLINING but does not set ARCH_USE_BUILTI

[PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Arnd Bergmann
gi?id=70646 Fixes: e3bde9568d99 ("include/linux/unaligned: force inlining of byteswap operations") Fixes: ef3fb2422ffe ("scsi: fc: use get/put_unaligned64 for wwn access") Tested-by: Josh Poimboeuf # on gcc-5.3 Tested-by: Quinn Tran Reviewed-by: Josh Poimboeuf Signed-off-by:

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Arnd Bergmann
On Monday 02 May 2016 16:02:18 Andrew Morton wrote: > On Mon, 02 May 2016 23:48:19 +0200 Arnd Bergmann wrote: > > > This is another attempt to avoid a regression in wwn_to_u64() after > > that started using get_unaligned_be64(), which in turn ran into a > > bug on gcc-4

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Arnd Bergmann
On Monday 02 May 2016 16:32:25 Andrew Morton wrote: > On Tue, 03 May 2016 01:10:16 +0200 Arnd Bergmann wrote: > > > On Monday 02 May 2016 16:02:18 Andrew Morton wrote: > > > On Mon, 02 May 2016 23:48:19 +0200 Arnd Bergmann wrote: > > > > > > > This i

[PATCH 00/15] Linux-3.10 ARM randconfig fixes

2013-05-31 Thread Arnd Bergmann
fine as well. Arnd Arnd Bergmann (15): irqdomain: export irq_domain_add_simple mtd: omap2: allow bulding as a module drm/nouveau: use mdelay instead of large udelay constants [SCSI] nsp32: use mdelay instead of large udelay constants hwrng: bcm2835: fix MODULE_LICENSE tag

[PATCH 04/15] [SCSI] nsp32: use mdelay instead of large udelay constants

2013-05-31 Thread Arnd Bergmann
ARM cannot handle udelay for more than 2 miliseconds, so we should use mdelay instead for those. Signed-off-by: Arnd Bergmann Acked-by: GOTO Masanori Cc: YOKOTA Hiroshi Cc: "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org --- drivers/scsi/nsp32.c | 2 +- 1 file changed, 1

Re: [PATCH] scsi, be2iscsi, LLVMLinux: Add missing MODULE_DEVICE_TABLE()

2015-01-29 Thread Arnd Bergmann
On Wednesday 28 January 2015 17:37:02 Behan Webster wrote: > Missing MODULE_DEVICE_TABLE for pci ids from be2iscsi driver found by clang. > > Signed-off-by: Behan Webster > Reviewed-by: Mark Charlebois > Suggested-by: Arnd Bergmann > Cc: Arnd Bergmann > --- Like on

Re: [PATCH] mpt3sas: Remove usage of 'struct timeval'

2015-02-04 Thread Arnd Bergmann
h provides > 64-bit seconds value. The timestamp computed remains unaffected (milliseconds > since Unix epoch). > > Signed-off-by: Tina Ruchandani > Same change as for mpt2sas, so Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-s

Re: [PATCH] mpt2sas: Remove usage of 'struct timeval'

2015-02-04 Thread Arnd Bergmann
h provides > 64-bit seconds value. The timestamp computed remains unaffected (milliseconds > since Unix epoch). > > Signed-off-by: Tina Ruchandani > Looks good to me, Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-s

Re: [PATCH] scsi: Remove usage of struct timeval

2015-02-04 Thread Arnd Bergmann
On Wednesday 04 February 2015 08:39:54 Tina Ruchandani wrote: > struct timeval will have its tv_sec field overflow on 32-bit systems > in year 2038 and beyond. This patch removes the usage of struct timeval > and instead uses 64-bit ktime_t to get the current milliseconds > to populate pmcraid_time

Re: [PATCH] scsi: Remove use of struct timeval

2015-02-04 Thread Arnd Bergmann
seconds, which returns a 64-bit seconds value. > > Signed-off-by: Tina Ruchandani > Acked-by: Arnd Bergmann The patch looks good, but please send it again with a proper subject that mentions the name of the driver. Arnd -- To unsubscribe from this list: send the line "un

Re: [PATCH] [SCSI] bfa: Remove use of struct timeval

2015-02-04 Thread Arnd Bergmann
On Wednesday 04 February 2015 08:42:03 Tina Ruchandani wrote: > struct timeval will have its tv_sec field overflow on 32-bit systems > in year 2038 and beyond. This patch removes the usage of struct timeval > and instead uses ktime_get_real_seconds() which returns 64-bit wall-clock > seconds. > >

Re: [PATCH v2] scsi: pmcraid: Remove usage of struct timeval

2015-02-25 Thread Arnd Bergmann
to populate pmcraid_timestamp_data. > > Signed-off-by: Tina Ruchandani > Reviewed-by: Arnd Bergmann I notice that this patch also increases the accuracy of the timestamp from seconds to milliseconds, where the original code ignores the sub-second portion of the timeval. Doing this will ma

Re: [PATCH] qla2xxx: Remove use of 'struct timeval'

2015-02-25 Thread Arnd Bergmann
On Wednesday 25 February 2015 07:45:12 Tina Ruchandani wrote: > struct register_host_info stores a 64-bit UTC system time timestamp. > This patch removes the use of 'struct timeval' to obtain that timestamp > as its tv_sec value will overflow on 32-bit systems in year 2038 beyond. > The patch uses

Re: [PATCH v2] [SCSI] bfa: Replace bfa_get_log_time()

2015-02-25 Thread Arnd Bergmann
real_seconds() which returns 64-bit wall-clock > seconds. > > Signed-off-by: Tina Ruchandani > Suggested-by: Arnd Bergmann > -- > Changes in v2: > - Removed call to bfa_get_log_time entirely, instead of retaining > it and making it call ktime_get_real_seconds inte

Re: [PATCH v2] scsi: stex: Remove use of struct timeval

2015-02-25 Thread Arnd Bergmann
On Wednesday 25 February 2015 07:41:36 Tina Ruchandani wrote: > @@ -364,10 +365,7 @@ MODULE_VERSION(ST_DRIVER_VERSION); > > static void stex_gettime(__le64 *time) > { > - struct timeval tv; > - > - do_gettimeofday(&tv); > - *time = cpu_to_le64(tv.tv_sec); > + *time = cpu

Re: [PATCH] [SCSI] mvumi: 64bit value for seconds_since1970

2015-02-25 Thread Arnd Bergmann
year 2038. > This patch uses ktime_get_real_seconds() instead since it provides a > 64-bit seconds value, which is 2038 safe. > > Signed-off-by: Tina Ruchandani Reviewed-by: Arnd Bergmann I note that in this case, the bug exists and is fixed by your patch on both 32-bit and 64-bit kernels

Re: [PATCH v2 1/1] ata: ahci_xgene: Add AHCI Support for second generation of APM X-Gene SoC

2015-04-13 Thread Arnd Bergmann
On Monday 13 April 2015 15:02:40 Suman Tripathi wrote: > This patch enables full AHCI feature support for APM X-Gene SoC SATA host host > controller. The following errata's are removed: > > 1. 2a0bdff6b95 ("ahci-xgene: fix the dma state machine lockup for the > IDENTIFY DEVICE PIO

[PATCH 00/21] more arm build fixes

2013-04-25 Thread Arnd Bergmann
back. Arnd Arnd Bergmann (21): ARM: topology: export cpu_topology ARM: default machine descriptor for multiplatform ARM: shmobile: don't call irqchip_init unconditionally ARM: orion5x: include linux/cpu.h atm: he: use mdelay instead of large udelay constants ALSA: ali5451: use mdel

[PATCH 10/21] [SCSI] nsp32: use mdelay instead of large udelay constants

2013-04-25 Thread Arnd Bergmann
ARM cannot handle udelay for more than 2 miliseconds, so we should use mdelay instead for those. Signed-off-by: Arnd Bergmann Cc: GOTO Masanori Cc: YOKOTA Hiroshi Cc: "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org --- drivers/scsi/nsp32.c | 2 +- 1 file changed, 1 inser

Re: [PATCH 10/21] [SCSI] nsp32: use mdelay instead of large udelay constants

2013-04-29 Thread Arnd Bergmann
On Friday 26 April 2013, Masanori Goto wrote: > 2013/4/25 Arnd Bergmann > > > > ARM cannot handle udelay for more than 2 miliseconds, so we > > should use mdelay instead for those. > > > > Singed-off-by: GOTO Masanori Thanks. I assume you mean "Acked-

[PATCH] mpt3sas: add PCI dependency for CONFIG_SCSI_MPT2SAS

2015-12-04 Thread Arnd Bergmann
/mpt3sas/mpt3sas_base.c: In function '_base_disable_msix': drivers/scsi/mpt3sas/mpt3sas_base.c:1921:2: error: implicit declaration of function 'pci_disable_msix' [-Werror=implicit-function-declaration] This adds the same dependencies that SCSI_MPT3SAS has. Signed-off-by:

Re: [PATCH] mpt3sas: add PCI dependency for CONFIG_SCSI_MPT2SAS

2015-12-04 Thread Arnd Bergmann
On Friday 04 December 2015 08:28:51 James Bottomley wrote: > On Fri, 2015-12-04 at 15:27 +0100, Arnd Bergmann wrote: > > CONFIG_SCSI_MPT2SAS was added as a backwards-compatibility helper that > > selects the replacement SCSI_MPT3SAS symbol, but lacks the dependencies: &

[PATCH, RESEND 2] qla2xxx: Remove use of 'struct timeval'

2016-01-22 Thread Arnd Bergmann
onds value. Signed-off-by: Tina Ruchandani Reviewed-by: Johannes Thumshirn Signed-off-by: Arnd Bergmann diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index b5029e543b91..15dff7099955 100644 --- a/drivers/scsi/qla2xxx/qla_mr.c +++ b/drivers/scsi/qla2xxx/qla_mr.c @@

Re: [Y2038] [PATCH, RESEND 2] qla2xxx: Remove use of 'struct timeval'

2016-01-22 Thread Arnd Bergmann
On Friday 22 January 2016 15:28:32 Arnd Bergmann wrote: > struct register_host_info stores a 64-bit UTC system time timestamp. > This patch removes the use of 'struct timeval' to obtain that timestamp > as its tv_sec value will overflow on 32-bit systems in year 2038 beyon

[PATCH, RESEND 3] qla2xxx: Remove use of 'struct timeval'

2016-01-25 Thread Arnd Bergmann
turns a 64-bit seconds value. Signed-off-by: Tina Ruchandani Reviewed-by: Johannes Thumshirn Acked-by: Himanshu Madhani Signed-off-by: Arnd Bergmann --- Resent with correct author field and added Ack diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index b5

[PATCH 2/7] mptfusion: hide unused seq_mpt_print_ioc_summary function

2016-01-27 Thread Arnd Bergmann
tatic void seq_mpt_print_ioc_summary(MPT_ADAPTER *ioc, struct seq_file *m, int showlan) This adds an #ifdef to hide the function definition in that case and avoid the warning. Signed-off-by: Arnd Bergmann --- drivers/message/fusion/mptbase.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mess

  1   2   3   4   5   >