Re: [PATCH 01/28] aic94xx: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v3 03/11] scsi: sd_zbc: Fix sd_zbc_check_zones() error checks

On 10/12/18 4:30 AM, Damien Le Moal wrote: The 32 bits overflow check for the zone size value is already done within sd_zbc_check_zones() with the test: } else if (logical_to_sectors(sdkp->device, zone_blocks) > UINT_MAX) { so there is no need to check again for an out of range value in sd_zbc_

Re: [PATCH 02/28] 3w-9xxx: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 03/28] 3w-xxx: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v3 05/11] block: Limit allocation of zone descriptors for report zones

On 10/12/18 4:30 AM, Damien Le Moal wrote: There is no point in allocating more zone descriptors than the number of zones a block device has for doing a zone report. Avoid doing that in blkdev_report_zones_ioctl() by limiting the number of zone decriptors allocated internally to process the user

Re: [PATCH 04/28] 3w-sas: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 05/28] BusLogic: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 06/28] a100u2w: switch to generic DMA API

On Thu, Oct 11, 2018 at 08:49:41PM +0200, Christoph Hellwig wrote: > @@ -1124,7 +1124,8 @@ static int inia100_probe_one(struct pci_dev *pdev, > > /* Get total memory needed for SCB */ > sz = ORC_MAXQUEUE * sizeof(struct orc_scb); > - host->scb_virt = pci_zalloc_consistent(pdev, sz

Re: [PATCH 07/28] atp870u: switch to generic DMA API

On Thu, Oct 11, 2018 at 08:49:42PM +0200, Christoph Hellwig wrote: > Switch from the legacy PCI DMA API to the generic DMA API. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/atp870u.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/atp870u

Re: [PATCH v3 11/11] block: Introduce blk_revalidate_disk_zones()

On 10/12/18 4:30 AM, Damien Le Moal wrote: Drivers exposing zoned block devices have to initialize and maintain correctness (i.e. revalidate) of the device zone bitmaps attached to the device request queue (seq_zones_bitmap and seq_zones_wlock). To simplify coding this, introduce a generic helpe

Re: [PATCH 08/28] be2iscsi: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 09/28] csiostor: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 11/28] hpsa: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 10/28] fnic: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 12/28] megaraid_mbox: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 13/28] megaraid_sas: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 13/28] megaraid_sas: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 14/28] mpt3sas: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 15/28] mvumi: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 16/28] mvsas: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 17/28] nsp32: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 18/28] pm8001: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 19/28] qedf: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 20/28] qedi: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 21/28] qla1280: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 22/28] qla2xxx: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 23/28] qla4xxx: fully convert to the generic DMA API

On Thu, Oct 11, 2018 at 08:49:58PM +0200, Christoph Hellwig wrote: > @@ -9026,19 +9026,13 @@ static void qla4xxx_remove_adapter(struct pci_dev > *pdev) > */ > static void qla4xxx_config_dma_addressing(struct scsi_qla_host *ha) > { > - int retval; > - Can you zap that: At exit, the @ha's

Re: [PATCH 18/28] pm8001: switch to generic DMA API

Christoph Hellwig 于2018年10月11日周四 下午9:38写道： > > Switch from the legacy PCI DMA API to the generic DMA API. > > Signed-off-by: Christoph Hellwig Reviewed-by: Jack Wang Thanks, Jack

Re: [PATCH 24/28] snic: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 25/28] vmw_pscsi: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 26/28] smartpqi: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v3 09/11] block: Expose queue nr_zones in sysfs

On Fri, Oct 12, 2018 at 09:41:28AM +0200, Hannes Reinecke wrote: >> +{ >> +return 0; >> +} >> #endif /* CONFIG_BLK_DEV_ZONED */ >> static inline bool rq_is_sync(struct request *rq) >> > Actually, we should be checking whether we can't blank out this attribute > via the is_visible mechani

Re: [PATCH 28/28] mesh: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 27/28] ips: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v3 09/11] block: Expose queue nr_zones in sysfs

On Fri, Oct 12, 2018 at 11:30:10AM +0900, Damien Le Moal wrote: > Expose through sysfs the nr_zones field of struct request_queue. > Exposing this value helps in debugging disk issues as well as > facilitating scripts based use of the disk (e.g. blktests). > > For zoned block devices, the nr_zones

[PATCH v2 1/5] target: use ISCSI_IQN_LEN in iscsi_target_stat

Move the ISCSI_IQN_LEN definition up, so that it can be used in more places instead of a hardcoded value. Signed-off-by: David Disseldorp --- drivers/target/iscsi/iscsi_target_stat.c | 4 ++-- include/target/iscsi/iscsi_target_core.h | 6 +++--- include/target/iscsi/iscsi_target_stat.h | 4 ++--

[PATCH v2 3/5] target: log NOP ping timeouts as errors

Events resulting in connection outages like this should be logged as errors. Include the I_T Nexus in the message to aid path identification. Signed-off-by: David Disseldorp --- drivers/target/iscsi/iscsi_target_util.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/d

[PATCH v2 0/5] target: improve Data-Out and NOP timeout error reporting

The following patchset converts existing Data-Out and NOP ping timeout messages from pr_debug() to pr_error(), to reflect the seriousness of unexpected connection termination events. These events can be triggered using a couple of libiscsi client hacks: https://github.com/ddiss/libiscsi/tree/hack-

[PATCH v2 5/5] target: stash sess_err_stats on Data-Out timeout

sess_err_stats are currently filled on NOP ping timeout, but not Data-Out timeout. Stash details of Data-Out timeouts using a ISCSI_SESS_ERR_CXN_TIMEOUT value for last_sess_failure_type. Signed-off-by: David Disseldorp --- drivers/target/iscsi/iscsi_target_erl1.c | 1 + 1 file changed, 1 inserti

[PATCH v2 2/5] target: log Data-Out timeouts as errors

Data-Out timeouts resulting in connection outages should be logged as errors. Include the I_T Nexus in the message to aid path identification. Signed-off-by: David Disseldorp --- drivers/target/iscsi/iscsi_target_erl1.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) dif

[PATCH v2 4/5] target: split out helper for cxn timeout error stashing

Replace existing nested code blocks with helper function calls. Signed-off-by: David Disseldorp --- drivers/target/iscsi/iscsi_target_erl0.c | 15 +- drivers/target/iscsi/iscsi_target_util.c | 35 +--- drivers/target/iscsi/iscsi_target_util.h | 1 + 3 fil

[PATCH -next] scsi: arcmsr: Remove set but not used variables 'id, lun'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/arcmsr/arcmsr_hba.c: In function 'arcmsr_drain_donequeue': drivers/scsi/arcmsr/arcmsr_hba.c:1320:10: warning: variable 'lun' set but not used [-Wunused-but-set-variable] drivers/scsi/arcmsr/arcmsr_hba.c:1320:6: warning: variable 'id' s

[PATCH 00/19] megaraid_sas: Driver updates

Shivasharan S (19): megaraid_sas: Add watchdog thread to detect FW fault megaraid_sas: Add support for FW snap dump megaraid_sas: Fix msleep granularity megaraid_sas: Add check for reset adapter bit megaraid_sas: Update copyright information megaraid_sas: Fix goto labels in error hand

[PATCH 01/19] megaraid_sas: Add watchdog thread to detect Firmware fault

Issue - Currently driver checks for Firmware state change from ISR context, and only when there are interrupts tied with no I/O completions. We have seen multiple cases where doorbell interrupts sent by firmware, to indicate FW state change are not processed by driver and it takes long time for dri

[PATCH 02/19] megaraid_sas: Add support for FW snap dump

Latest firmware adds a mechanism to save firmware logs just before controller reset on pre-allocated internal controller DRAM. This feature is called snapdump which will help debugging firmware issues. This feature requires extra time and firmware reports these values through new driver interface.

[PATCH 03/19] megaraid_sas: Fix msleep granularity

Issue - In megasas_transition_to_ready() driver waits 180seconds for controller to change FW state. Here we are calling msleep(1) in a loop for this. As explained in timers-howto.txt, msleep(1) will actually sleep longer than 1ms. If a faulty controller is connected, we will end up waiting for much

[PATCH 08/19] megaraid_sas: Fix combined reply queue mode detection

Fix - For Invader series, if FW supports more than 8 MSI-x vectors, driver needs to enable combined reply queue mode. For Ventura series, driver enables combined reply queue mode in case of more than 16 MSI-x vectors. Signed-off-by: Sumit Saxena Signed-off-by: Shivasharan S --- drivers/scsi/meg

[PATCH 04/19] megaraid_sas: Add check for reset adapter bit

For SAS3 and later controllers, FW sets the reset adapter bit indicating the driver to perform a controller reset. Driver needs to check if this bit is set before doing a reset. This reduces the driver probe failure time to 180seconds in case there is a faulty controller connected. Signed-off-by:

[PATCH 07/19] megaraid_sas: Fix module parameter description

Module parameter description for rdpq_enable incorrectly lists the default as enabled. Also, provide range of valid values for resetwaittime in the description. Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas_base.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[PATCH 09/19] megaraid_sas: For SRIOV, do not set STOP_ADP bit

Fix - For SRIOV based adapters, driver should not set the STOP_ADP bit as part of kill adapter. Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas_base.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/driv

[PATCH 05/19] megaraid_sas: Update copyright information

Change copyright to Broadcom Inc. Also update any references to Avago with Broadcom. Update copyright duration wherever required. Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas.h| 14 ++ drivers/scsi/megaraid/megaraid_sas_base.c | 18 --

[PATCH 06/19] megaraid_sas: Fix goto labels in error handling

Fix - During init, if pci_alloc_irq_vectors() fails, the driver has not yet setup the IRQs. Fix the goto labels and error handling for this case. Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas_base.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dr

[PATCH 14/19] megaraid_sas: Re-use max_mfi_cmds to calculate queue sizes

In megasas_init_adapter_fusion(), max_mfi_cmds is being calcuated as (MEGASAS_FUSION_INTERNAL_CMDS + MEGASAS_FUSION_IOCTL_CMDS). max_mfi_cmds can be used in megasas_configure_queue_sizes. Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 +--- 1 file changed, 1 ins

[PATCH 13/19] megaraid_sas: Rename scratch_pad registers

No functional change. Rename the scratch pad registers to match firmware headers. Signed-off-by: Sumit Saxena Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas.h| 9 +++ drivers/scsi/megaraid/megaraid_sas_base.c | 40 +-- drivers/scsi/meg

[PATCH 12/19] megaraid_sas: Remove spin lock for dpc operation

Optimization - No need to hold hba_lock in dpc context for reading atomic variable. Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/m

[PATCH 11/19] megaraid_sas: optimize raid context access in IO path

No functional change. Use local variables when accessing raid context in IO path. Improves code readability. Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 74 - 1 file changed, 31 insertions(+), 43 deletions(-) diff --git a/drivers/sc

[PATCH 10/19] megaraid_sas: Fail init if heartbeat timer fails

When driver fails to start the heartbeat timer, exit from FW init. Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas_base.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_

[PATCH 15/19] megaraid_sas: Remove double endian conversion

Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index 0a8b7167d05d..76ea5dc656b1 100644 --- a/drivers/scsi

[PATCH 16/19] megaraid_sas: increase timeout for IOC INIT to 180seconds

IOC INIT frame needs to be fired with a timeout of 180seconds. Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion

[PATCH 17/19] megaraid_sas: remove unused macro

Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index 2c044106c35f..994c6ac6f920 100644 --- a/drivers/scsi/megaraid/megaraid_sas.h +++ b/drivers/sc

[PATCH 18/19] megaraid_sas: modify max supported lds related print

The print related to number of VDs that a particular firmware supports is misleading in some cases. Even though supportMaxExtLDs is set, certain firmware profiles only supports upto 64VDs. Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas_base.c | 6 +++--- 1 file changed, 3 in

[PATCH 19/19] megaraid_sas: Update driver version

Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index 994c6ac6f920..8edba2227cd3 100644 --- a/drivers/scsi/megaraid/megaraid_s

URGENT RESPONSE NEEDED

Hello my dear. Did you receive my email message to you? Please, get back to me ASAP as the matter is becoming late. Expecting your urgent response. Sean.

Re: [PATCH 3/5] esp_scsi: use strong typing for the dev field

On Fri, Oct 12, 2018 at 04:47:23PM +1100, Finn Thain wrote: > > + esp->dev = &dev->dev; > > > > esp->command_block = kzalloc(16, GFP_KERNEL); > > if (!esp->command_block) > > > Isn't this missing the corresponding dev_set_drvdata() in esp_mac_probe()? > Also conversion to dev_get_drv

Re: [PATCH 5/5] esp_scsi: move dma mapping into the core code

On Fri, Oct 12, 2018 at 04:45:57PM +1100, Finn Thain wrote: > > + if (esp->flags & ESP_FLAG_NO_DMA_MAP) > > + return; > > + > > + dma_unmap_single(esp->dev, ent->sense_dma, SCSI_SENSE_BUFFERSIZE, > > +DMA_FROM_DEVICE); > > + ent->sense_ptr = NULL; > > +} > > + >

Re: [PATCH v2 4/5] target: split out helper for cxn timeout error stashing

On Fri, 2018-10-12 at 12:01 +0200, David Disseldorp wrote: > +void iscsit_fill_cxn_timeout_err_stats(struct iscsi_session *sess) > +{ > + struct iscsi_portal_group *tpg = sess->tpg; > + struct iscsi_tiqn *tiqn = tpg->tpg_tiqn; > + > + if (!tiqn) > + return; > + > + spin_

Re: [PATCH 03/28] 3w-xxx: fully convert to the generic DMA API

On Thu, Oct 11, 2018 at 12:38 PM Christoph Hellwig wrote: > > The driver is currently using an odd mix of legacy PCI DMA API and > generic DMA API calls, switch it over to the generic API entirely. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/3w-.c | 20 ++-- > d

Re: [PATCH 02/28] 3w-9xxx: fully convert to the generic DMA API

On Thu, Oct 11, 2018 at 12:38 PM Christoph Hellwig wrote: > > The driver is currently using an odd mix of legacy PCI DMA API and > generic DMA API calls, switch it over to the generic API entirely. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/3w-9xxx.c | 50 -

Re: [PATCH 04/28] 3w-sas: fully convert to the generic DMA API

On Thu, Oct 11, 2018 at 12:38 PM Christoph Hellwig wrote: > > The driver is currently using an odd mix of legacy PCI DMA API and > generic DMA API calls, switch it over to the generic API entirely. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/3w-sas.c | 38 +-

SCSI qla2xxx: tcm_qla2xxx server code seems to have regressed quite badly with latest testing

Hello While I have for the longest time used 4.5 as a base for my F/C jammer that I use every day here in our lab I recently added more jammer code so I decided to test this all on latest upstream. Booting the target server on my 4.5 kernel with jammer code is flawless and serves LUNS with no iss

Re: [PATCH 3/5] esp_scsi: use strong typing for the dev field

> On Fri, 12 Oct 2018, Christoph Hellwig wrote: > > > > > > diff --git a/drivers/scsi/mac_esp.c b/drivers/scsi/mac_esp.c > > > index eb551f3cc471..85d067889a9b 100644 > > > --- a/drivers/scsi/mac_esp.c > > > +++ b/drivers/scsi/mac_esp.c > > > @@ -58,8 +58,7 @@ static struct esp *esp_chips[2]; > >

Re: [PATCH 5/5] esp_scsi: move dma mapping into the core code

On Thu, 11 Oct 2018, Christoph Hellwig wrote: > diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c > index 90604bff8dd2..73fcbd65b9fe 100644 > --- a/drivers/scsi/esp_scsi.c > +++ b/drivers/scsi/esp_scsi.c > @@ -369,19 +369,25 @@ static void esp_map_dma(struct esp *esp, struct > scsi_c

Re: SCSI qla2xxx: tcm_qla2xxx server code seems to have regressed quite badly with latest testing

On 10/12/18 1:36 PM, Laurence Oberman wrote: > While I have for the longest time used 4.5 as a base for my F/C jammer > that I use every day here in our lab I recently added more jammer code > so I decided to test this all on latest upstream. > > Booting the target server on my 4.5 kernel with jam

Re: aic7xxx DMA overflow error

> That isn't a limit, just a reporting clause - the real check is this > line a little above: > > if (unlikely(dev && !dma_capable(dev, dma_addr, size))) { > > which is purely based on the dma mask. So for some reason we must > be in 32-bit only mode for the dma-mask, and not actually enab

Re: aic7xxx DMA overflow error

Hi Ted, thanks for the dmesg. This shows your HBA doesn't even support the odd 39-bit addressing. Now the real question is why we don't use swiotlb. For that I'd like to see the whole dmesg from the very beinning if you have it. Also it seems this boot didn't have the WARN_ON_ONCE I sent you a

Re: [PATCH 5/5] esp_scsi: move dma mapping into the core code

On Sat, Oct 13, 2018 at 09:24:51AM +1100, Finn Thain wrote: > > struct scatterlist *sg = scsi_sglist(cmd); > > - int dir = cmd->sc_data_direction; > > - int total, i; > > + int total = 0, i; > > > > - if (dir == DMA_NONE) > > - return; > > - > > Removing this DMA_NONE test

[PATCHv5 0/3] Deprecate DAC960 driver

Hi all, as we're trying to get rid of the remaining request_fn drivers here's a patchset to move the DAC960 driver to the SCSI stack. As per request from hch I've split up the driver into two new SCSI drivers called 'myrb' and 'myrs'. The 'myrb' driver only supports the earlier (V1) firmware inte

[PATCH 2/3] myrs: Add Mylex RAID controller (SCSI interface)

This patch adds support for the Mylex DAC960 RAID controller, supporting the newer, SCSI-based interface. The driver is a re-implementation of the original DAC960 driver. Signed-off-by: Hannes Reinecke --- MAINTAINERS |1 + drivers/scsi/Kconfig | 15 + drivers/scsi/Makefile |

[PATCH 1/3] myrb: Add Mylex RAID controller (block interface)

This patch adds support for the Mylex DAC960 RAID controller, supporting the older, block-based interface only. The driver is a re-implementation of the original DAC960 driver. Signed-off-by: Hannes Reinecke --- MAINTAINERS |6 + drivers/scsi/Kconfig| 15 + drivers/scsi/Mak

Re: [PATCH v3 01/11] scsi: sd_zbc: Rearrange code

On 10/12/18 4:30 AM, Damien Le Moal wrote: Move the urswrz check out of sd_zbc_read_zones() and into sd_zbc_read_zoned_characteristics() where that value is obtained (read from the disk zoned characteristics VPD page). Since this function now does more than simply reading the VPD page, rename it

Re: [PATCH v3 02/11] scsi: sd_zbc: Reduce boot device scan and revalidate time

On 10/12/18 4:30 AM, Damien Le Moal wrote: Handling checks of ZBC device capacity using the max_lba field of the REPORT ZONES command reply for disks with rc_basis == 0 can be done using the same report zones command reply used to check the "same" field. Avoid executing a report zones command so

Re: [PATCH v3 04/11] block: Introduce blkdev_nr_zones() helper

On 10/12/18 4:30 AM, Damien Le Moal wrote: Introduce the blkdev_nr_zones() helper function to get the total number of zones of a zoned block device. This number is always 0 for a regular block device (q->limits.zoned == BLK_ZONED_NONE case). Replace hard-coded number of zones calculation in dmz_

Re: [PATCH v3 06/11] block: Introduce BLKGETZONESZ ioctl

On 10/12/18 4:30 AM, Damien Le Moal wrote: Get a zoned block device zone size in number of 512 B sectors. The zone size is always 0 for regular block devices. Signed-off-by: Damien Le Moal --- block/ioctl.c | 2 ++ include/uapi/linux/blkzoned.h | 2 ++ 2 files changed, 4 ins

Re: [PATCH v3 07/11] block: Introduce BLKGETNRZONES ioctl

On 10/12/18 4:30 AM, Damien Le Moal wrote: Get a zoned block device total number of zones. The device can be a partition of the whole device. The number of zones is always 0 for regular block devices. Signed-off-by: Damien Le Moal --- block/ioctl.c | 2 ++ include/uapi/linux/

Re: [PATCH v3 08/11] block: Improve zone reset execution

On 10/12/18 4:30 AM, Damien Le Moal wrote: There is no need to synchronously execute all REQ_OP_ZONE_RESET BIOs necessary to reset a range of zones. Similarly to what is done for discard BIOs in blk-lib.c, all zone reset BIOs can be chained and executed asynchronously and a synchronous call done

Re: [PATCH v3 09/11] block: Expose queue nr_zones in sysfs

On 10/12/18 4:30 AM, Damien Le Moal wrote: Expose through sysfs the nr_zones field of struct request_queue. Exposing this value helps in debugging disk issues as well as facilitating scripts based use of the disk (e.g. blktests). For zoned block devices, the nr_zones field indicates the total nu

Re: [PATCH v3 10/11] block: add a report_zones method

On 10/12/18 4:30 AM, Damien Le Moal wrote: From: Christoph Hellwig Dispatching a report zones command through the request queue is a major pain due to the command reply payload rewriting necessary. Given that blkdev_report_zones() is executing everything synchronously, implement report zones as

Re: [PATCH v3 02/11] scsi: sd_zbc: Reduce boot device scan and revalidate time

On 2018/10/12 16:33, Hannes Reinecke wrote: > On 10/12/18 4:30 AM, Damien Le Moal wrote: >> Handling checks of ZBC device capacity using the max_lba field of the >> REPORT ZONES command reply for disks with rc_basis == 0 can be done >> using the same report zones command reply used to check the "sa

Re: [PATCH v3 03/11] scsi: sd_zbc: Fix sd_zbc_check_zones() error checks

On 2018/10/12 16:35, Hannes Reinecke wrote: > On 10/12/18 4:30 AM, Damien Le Moal wrote: >> The 32 bits overflow check for the zone size value is already done >> within sd_zbc_check_zones() with the test: >> >> } else if (logical_to_sectors(sdkp->device, zone_blocks) > UINT_MAX) { >> >> so there is

Re: [PATCH v3 09/11] block: Expose queue nr_zones in sysfs

On 2018/10/12 16:41, Hannes Reinecke wrote: > On 10/12/18 4:30 AM, Damien Le Moal wrote: >> Expose through sysfs the nr_zones field of struct request_queue. >> Exposing this value helps in debugging disk issues as well as >> facilitating scripts based use of the disk (e.g. blktests). >> >> For zone

Re: [PATCH v3 06/11] block: Introduce BLKGETZONESZ ioctl

On Fri, Oct 12, 2018 at 11:30:07AM +0900, Damien Le Moal wrote: > Get a zoned block device zone size in number of 512 B sectors. > The zone size is always 0 for regular block devices. > > Signed-off-by: Damien Le Moal Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v3 07/11] block: Introduce BLKGETNRZONES ioctl

On Fri, Oct 12, 2018 at 11:30:08AM +0900, Damien Le Moal wrote: > Get a zoned block device total number of zones. The device can be a > partition of the whole device. The number of zones is always 0 for > regular block devices. > > Signed-off-by: Damien Le Moal Looks good, Reviewed-by: Christop

Re: [PATCH v3 11/11] block: Introduce blk_revalidate_disk_zones()

Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v3 09/11] block: Expose queue nr_zones in sysfs

On 10/12/18 9:55 AM, Damien Le Moal wrote: On 2018/10/12 16:41, Hannes Reinecke wrote: On 10/12/18 4:30 AM, Damien Le Moal wrote: Expose through sysfs the nr_zones field of struct request_queue. Exposing this value helps in debugging disk issues as well as facilitating scripts based use of the

Re: [PATCH 0/7] hisi_sas: Misc bugfixes and an optimisation patch

Hi Ming, In theory, you still may generate and manage the IPTT in the LLDD by simply ignoring rq->tag, meantime enabling SCSI_MQ with 16 hw queues. Well at the moment we can't expose all 16 hw queues to upper layer anyway, due to ordering restiction imposed by HW on LLDD. We have a plan to

[PATCH v4 02/11] scsi: sd_zbc: Reduce boot device scan and revalidate time

Handling checks of ZBC device capacity using the max_lba field of the REPORT ZONES command reply for disks with rc_basis == 0 can be done using the same report zones command reply used to check the "same" field. Avoid executing a report zones command solely to check the disk capacity by merging sd

[PATCH v4 01/11] scsi: sd_zbc: Rearrange code

Move the urswrz check out of sd_zbc_read_zones() and into sd_zbc_read_zoned_characteristics() where that value is obtained (read from the disk zoned characteristics VPD page). Since this function now does more than simply reading the VPD page, rename it to sd_zbc_check_zoned_characteristics(). Also

[PATCH v4 03/11] scsi: sd_zbc: Fix sd_zbc_check_zones() error checks

The unsigned 32 bits overflow check for the zone size value is already done within sd_zbc_check_zones() with the test: } else if (logical_to_sectors(sdkp->device, zone_blocks) > UINT_MAX) { so there is no need to check again for an out of range value in sd_zbc_read_zones(). Simplify the code and

[PATCH v4 00/11] Zoned block device support improvements

This series improves zoned block device support (reduce overhead) and introduces many simplifications to the code (overall, there are more deletions than insertions). In more details: * Patches 1 to 3 are SCSI side (sd driver) cleanups and improvements reducing the overhead of report zones comma

[PATCH v4 06/11] block: Introduce BLKGETZONESZ ioctl

Get a zoned block device zone size in number of 512 B sectors. The zone size is always 0 for regular block devices. Signed-off-by: Damien Le Moal Reviewed-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- block/ioctl.c | 2 ++ include/uapi/linux/blkzoned.h | 2 ++ 2 files

  1   2   >