On Fri, Oct 12, 2018 at 04:47:23PM +1100, Finn Thain wrote: > > + esp->dev = &dev->dev; > > > > esp->command_block = kzalloc(16, GFP_KERNEL); > > if (!esp->command_block) > > > Isn't this missing the corresponding dev_set_drvdata() in esp_mac_probe()? > Also conversion to dev_get_drvdata() in esp_mac_remove()?
I don't think it matters at all, as nothing in the core esp_scsi.c code looks into the driver data to start with, but even if it did, platform_set_drvdata and platform_get_drvdata and just trivial wrappers around dev_set_drvdata and dev_get_drvdata and we rely on that fact all over the kernel. That being said if you want them converted I can throw in another patch at the end of the series.
