Re: [PATCH 5/5] esp_scsi: move dma mapping into the core code

[Christoph Hellwig]

On Fri, Oct 12, 2018 at 04:45:57PM +1100, Finn Thain wrote:
> > +   if (esp->flags & ESP_FLAG_NO_DMA_MAP)
> > +           return;
> > +
> > +   dma_unmap_single(esp->dev, ent->sense_dma, SCSI_SENSE_BUFFERSIZE,
> > +                    DMA_FROM_DEVICE);
> > +   ent->sense_ptr = NULL;
> > +}
> > +
> 
> I think it is better to clear ent->sense_ptr unconditionally, as before.

Ok.