.c | 15 -
>> drivers/scsi/pm8001/pm8001_sas.h | 12 +++-
>> drivers/scsi/pm8001/pm80xx_hwi.c | 111
>> +++--
>> drivers/scsi/pm8001/pm80xx_hwi.h |5 +-
>> 6 files changed, 112 insertions(+), 36 deletions(-)
>>
> For the whole
Hi James,
This patch is not pulled in yet.
Regards,
Suresh
-Original Message-
From: Jack Wang [mailto:xjtu...@gmail.com]
Sent: Tuesday, February 24, 2015 2:07 PM
To: Suresh Thiagarajan
Cc: linux-scsi@vger.kernel.org; James Bottomley; Viswas G; pmc...@pmcs.com
Subject: Re: [PATCH
Added the pm8006 controller id in pci table
Signed-off-by: Suresh Thiagarajan
Signed-off-by: Viswas G
---
drivers/scsi/pm8001/pm8001_defs.h |3 ++-
drivers/scsi/pm8001/pm8001_init.c |5 -
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/pm8001
On Mon, Sep 1, 2014 at 9:36 PM, Andrew Robertson
wrote:
> Hi,
>
> I have an Adaptec 71605H HBA that's randomly failing to detect any
> drives at boot. I have two systems with this HBA, and both are
> showing the exact same behavior. I can reproduce this randomly about
> 3 out of 4 times, where
Instead of using the virt_ptr use request buffer for copying
back the nvmd response data and use the same in request function also
Signed-off-by: Suresh Thiagarajan
Reviewed-by: Tomas Henzl
---
drivers/scsi/pm8001/pm8001_ctl.c |4 +---
drivers/scsi/pm8001/pm8001_hwi.c |8
2
On Wed, Jul 30, 2014 at 5:42 PM, James Bottomley
wrote:
> On Wed, 2014-07-30 at 17:37 +0530, Suresh Thiagarajan wrote:
>> From: Suresh Thiagarajan
>>
>> Update pmcs mail list for pm8001 driver support
>>
>> Signed-off-by: Suresh Thiagarajan
>> ---
>&
From: Tomas Henzl
The loopcount is calculated by using some weird magic.
Use instead a boring macro
Signed-off-by: Tomas Henzl
Signed-off-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/pm8001_ctl.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi
From: Tomas Henzl
The current implementation may mix the negative value returned
from pm8001_set_nvmd with with count. -(-ENOMEM) could be interpreted
as bytes programmed, this patch fixes it.
Signed-off-by: Tomas Henzl
Signed-off-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/pm8001_ctl.c
On Wed, Jul 30, 2014 at 5:40 PM, James Bottomley
wrote:
> On Wed, 2014-07-30 at 17:33 +0530, Suresh Thiagarajan wrote:
>> From: Suresh Thiagarajan
>>
>> The current implementation may mix the negative value returned
>> from pm8001_set_nvmd with with count. -(-E
From: Suresh Thiagarajan
Update pmcs mail list for pm8001 driver support
Signed-off-by: Suresh Thiagarajan
---
MAINTAINERS |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3f2e171..a63259c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
From: Suresh Thiagarajan
The loopcount is calculated by using some weird magic.
Use instead a boring macro
Signed-off-by: Tomas Henzl
Signed-off-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/pm8001_ctl.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers
From: Suresh Thiagarajan
The current implementation may mix the negative value returned
from pm8001_set_nvmd with with count. -(-ENOMEM) could be interpreted
as bytes programmed, this patch fixes it.
Signed-off-by: Tomas Henzl
Signed-off-by: Suresh Thiagarajan
---
drivers/scsi/pm8001
as.
Acked-by: Suresh Thiagarajan
>
> Signed-off-by: Tomas Henzl
> ---
> drivers/scsi/pm8001/pm8001_ctl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_ctl.c
> b/drivers/scsi/pm8001/pm8001_ctl.c
> index 211ff
nd the completion thread takes the info from virt_ptr again.
Looks good. Thanks Tomas.
Acked-by: Suresh Thiagarajan
>
> Signed-off-by: Tomas Henzl
> ---
> drivers/scsi/pm8001/pm8001_hwi.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drive
On Mon, Jul 7, 2014 at 8:49 PM, Tomas Henzl wrote:
> Instead of copying information to fw_control_context free it.
>
> The task is forgotten thus also the reference to fw_control_context
> and the completion thread takes the info from virt_ptr again.
Looks good. Thanks Tomas.
Acke
From: Suresh Thiagarajan
The driver ignores the return value in a lot of places, fix
it at least somewhere (and release the resources in such cases),
to avoid that bad things happen.
A memory leak is fixed too.
Signed-off-by: Tomas Henzl
Acked-by: Suresh Thiagarajan
---
drivers/scsi/pm8001
From: Suresh Thiagarajan
Patch adds a new spinlock to protect the ccb management.
It may happen that concurrent threads become the same tag value
from the 'alloc' function', the spinlock prevents this situation.
Signed-off-by: Tomas Henzl
Acked-by: Suresh Thiagarajan
---
driv
From: Suresh Thiagarajan
The driver ignores the return value in a lot of places, fix
it at least somewhere (and release the resources in such cases),
to avoid that bad things happen.
Signed-off-by: Tomas Henzl
Signed-off-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/pm8001_hwi.c | 33
From: Suresh Thiagarajan
During hibernation, the HBA firmware may lose power and forget the device
id info. This causes the HBA to reject IO upon resume. The fix is
to call the libsas power management routines to make the domain device
forgetful.
This fixes bug 76681: https
From: Suresh Thiagarajan
The pm8001_get_phy_settings_info() function does not check the
kzalloc() return value and does not free the allocated memory.
Signed-off-by: Maurizio Lombardi
Acked-by: Jack Wang
Acked-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/pm8001_init.c | 13
From: Suresh Thiagarajan
In the driver two different functions are used to free the same resource,
this patch makes the code easier to read. In addittion to that, some
minor optimisations were made too.
Signed-off-by: Tomas Henzl
Acked-by: Suresh Thiagarajan
---
drivers/scsi/pm8001
From: Suresh Thiagarajan
There is a risk that the variable will be used without being initialized.
This was largely found by using a static code analysis program called cppche
Signed-off-by: Rickard Strandqvist
Acked-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/pm80xx_hwi.c |6
From: Suresh Thiagarajan
Removal of null pointer checks that could never happen
Signed-off-by: Rickard Strandqvist
Acked-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/pm8001_hwi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b
From: Suresh Thiagarajan
Updated comments for pm8001: honor return value
Remaining patches are resend
Suresh Thiagarajan (8):
pm8001: Fix to remove null pointer checks that could never happen
pm8001: Cleaning up uninitialized variables
pm8001: Fix hibernation issue
pm8001: Fix potential
On Mon, Jul 7, 2014 at 7:14 PM, Tomas Henzl wrote:
> On 07/07/2014 03:12 PM, Suresh Thiagarajan wrote:
>>
>> On Thu, Jul 3, 2014 at 2:15 PM, Christoph Hellwig wrote:
>>> Suresh,
>>>
>>> do you maintain pm8001 for pmcs now? There have been lots of pm
n't uptodate anymore
> please update it.
Will send a patch to update the Maintainer's list.
Thanks,
Suresh Thiagarajan
>
> Thanks,
> Christoph
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majo
001_tag_alloc, better way is to use this bitmap lock. Thanks for adding it.
Thanks Tomas. Looks good
Acked-by: Suresh Thiagarajan
> pm8001_chip_get_nvmd_req is invoked and there is a new 'tag' allocated.
> I have noticed your lock nowhere in the path, in addition I was able
> to t
nzl
Thanks Tomas. Looks good
Acked-by: Suresh Thiagarajan
> ---
> drivers/scsi/pm8001/pm8001_ctl.c | 5 -
> drivers/scsi/pm8001/pm8001_init.c | 22 --
> 2 files changed, 24 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_ctl.c
-1821,7 +1822,10 @@ static void pm8001_send_read_log(struct
> pm8001_hba_info *pm8001_ha,
When tag allocation is failed, task needs to be freed.
When domain device allocation fails, task and tag needs to be freed.
> memcpy(&sata_cmd.sata_fis, &fis, si
mas. Looks good
Acked-by: Suresh Thiagarajan
> ---
> drivers/scsi/pm8001/pm8001_hwi.c | 10 +-
> drivers/scsi/pm8001/pm8001_sas.c | 31 +++
> drivers/scsi/pm8001/pm8001_sas.h | 1 -
> 3 files changed, 12 insertions(+), 30 deletions(-)
>
&
at this fields is only set and appears
> to be never used,
> maybe it could be completely removed.
You are correct. The whole forensic_info structure itself is not used or
referred anywhere. I will remove it and send a patch.
Regards,
Suresh Thiagarajan
>
> Regards,
> Maurizio Lombard
rdi
>
> Looks good, thanks
> Acked-by: Jack Wang
Looks good, Thanks Maurizio
Acked-by: Suresh Thiagarajan
>> ---
>> drivers/scsi/pm8001/pm8001_init.c | 13 ++---
>> 1 file changed, 10 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/scsi/pm8
Checking return value for the memory allocattion and freeing it
while exiting the function
Signed-off-by: Viswas G
Signed-off-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/pm8001_ctl.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/pm8001/pm8001_ctl.c
On Fri, Dec 27, 2013 at 9:48 PM, Oleg Nesterov wrote:
> On 12/24, Suresh Thiagarajan wrote:
>>
>> Below is a small pseudo code on protecting/serializing the flag for global
>> access.
>> struct temp
>> {
>> ...
>> spinlock_t lock;
>
On Tue, Dec 24, 2013 at 1:59 PM, Ingo Molnar wrote:
>
> * Oleg Nesterov wrote:
>
>> On 12/23, Ingo Molnar wrote:
>> >
>> > * Oleg Nesterov wrote:
>> >
>> > > Initially I thought that this is obviously wrong, irqsave/irqrestore
>> > > assume that "flags" is owned by the caller, not by the lock.
-Original Message-
From: Jack Wang [mailto:xjtu...@gmail.com]
Sent: Monday, December 23, 2013 7:03 PM
To: Tomas Henzl; Viswas G
Cc: linux-scsi@vger.kernel.org; jason.seb...@gmail.com;
jbottom...@parallels.com; Vasanthalakshmi Tharmarajan; Suresh Thiagarajan
Subject: Re: [PATCH] pm80xx
Jason,
I have sent you the patch for testing. Could you please help testing this patch?
Will submit it here once it is tested by you.
Regards,
Suresh
-Original Message-
From: Suresh Thiagarajan [mailto:sureshka...@gmail.com]
Sent: Wednesday, November 27, 2013 11:11 AM
To: Jason Seba
Cc
Niall Drievers hotmail.com> writes:
>
> Jack, Suresh
>
> Thanks for your response! Here's what I get from lspci - 30:00.0 Serial
Attached SCSI controller:
> PMC-Sierra Inc. Device 8001 (rev 05)
>
> cat /sys/class/scsi_host/host7/version_product
> PM8001
>
> cat /sys/class/scsi_host/host7/
Hi Niall,
Please update the firmware from
http://www.adaptec.com/en-us/support/sas/#sas_raid Adaptec Series 7 SAS/SATA 6
Gb - Host Bus Adapter section based on your card.
What is the current firmware version? You can get from the sys file
"fw_version" under /sys/devices.
Can you please try che
Hi Jason
On Sat, Oct 12, 2013 at 2:02 AM, Jason Seba wrote:
> The pm8xxx driver uses a per-adapter spinlock (pm8001_ha->lock) which
> is usually acquired and released with the irqsave routines. However,
> some functions which are called with the lock held
> (mpi_sata_completion, mpi_sata_event, p
40 matches
Mail list logo
