be accessed in unpowered state.
To solve this issue, simply add checking to skip shutdown for above
kind of situation.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index
Rework from previous work by:
Sujit Reddy Thumma
Override auto suspend tunables for UFS device LUNs during
initialization so as to efficiently manage background operations
and the power consumption.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
Reviewed-by: Bean Huo
---
drivers/scsi
spend parameters override within the LLD itself
instead of waiting for userspace to control the power management.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
Reviewed-by: Bart Van Assche
---
drivers/scsi/scsi_sysfs.c | 3 ++-
drivers/scsi/sd.c | 4
include/scsi/scsi_device.
Enable auto suspend capability in MediaTek UFS driver.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
---
drivers/scsi/ufs/ufs-mediatek.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 0f6ff33ce52e
y
v1 => v2:
- Allow "zero" sdev->rpm_autosuspend_delay (Avri)
- Fix format of some lines (Avri)
Stanley Chu (3):
scsi: core: allow auto suspend override by low-level driver
scsi: ufs: override auto suspend tunables for ufs
scsi: ufs-mediatek: enable auto suspend capability
Hi Bart,
> > -
> > + unsigned rpm_autosuspend_on:1; /* Runtime autosuspend */
> > atomic_t disk_events_disable_depth; /* disable depth for disk events */
> The "_on" part in the variable name "rpm_autosuspend_on" is probably
> redundant and the comment could have been more elaborate. A
spend parameters override within the LLD itself
instead of waiting for userspace to control the power management.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
---
drivers/scsi/scsi_sysfs.c | 3 ++-
drivers/scsi/sd.c | 4
include/scsi/scsi_device.h | 2 +-
include/scsi/scsi_host.h
Rework from previous work by:
Sujit Reddy Thumma
Override auto suspend tunables for UFS device LUNs during
initialization so as to efficiently manage background operations
and the power consumption.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
---
drivers/scsi/ufs/ufshcd.c | 9
Enable auto suspend capability in MediaTek UFS driver.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
---
drivers/scsi/ufs/ufs-mediatek.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 0f6ff33ce52e
s, (Bart)
(a) Whether or not runtime suspend is enabled at device creation time
(b) The power management autosuspend delay
v1 => v2:
- Allow "zero" sdev->rpm_autosuspend_delay (Avri)
- Fix format of some lines (Avri)
Stanley Chu (3):
scsi: core: allow auto suspend override by
Hi Bart,
> > - pm_runtime_forbid(&sdev->sdev_gendev);
> > + if (sdev->rpm_autosuspend_delay < 0)
> > + pm_runtime_forbid(&sdev->sdev_gendev);
> > pm_runtime_enable(&sdev->sdev_gendev);
> > scsi_autopm_put_target(starget);
>
> So we have a single new struct member, rpm_autosu
Hi Bart,
> > @@ -147,6 +152,8 @@ static int ufs_mtk_init(struct ufs_hba *hba)
> > if (err)
> > goto out_variant_clear;
> >
> > + ufs_mtk_set_caps(hba);
> > +
> > /*
> > * ufshcd_vops_init() is invoked after
> > * ufshcd_setup_clock(true) in ufshcd_hba_init() thus
spend parameters override within the LLD itself
instead of waiting for userspace to control the power management.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
---
drivers/scsi/scsi_scan.c | 6 ++
drivers/scsi/scsi_sysfs.c | 3 ++-
drivers/scsi/sd.c | 4
include/scsi/scsi_dev
Enable auto suspend capability in MediaTek UFS driver.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
---
drivers/scsi/ufs/ufs-mediatek.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 0f6ff33ce52e
Rework from previous work by:
Sujit Reddy Thumma
Override auto suspend tunables for UFS device LUNs during
initialization so as to efficiently manage background operations
and the power consumption.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
---
drivers/scsi/ufs/ufshcd.c | 8
tself
instead of waiting for userspace to control the power management, and
make UFS as the first user of this capability.
v1 => v2:
- Allow "zero" sdev->rpm_autosuspend_delay (Avri)
- Fix format of some lines (Avri)
Stanley Chu (3):
scsi: core: allow auto suspend override by lo
Hi Avri,
On Wed, 2019-09-11 at 10:58 +, Avri Altman wrote:
> >
> > Enable auto suspend capability in MediaTek UFS driver.
> >
> > Signed-off-by: Stanley Chu
> Reviewed-by: Avri Altman
>
> > ---
> > drivers/scsi/ufs/ufs-mediatek.c | 7
Hi Avri,
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
> > 30b752c61b97..d253a018a73b 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -88,6 +88,9 @@
> > /* Interrupt aggregation default timeout, unit: 40us */
> > #define INT_AG
Hi Avri,
> > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index
> > 149d406aacc9..2218d57c4c0c 100644
> > --- a/drivers/scsi/sd.c
> > +++ b/drivers/scsi/sd.c
> > @@ -3371,6 +3371,9 @@ static int sd_probe(struct device *dev)
> > }
> >
> > blk_pm_runtime_init(sdp->request_queu
tself
instead of waiting for userspace to control the power management, and
make UFS as the first user of this capability.
Stanley Chu (3):
scsi: core: allow auto suspend override by low-level driver
scsi: ufs: override auto suspend tunables for ufs
scsi: ufs-mediatek: enable auto su
Rework from previous work by:
Sujit Reddy Thumma
Override auto suspend tunables for UFS device LUNs during
initialization so as to efficiently manage background operations
and the power consumption.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 8
drivers/scsi/ufs
spend parameters override within the LLD itself
instead of waiting for userspace to control the power management.
Signed-off-by: Stanley Chu
---
drivers/scsi/scsi_sysfs.c | 3 ++-
drivers/scsi/sd.c | 3 +++
include/scsi/scsi_device.h | 2 +-
3 files changed, 6 insertions(+), 2 deletions(-)
Enable auto suspend capability in MediaTek UFS driver.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufs-mediatek.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 0f6ff33ce52e..b7b177c6194c 100644
--- a
lution is referried from error handling of device commands: bits in
hba->outstanding_tasks shall be cleared regardless of their execution
results.
Signed-off-by: Stanley Chu
Signed-off-by: Chun-Hung Wu
---
drivers/scsi/ufs/ufshcd.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
Hi Avri,
On Thu, 2019-07-25 at 16:52 +0800, Stanley Chu wrote:
> Hi Avri,
>
> On Thu, 2019-07-25 at 07:54 +, Avri Altman wrote:
> > Stanly,
> >
> > >
> > > Currently bits in hba->outstanding_tasks are cleared only after their
> > > corr
Hi Avri,
On Thu, 2019-07-25 at 07:54 +, Avri Altman wrote:
> Stanly,
>
> >
> > Currently bits in hba->outstanding_tasks are cleared only after their
> > corresponding task management commands are successfully done by
> > __ufshcd_issue_tm_cmd().
> >
> > If timeout happens in a task manageme
immediately only if task is responded.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 3804a704e565..66c8e7402001 100644
--- a/drivers/scs
Introduce ufshcd_tm_cmd_compl() to re-factor taks cleanup jobs
to make code more readable and for future wider usage by task error
handling.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs
t; ufshcd_tmc_handler().
This patch tries to "re-factor" cleanup jobs first, and then add fixed
flow to make the whole patch more readable.
Stanley Chu (3):
scsi: ufs: clean-up task resource immediately only if task is
responded
scsi: ufs: introduce ufshcd_tm_cmd_compl() to refacto
t; ufshcd_tmc_handler().
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 114c15ed75f7..3cb942ef64e2 100644
--- a/drivers/scsi/ufs/ufshcd.c
+
Hi Avri,
On Mon, 2019-07-22 at 06:10 +, Avri Altman wrote:
> >
> > >
> > > Hi,
> > >
> > > >
> > > > Currently bits in hba->outstanding_tasks are cleared only after their
> > > > corresponding task management commands are successfully done by
> > > > __ufshcd_issue_tm_cmd().
> > > >
> > > > I
Hi Avri, Alim and Pedrom,
Gentle ping for this fix.
On Fri, 2019-07-12 at 12:44 +0800, Stanley Chu wrote:
> Currently bits in hba->outstanding_tasks are cleared only after their
> corresponding task management commands are successfully done by
> __ufshcd_issue_tm_cmd().
>
>
Make a new function "ufshcd_outstanding_task_clear()" used to
clear bits in hba->outstanding_tasks for future wider usage.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/u
ing flow can clear their tags specifically.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 38 +++---
drivers/scsi/ufs/ufshcd.h | 1 +
2 files changed, 32 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/uf
ing flow can clear their tags specifically.
Stanley Chu (2):
scsi: ufs: Make new function for clearing outstanding task bits
scsi: ufs: Fix broken hba->outstanding_tasks
drivers/scsi/ufs/ufshcd.c | 49 +--
drivers/scsi/ufs/ufshcd.h | 1 +
2 files changed
Currently UFS error history will be reset and lost during host reset
flow by ufschd_probe_hba().
We shall not reset it and then error history can be kept as completed
as possible to improve debugging.
In addition, fix a minor display error in ufshcd_print_err_hist().
Signed-off-by: Stanley Chu
error
- Resume error
Example of abnormal events,
- Task or request abort
- Device reset (now equals to Logical Unit Reset)
- Host reset
This patch tries to track above errors and events by existed UFS error
history mechanism.
Signed-off-by: Stanley Chu
---
drivers/sc
st reset
Changes in v3:
- Fix one missing place to track link startup error (Avri Altman)
- Add history of device reset events (Avri Altman)
- Add history of host reset events
Changes in v2:
- Add new patch "scsi: ufs: Add history of fatal events"
Stanley Chu (4):
scsi: ufs: Change
r_reg_hist *err_hist, char *err_name);
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
---
drivers/scsi/ufs/ufshcd.c | 39 ---
drivers/scsi/ufs/ufshcd.h | 20 ++--
2 files changed, 30 insertions(+), 29 deletions(-)
diff --git a/driver
Provide more information of fatal errros and auto-hibern8 errors
to improve debugging by extending extend existed UFS error history
framework.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
---
drivers/scsi/ufs/ufshcd.c | 11 ++-
drivers/scsi/ufs/ufshcd.h | 10 +-
2 files
Hi Avri,
On Wed, 2019-07-10 at 08:04 +, Avri Altman wrote:
> Hi Stanley,
>
> > + (u32)ret);
> > goto out;
> > + }
> > } while (ret && retries--);
> >
> > if (ret)
> Here also link startup fails...
Thanks! Will tr
Currently UFS error history will be reset and lost during host reset
flow by ufschd_probe_hba().
We shall not reset it and then error history can be kept as completed
as possible to improve debugging.
In addition, fix a minor display error in ufshcd_print_err_hist().
Signed-off-by: Stanley Chu
fatal
events"
to add history for "non-interrupt-based" errors as well, for example,
- Link startup fail
- Suspend fail
- Resume fail
- Task or request abort event
Changes in v2:
- Add new patch "scsi: ufs: Add history of fatal events".
Stanley Chu (4):
scsi: ufs: Change
Provide more information of fatal errros and auto-hibern8 errors
to improve debugging by extending extend existed UFS error history
framework.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
---
drivers/scsi/ufs/ufshcd.c | 11 ++-
drivers/scsi/ufs/ufshcd.h | 10 +-
2 files
r_reg_hist *err_hist, char *err_name);
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
---
drivers/scsi/ufs/ufshcd.c | 39 ---
drivers/scsi/ufs/ufshcd.h | 20 ++--
2 files changed, 30 insertions(+), 29 deletions(-)
diff --git a/driver
esume fail
- Task or request abort event
This patch tries to add those failed events by existed UFS error
history mechanism.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 36 +++-
drivers/scsi/ufs/ufshcd.h | 10 ++
2 files changed, 37 insertions(+),
This patch set provides more information of fatal errros and auto-hibern8 errors
to improve debugging by keeping their error history as completed as possible.
Stanley Chu (3):
scsi: ufs: Change names related to error history
scsi: ufs: Add fatal and auto-hibern8 error history
scsi: ufs: Do
Provide more information of fatal errros and auto-hibern8 errors
to improve debugging by extending existed UFS error history
framework.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 11 ++-
drivers/scsi/ufs/ufshcd.h | 6 ++
2 files changed, 16 insertions(+), 1 deletion
r_reg_hist *err_hist, char *err_name);
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 39 ---
drivers/scsi/ufs/ufshcd.h | 20 ++--
2 files changed, 30 insertions(+), 29 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/driver
Currently UFS error history will be reset and lost during host reset
flow by ufschd_probe_hba().
We shall not reset it and then error history can be kept as completed
as possible to improve debugging.
In addition, fix a minor display error in ufshcd_print_err_hist().
Signed-off-by: Stanley Chu
e PM
only after hba is successfully bound to UFS device structure.
Fixes: 62694735ca95 ([SCSI] ufs: Add runtime PM support for UFS host controller
driver)
Cc: sta...@vger.kernel.org
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd-pltfrm.c | 11 ---
1 file changed, 4 insertions(+), 7 dele
Hi Marc,
On Wed, 2019-06-12 at 13:30 +0200, Marc Gonzalez wrote:
> On 12/06/2019 13:10, Avri Altman wrote:
>
> > On 12/06/2019 09:42, Stanley Chu wrote:
> >
> >> Fixes: e3ce73d (scsi: ufs: fix bugs related to null pointer access and
> >> array size)
&g
Hi Avri,
On Wed, 2019-06-12 at 11:10 +, Avri Altman wrote:
> Hi,
>
> >
> > UFS runtime suspend can be triggered after pm_runtime_enable()
> > is invoked in ufshcd_pltfrm_init(). However if the first runtime
> > suspend is triggered before binding ufs_hba structure to ufs
> > device structure
e PM
only after hba is successfully bound to UFS device structure.
Fixes: e3ce73d (scsi: ufs: fix bugs related to null pointer access and array
size)
Cc: sta...@vger.kernel.org
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd-pltfrm.c | 11 ---
1 file changed, 4 insertions(+), 7 dele
_sync() in
shutdown flow instead of internal function ufshcd_runtime_resume() for
consolidated control of RPM status.
One concern is that pm_runtime_get_sync() may be better paired with
pm_runtime_put_sync(), however shutdown could be one-way path thus the
pairing is not required.
Signed-off-by: S
e timer" (Avri
Altman)
- Rebase to Linux 5.2-rc1
v2:
- Fix sentences in commit message (Marc Gonzalez)
- Make "Auto-Hibernate" error detection more precise (Bean Huo)
Stanley Chu (3):
scsi: ufs: Introduce ufshcd_is_auto_hibern8_supported()
scsi: ufs: Do not overwrite Auto-Hibern
The checking of Auto-Hibernation support is used in
many places in the driver, thus re-factor it as
ufshcd_is_auto_hibern8_supported() to make code more
clean.
Signed-off-by: Stanley Chu
Reviewed-by: Bean Huo
Reviewed-by: Alim Akhtar
---
drivers/scsi/ufs/ufs-sysfs.c | 6 +++---
drivers/scsi
happens, trigger error-handling just like "manual-hibernate"
fail and apply the same recovery flow: schedule UFS error handler in
ufshcd_check_errors(), and then do host reset and restore
in UFS error handler.
Signed-off-by: Stanley Chu
Reviewed-by: B
Some vendor-specific initialization flow may set its own
auto-hibernate timer. In this case, do not overwrite timer value
as "default value" in ufshcd_init().
Signed-off-by: Stanley Chu
Reviewed-by: Alim Akhtar
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+),
Hi Avri,
On Tue, 2019-05-21 at 06:18 +, Avri Altman wrote:
> >
> > ufshcd_is_auto_hibern8_supported() will be used elsewhere
> > in the driver, thus refactor it for preparation.
> You missed a couple of spots, e.g. in ufshcd_auto_hibern8_enable and in
> ufs-sysfs.
Yes...
Will re-factor them
Some vendor-specific initialization flow may set its own
auto-hibernate timer. In this case, do not overwrite timer value
as "default value" in ufshcd_init().
Signed-off-by: Stanley Chu
Reviewed-by: Alim Akhtar
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+),
Auto-Hibernate timer" (Avri
Altman)
- Rebase to Linux 5.2-rc1
v2:
- Fix sentences in commit message (Marc Gonzalez)
- Make "Auto-Hibernate" error detection more precise (Bean Huo)
Stanley Chu (3):
scsi: ufs: Do not overwrite Auto-Hibernate timer
scsi: ufs: Introduce ufshcd_
happens, trigger error-handling just like "manual-hibernate"
fail and apply the same recovery flow: schedule UFS error handler in
ufshcd_check_errors(), and then do host reset and restore
in UFS error handler.
Signed-off-by: Stanley Chu
Reviewed-by: B
ufshcd_is_auto_hibern8_supported() will be used elsewhere
in the driver, thus refactor it for preparation.
Signed-off-by: Stanley Chu
Reviewed-by: Bean Huo
Reviewed-by: Alim Akhtar
---
drivers/scsi/ufs/ufshcd.c | 2 +-
drivers/scsi/ufs/ufshcd.h | 5 +
2 files changed, 6 insertions(+), 1
Hi Avri,
On Mon, 2019-05-20 at 09:51 +, Avri Altman wrote:
> Aside from some nits - see below, looks fine.
>
> Thanks,
> Avri
>
> > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> > index ecfa898b9ccc..994d73d03207 100644
> > --- a/drivers/scsi/ufs/ufshcd.h
> > +++ b/dri
" (Avri
Altman)
- Rebase to Linux 5.2-rc1
v2:
- Fix sentences in commit message (Marc Gonzalez)
- Make "Auto-Hibernate" error detection more precise (Bean Huo)
Stanley Chu (3):
scsi: ufs: Do not overwrite Auto-Hibernate timer
scsi: ufs: Add error-handling of Auto-Hiber
Some vendor-specific initialization flow may set its own
auto-hibernate timer. In this case, do not overwrite timer value
as "default value" in ufshcd_init().
Signed-off-by: Stanley Chu
Reviewed-by: Alim Akhtar
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+),
happens, trigger error-handling just like "manual-hibernate"
fail and apply the same recovery flow: schedule UFS error handler in
ufshcd_check_errors(), and then do host reset and restore
in UFS error handler.
Signed-off-by: Stanley Chu
Reviewed-by: B
Use re-factored ufshcd_is_auto_hibern8_supported() function
in ufshcd_init() instead to make code more cleaner.
Signed-off-by: Stanley Chu
Reviewed-by: Bean Huo
Reviewed-by: Alim Akhtar
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Hi Avri,
On Mon, 2019-05-20 at 05:47 +, Avri Altman wrote:
> >
> > Hello Stanley,
> >
> > On 5/15/19 3:06 PM, Stanley Chu wrote:
> > > Some vendor-specific initialization flow may set its own
> > > auto-hibernate timer. In this case, do not overwri
Hi Avri, Alim, Pedro,
Gentle ping for this patch.
On Wed, 2019-05-15 at 17:36 +0800, Stanley Chu wrote:
> Currently auto-hibernate is activated if host supports
> auto-hibern8 capability. However error-handling is not implemented,
> which makes the feature somewhat risky.
>
happens, trigger error-handling just like "manual-hibernate"
fail and apply the same recovery flow: schedule UFS error handler in
ufshcd_check_errors(), and then do host reset and restore
in UFS error handler.
v2:
- Fix sentences in commit message (Marc Gonzalez)
- Make "Auto-Hiber
Some vendor-specific initialization flow may set its own
auto-hibernate timer. In this case, do not overwrite timer value
as "default value" in ufshcd_init().
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
happens, trigger error-handling just like "manual-hibernate"
fail and apply the same recovery flow: schedule UFS error handler in
ufshcd_check_errors(), and then do host reset and restore
in UFS error handler.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 31 +
Use re-factored ufshcd_is_auto_hibern8_supported() function
in ufshcd_init() instead to make code more cleaner.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
Hi Bean,
On Tue, 2019-05-14 at 11:14 +, Bean Huo (beanhuo) wrote:
> Hi, Stanley
> Thanks for reply.
>
> >
> >On Mon, 2019-05-13 at 18:21 +, Bean Huo (beanhuo) wrote:
> >> Hi, Stanley
> >>
> >> >+
> >> >+static inline bool ufshcd_is_auto_hibern8_error(struct ufs_hba *hba,
> >> >+
Hi Bean,
Thanks so much for review.
On Mon, 2019-05-13 at 18:21 +, Bean Huo (beanhuo) wrote:
> Hi, Stanley
>
> >+
> >+static inline bool ufshcd_is_auto_hibern8_error(struct ufs_hba *hba,
> >+u32 intr_mask)
> >+{
> >+return (ufshcd_is_auto_hiber
Hi Marc,
Thank you so much for below suggestions. I will fix them all in next
version.
On Mon, 2019-05-13 at 16:51 +0200, Marc Gonzalez wrote:
> On 13/05/2019 16:36, Stanley Chu wrote:
>
> > Currently auto-hibern8 is activated if host supports
> > auto-hibern8 capability
or handlings just like "manual-hibernate"
fail and use the same flow: Identify errors and schedule UFS error
handler in ufshcd_check_errors(), and then do host reset and restore
in UFS error handler.
Stanley Chu (3):
scsi: ufs: do not overwrite auto-hibern8 timer
scsi
Use re-factored ufshcd_is_auto_hibern8_supported() function
in ufshcd_init() instead to make code more cleaner.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
or handlings just like "manual-hibernate"
fail and use the same flow: Identify errors and schedule UFS error
handler in ufshcd_check_errors(), and then do host reset and restore
in UFS error handler.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 14 ++
d
Some vendor-specific initialization flow may set its own
auto-hibern8 timer. In this case, do not overwrite timer value
as "default value" in ufshcd_init().
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dr
If UFS device responds an unknown request response code,
we can not know what it was via logs because the code
is replaced by "DID_ERROR << 16" before log printing.
Fix this to provide precise request response code information
for easier issue breakdown.
Signed-off-by: Stanley C
Add VCC supply for ufs-mediatek driver to provide power-saving
operation during low-power modes, for example, VCC can be
turned-off during system suspend and turned-on after
system is resumed.
Signed-off-by: Stanley Chu
---
Documentation/devicetree/bindings/ufs/ufs-mediatek.txt | 3 +++
1 file
" property in device tree.
Besides, add VCC supply capability on MediaTek UFS driver.
Stanley Chu (2):
scsi: dt-bindings: ufs: Remove custom property
"-fixed-regulator"
scsi: dt-bindings: ufs: Add VCC capability on MediaTek UFS driver
Documentation/devicetree/bindings/ufs/
ty in device tree.
Signed-off-by: Stanley Chu
---
Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 2 --
1 file changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
index 5111e9130
nd return "good" results.
However improper values shall be fixed to avoid potential bugs.
Simply bypass voltage configuration if voltage range is not defined.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
Acked-by: Alim Akhtar
---
drivers/scsi/ufs/ufshcd.c | 13 -
1
ever "min_uA" field is not used anywhere, thus we can remove it.
Signed-off-by: Stanley Chu
Reviewed-by: Marc Gonzalez
Reviewed-by: Avri Altman
Acked-by: Alim Akhtar
---
drivers/scsi/ufs/ufs.h | 1 -
drivers/scsi/ufs/ufshcd-pltfrm.c | 1 -
2 files changed, 2 deletions(-)
uot;.
V2:
- Add two patches to prepare to and remove "-fixed-regulator" device tree
property.
- Add more details on patch "scsi: ufs: remove unused min_uA field in struct
ufs_vreg" (Marc Gonzalez).
Stanley Chu (5):
scsi: ufs: Remove unused min_uA field in struct ufs_vreg
scs
e of undefined
current limit, this patch shall be safe.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
Acked-by: Alim Akhtar
---
drivers/scsi/ufs/ufshcd-pltfrm.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufsh
alid current limit,
otherwise a wrong icc_level will be calculated by zero "max_uA" and
thus causes unexpected results after it is written to device.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
Acked-by: Alim Akhtar
---
drivers/scsi/ufs/ufshcd.c | 15 ---
1 file changed
unexpected.
* For other regulators with undefined voltage range, voltage range
will be still undefined after patched.
Therefore this patch is safe for all existed regulators with
"-fixed-regulator" property already defined.
Signed-off-by: Stanley Chu
Reviewed-by: Avri Altman
take to miss some tags in reposted patch.
Will fix it in next version.
> This series looks good, it will be if we get a Tested-by as well.
> For this series
> Acked-by: Alim Akhtar
Thanks so much for review.
>
> On Wed, Mar 27, 2019 at 3:29 PM Stanley Chu wrote:
> >
> &
t; V2:
> > - Add two patches to prepare to and remove "-fixed-regulator" device
> > tree property.
> > - Add more details on patch "scsi: ufs: remove unused min_uA field in struct
> > ufs_vreg" (Marc Gonzalez).
> >
> > Stanley Chu (5):
> >
in case of undefined
current limit, this patch shall be safe.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd-pltfrm.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index 32cf8c56f029..2420e69
nd return "good" results.
However improper values shall be fixed to avoid potential bugs.
Simply bypass voltage configuration if voltage range is not defined.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-
nge on a
regulator".
V2:
- Add two patches to prepare to and remove "-fixed-regulator" device tree
property.
- Add more details on patch "scsi: ufs: remove unused min_uA field in struct
ufs_vreg" (Marc Gonzalez).
Stanley Chu (5):
scsi: ufs: Remove unused min_uA field
ever "min_uA" field is not used anywhere, thus we can remove it.
Signed-off-by: Stanley Chu
Reviewed-by: Marc Gonzalez
---
drivers/scsi/ufs/ufs.h | 1 -
drivers/scsi/ufs/ufshcd-pltfrm.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi
alid current limit,
otherwise a wrong icc_level will be calculated by zero "max_uA" and
thus causes unexpected results after it is written to device.
Signed-off-by: Stanley Chu
---
drivers/scsi/ufs/ufshcd.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --
unexpected.
* For other regulators with undefined voltage range, voltage range
will be still undefined after patched.
Therefore this patch is safe for all existed regulators with
"-fixed-regulator" property already defined.
Signed-off-by: Stanley Chu
---
drivers/scsi/uf
1 - 100 of 176 matches
Mail list logo
