Provide more information of fatal errros and auto-hibern8 errors
to improve debugging by extending existed UFS error history
framework.

Signed-off-by: Stanley Chu <stanley....@mediatek.com>
---
 drivers/scsi/ufs/ufshcd.c | 11 ++++++++++-
 drivers/scsi/ufs/ufshcd.h |  6 ++++++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index eb062aba0d21..b8b874311509 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -429,6 +429,9 @@ static void ufshcd_print_host_regs(struct ufs_hba *hba)
        ufshcd_print_err_hist(hba, &hba->ufs_stats.nl_err, "nl_err");
        ufshcd_print_err_hist(hba, &hba->ufs_stats.tl_err, "tl_err");
        ufshcd_print_err_hist(hba, &hba->ufs_stats.dme_err, "dme_err");
+       ufshcd_print_err_hist(hba, &hba->ufs_stats.fatal_err, "fatal_err");
+       ufshcd_print_err_hist(hba, &hba->ufs_stats.auto_hibern8_err,
+                             "auto_hibern8_err");
 
        ufshcd_print_clk_freqs(hba);
 
@@ -5440,8 +5443,10 @@ static void ufshcd_check_errors(struct ufs_hba *hba)
 {
        bool queue_eh_work = false;
 
-       if (hba->errors & INT_FATAL_ERRORS)
+       if (hba->errors & INT_FATAL_ERRORS) {
+               ufshcd_update_reg_hist(&hba->ufs_stats.fatal_err, hba->errors);
                queue_eh_work = true;
+       }
 
        if (hba->errors & UIC_ERROR) {
                hba->uic_error = 0;
@@ -5456,6 +5461,8 @@ static void ufshcd_check_errors(struct ufs_hba *hba)
                        __func__, (hba->errors & UIC_HIBERNATE_ENTER) ?
                        "Enter" : "Exit",
                        hba->errors, ufshcd_get_upmcrs(hba));
+               ufshcd_update_reg_hist(&hba->ufs_stats.auto_hibern8_err,
+                                      hba->errors);
                queue_eh_work = true;
        }
 
@@ -6693,6 +6700,8 @@ static void ufshcd_clear_dbg_ufs_stats(struct ufs_hba 
*hba)
        memset(&hba->ufs_stats.nl_err, 0, err_reg_hist_size);
        memset(&hba->ufs_stats.tl_err, 0, err_reg_hist_size);
        memset(&hba->ufs_stats.dme_err, 0, err_reg_hist_size);
+       memset(&hba->ufs_stats.fatal_err, 0, err_reg_hist_size);
+       memset(&hba->ufs_stats.auto_hibern8_err, 0, err_reg_hist_size);
 
        hba->req_abort_count = 0;
 }
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index dcc61f857c38..edd9a6f9cc3b 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -440,11 +440,17 @@ struct ufs_err_reg_hist {
 struct ufs_stats {
        u32 hibern8_exit_cnt;
        ktime_t last_hibern8_exit_tstamp;
+
+       /* uic specific errors */
        struct ufs_err_reg_hist pa_err;
        struct ufs_err_reg_hist dl_err;
        struct ufs_err_reg_hist nl_err;
        struct ufs_err_reg_hist tl_err;
        struct ufs_err_reg_hist dme_err;
+
+       /* fatal errors */
+       struct ufs_err_reg_hist fatal_err;
+       struct ufs_err_reg_hist auto_hibern8_err;
 };
 
 /**
-- 
2.18.0

Reply via email to