Hi Avri,
> > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index
> > 149d406aacc9..2218d57c4c0c 100644
> > --- a/drivers/scsi/sd.c
> > +++ b/drivers/scsi/sd.c
> > @@ -3371,6 +3371,9 @@ static int sd_probe(struct device *dev)
> > }
> >
> > blk_pm_runtime_init(sdp->request_queue, dev);
> > + if (sdp->rpm_autosuspend_delay > 0)
> > + pm_runtime_set_autosuspend_delay(dev,
> > +
> Redundant line ?
checkpatch reported "WARNING:LONG_LINE:line over 80 characters" when I
made this as oneline : (
> > + sdp->rpm_autosuspend_delay);
> Don't you need to call now pm_runtime_use_autosuspend() ?
dev->power.user_autosuspend was set by blk_pm_runtime_init() above, thus
pm_runtime_use_autosuspend() is not necessary here.
>
> > device_add_disk(dev, gd, NULL);
> > if (sdkp->capacity)
> > sd_dif_config_host(sdkp); diff --git
> > a/include/scsi/scsi_device.h
> > b/include/scsi/scsi_device.h index 202f4d6a4342..133b282fae5a 100644
> > --- a/include/scsi/scsi_device.h
> > +++ b/include/scsi/scsi_device.h
> > @@ -199,7 +199,7 @@ struct scsi_device {
> > unsigned broken_fua:1; /* Don't set FUA bit */
> > unsigned lun_in_cdb:1; /* Store LUN bits in CDB[1] */
> > unsigned unmap_limit_for_ws:1; /* Use the UNMAP limit for WRITE
> > SAME */
> > -
> > + int rpm_autosuspend_delay;
> Can suspend be negative?
Yes, however negative delay value will block rpm.
Here we just use the same type as parameter "delay" of
pm_runtime_set_autosuspend() even though we do not set it as negative
value in this version.
But thank you so much to remind me that
pm_runtime_set_autosuspend_delay() can accept "zero" delay so we shall
allow "zero" sdev->rpm_autosuspend_delay as well.
I will fix it in v2.
>
> > atomic_t disk_events_disable_depth; /* disable depth for disk
> > events */
> >
> > DECLARE_BITMAP(supported_events, SDEV_EVT_MAXBITS); /*
> > supported events */
> > --
> > 2.18.0
>
Thanks,
Stanley
