Re: [PATCH 00/14] qedf: Miscellaneous fixes.

Hi Martin, On 30/08/19, 4:22 AM, "Martin K. Petersen" wrote: > >Saurav, > >> This series have bug fixes and improve the log messages for better >> debugging. >> >> Kindly apply this series to scsi-queue at your earliest convenience. > >Applied to 5.4/scsi-queue. I fixed a warning in patch #8. Pl

Re: [PATCH 2/3] scsi: bnx2fc: remove set but not used variables 'lport','host'

cmd->device->host; if (!sc_cmd->SCp.ptr) { printk(KERN_ERR PFX "SCp.ptr is NULL\n"); return; -- 2.7.4 Hi, Thanks for patch. Acked-by: Saurav Kashyap Thanks, ~Saurav

Re: [PATCH 3/3] scsi: bnx2fc: remove set but not used variables 'task','port','orig_task'

ctx.read_info.sgl_ctx.sgl; sgl->mul_sgl.cur_sge_addr.lo = (u32)phys_addr; -- 2.7.4 Hi, Thanks for patch. Acked-by: Saurav Kashyap Thanks, ~Saurav

Re: [PATCH 1/3] scsi: bnx2fc: remove set but not used variable 'fh'

t_header(skb, sizeof(struct fcoe_hdr)); - fh = (struct fc_frame_header *) skb_transport_header(skb); fr = fcoe_dev_from_skb(skb); fr->fr_dev = lport; -- 2.7.4 Hi, Thanks for patch. Acked-by: Saurav Kashyap Thanks, ~Saurav

[PATCH 13/14] qedf: Fix race betwen fipvlan request and response path.

fails to call ctrl_link_up. Fix: - while setting vlan_id use local variable and before setting vlan_id. - call fcoe_ctlr_link_up in next iteration of fipvlan request. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 25 - 1 file changed, 12 insertions

[PATCH 07/14] qedf: Add support for 20 Gbps speed.

- The current code doeesn't support 20Gbps speed for current and supported speed, add support for the same. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_m

[PATCH 09/14] qedf: Initiator fails to re-login to switch after link down.

ck if any one of these 3 is valid and if so, handle the CVL (basically switching from AND to OR). The port name field is definitely expected to be valid always. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_fip.c | 28 +--- 1 file changed, 17 insertions(+

[PATCH 05/14] qedf: Add shutdown callback handler.

- Add shutdown callback handler. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 6959f7c..a824bbb 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b

[PATCH 06/14] qedf: Interpret supported caps value correctly.

- Driver was wrongly interpreting the supported cap value returned by qed. Solution: Use QED define macros instead of OS defined for interpreting supporting speeds. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 32 +++- 1 file changed, 27

[PATCH 08/14] qedf: Add debug information for unsolicited processing.

- log s_id, d_id, type and command to the log message. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 7377a53..27989b3 100644 --- a/drivers/scsi/qedf/qedf_io.c

[PATCH 14/14] qedf: Update the version to 8.42.3.0.

- Update the driver version to 8.42.3.0 Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_version.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qedf/qedf_version.h b/drivers/scsi/qedf/qedf_version.h index e57533d..b0e37af 100644 --- a/drivers

[PATCH 04/14] qedf: Update module description string.

From: Nilesh Javali Update module description. Signed-off-by: Nilesh Javali Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 2d69860..6959f7c

[PATCH 00/14] qedf: Miscellaneous fixes.

Nilesh Javali (1): qedf: Update module description string. Saurav Kashyap (11): qedf: Print message during bailout conditions. qedf: Stop sending fipvlan request on unload. qedf: Add shutdown callback handler. qedf: Interpret supported caps value correctly. qedf: Add support for 20

[PATCH 11/14] qedf: Decrease the LL2 MTU size to 2500.

- Decrease the LL2 MTU size to 2500. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf.h | 1 + drivers/scsi/qedf/qedf_main.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf.h b/drivers/scsi/qedf/qedf.h index 5a02121..f3f399f 100644 --- a

[PATCH 03/14] qedf: Fix crash during sg_reset.

] [84790.865204] Call Trace: [84790.865246] scsi_try_target_reset+0x2b/0x90 [scsi_mod] [84790.865266] scsi_ioctl_reset+0x20f/0x2a0 [scsi_mod] [84790.865284] scsi_ioctl+0x131/0x3a0 [scsi_mod] Signed-off-by: Arun Easi Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 4 ++-- 1 file

[PATCH 12/14] qedf: Use discovery list to traverse rports

From: Hannes Reinecke The list of rports might become stale, so we should rather traverse the discovery list when trying relogin. Signed-off-by: Hannes Reinecke Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 39 +++ 1 file changed, 7

[PATCH 10/14] qedf: Check for module unloading bit before processing link update AEN.

- Prevent race where we're removing the module and we get link update Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 50b1fa8..ab9a932 100644

[PATCH 01/14] qedf: Print message during bailout conditions.

- Print messages during exiting condition to help debugging. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_debugfs.c | 16 +-- drivers/scsi/qedf/qedf_els.c | 38 -- drivers/scsi/qedf/qedf_fip.c | 5 +++- drivers/scsi/qedf/qedf_io.c | 58

[PATCH 02/14] qedf: Stop sending fipvlan request on unload.

- On some setups fipvlan can be retried for long duration and the connection to switch was not there so it was not getting any reply. - During unload this thread was hanging. Problem Resolution: Check if unload is in progress then quit from fipvlan thread. Signed-off-by: Saurav Kashyap

Re: [EXT] [PATCH v2 2/2] scsi :bnx2fc :bnx2fc_els :fix bnx2fc_cmd refcount imbalance in send_srr

iled - release\n"); > spin_lock_bh(&tgt->tgt_lock); >@@ -664,6 +663,7 @@ int bnx2fc_send_srr(struct bnx2fc_cmd *orig_io_req, >u32 offset, u8 r_ctl) > } else > set_bit(BNX2FC_FLAG_SRR_SENT, &orig_io_req->req_flags); > >+srr_err: > return rc; > } > >-- >1.9.1 Thanks for the patch. Asked-by: Saurav Kashyap > >

Re: [EXT] [PATCH v2 1/2] scsi :bnx2fc :bnx2fc_els :fix bnx2fc_cmd refcount imbalance in send_rec

elease\n"); > spin_lock_bh(&tgt->tgt_lock); >@@ -618,6 +617,7 @@ int bnx2fc_send_rec(struct bnx2fc_cmd *orig_io_req) > spin_unlock_bh(&tgt->tgt_lock); > kfree(cb_arg); > } >+rec_err: > return rc; > } > >-- >1.9.1 Thanks for the patch. Acked-by: Saurav Kashyap > >

Re: [PATCH 2/2] scsi :bnx2fc :bnx2fc_els :fix bnx2fc_cmd refcount imbalance in send_srr

Hi Lin, On 23/06/19, 7:28 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Lin Yi" wrote: >if cb_arg alloc failed, we can't release orig_io_req refcount before >we take it's refcount. call kref_get before malloc, so as to pair with >the kref_put on the srr_err path. > >Signed-off-by: Lin Yi

Re: [PATCH 1/2] scsi :bnx2fc :bnx2fc_els :fix bnx2fc_cmd refcount imbalance in send_rec

Hi Lin, On 23/06/19, 7:27 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Lin Yi" wrote: >if cb_arg alloc failed, we can't release the struct orig_io_req refcount >before we take it's refcount. call kref_get before malloc, so as to pair >with kref_put on rec_err path. > >Signed-off-by: Lin Yi

[PATCH 4/6] bnx2fc: Do not allow both a cleanup completion and abort completion for the same request.

- If firmware send any one of cleanup or abort completion, it means other won't be send, clean out flags for other as well. Signed-off-by: Saurav Kashyap --- drivers/scsi/bnx2fc/bnx2fc.h| 1 + drivers/scsi/bnx2fc/bnx2fc_io.c | 32 2 files change

[PATCH 5/6] bnx2fc: Limit the IO size according to the FW capability.

- Reduce the sg_tablesize to 255. - Reduce the MAX BDs firmware can handle to 255. - Return IO to ML if BD goes more then 255 after split. - Correct the size of each BD split to 0x. Signed-off-by: Saurav Kashyap --- drivers/scsi/bnx2fc/bnx2fc.h | 5 +++-- drivers/scsi/bnx2fc

[PATCH 2/6] bnx2fc: Only put reference to io_req in bnx2fc_abts_cleanup if cleanup times out.

e fix for this is to only take the extra put in bnx2fc_abts_cleanup if the completion for the cleanup times out. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/bnx2fc/bnx2fc_io.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH 0/6] bnx2fc: Update to the driver.

times out. Saurav Kashyap (4): bnx2fc: Separate out completion flags and variables for abort and cleanup. bnx2fc: Do not allow both a cleanup completion and abort completion for the same request. bnx2fc: Limit the IO size according to the FW capability. bnx2fc: Update the driver

[PATCH 1/6] bnx2fc: Redo setting source FCoE MAC.

ame. 3. If there is no FCF-MAP the use the spec. default FCF-MAP and the destination ID from the frame. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/bnx2fc/bnx2fc_els.c | 56 1 file changed, 40 insertions(+), 16 deleti

[PATCH 6/6] bnx2fc: Update the driver version to 2.12.10.

Update the driver version to 2.12.10. Signed-off-by: Saurav Kashyap --- drivers/scsi/bnx2fc/bnx2fc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b/drivers/scsi/bnx2fc/bnx2fc.h index 170abe9..3b84db8 100644 --- a/drivers/scsi/bnx2fc/bnx2fc.h

[PATCH 3/6] bnx2fc: Separate out completion flags and variables for abort and cleanup.

- Separate out abort and cleanup flag and completion, to have better understaning of what is getting processed. Signed-off-by: Saurav Kashyap --- drivers/scsi/bnx2fc/bnx2fc.h | 6 ++-- drivers/scsi/bnx2fc/bnx2fc_io.c | 59 ++-- drivers/scsi/bnx2fc

Re: [PATCH] scsi: bnx2fc: fix incorrect cast to u64 on shift operation

for (i = 0; i < BNX2FC_NUM_ERR_BITS; i++) { >- if (err_warn_bit_map & (u64) (1 << i)) { >+ if (err_warn_bit_map & ((u64)1 << i)) { > err_warn = i; > break; > } >-- >2.20.1 Thanks for the Patch. Acked-by: Saurav Kashyap >

Re: [PATCH -next] scsi: qedf: remove set but not used variables

ct qedf_els_cb_arg *cb_arg = NULL; >- u32 sid, r_a_tov; >+ u32 r_a_tov; > int rc; > > if (!orig_io_req) { >@@ -635,7 +628,6 @@ static int qedf_send_srr(struct qedf_ioreq >*orig_io_req, u32 offset, u8 r_ctl) > > qedf = fcport->qedf; > lport = qedf->lport; >- sid = fcport->sid; > r_a_tov = lport->r_a_tov; > > QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_ELS, "Sending SRR orig_io=%p, " >-- >2.7.0 Thanks, Acked-by: Saurav Kashyap > >

[PATCH 12/12] qedf: Update the driver version to 8.37.25.20.

- Update the driver version to 8.37.25.20. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf/qedf_version.h b/drivers/scsi/qedf/qedf_version.h index 9a06a58..334a9cd 100644 --- a/drivers

[PATCH 04/12] qedf: Add LBA to underrun debug messages.

From: Chad Dupuis - Print LBA information for underrun cases. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c

[PATCH 06/12] qedf: Add comment to display logging levels.

- Comment will help in decoding the logging level. Signed-off-by: Saurav Kashyap Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/qedf/qedf.h b/drivers/scsi/qedf/qedf.h index f647817..2c08f6f 100644 --- a/drivers

[PATCH 01/12] qedf: Change MSI-X load error message.

From: Chad Dupuis - Change the message to display load failure. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index

[PATCH 09/12] qedf: Check the return value of start_xmit.

- Log the reason for start xmit failure. Signed-off-by: Saurav Kashyap Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_fip.c | 17 +++-- drivers/scsi/qedf/qedf_main.c | 7 ++- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_fip.c b

[PATCH 05/12] qedf: Add port_id for fcport into initiate_cleanup debug message.

From: Chad Dupuis - port id will help in debugging. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 29b456d

[PATCH 03/12] qedf: Print scsi_cmd backpointer in good completion path if the command is still being used.

From: Chad Dupuis - Printing scsi command pointer will help in crash dump analysis. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi

[PATCH 00/12] qedf: Changes to log messages

edf: Print scsi_cmd backpointer in good completion path if the command is still being used. qedf: Add LBA to underrun debug messages. qedf: Add port_id for fcport into initiate_cleanup debug message. Saurav Kashyap (7): qedf: Add comment to display logging levels. qedf: Check for fcoe_li

[PATCH 07/12] qedf: Check for fcoe_libfc_config failure.

From: Saurav Kashyap - Print the fcoe_libfc_config failure and return proper failure. Signed-off-by: Saurav Kashyap Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers

[PATCH 08/12] qedf: Log message if scsi_add_host fails.

- print message on scsi_add_host failure. Signed-off-by: Saurav Kashyap Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index a527b9b..e2f3228

[PATCH 02/12] qedf: Add driver state to 'driver_stats' debugfs node.

From: Chad Dupuis - Add debugs node for driver stats. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_debugfs.c | 55 +--- 1 file changed, 52 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_debugfs.c b

[PATCH 10/12] qedf: Print fcport information on wait for upload timeout.

- Log fcport for which upload failed. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 1de2b18..ffe536e 100644 --- a/drivers/scsi/qedf

[PATCH 11/12] qedf: Add return value to log message if scsi_add_host fails.

- Print return value of scsi_add_host on failure. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index ffe536e..5b07235 100644 --- a/drivers

[PATCH] Revert "scsi: fcoe: clear FC_RP_STARTED flags when receiving a LOGO"

This patch clears FC_RP_STARTED flag during logoff, because of this re-login(flogi) didn't happen to the switch. This reverts commit 1550ec458e0cf1a40a170ab1f4c46e3f52860f65. --- drivers/scsi/libfc/fc_rport.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_rport.c b/drive

Re: [PATCH][V2] scsi: qedf: remove memset/memcpy to nfunc and use func instead

_format vaf; >- char nfunc[32]; >- >- memset(nfunc, 0, sizeof(nfunc)); >- memcpy(nfunc, func, sizeof(nfunc) - 1); > > va_start(va, fmt); > >@@ -114,9 +98,9 @@ qedf_dbg_info(struct qedf_dbg_ctx *qedf, const char >*func, u32 line, > > if (likely(qedf) && likely(qedf->pdev)) > pr_info("[%s]:[%s:%d]:%d: %pV", dev_name(&(qedf->pdev->dev)), >- nfunc, line, qedf->host_no, &vaf); >+ func, line, qedf->host_no, &vaf); > else >- pr_info("[:00:00.0]:[%s:%d]: %pV", nfunc, line, &vaf); >+ pr_info("[:00:00.0]:[%s:%d]: %pV", func, line, &vaf); > > ret: > va_end(va); >-- >2.20.1 Thanks, Acked-by: Saurav Kashyap >

Re: [EXT] Re: [PATCH v2 00/26] qedf: Misc fixes for the driver.

Hi Martin, We will take care from next time, thanks for the support. Thanks, ~Saurav -Original Message- From: "Martin K. Petersen" Organization: Oracle Corporation Date: Thursday, 28 March 2019 at 7:43 AM To: Saurav Kashyap Cc: "martin.peter...@oracle.com" , &

[PATCH v2 26/26] qedf: Update the driver version to 8.37.25.19.

- Update the driver version. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_version.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qedf/qedf_version.h b/drivers/scsi/qedf/qedf_version.h index 9455faa..9a06a58 100644 --- a/drivers/scsi/qedf

[PATCH v2 23/26] qedf: Cleanup rrq_work after QEDF_CMD_OUTSTANDING is cleared.

succeed, we drop the reference and free the io_req. If we cannot, then the els will get sent out and we will wait for 10 secs for it to complete. Signed-off-by: Shyam Sundar Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf.h| 17 +++ drivers/scsi/qedf/qedf_i

[PATCH v2 25/26] qedf: Fix lport may be used uninitialezed warning.

- lport was getting used without initialization, initialize it to fix a warning. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index b359ae3

[PATCH v2 24/26] qedf: Correctly handle refcounting of rdata.

- handle refcount of rdata during error conditions. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index db5d49e..b359ae3

[PATCH v2 22/26] qedf: Check for tm_flags instead of cmd_type during cleanup.

cmd_type is over written to QEDF_CLEANUP during cleanup, so check for tm_flags. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 4a792ea..ca7ca8c

[PATCH v2 20/26] qedf: Don't send ABTS for under run scenario.

- Command is already completed with underrun so no need to send ABTS. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index eeb96c7..889b300

[PATCH v2 21/26] qedf: Add a flag to help debugging io_req which could not be cleaned.

From: Shyam Sundar - The flag will help in to figure out if io_req is cleaned or not. Signed-off-by: Shyam Sundar Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c

[PATCH v2 16/26] qedf: Add missing return in qedf_scsi_done().

From: Chad Dupuis On completions where we do not have a bad scsi_cmnd pointer we should return before the the label lest we do a double kref_put. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v2 10/26] qedf: Check for link state before processing LL2 packets and send fipvlan retries.

- Check if link is UP before sending and processing any packets on wire. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_fip.c | 6 ++ drivers/scsi/qedf/qedf_main.c | 28 ++-- 2 files changed, 28 insertions(+), 6 deletions(-) diff --git a/drivers/scsi

[PATCH v2 18/26] qedf: Check both the FCF and fabric ID before servicing clear virtual link.

From: Chad Dupuis - Check proper values before servicing CVL. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_fip.c | 66 1 file changed, 48 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/qedf

[PATCH v2 07/26] qedf: Use a separate completion for cleanup commands.

From: Chad Dupuis - If a TMF and cleanup are issued at the same time they could cause a call trace if issued against the same xid as the io_req->tm_done completion is used for both. - Set and clear cleanup bit in cleanup routine. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kash

[PATCH v2 11/26] qedf: missing kref_put in qedf_xmit()

From: Hannes Reinecke qedf_xmit() calls fc_rport_lookup(), but discards the returned rdata structure almost immediately without decreasing the refcount. This leads to a refcount leak and the rdata never to be freed. Signed-off-by: Hannes Reinecke Signed-off-by: Saurav Kashyap --- drivers

[PATCH v2 17/26] qedf: fc_rport_priv reference counting fixes

From: Hannes Reinecke The fc_rport_priv structure is reference counted, so we need to ensure that the reference is increased before accessing the structure. Signed-off-by: Hannes Reinecke Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_els.c | 9 - drivers/scsi/qedf

[PATCH v2 19/26] qedf: Don't queue anything if upload is in progress.

From: Shyam Sundar - I/Os, aborts and tmf should not be queued if flush is in progress. Signed-off-by: Shyam Sundar Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers

[PATCH v2 15/26] qedf: Wait for upload and link down processing during soft ctx reset.

From: Chad Dupuis - Wait for all the connections to get uploaded. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf.h | 4 ++- drivers/scsi/qedf/qedf_fip.c | 4 +-- drivers/scsi/qedf/qedf_main.c | 60 ++- 3

[PATCH v2 12/26] qedf: fixup locking in qedf_restart_rport()

From: Hannes Reinecke fc_rport_create() needs to be called with disc_mutex held. And we should re-assign the 'rdata' pointer in case it got changed. Signed-off-by: Hannes Reinecke Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_els.c | 8 +++- 1 file changed, 7 insert

[PATCH v2 05/26] qedf: Modify flush routine to handle all I/Os and TMF.

Shyam Sundar Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf.h | 6 + drivers/scsi/qedf/qedf_els.c | 4 + drivers/scsi/qedf/qedf_io.c | 285 ++ drivers/scsi/qedf/qedf_main.c | 8 +- 4 files changed

[PATCH v2 04/26] qedf: Simplify s/g list mapping.

SGE Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf.h | 8 +-- drivers/scsi/qedf/qedf_debugfs.c | 2 - drivers/scsi/qedf/qedf_io.c | 124 --- 3 files changed, 40 insertions(+), 94 deletions(-) diff --git a/driv

[PATCH v2 08/26] qedf: Correct the memory barriers in qedf_ring_doorbell.

From: Andrew Vasquez - Correct memory barriers to make sure all cmnds are flushed. Signed-off-by: Andrew Vasquez Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b

[PATCH v2 06/26] qedf: Modify abort and tmf handler to handle edge condition and flush.

RRQ is pending. - Differentiate LUN/TARGET reset, as cleanup needs to be send to firmware accordingly. - Add flush mutex to sync cleanup call from abort and flush routine. - Clear abort/outstanding bit on timeout. Signed-off-by: Shyam Sundar Signed-off-by: Chad Dupuis Signed-off-by: Saurav

[PATCH v2 13/26] qedf: fixup bit operations.

From: Hannes Reinecke test_bit() is atomic, test_bit() || test_bit() is not. So protect consecutive bit tests with a lock to avoid races. Signed-off-by: Hannes Reinecke Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_els.c | 4 drivers/scsi/qedf/qedf_main.c | 5 - 2 files

[PATCH v2 14/26] qedf: Add additional checks for io_req->sc_cmd validity.

From: Chad Dupuis - Check the validity of various pointers before processing. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/scsi

[PATCH v2 09/26] qedf: Add missing fc_disc_init call after allocating lport.

d-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 3fd8107..dee6fef 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -3042,6 +3042,8 @@ s

[PATCH v2 03/26] qedf: Add missing return in qedf_post_io_req() in the fcport offload check.

2] RIP [] qedf_init_task.isra.16+0x3d/0x450 [qedf] [30259.990630] RSP [30259.994127] CR2: 0198 Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qed

[PATCH v2 01/26] qedf: Do not retry ELS request if qedf_alloc_cmd fails.

/0x3c0 [] ? manage_workers.isra.24+0x2a0/0x2a0 [] kthread+0xd1/0xe0 [] ? insert_kthread_work+0x40/0x40 [] ret_from_fork_nospec_begin+0x21/0x21 [] ? insert_kthread_work+0x40/0x40 Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_els.c | 16 1

[PATCH v2 02/26] qedf: Correct xid range overlap between offloaded requests and libfc requests.

: Saurav Kashyap --- drivers/scsi/qedf/qedf.h | 5 - drivers/scsi/qedf/qedf_io.c | 6 +++--- drivers/scsi/qedf/qedf_main.c | 13 - 3 files changed, 7 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/qedf/qedf.h b/drivers/scsi/qedf/qedf.h index 2c78d8f..8e75c21 100644

[PATCH v2 00/26] qedf: Misc fixes for the driver.

urn in qedf_scsi_done(). qedf: Check both the FCF and fabric ID before servicing clear virtual link. Hannes Reinecke (4): qedf: missing kref_put in qedf_xmit() qedf: fixup locking in qedf_restart_rport() qedf: fixup bit operations. qedf: fc_rport_priv reference counting fixes Saurav Kash

Re: [PATCH 04/26] qedf: Simplify s/g list mapping.

Hi Martin, I will provide an update patch list soon. Thanks, ~Saurav -Original Message- From: "Martin K. Petersen" Organization: Oracle Corporation Date: Tuesday, 19 March 2019 at 5:32 AM To: Saurav Kashyap , Chad Dupuis Cc: "kbuild-...@01.org" , "m

Re: [PATCH 00/26] qedf: Misc fixes for the driver.

Hi Martin, Kindly share the latest update on this. Thanks, ~Saurav -Original Message- From: Saurav Kashyap Date: Tuesday, 5 March 2019 at 4:29 PM To: "martin.peter...@oracle.com" Cc: "qlogic-storage-upstr...@cavium.com" , "linux-scsi@vger.kernel.org"

[PATCH 24/26] qedf: Correctly handle refcounting of rdata.

- handle refcount of rdata during error conditions. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index d98f5f4..b9877f1

[PATCH 26/26] qedf: Update the driver version to 8.37.25.19.

- Update the driver version. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_version.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qedf/qedf_version.h b/drivers/scsi/qedf/qedf_version.h index 9455faa..9a06a58 100644 --- a/drivers/scsi/qedf

[PATCH 25/26] qedf: Fix lport may be used uninitialezed warning.

- lport was getting used without initialization, initialize it to fix a warning. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index b9877f1

[PATCH 23/26] qedf: Cleanup rrq_work after QEDF_CMD_OUTSTANDING is cleared.

succeed, we drop the reference and free the io_req. If we cannot, then the els will get sent out and we will wait for 10 secs for it to complete. Signed-off-by: Shyam Sundar Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf.h| 17 +++ drivers/scsi/qedf/qedf_i

[PATCH 22/26] qedf: Check for tm_flags instead of cmd_type during cleanup.

cmd_type is over written to QEDF_CLEANUP during cleanup, so check for tm_flags. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 90d1645..d8d55bc

[PATCH 18/26] qedf: Check both the FCF and fabric ID before servicing clear virtual link.

From: Chad Dupuis - Check proper values before servicing CVL. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_fip.c | 66 1 file changed, 48 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/qedf

[PATCH 19/26] qedf: Don't queue anything if upload is in progress.

From: Shyam Sundar - I/Os, aborts and tmf should not be queued if flush is in progress. Signed-off-by: Shyam Sundar Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers

[PATCH 20/26] qedf: Don't send ABTS for under run scenario.

- Command is already completed with underrun so no need to send ABTS. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 30932a8..5e7745e

[PATCH 21/26] qedf: Add a flag to help debugging io_req which could not be cleaned.

From: Shyam Sundar - The flag will help in to figure out if io_req is cleaned or not. Signed-off-by: Shyam Sundar Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c

[PATCH 16/26] qedf: Add missing return in qedf_scsi_done().

From: Chad Dupuis On completions where we do not have a bad scsi_cmnd pointer we should return before the the label lest we do a double kref_put. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH 17/26] qedf: fc_rport_priv reference counting fixes

From: Hannes Reinecke The fc_rport_priv structure is reference counted, so we need to ensure that the reference is increased before accessing the structure. Signed-off-by: Hannes Reinecke Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_els.c | 9 - drivers/scsi/qedf

[PATCH 09/26] qedf: Add missing fc_disc_init call after allocating lport.

d-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 3fd8107..dee6fef 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -3042,6 +3042,8 @@ s

[PATCH 14/26] qedf: Add additional checks for io_req->sc_cmd validity.

From: Chad Dupuis - Check the validity of various pointers before processing. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/scsi

[PATCH 00/26] qedf: Misc fixes for the driver.

ore servicing clear virtual link. Hannes Reinecke (4): qedf: missing kref_put in qedf_xmit() qedf: fixup locking in qedf_restart_rport() qedf: fixup bit operations. qedf: fc_rport_priv reference counting fixes Saurav Kashyap (7): qedf: Modify abort and tmf handler to handle edge condit

[PATCH 07/26] qedf: Use a separate completion for cleanup commands.

From: Chad Dupuis - If a TMF and cleanup are issued at the same time they could cause a call trace if issued against the same xid as the io_req->tm_done completion is used for both. - Set and clear cleanup bit in cleanup routine. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kash

[PATCH 01/26] qedf: Do not retry ELS request if qedf_alloc_cmd fails.

/0x3c0 [] ? manage_workers.isra.24+0x2a0/0x2a0 [] kthread+0xd1/0xe0 [] ? insert_kthread_work+0x40/0x40 [] ret_from_fork_nospec_begin+0x21/0x21 [] ? insert_kthread_work+0x40/0x40 Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_els.c | 16 1

[PATCH 10/26] qedf: Check for link state before processing LL2 packets and send fipvlan retries.

- Check if link is UP before sending and processing any packets on wire. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_fip.c | 6 ++ drivers/scsi/qedf/qedf_main.c | 28 ++-- 2 files changed, 28 insertions(+), 6 deletions(-) diff --git a/drivers/scsi

[PATCH 02/26] qedf: Correct xid range overlap between offloaded requests and libfc requests.

: Saurav Kashyap --- drivers/scsi/qedf/qedf.h | 5 - drivers/scsi/qedf/qedf_io.c | 6 +++--- drivers/scsi/qedf/qedf_main.c | 13 - 3 files changed, 7 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/qedf/qedf.h b/drivers/scsi/qedf/qedf.h index 2c78d8f..8e75c21 100644

[PATCH 12/26] qedf: fixup locking in qedf_restart_rport()

From: Hannes Reinecke fc_rport_create() needs to be called with disc_mutex held. And we should re-assign the 'rdata' pointer in case it got changed. Signed-off-by: Hannes Reinecke Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_els.c | 8 +++- 1 file changed, 7 insert

[PATCH 15/26] qedf: Wait for upload and link down processing during soft ctx reset.

From: Chad Dupuis - Wait for all the connections to get uploaded. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf.h | 4 ++- drivers/scsi/qedf/qedf_fip.c | 4 +-- drivers/scsi/qedf/qedf_main.c | 60 ++- 3

[PATCH 13/26] qedf: fixup bit operations.

From: Hannes Reinecke test_bit() is atomic, test_bit() || test_bit() is not. So protect consecutive bit tests with a lock to avoid races. Signed-off-by: Hannes Reinecke Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_els.c | 4 drivers/scsi/qedf/qedf_main.c | 5 - 2 files

[PATCH 08/26] qedf: Correct the memory barriers in qedf_ring_doorbell.

From: Andrew Vasquez - Correct memory barriers to make sure all cmnds are flushed. Signed-off-by: Andrew Vasquez Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b

[PATCH 11/26] qedf: missing kref_put in qedf_xmit()

From: Hannes Reinecke qedf_xmit() calls fc_rport_lookup(), but discards the returned rdata structure almost immediately without decreasing the refcount. This leads to a refcount leak and the rdata never to be freed. Signed-off-by: Hannes Reinecke Signed-off-by: Saurav Kashyap --- drivers

  1   2   3   4   5   6   >