[PATCH v2 11/26] qedf: missing kref_put in qedf_xmit()

[Saurav Kashyap]

From: Hannes Reinecke <h...@suse.com>

qedf_xmit() calls fc_rport_lookup(), but discards the returned
rdata structure almost immediately without decreasing the refcount.
This leads to a refcount leak and the rdata never to be freed.

Signed-off-by: Hannes Reinecke <h...@suse.com>
Signed-off-by: Saurav Kashyap <skash...@marvell.com>
---
 drivers/scsi/qedf/qedf_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index f84552e..fb9c288 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -971,8 +971,10 @@ static int qedf_xmit(struct fc_lport *lport, struct 
fc_frame *fp)
                    "Dropping FCoE frame to %06x.\n", ntoh24(fh->fh_d_id));
                kfree_skb(skb);
                rdata = fc_rport_lookup(lport, ntoh24(fh->fh_d_id));
-               if (rdata)
+               if (rdata) {
                        rdata->retries = lport->max_rport_retry_count;
+                       kref_put(&rdata->kref, fc_rport_destroy);
+               }
                return -EINVAL;
        }
        /* End NPIV filtering */
-- 
1.8.3.1