trying to set queue depth.
Reported-by: Steve Best
Fixes: 0bcb45fb20c2a ("scsi: aacraid: Add helper function to set queue depth")
cc: sta...@vger.kernel.org
Signed-off-by: Raghava Aditya Renukunta
Reviewed-by: David Carroll
---
drivers/scsi/aacraid/aachba.c | 15 +++
1 fi
a7e30] [c000b528]
> ret_from_kernel_thread+0x5c/0xb4
> [ 336.645971] Instruction dump:
> [ 336.648743] 384216a0 7c0802a6 fbe1fff8 f8010010 f821ffd1 7c7f1b78
> 6000 6000
> [ 336.657056] 3940 e87f0838 f95f0838 7c0004ac <7d401828> 314affff
> 7d40192d 40c2fff4
> [ 336.663997] -[ end trace 4640cf8d4945ad95 ]-
>
> So flag when the thread is stopped by setting the thread pointer to NULL.
>
> Signed-off-by: Dave Carroll
Reviewed-by: Raghava Aditya Renukunta
During sync command processing if legacy INTx status indicates
command is not completed, sample the MSIx register and check if
it indicates command completion, set controller MSIx enabled flag.
Signed-off-by: Prasad B Munirathnam
Signed-off-by: Raghava Aditya Renukunta
Reviewed-by: Dave Carroll
the IOP_RESET.
Signed-off-by: Prasad B Munirathnam
Signed-off-by: Raghava Aditya Renukunta
Reviewed-by: Dave Carroll
---
Changes in V2:
Re based on Linus Master
drivers/scsi/aacraid/aacraid.h | 4 +
drivers/scsi/aacraid/src.c | 161 +++--
2 files
Preserve the current MSIX mode value in the OMR before
rewriting the OMR to initiate the IOP or Soft Reset.
Signed-off-by: Prasad B Munirathnam
Signed-off-by: Raghava Aditya Renukunta
Reviewed-by: Dave Carroll
---
Changes in V2:
Re based on Linus Master
drivers/scsi/aacraid/src.c | 22
induces the fw to drop any pending IO in the fw and making the reset
process quicker.
Changes in v2:
Respun patchset against Linus Master
Added Dave Carroll's reviewed-by tags
Raghava Aditya Renukunta (3):
scsi: aacraid: Implement DropIO sync command
scsi: aacraid: Preserve MSIX mode in th
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf Of Martin K. Petersen
> Sent: Tuesday, February 6, 2018 4:21 PM
> To: Raghava Aditya Renukunta
>
> Cc: j...@linux.vnet.ibm.com; martin.peter...@o
induces the fw to drop any pending IO in the fw and making the reset
process quicker.
Raghava Aditya Renukunta (3):
scsi: aacraid: Implement DropIO sync command
scsi: aacraid: Preserve MSIX mode in the OMR register
scsi: aacraid: Auto detect INTx or MSIx mode during sync cmd
processing
the IOP_RESET.
Signed-off-by: Prasad B Munirathnam
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aacraid.h | 4 +
drivers/scsi/aacraid/src.c | 167 +++--
2 files changed, 163 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi
Preserve the current MSIX mode value in the OMR before
rewriting the OMR to initiate the IOP or Soft Reset.
Signed-off-by: Prasad B Munirathnam
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/src.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a
During sync command processing if legacy INTx status indicates
command is not completed, sample the MSIx register and check if
it indicates command completion, set controller MSIx enabled flag.
Signed-off-by: Prasad B Munirathnam
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid
The delay for the rescan worker needs to 10 seconds, missed the HZ in
there.
Fixes: a1367e4adee207fe (scsi: aacraid: Reschedule host scan in case of failure)
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aacraid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
The correct lun count needs to be divided by 24, missed it in the previous
patch set.
Fixes: 4b00022753550055 (scsi: aacraid: Create helper functions to get lun info)
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
d: Fix udev inquiry race condition")
> Signed-off-by: Colin Ian King
> ---
Reviewed-by :Raghava Aditya Renukunta
64/0x34a0
> ? kernel_read_file+0x150/0x320
> SyS_finit_module+0x82/0xa0
> do_fast_syscall_32+0xba/0x340
>
> Signed-off-by: Meelis Roos
.
Reviewed-by: Raghava Aditya Renukunta
Hi Nikola,
> -Original Message-
> From: Nikola Pajkovsky [mailto:npajkov...@suse.cz]
> Sent: Wednesday, January 3, 2018 2:02 AM
> To: Raghava Aditya Renukunta
>
> Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux-
> s...@vger.kernel.org; Scott Benesh ;
Refactored the reset_host store function to make consistent across code
bases
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/linit.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi
Driver would hang when attempting to send reset from the ioctl interface,
since it would wait to retrieve the ioctl mutex at send shutdown.
Set adapter shutdown and unlock mutex before sending down reset request.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi
not. Add helper functions to add, remove and put
devices based on their fw bus and target number.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
Removed unnecessary check and assignment for bus number
drivers/scsi/aacraid/commsup.c | 71 --
1
Add back the ability to scan for hotplug changes while eh was in progress.
Schedule a rescan for a later time in the eh recovery code and wait for
eh to complete in the rescan worker.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/aacraid.h | 4
.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/aachba.c | 9 ---
drivers/scsi/aacraid/aacraid.h | 3 ++-
drivers/scsi/aacraid/commsup.c | 59 --
3 files changed, 30 insertions(+), 41 deletions(-)
diff --git a
devices are going to go away anyway.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/commsup.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index 706aba0..f0c3e7d 100644
Merge aac_get_containers to setup target function, so that information
about all the present devices can be retrieved in one shot.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/aachba.c | 4
drivers/scsi/aacraid/commsup.c | 34
Remove unused rescan variable.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/aachba.c | 19 +--
drivers/scsi/aacraid/aacraid.h | 6 +++---
drivers/scsi/aacraid/commsup.c | 14 +++---
drivers/scsi/aacraid/linit.c | 4 ++--
4
Update driver Version to 50877
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aacraid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h
index 4d3536d..3e8bfcf 100644
--- a/drivers/scsi/aacraid
safw. For ARC scsi_scan_host will still
apply.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/aachba.c | 4
drivers/scsi/aacraid/aacraid.h | 1 +
drivers/scsi/aacraid/commsup.c | 18 +++---
drivers/scsi/aacraid/linit.c | 5 +++--
4
Created inline function to retrieve lun info for each device from the
phy luns structure.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
Use get_unaligned_be32 instead of open ended conversion
drivers/scsi/aacraid/aachba.c | 54 +--
1 file
The device hotplug events are processed only after retrieving the updated
lun information from the fw. Does not make sense to keep them separate.
Merge both the hotplug handling and safw adapter setup code into single
function.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
Currently driver will attempt to process hotplug events concurrently based
on the FW interrupt.
Protect safw update function with a scan mutex.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/aacraid.h | 1 +
drivers/scsi/aacraid/commsup.c | 2 ++
drivers
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/comminit.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/aacraid/comminit.c b/drivers/scsi/aacraid/comminit.c
index 1bc623a..9eff246 100644
--- a/drivers/scsi
Added macros to loop through the MAX SUPPORTED Buses and Targets. This
will make the code a bit easier to read.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/aacraid.h | 4
drivers/scsi/aacraid/commsup.c | 34 +-
2
Aditya Renukunta
---
Changes in V2:
Replaced kmalloc and memcpy adapter_type_text with kmemdup
drivers/scsi/aacraid/aachba.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index af3e4d3..548a3e7
Rename variables and functions to make bmic identify, report phy luns
to make them consistent across code internal existing code bases
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/aachba.c | 36 +++-
drivers/scsi/aacraid
Tested-by: Guilherme G. Piccoli
Fixes: a2d0321dd532901e (scsi: aacraid: Reload offlined drives after controller
reset)
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
Changed reported by from Guilherme G. Piccoli to Douglas Miller
drivers/scsi/aacraid/aachba.c | 1 -
drivers/scsi
Save the bmic information for each phy, so that it can processed in
target setup function.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
Removed unused phy_luns variable
drivers/scsi/aacraid/aachba.c | 84 +++---
drivers/scsi/aacraid/aacraid.h
to be
exposed, this code can be removed.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/aachba.c | 10 --
drivers/scsi/aacraid/aacraid.h | 3 ---
2 files changed, 13 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid
happen on SAFW devices.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
Rename rescan worker to match kernel coding conventions
drivers/scsi/aacraid/aacraid.h | 27 ++-
drivers/scsi/aacraid/commsup.c | 14 +-
drivers/scsi/aacraid/linit.c | 5
Add helper function to set queue depth from information retrieved from
the bmic phy structure.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/aachba.c | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff
that one)
Raghava Aditya Renukunta (30):
scsi: aacraid: Fix udev inquiry race condition
scsi: aacraid: Do not attempt abort when Fw panicked
scsi: aacraid: Fix hang in kdump
scsi: aacraid: Do not remove offlined devices
scsi: aacraid: Fix ioctl reset hang
scsi: aacraid: Allow
As part of the recovery process, the drivers removes offline devices (
done by the kernel) and then tries to add them back in the rescan code.
Removing the device is like taking a sledgehammer to a nail.
Set the device as running if it is marked offline.
Signed-off-by: Raghava Aditya Renukunta
safw command submission is duplicated across many functions.
Move the safw submission code from bmic identify into its own function
for common use
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/aachba.c | 147
Remove function call to process targets from the report phy luns function
and make it a function in its own right. This will help understand the
flow of the code.
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/aachba.c | 44
Ideally driver needs to wait for IO to be submitted or responded to before
shutdown.
Move code to wait for IO completion into shutdown path
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/comminit.c | 36
drivers/scsi
Move the function to get phy luns information to the top of function
to set target information
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/aachba.c | 112 +-
1 file changed, 56 insertions(+), 56 deletions
Add helper function to setup targets devices and create the base for the
upcoming patches
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/aachba.c | 18 +-
drivers/scsi/aacraid/aacraid.h | 2 +-
drivers/scsi/aacraid/commsup.c | 2 +-
3
Check if the adapter can receive abort requests, before sending aborts
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
None
drivers/scsi/aacraid/linit.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 3677bef
Edit function that retrieves phy lun information to use common
bmic function
Signed-off-by: Raghava Aditya Renukunta
---
Changes in V2:
Added missing colon to match kernel coding style
drivers/scsi/aacraid/aachba.c | 75 +-
drivers/scsi/aacraid
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@wdc.com]
> Sent: Friday, December 22, 2017 8:27 AM
> To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta
> ; linux-scsi@vger.kernel.org;
> martin.peter...@oracle.com
> Cc: dl-esc-Aacraid L
> -Original Message-
> From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com]
> Sent: Friday, December 22, 2017 7:14 AM
> To: Raghava Aditya Renukunta
> ; j...@linux.vnet.ibm.com;
> martin.peter...@oracle.com; linux-scsi@vger.kernel.org
> Cc: Scott Benesh ;
> -Original Message-
> From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com]
> Sent: Friday, December 22, 2017 7:07 AM
> To: Raghava Aditya Renukunta
> ; linux-scsi@vger.kernel.org
> Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; Scott Benesh
> ;
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@wdc.com]
> Sent: Thursday, December 21, 2017 10:45 AM
> To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta
> ; linux-scsi@vger.kernel.org;
> martin.peter...@oracle.com
> Cc: dl-esc-Aacraid L
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@wdc.com]
> Sent: Thursday, December 21, 2017 10:43 AM
> To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta
> ; linux-scsi@vger.kernel.org;
> martin.peter...@oracle.com
> Cc: dl-esc-Aacraid L
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@wdc.com]
> Sent: Thursday, December 21, 2017 10:40 AM
> To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta
> ; linux-scsi@vger.kernel.org;
> martin.peter...@oracle.com
> Cc: dl-esc-Aacraid L
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@wdc.com]
> Sent: Thursday, December 21, 2017 10:41 AM
> To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta
> ; linux-scsi@vger.kernel.org;
> martin.peter...@oracle.com
> Cc: dl-esc-Aacraid L
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@wdc.com]
> Sent: Thursday, December 21, 2017 9:54 AM
> To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta
> ; linux-scsi@vger.kernel.org;
> martin.peter...@oracle.com
> Cc: dl-esc-Aacraid L
happen on SAFW devices.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aacraid.h | 27 ++-
drivers/scsi/aacraid/commsup.c | 14 +-
drivers/scsi/aacraid/linit.c | 5 +
3 files changed, 44 insertions(+), 2 deletions(-)
diff --git a
to be
exposed, this code can be removed.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 10 --
drivers/scsi/aacraid/aacraid.h | 3 ---
2 files changed, 13 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index aabbefd
Currently driver will attempt to process hotplug events concurrently based
on the FW interrupt.
Protect safw update function with a scan mutex.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aacraid.h | 1 +
drivers/scsi/aacraid/commsup.c | 2 ++
drivers/scsi/aacraid/linit.c
Remove unused rescan variable.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 19 +--
drivers/scsi/aacraid/aacraid.h | 6 +++---
drivers/scsi/aacraid/commsup.c | 14 +++---
drivers/scsi/aacraid/linit.c | 4 ++--
4 files changed, 21
devices are going to go away anyway.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/commsup.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index adebf2e..6f5dfc9 100644
--- a/drivers/scsi
safw. For ARC scsi_scan_host will still
apply.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 4
drivers/scsi/aacraid/aacraid.h | 1 +
drivers/scsi/aacraid/commsup.c | 18 +++---
drivers/scsi/aacraid/linit.c | 5 +++--
4 files changed, 19
Add back the ability to scan for hotplug changes while eh was in progress.
Schedule a rescan for a later time in the eh recovery code and wait for
eh to complete in the rescan worker.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aacraid.h | 4
drivers/scsi/aacraid
Added macros to loop through the MAX SUPPORTED Buses and Targets. This
will make the code a bit easier to read.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aacraid.h | 4
drivers/scsi/aacraid/commsup.c | 34 +-
2 files changed, 21
The device hotplug events are processed only after retrieving the updated
lun information from the fw. Does not make sense to keep them separate.
Merge both the hotplug handling and safw adapter setup code into single
function.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid
not. Add helper functions to add, remove and put
devices based on their fw bus and target number.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/commsup.c | 75 --
1 file changed, 58 insertions(+), 17 deletions(-)
diff --git a/drivers
Merge aac_get_containers to setup target function, so that information
about all the present devices can be retrieved in one shot.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 4
drivers/scsi/aacraid/commsup.c | 34 +++---
2
Add helper function to setup targets devices and create the base for the
upcoming patches
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 18 +-
drivers/scsi/aacraid/aacraid.h | 2 +-
drivers/scsi/aacraid/commsup.c | 2 +-
3 files changed, 15
Created inline function to retrieve lun info for each device from the
phy luns structure.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 59 ++-
1 file changed, 47 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi
Add helper function to set queue depth from information retrieved from
the bmic phy structure.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi
.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 9 ---
drivers/scsi/aacraid/aacraid.h | 3 ++-
drivers/scsi/aacraid/commsup.c | 59 --
3 files changed, 30 insertions(+), 41 deletions(-)
diff --git a/drivers/scsi/aacraid
Check if the adapter can receive abort requests, before sending aborts
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/linit.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 3677bef..5eb0722 100644
--- a
Save the bmic information for each phy, so that it can processed in
target setup function.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 87 +++---
drivers/scsi/aacraid/aacraid.h | 1 +
2 files changed, 82 insertions(+), 6
Edit function that retrieves phy lun information to use common
bmic function
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 75 +-
drivers/scsi/aacraid/aacraid.h | 2 +-
drivers/scsi/aacraid/commsup.c | 11 +--
3 files
Remove function call to process targets from the report phy luns function
and make it a function in its own right. This will help understand the
flow of the code.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 44 +++---
drivers
Ideally driver needs to wait for IO to be submitted or responded to before
shutdown.
Move code to wait for IO completion into shutdown path
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/comminit.c | 36
drivers/scsi/aacraid/commsup.c
Move the function to get phy luns information to the top of function
to set target information
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 112 +-
1 file changed, 56 insertions(+), 56 deletions(-)
diff --git a/drivers/scsi
Rename variables and functions to make bmic identify, report phy luns
to make them consistent across code internal existing code bases
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 36 +++-
drivers/scsi/aacraid/aacraid.h | 2
Refactored the reset_host store function to make consistent across code
bases.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/linit.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index
safw command submission is duplicated across many functions.
Move the safw submission code from bmic identify into its own function
for common use
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 147 +++--
drivers/scsi/aacraid
. Piccoli
Tested-by: Guilherme G. Piccoli
Fixes: a2d0321dd532901e (scsi: aacraid: Reload offlined drives after controller
reset)
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/commsup.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/scsi/aacraid
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/comminit.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/aacraid/comminit.c b/drivers/scsi/aacraid/comminit.c
index 1bc623a..9eff246 100644
--- a/drivers/scsi/aacraid/comminit.c
+++ b
Driver would hang when attempting to send reset from the ioctl interface,
since it would wait to retrieve the ioctl mutex at send shutdown.
Set adapter shutdown and unlock mutex before sending down reset request.
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/commctrl.c | 6
As part of the recovery process, the drivers removes offline devices (
done by the kernel) and then tries to add them back in the rescan code.
Removing the device is like taking a sledgehammer to a nail.
Set the device as running if it is marked offline.
Signed-off-by: Raghava Aditya Renukunta
Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index af3e4d3..f264515 100644
--- a/drivers/scsi/aacraid/aachba.c
+++ b/drivers/scsi/aacraid/aachba.c
now explicitly add devices
retrieved from the fw.
- Reschedule scan in driver fails to retrieve lun information from fw.
(usually works in a few attempts)
- Rescan worker waits for any pending EH recovery before rescanning
- Do not trigger rescan worker in kdump kernel
Raghava Aditya
Hi Paul,
> -Original Message-
> From: Paul Menzel [mailto:pmen...@molgen.mpg.de]
> Sent: Tuesday, December 19, 2017 3:12 PM
> To: Raghava Aditya Renukunta
> ; dl-esc-Aacraid Linux Driver
>
> Cc: linux-scsi@vger.kernel.org; it+linux-s...@molgen.mpg.de
> Subject: Re
Hi Paul,
> -Original Message-
> From: Paul Menzel [mailto:pmen...@molgen.mpg.de]
> Sent: Saturday, December 16, 2017 1:39 AM
> To: Raghava Aditya Renukunta
> ; dl-esc-Aacraid Linux Driver
>
> Cc: linux-scsi@vger.kernel.org; it+linux-s...@vger.kernel.org
> Subject
> -Original Message-
> From: Prasad B Munirathnam [mailto:prasad.munirath...@microsemi.com]
> Sent: Tuesday, December 12, 2017 11:40 AM
> To: Prasad Munirathnam ; Dave
> Carroll ; Raghava Aditya Renukunta
> ;
> martin.peter...@oracle.com; james.bottom...@hansenpartne
> -Original Message-
> From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com]
> Sent: Friday, November 17, 2017 1:15 PM
> To: dl-esc-Aacraid Linux Driver ; linux-
> s...@vger.kernel.org
> Cc: gpicc...@linux.vnet.ibm.com; Dave Carroll
> ; Raghava Adity
> -Original Message-
> From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com]
> Sent: Friday, November 17, 2017 1:15 PM
> To: dl-esc-Aacraid Linux Driver ; linux-
> s...@vger.kernel.org
> Cc: gpicc...@linux.vnet.ibm.com; Dave Carroll
> ; Raghava Adity
: Fix AIF triggered IOP_RESET)
Signed-off-by: Raghava Aditya Renukunta
Reviewed-by: Dave Carroll
---
drivers/scsi/aacraid/comminit.c |8 +---
drivers/scsi/aacraid/linit.c|7 ++-
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aacraid/comminit.c b
c_is_src(struct aac_dev *dev)
> return 0;
> }
>
> +static inline int aac_supports_2T(struct aac_dev *dev)
> +{
> + return (dev->adapter_info.options & AAC_OPT_NEW_COMM_64);
> +}
> +
> char * get_container_type(unsigned type);
> extern int numacb;
> extern char aac_driver_version[];
> --
> 2.8.4
Reviewed-by: Raghava Aditya Renukunta
ev *dev)
> return 0;
> }
>
> +static inline int aac_supports_2T(struct aac_dev *dev)
> +{
> + return (dev->adapter_info.options & AAC_OPT_NEW_COMM_64);
> +}
> +
> char * get_container_type(unsigned type);
> extern int numacb;
> extern char aac_driver_version[];
> --
> 2.8.4
Reviewed-by: Raghava Aditya Renukunta
}
> return byte_count;
>
> is equal to
>
> unsigned long byte_count = 0;
> nseg = scsi_dma_map(scsicmd);
> if (nseg <= 0)
> return nseg;
> ...
> return byte_count;
>
> No other code has changed.
>
> Signed-off-by: Nikola Pajkovsky
> ---
[.]
Reviewed-by: Raghava Aditya Renukunta
so with
> this change, -ENOMEM is propagated to upper layer.
>
> Signed-off-by: Nikola Pajkovsky
> ---
[.]
Reviewed-by: Raghava Aditya Renukunta
; ker...@vger.kernel.org
> Subject: [PATCH 1/3] scsi: aacraid: fix indentation errors
>
> EXTERNAL EMAIL
>
>
> fix stupid indent error, no rocket science here.
>
> Signed-off-by: Nikola Pajkovsky
> ---
[.]
Reviewed-by: Raghava Aditya Renukunta
: b836439faf04 ("aacraid: 4KB sector support")
Reported-by: Dan Carpenter
Signed-off-by: David Carroll
Signed-off-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/aachba.c |9 +++--
drivers/scsi/aacraid/aacraid.h |2 +-
2 files changed, 8 insertions(+), 3 deletions(-)
di
any other changes if
required.
Signed-off-by: Raghava Aditya Renukunta
---
0 files changed
diff --git a/drivers/scsi/scsi_transport_sas.c
b/drivers/scsi/scsi_transport_sas.c
index 5006a656e16a..a6ef5520cb66 100644
--- a/drivers/scsi/scsi_transport_sas.c
+++ b/drivers/scsi/scsi_transport_sas.c
> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de]
> Sent: Friday, June 30, 2017 10:18 AM
> To: Martin K. Petersen
> Cc: Christoph Hellwig ; James Bottomley
> ; linux-scsi@vger.kernel.org;
> Raghava Aditya Renukunta ;
> Hannes Reinecke ; Ha
inue;
> + cid = scmd_id(cmd);
> + info = &aac->hba_map[bus][cid];
> + if (bus >= AAC_MAX_BUSES || cid >= AAC_MAX_TARGETS ||
> + info->devtype != AAC_DEVTYPE_NATIVE_RAW) {
> fib->flags |= FIB_CONTEXT_FLAG_TIMED_OUT;
> cmd->SCp.phase = AAC_OWNER_ERROR_HANDLER;
> }
> --
> 1.8.5.6
Reviewed-by: Raghava Aditya Renukunta
1 - 100 of 441 matches
Mail list logo
