> -----Original Message----- > From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] > Sent: Friday, December 22, 2017 7:07 AM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; linux-scsi@vger.kernel.org > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; Scott Benesh > <scott.ben...@microsemi.com>; dl-esc-Aacraid Linux Driver > <aacr...@microsemi.com>; Tom White <tom.wh...@microsemi.com> > Subject: Re: [PATCH 00/28] aacraid: Refactor for sas transport and bug fixes > > EXTERNAL EMAIL > > > On 12/21/2017 03:33 PM, Raghava Aditya Renukunta wrote: > > This patchset primarily lays the foundation for adding sas transport > > support to the aacraid driver. Being said these patches are mainly code > > refactors, bug fixes and improvements. > > I was thinking...if possible, and just in case you plan to send a V2 > after Bart's comments (or any other future reviews this patchset gets), > how about splitting in 2 patchsets, one for bug fixes and the other for > improvements/foundation of sas support? > > It could help to speed-up the merge of bug fixes.
Hi Guilherme, It did cross my mind, but I wanted to get the sas transport and bug fixes in by 4.16. I thought that breaking the patches into 3 patch sets might not help with it. Regards, Raghava Aditya > Thanks, > > > Guilherme > > > > - Fixed a udev inquiry race condition > > - Fixed a kdump hang issue which occurs in case of error recovery in kdump > > - Made improvements to ioctl reset and reset_host sysfs reset paths > > - Changed the code to retrieve lun information into stand alone functions. > > - Merged container and hba hotplug event processing (device addition and > > and removal into single function) > > - Removed scsi_scan_host for safw devices and now explicitly add devices > > retrieved from the fw. > > - Reschedule scan in driver fails to retrieve lun information from fw. > > (usually works in a few attempts) > > - Rescan worker waits for any pending EH recovery before rescanning > > - Do not trigger rescan worker in kdump kernel > > > > Raghava Aditya Renukunta (29): > > scsi: aacraid: Fix udev inquiry race condition > > scsi: aacraid: Do not attempt abort when Fw panicked > > scsi: aacraid: Fix hang in kdump > > scsi: aacraid: Do not remove offlined devices > > scsi: aacraid: Fix ioctl reset hang > > scsi: aacraid: Allow reset_host sysfs var to recover Panicked Fw > > scsi: aacraid: Refactor reset_host store function > > scsi: aacraid: Move code to wait for IO completion to shutdown func > > scsi: aacraid: Create bmic submission function from bmic identify > > scsi: aacraid: Change phy luns function to use common bmic function > > scsi: aacraid: Refactor and rename to make mirror existing changes > > scsi: aacraid: Add target setup helper function > > scsi: aacraid: Untangle targets setup from report phy luns > > scsi: aacraid: Move function around to match existing code > > scsi: aacraid: Create helper functions to get lun info > > scsi: aacraid: Save bmic phy information for each phy > > scsi: aacraid: Add helper function to set queue depth > > scsi: aacraid: Merge func to get container information > > scsi: aacraid: Process hba and container hot plug events in single > > function > > scsi: aacraid: Added macros to help loop through known buses and targets > > scsi: aacraid: Refactor resolve luns code and scsi functions > > scsi: aacraid: Merge adapter setup with resolve luns > > scsi: aacraid: Block concurrent hotplug event handling > > scsi: aacraid: Use hotplug handling function in place of scsi_scan_host > > scsi: aacraid: Reschedule host scan in case of failure > > scsi: aacraid: Fix hang while scanning in eh recovery > > scsi: aacraid: Skip schedule rescan in case of kdump > > scsi: aacraid: Remove unused rescan variable > > scsi: aacraid: Remove AAC_HIDE_DISK check in queue command > > > > drivers/scsi/aacraid/aachba.c | 479 +++++++++++++++++++++++++++---- > --------- > > drivers/scsi/aacraid/aacraid.h | 52 ++++- > > drivers/scsi/aacraid/commctrl.c | 6 +- > > drivers/scsi/aacraid/comminit.c | 49 +++- > > drivers/scsi/aacraid/commsup.c | 224 ++++++++++--------- > > drivers/scsi/aacraid/linit.c | 23 +- > > 6 files changed, 561 insertions(+), 272 deletions(-) > >
