Re: [PATCH] scsi_dh_alua: handle RTPG sense code correctly during state transitions

2019-10-07 Thread Laurence Oberman
+ pg->state = SCSI_ACCESS_STATE_TRANSITIONING; > + > sdev_printk(KERN_INFO, sdev, > "%s: port group %02x state %c %s supports > %c%c%c%c%c%c%c\n", > ALUA_DH_NAME, pg->group_id, print_alua_state(pg- > >state), This makes sense to me and has affected recovery timeouts in the past. Code looks correct to me. Reviewed-by: Laurence Oberman

Re: [PATCH v2 12/14] qla2xxx: Capture FW dump on MPI heartbeat stop event

2019-09-12 Thread Laurence Oberman
@ qla27xx_fwdump(scsi_qla_host_t *vha, int > hardware_locked) > } > > bailout: > + vha->hw->fw_dump_mpi = 0; > #ifndef __CHECKER__ > if (!hardware_locked) > spin_unlock_irqrestore(&vha->hw->hardware_lock, flags); Being aware of this issue I reviewed it for sanity and code. I cant speak to functions that interract with the firmware though. Looks good otherwise Reviewed-by: Laurence Oberman

Re: [PATCH v2 11/14] qla2xxx: Check for MB timeout while capturing ISP27/28xx FW dump

2019-09-12 Thread Laurence Oberman
5,6 +1045,7 @@ qla27xx_fwdump(scsi_qla_host_t *vha, int > hardware_locked) > qla2x00_post_uevent_work(vha, QLA_UEVENT_CODE_FW_DUMP); > } > > +bailout: > #ifndef __CHECKER__ > if (!hardware_locked) > spin_unlock_irqrestore(&vha->hw->hardware_lock, flags); Being aware of this issue I reviewed it for sanity and code. I cant speak to functions that interract with the firmware though. Looks good otherwise Reviewed-by: Laurence Oberman

[PATCH] bnx2fc: Handle scope bits when array returns BUSY or TASK_SET_FULL

2019-09-11 Thread Laurence Oberman
27 Minutes. This patch adds similar code to handle this to the bnx2fc driver to avoid the huge delay. --- V2. Fix Indent for comments (Chad) V3. Kbuild robot reported uninitialized variable scope Initialize scope to 0 Signed-off-by: Laurence Oberman Reported-by: David Jeffery Reported-by

[PATCH] bnx2fc: Handle scope bits when array returns BUSY or TASK_SET_FULL

2019-09-09 Thread Laurence Oberman
27 Minutes. This patch adds similar code to handle this to the bnx2fc driver to avoid the huge delay. V2. Indent comments as suggested Signed-off-by: Laurence Oberman --- drivers/scsi/bnx2fc/bnx2fc_io.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a

Re: [PATCH] V2. bnx2fc: Handle scope bits when array returns BUSY or TASK_SET_FULL

2019-09-09 Thread Laurence Oberman
On Mon, 2019-09-09 at 07:52 -0400, Laurence Oberman wrote: > On Sat, 2019-09-07 at 21:34 -0400, cdupu...@gmail.com wrote: > > On Fri, 2019-09-06 at 16:26 -0400, Laurence Oberman wrote: > > > The qla2xxx driver had this issue as well when the newer array > >

Re: [PATCH] V2. bnx2fc: Handle scope bits when array returns BUSY or TASK_SET_FULL

2019-09-09 Thread Laurence Oberman
On Sat, 2019-09-07 at 21:34 -0400, cdupu...@gmail.com wrote: > On Fri, 2019-09-06 at 16:26 -0400, Laurence Oberman wrote: > > The qla2xxx driver had this issue as well when the newer array > > firmware returned the retry_delay_timer in the fcp_rsp. > > The bnx2fc is not handli

Re: [PATCH] bnx2fc: Handle scope bits when array returns BUSY or TASK_SET_FULL

2019-09-06 Thread Laurence Oberman
On Fri, 2019-09-06 at 16:26 -0400, Laurence Oberman wrote: > The qla2xxx driver had this issue as well when the newer array > firmware returned the retry_delay_timer in the fcp_rsp. > The bnx2fc is not handling the masking of the scope bits either > so the retry_delay_timestamp va

[PATCH] bnx2fc: Handle scope bits when array returns BUSY or TASK_SET_FULL

2019-09-06 Thread Laurence Oberman
27 Minutes. This patch adds similar code to handle this to the bnx2fc driver to avoid the huge delay. Signed-off-by: Laurence Oberman --- drivers/scsi/bnx2fc/bnx2fc_io.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b

Re: [Bug 204769] New: SCSI devices missing for disks attached to controller

2019-09-04 Thread Laurence Oberman
On Wed, 2019-09-04 at 15:18 +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=204769 > > Bug ID: 204769 >Summary: SCSI devices missing for disks attached to > controller >Product: SCSI Drivers >Version: 2

Re: [PATCH 1/3] scsi: Do not allow user space to change the SCSI device state into SDEV_BLOCK

2019-06-06 Thread Laurence Oberman
On Thu, 2019-06-06 at 10:26 -0700, Bart Van Assche wrote: > On 6/5/19 10:46 PM, Hannes Reinecke wrote: > > Why not simply '-EPERM' ? > > > Translating a state into something else seems counterproductive. > > Personally I'm OK with returning -EPERM for attempts from user space > to > change the

Re: [PATCH 3/3] RDMA/srp: Fix a sleep-in-invalid-context bug

2019-06-06 Thread Laurence Oberman
gt; kthread+0x11c/0x140 > ret_from_fork+0x24/0x30 > > Reviewed-by: Hannes Reinecke > Reviewed-by: Christoph Hellwig > Cc: Jason Gunthorpe > Cc: Leon Romanovsky > Cc: Doug Ledford > Cc: Laurence Oberman > Signed-off-by: Bart Van Assche > --- > drivers/inf

Re: Kernel panic w/ message request_threaded_irq -> qla2x00_request_irqs -> qla2x00_probe_one -> mod_timer

2019-05-02 Thread Laurence Oberman
On Sun, 2019-04-28 at 12:11 -0400, TomK wrote: > On 4/15/2019 10:26 PM, TomK wrote: > > On 4/15/2019 3:35 PM, Laurence Oberman wrote: > > > On Mon, 2019-04-15 at 08:39 -0700, Bart Van Assche wrote: > > > > On Mon, 2019-04-15 at 08:55 -0400, Laurence Oberman wrote:

Re: Kernel panic w/ message request_threaded_irq -> qla2x00_request_irqs -> qla2x00_probe_one -> mod_timer

2019-04-15 Thread Laurence Oberman
On Mon, 2019-04-15 at 08:39 -0700, Bart Van Assche wrote: > On Mon, 2019-04-15 at 08:55 -0400, Laurence Oberman wrote: > > On Sun, 2019-04-14 at 23:25 -0400, TomK wrote: > > > Hey All, > > > > > > I'm getting a kernel panic on an Gigabyte GA-890XA-UD3 >

Re: Kernel panic w/ message request_threaded_irq -> qla2x00_request_irqs -> qla2x00_probe_one -> mod_timer

2019-04-15 Thread Laurence Oberman
On Sun, 2019-04-14 at 23:25 -0400, TomK wrote: > Hey All, > > I'm getting a kernel panic on an Gigabyte GA-890XA-UD3 motherboard > that > I've got a QLE2464 card in as a target (FC). The kernel has been > crashing / panicking in the last 1-2 months about once a > week. Before > that, it was r

Re: Panic when rebooting target server testing srp on 5.0.0-rc2

2019-03-21 Thread Laurence Oberman
On Wed, 2019-03-20 at 16:35 -0400, Laurence Oberman wrote: > On Wed, 2019-03-20 at 13:28 -0700, Bart Van Assche wrote: > > On Wed, 2019-03-20 at 11:11 -0400, Laurence Oberman wrote: > > > On Wed, 2019-03-20 at 09:45 -0400, Laurence Oberman wrote: > > > > Hello Bar

Re: Panic when rebooting target server testing srp on 5.0.0-rc2

2019-03-20 Thread Laurence Oberman
On Wed, 2019-03-20 at 13:28 -0700, Bart Van Assche wrote: > On Wed, 2019-03-20 at 11:11 -0400, Laurence Oberman wrote: > > On Wed, 2019-03-20 at 09:45 -0400, Laurence Oberman wrote: > > > Hello Bart, I hope all is well with you. > > > > > > Quick question >

Re: Panic when rebooting target server testing srp on 5.0.0-rc2

2019-03-20 Thread Laurence Oberman
On Wed, 2019-03-20 at 09:45 -0400, Laurence Oberman wrote: > Hello Bart, I hope all is well with you. > > Quick question > preparing to test v5.1-rc2 SRP, my usual method is first validate the > prior kernel I had in place. > This had passed tests previously (5.0.0-rc2) but

Panic when rebooting target server testing srp on 5.0.0-rc2

2019-03-20 Thread Laurence Oberman
Hello Bart, I hope all is well with you. Quick question preparing to test v5.1-rc2 SRP, my usual method is first validate the prior kernel I had in place. This had passed tests previously (5.0.0-rc2) but I had not run the target server reboot test, just the disconnect tests. Today with mapped SRP

Re: [PATCH] scsi: lpfc: do not set queue->page_count to 0 if pc_sli4_params.wqpcnt is invalid

2018-12-13 Thread Laurence Oberman
gt; + (queue->page_count > phba- > >sli4_hba.pc_sli4_params.wqpcnt)) >   queue->page_count = phba- > >sli4_hba.pc_sli4_params.wqpcnt; >   >   INIT_LIST_HEAD(&queue->list); Compiled and test to bring up card fully and connect to switch port the Red Hat Lab. Reviewed-by: Laurence Oberman Tested-by: Laurence Oberman

Re: [PATCH 0/2] Two refactoring patches for the qla2xxx driver

2018-11-27 Thread Laurence Oberman
qla_target.c | 14 ++--- >  2 files changed, 51 insertions(+), 52 deletions(-) > These look fine to me and the switch change makes it much cleaner. Reviewed-by: Laurence Oberman

Re: [PATCH V2 RESEND] Timeouts occur on surprise removal of QLogic adapter

2018-11-05 Thread Laurence Oberman
On Mon, 2018-11-05 at 11:32 -0500, Laurence Oberman wrote: > On Mon, 2018-11-05 at 11:23 -0500, Bill Kuzeja wrote: > > When doing a surprise removal of an adapter, some in flight I/Os > > can > > get  > > stuck and take a while to complete (they actually timeout and ar

Re: [PATCH V2 RESEND] Timeouts occur on surprise removal of QLogic adapter

2018-11-05 Thread Laurence Oberman
On Mon, 2018-11-05 at 11:23 -0500, Bill Kuzeja wrote: > When doing a surprise removal of an adapter, some in flight I/Os can > get  > stuck and take a while to complete (they actually timeout and are  > retried). We are not handling an early error exit from  > qla2xxx_eh_abort properly. > > Fixes:

Re: [PATCH 0/3] sd: Rely on the driver core for asynchronous probing

2018-10-28 Thread Laurence Oberman
on the SRP test bed here. Multiple disconnects/reconnects during heavy IO activity on 32 SRP 64 LUNS/ 32 mpaths with no issues seen with probes and reconnects. For the series. Tested-by: Laurence Oberman

Re: SCSI qla2xxx: tcm_qla2xxx target server code regession

2018-10-18 Thread Laurence Oberman
On Wed, 2018-10-17 at 16:42 -0400, Laurence Oberman wrote: > On Mon, 2018-10-15 at 08:51 -0400, Laurence Oberman wrote: > > On Sat, 2018-10-13 at 10:42 -0400, Laurence Oberman wrote: > > > On Fri, 2018-10-12 at 17:51 -0700, Bart Van Assche wrote: > > > > On 10/12/18 1

Re: SCSI qla2xxx: tcm_qla2xxx target server code regession

2018-10-17 Thread Laurence Oberman
On Mon, 2018-10-15 at 08:51 -0400, Laurence Oberman wrote: > On Sat, 2018-10-13 at 10:42 -0400, Laurence Oberman wrote: > > On Fri, 2018-10-12 at 17:51 -0700, Bart Van Assche wrote: > > > On 10/12/18 1:36 PM, Laurence Oberman wrote: > > >  > While I have for the longe

[PATCH] scsi_error: Remove scsi_block_when_processing_errors: message

2018-10-16 Thread Laurence Oberman
This message floods the log when enabling mask 0x7 for  /proc/sys/dev/scsi/logging_level  kernel: scsi_block_when_processing_errors: rtn: 1  Its not needed and makes tracing just scsi_eh* messages way too verbose so get rid of it Signed-off-by: Laurence Oberman ---  drivers/scsi

Re: [PATCH RESEND] scsi: qla2xxx: I/Os timing out on surprise removal of

2018-10-16 Thread Laurence Oberman
+ (qla2x00_isp_reg_stat(ha > ))) || > +  (status == > FAST_IO_FAIL)) >   atomic_dec( >   &sp->ref_count); >   } I recently bumped into this issue. The fix looks correct to me. Reviewed-by Laurence Oberman

SCSI qla2xxx: tcm_qla2xxx target server code regession

2018-10-15 Thread Laurence Oberman
On Sat, 2018-10-13 at 10:42 -0400, Laurence Oberman wrote: > On Fri, 2018-10-12 at 17:51 -0700, Bart Van Assche wrote: > > On 10/12/18 1:36 PM, Laurence Oberman wrote: > >  > While I have for the longest time used 4.5 as a base for my F/C > > jammer > >  > that

Re: SCSI qla2xxx: tcm_qla2xxx server code seems to have regressed quite badly with latest testing

2018-10-13 Thread Laurence Oberman
On Fri, 2018-10-12 at 17:51 -0700, Bart Van Assche wrote: > On 10/12/18 1:36 PM, Laurence Oberman wrote: >  > While I have for the longest time used 4.5 as a base for my F/C > jammer >  > that I use every day here in our lab I recently added more jammer > code >  > so I

SCSI qla2xxx: tcm_qla2xxx server code seems to have regressed quite badly with latest testing

2018-10-12 Thread Laurence Oberman
Hello While I have for the longest time used 4.5 as a base for my F/C jammer that I use every day here in our lab I recently added more jammer code so I decided to test this all on latest upstream. Booting the target server on my 4.5 kernel with jammer code is flawless and serves LUNS with no iss

Re: [PATCH 0/4] libfc/fcoe: disc_mutex fixes

2018-07-11 Thread Laurence Oberman
t lists > >  drivers/scsi/fcoe/fcoe_ctlr.c | 12 >  drivers/scsi/libfc/fc_disc.c  | 10 -- >  drivers/scsi/libfc/fc_rport.c |  3 ++- >  3 files changed, 10 insertions(+), 15 deletions(-) > Hannes Series looks fine to me, I will try get this tested as well. Reviewed-by Laurence Oberman

Re: Possible race in completion with SRP after abort with latest upstream kernel 4.17.0+

2018-06-07 Thread Laurence Oberman
On Thu, 2018-06-07 at 15:21 +, Bart Van Assche wrote: > On Thu, 2018-06-07 at 09:23 -0400, Laurence Oberman wrote: > > Have you seen this before, let me know what else you want from the > > dump > > while I look further. > > Hello Laurence, > > I hav

Possible race in completion with SRP after abort with latest upstream kernel 4.17.0+

2018-06-07 Thread Laurence Oberman
Hello Bart Have not seen this more than twice but during testing of latest upstream kernel with SRP I have had two of these completion races. 4.17.0+ [49945.984133] sd 2:0:0:29: alua: transition timeout set to 60 seconds [49945.984136] sd 2:0:0:29: alua: port group 00 state A non-preferred suppo

Re: [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq

2018-05-02 Thread Laurence Oberman
r_template(&tcm_qla2xxx_ops); When I first saw this I thought, no way, it must be used, but when I had a closer look and checked its indeed not used or even made external. This looks OK to me. Reviewed-by: Laurence Oberman

Re: [PATCH 0/3] scsi: scsi-mq: don't hold host_busy in IO path

2018-04-27 Thread Laurence Oberman
On Fri, 2018-04-27 at 15:48 +, Bart Van Assche wrote: > On Fri, 2018-04-27 at 09:39 -0600, Jens Axboe wrote: > > blk_mq_tagset_busy_iter(&shost->tag_set, scsi_host_check_in_flight, > > &in_flight); > > return in_flight.cnt + atomic_read(&shost->host_busy); > > > > The atomi

Re: [PATCH 13/25] tcm_qla2xxx: Do not allow aborted cmd to advance.

2018-03-31 Thread Laurence Oberman
On Sun, 2017-05-21 at 21:45 -0700, Nicholas A. Bellinger wrote: > On Fri, 2017-05-19 at 14:53 -0700, Himanshu Madhani wrote: > > From: Quinn Tran > > > > In case of hardware queue full, commands can loop between > > TCM stack and tcm_qla2xx shim layers for retry. While command > > is waiting for

Re: [PATCH v4 1/7] scsi: hpsa: Eliminate duplicate barriers on weakly-ordered archs

2018-03-20 Thread Laurence Oberman
tstanding); >   } This looks like it would work for the x86_64 and arm because of how its defined architecture specific for the x86_64 and the arm64 I guess its up to Don and the driver folks and if its worth the change. I am generally not a fan of messing with these barrier things though. Reviewed-by: Laurence Oberman

Re: [PATCH] scsi: scsi_dh_alua: Correct comment for alua_alloc_pg()

2018-03-14 Thread Laurence Oberman
scsi device > - * @h: alua device_handler data >   * @group_id: port group id > + * @tpgs: target port group settings >   * >   * Allocate a new port_group structure for a given >   * device. Looks good to me, Thanks Reviewed-by Laurence Oberman

Re: [PATCH] scsi: sd: Remember that READ CAPACITY(16) succeeded

2018-03-14 Thread Laurence Oberman
> */ > + sdp->try_rc_10_first = 0; >   } >   } >   Looks fine to me. Reviewed-by: Laurence Oberman

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-08 Thread Laurence Oberman
On Thu, 2018-03-08 at 21:42 +0800, Ming Lei wrote: > On Wed, Mar 07, 2018 at 09:11:37AM -0500, Laurence Oberman wrote: > > On Tue, 2018-03-06 at 14:24 -0500, Martin K. Petersen wrote: > > > Ming, > > > > > > > Given both Don and Laurence have verified that p

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-07 Thread Laurence Oberman
/8 from the V3 series. No issues running workload and no issues booting on the DL380G7. Don can you ack this so we can at least get this one in. Against: 4.16.0-rc4.v31of8+ on an x86_64 Tested-by: Laurence Oberman Thanks Laurence

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-02 Thread Laurence Oberman
On Fri, 2018-03-02 at 15:03 +, Don Brace wrote: > > -Original Message- > > From: Laurence Oberman [mailto:lober...@redhat.com] > > Sent: Friday, March 02, 2018 8:09 AM > > To: Ming Lei > > Cc: Don Brace ; Jens Axboe > k>; > > linux-bl...@vge

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-02 Thread Laurence Oberman
On Fri, 2018-03-02 at 10:16 +0800, Ming Lei wrote: > On Thu, Mar 01, 2018 at 04:19:34PM -0500, Laurence Oberman wrote: > > On Thu, 2018-03-01 at 14:01 -0500, Laurence Oberman wrote: > > > On Thu, 2018-03-01 at 16:18 +, Don Brace wrote: > > > > > -Original

Re: [PATCH V3 0/8] blk-mq & scsi: fix reply queue selection and improve host wide tagset

2018-03-01 Thread Laurence Oberman
et above All functional I/O tests and boot tests passed with multiple concurrent fio runs. Original HPSA booting issue is also resolved and its important or we will have to revert original genirq commit commit 84676c1f21e8ff54befe985f4f14dc1edc10046b Tested-by: Laurence Oberman Thanks Laurence

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-01 Thread Laurence Oberman
On Thu, 2018-03-01 at 14:01 -0500, Laurence Oberman wrote: > On Thu, 2018-03-01 at 16:18 +, Don Brace wrote: > > > -Original Message- > > > From: Ming Lei [mailto:ming@redhat.com] > > > Sent: Tuesday, February 27, 2018 4:08 AM > > > To: J

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-01 Thread Laurence Oberman
g ; Mike Snitzer > > Cc: linux-scsi@vger.kernel.org; Hannes Reinecke ; > > Arun Easi > > ; Omar Sandoval ; Martin K . > > Petersen ; James Bottomley > > ; Christoph Hellwig > .de>; > > Don Brace ; Kashyap Desai > > ; Peter Rivera > om>; > > Laurenc

Re: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

2018-02-28 Thread Laurence Oberman
On Wed, 2018-02-28 at 23:21 +0800, Ming Lei wrote: > On Wed, Feb 28, 2018 at 08:28:48PM +0530, Kashyap Desai wrote: > > Ming - > > > > Quick testing on my setup -  Performance slightly degraded (4-5% > > drop)for > > megaraid_sas driver with this patch. (From 1610K IOPS it goes to > > 1544K) > > I

Re: Fwd: All scsi_debug devices in the scsi_debug driver share the same RAM space

2018-02-14 Thread Laurence Oberman
On Tue, 2018-02-13 at 21:14 -0500, Martin K. Petersen wrote: > Lukas, > > > I like the idea to have an option to separate the memory area for > > different LUNs, while keeping the current behavior as default. > > As the name implies, scsi_debug is mostly a tool for debugging the > SCSI > stack. >

Re: [PATCH V2 8/8] scsi: hpsa: use blk_mq to solve irq affinity issue

2018-02-05 Thread Laurence Oberman
; Cc: Don Brace > Cc: Kashyap Desai > Cc: Peter Rivera > Cc: Paolo Bonzini > Cc: Mike Snitzer > Tested-by: Laurence Oberman > Signed-off-by: Ming Lei > --- >  drivers/scsi/hpsa.c | 51 ++- > >  1 file changed, 3

Re: All scsi_debug devices in the scsi_debug driver share the same RAM space

2018-02-05 Thread Laurence Oberman
On Sat, 2018-02-03 at 14:43 -0500, Laurence Oberman wrote: > Hello Doug > > I had emailed you earlier about this issue forgetting to copy others. > > All test devices in the scsi_debug driver share the same ram space so > we cannot really have individual devices for testing stu

All scsi_debug devices in the scsi_debug driver share the same RAM space

2018-02-03 Thread Laurence Oberman
Hello Doug I had emailed you earlier about this issue forgetting to copy others. All test devices in the scsi_debug driver share the same ram space so we cannot really have individual devices for testing stuff like md- raid. I bumped into this a few times already and I think it would be useful t

[PATCH] scsi_debug: Add two new parameters to scsi_debug driver

2018-02-03 Thread Laurence Oberman
lt of OPT_MEDIUM_ERR_ADDR, but use that set value. If medium_error_count is set we use that value otherwise default to OPT_MEDIUM_ERR_NUM. Signed-off-by: Laurence Oberman Tested-by : Laurence Oberman drivers/scsi/scsi_debug.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --

Request for input on new options for scsi_debug driver

2018-02-03 Thread Laurence Oberman
count is set we use that value otherwise default to OPT_MEDIUM_ERR_NUM. Should I send a patch for this, wanted to find out if this would be acceptable before I waste anybody's time having to review. Regards Laurence Oberman

Re: [dm-devel] [PATCH v5] blk-mq: introduce BLK_STS_DEV_RESOURCE

2018-01-30 Thread Laurence Oberman
On Tue, 2018-01-30 at 09:52 -0800, Bart Van Assche wrote: > On 01/30/18 06:24, Mike Snitzer wrote: > > +  * > > +  * If driver returns BLK_STS_RESOURCE and > > SCHED_RESTART > > +  * bit is set, run queue after a delay to avoid IO > > stalls > > +  * that cou

Re: [PATCH V3] blk-mq: introduce BLK_STS_DEV_RESOURCE

2018-01-28 Thread Laurence Oberman
On Sun, 2018-01-28 at 16:57 +, Bart Van Assche wrote: > On Sat, 2018-01-27 at 23:58 -0500, Mike Snitzer wrote: > > On Sat, Jan 27 2018 at 10:00pm -0500, > > Bart Van Assche wrote: > > > > > On Sat, 2018-01-27 at 21:03 -0500, Mike Snitzer wrote: > > > > You cannot even be forthcoming about the

Re: [PATCH] qla2xxx: Avoid triggering undefined behavior in qla2x00_mbx_completion()

2018-01-25 Thread Laurence Oberman
NCE(ha->mbx_count > 32); > + mboxes = (1ULL << ha->mbx_count) - 1; >   if (!ha->mcp) >   ql_dbg(ql_dbg_async, vha, 0x504e, "MBX pointer > ERROR.\n"); >   else This looks fine to me and I tested the earlier patch suggestion supplied by Meelis. Reviewed-by: Laurence Oberman

Re: [PATCH] bnx2fc: Fix check in SCSI completion handler when reqeust has already timed out.

2018-01-24 Thread Laurence Oberman
; > + return; >   } >   >   /* Cancel the timeout_work, as we received IO completion */ Hello This was added after the race showed up for the first issue we fixed. Its been running stable in our lab and at the customer. Reviewed-by: Laurence Oberman Tested-by: Laurence Oberman Thanks Laurence

Re: HP ProLiant DL360p Gen8 hangs with Linux 4.13+.

2018-01-15 Thread Laurence Oberman
On Mon, 2018-01-15 at 07:01 -0800, Hellwig, Christoph wrote: > Laurence, I'm a little confused.  Is this the same issue we just > fixed, > or is this an issue showing up with the fix? > > E.g. what kernel versions or trees are affected? Hello Christoph This showed up on a combined tree of Mikes

Re: HP ProLiant DL360p Gen8 hangs with Linux 4.13+.

2018-01-15 Thread Laurence Oberman
On Mon, 2018-01-15 at 20:17 +0800, Ming Lei wrote: > On Sun, Jan 14, 2018 at 06:40:40PM -0500, Laurence Oberman wrote: > > On Thu, 2018-01-04 at 14:32 -0800, Vinson Lee wrote: > > > Hi. > > > > > > HP ProLiant DL360p Gen8 with Smart Array P420i boots to the log

Re: HP ProLiant DL360p Gen8 hangs with Linux 4.13+.

2018-01-14 Thread Laurence Oberman
On Thu, 2018-01-04 at 14:32 -0800, Vinson Lee wrote: > Hi. > > HP ProLiant DL360p Gen8 with Smart Array P420i boots to the login > prompt and hangs with Linux 4.13 or later. I cannot log in on console > or SSH into the machine. Linux 4.12 and older boot fine. > > ... ... This issue bit me for

Re: HP ProLiant DL360p Gen8 hangs with Linux 4.13+.

2018-01-06 Thread Laurence Oberman
On Fri, 2018-01-05 at 16:32 +, Bart Van Assche wrote: > On Thu, 2018-01-04 at 14:32 -0800, Vinson Lee wrote: > > HP ProLiant DL360p Gen8 with Smart Array P420i boots to the login > > prompt and hangs with Linux 4.13 or later. I cannot log in on > > console > > or SSH into the machine. Linux 4.1

Re: [PATCH] bnx2fc: Fix hung task messages when a cleanup response is not received during abort.

2017-11-15 Thread Laurence Oberman
SCSI ML. > +  */ >   rc = bnx2fc_abts_cleanup(io_req); > - goto out; > + goto done; >   } else { >   /* >    * We come here even when there was a race condition > @@ -1249,7 +1274,6 @@ int bnx2fc_eh_abort(struct scsi_cmnd *sc_cmd) >  done: >   /* release the reference taken in eh_abort */ >   kref_put(&io_req->refcount, bnx2fc_cmd_release); > -out: >   spin_unlock_bh(&tgt->tgt_lock); >   return rc; >  } We experienced this at a major customer and provided this patch after working with Chad and backported to RHEL as a test kernel. Its been stable while running a test kernel and the changes look good ate least to me. Reviewed-by: Laurence Oberman Tested-by: Laurence Oberman Thanks Laurence

Re: [PATCH] SCSI: don't get target/host busy_count in scsi_mq_get_budget()

2017-11-08 Thread Laurence Oberman
On Wed, 2017-11-08 at 10:57 -0700, Jens Axboe wrote: > On 11/08/2017 09:41 AM, Bart Van Assche wrote: > > On Tue, 2017-11-07 at 20:06 -0700, Jens Axboe wrote: > > > At this point, I have no idea what Bart's setup looks like. Bart, > > > it > > > would be REALLY helpful if you could tell us how you

[PATCH] Added notes to scsi-parameters.txt to show how to pass parameters on kernel line

2017-10-19 Thread Laurence Oberman
--- Documentation/scsi/scsi-parameters.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/scsi/scsi-parameters.txt b/Documentation/scsi/scsi-parameters.txt index 8477655..5b87a11 100644 --- a/Documentation/scsi/scsi-parameters.txt +++ b/Documentation/scsi/scsi-parameter

Re: Patch: add to Documentation/scsi for scsi_dev_flags and command line passing

2017-10-18 Thread Laurence Oberman
Indeed it was Evolution and then linux-scsi rejected my fix. Trying again, for some reason it thought I had html Signed-off-by: Laurence Oberman --- a/Documentation/scsi/scsi-parameters.txt +++ b/Documentation/scsi/scsi-parameters.txt @@ -116,3 +116,11 @@ parameters may be changed at runtime

Patch: add to Documentation/scsi for scsi_dev_flags and command line passing

2017-10-18 Thread Laurence Oberman
Tired of forgetting about this so documented it for others so they also don't spend unnecessary time figuring this out. Signed-off-by: Laurence Oberman diff --git a/Documentation/scsi/scsi-parameters.txt b/Documentation/scsi/scsi-parameters.txt index 8477655..c9e9ce8 100644 --- a/Document

Re: [PATCH] scsi: sd: Implement blacklist option for WRITE SAME w/ UNMAP

2017-10-17 Thread Laurence Oberman
On Tue, 2017-10-17 at 10:26 -0400, Laurence Oberman wrote: > On Fri, 2017-09-29 at 10:01 -0400, Laurence Oberman wrote: > > On Fri, 2017-09-29 at 09:21 -0400, Martin K. Petersen wrote: > > > Laurence, > > > > > > > I am testing this but its not being

Re: [PATCH] scsi: sd: Implement blacklist option for WRITE SAME w/ UNMAP

2017-10-17 Thread Laurence Oberman
On Fri, 2017-09-29 at 10:01 -0400, Laurence Oberman wrote: > On Fri, 2017-09-29 at 09:21 -0400, Martin K. Petersen wrote: > > Laurence, > > > > > I am testing this but its not being picked up so I want to know > > > if > > > I >

Re: [PATCH] scsi: sd: Implement blacklist option for WRITE SAME w/ UNMAP

2017-09-29 Thread Laurence Oberman
report the UNMAP > parameters despite lbpu being 0). > OK, Thanks, that is working now and I pick up the correct size now. Its going to be very useful for these corner case array inconsistencies. Tested-by: Laurence Oberman Sep 29 09:56:11 localhost kernel: scsi 1:0:0:50: Direct-Acce

Re: [PATCH] scsi: sd: Implement blacklist option for WRITE SAME w/ UNMAP

2017-09-29 Thread Laurence Oberman
On Wed, 2017-09-27 at 21:35 -0400, Martin K. Petersen wrote: > SBC-4 states: > >   "A MAXIMUM UNMAP LBA COUNT field set to a non-zero value indicates > the >    maximum number of LBAs that may be unmapped by an UNMAP command" > >   "A MAXIMUM WRITE SAME LENGTH field set to a non-zero value > indi

Re: Sniffing FC traffic

2017-08-18 Thread Laurence Oberman
On Fri, Aug 18, 2017 at 8:37 AM, Thomas Glanzmann wrote: > Hello, > I would like to create a setup that allows me to sniff FC traffic. Is it > possible with Linux or can someone recommend a setup that works. I want > to avoid buying a 120kUSD fabric analyzer. > > Cheers, > Thomas There is

Re: HBA recommended as FC target

2017-08-18 Thread Laurence Oberman
On Fri, Aug 18, 2017 at 8:36 AM, Thomas Glanzmann wrote: > Hello, > I look for a FC HBA that works with the Linux target. Can somone > recommend a HBA type to me? > > Cheers, > Thomas Hello Any of the Qlogic qla24xx or qla25xx and higher that allow you to disable initiator mode will work

Re: [v4.13-rc BUG] system lockup when running big buffered write(4M) to IB SRP via mpath

2017-08-09 Thread Laurence Oberman
On 08/08/2017 10:28 PM, Laurence Oberman wrote: On Tue, 2017-08-08 at 20:11 -0400, Laurence Oberman wrote: On Tue, 2017-08-08 at 22:17 +0800, Ming Lei wrote: Hi Guys, Laurence and I see a system lockup issue when running concurrent big buffered write(4M bytes) to IB SRP on v4.13-rc3

Re: [v4.13-rc BUG] system lockup when running big buffered write(4M) to IB SRP via mpath

2017-08-08 Thread Laurence Oberman
On Tue, 2017-08-08 at 20:11 -0400, Laurence Oberman wrote: > > On Tue, 2017-08-08 at 22:17 +0800, Ming Lei wrote: > > > > Hi Guys, > > > >  > > > > Laurence and I see a system lockup issue when running > > concurrent > > > > big buffere

Re: [v4.13-rc BUG] system lockup when running big buffered write(4M) to IB SRP via mpath

2017-08-08 Thread Laurence Oberman
On Tue, 2017-08-08 at 22:17 +0800, Ming Lei wrote: > Hi Guys, > > Laurence and I see a system lockup issue when running concurrent > big buffered write(4M bytes) to IB SRP on v4.13-rc3. > > 1 how to reproduce > > 1) setup IB_SRR & multi path > > #./start_opensm.sh > #./start_srp.sh 

Re: device support in hpsa, was: Re: OOPS from cciss_ioctl in 4.12+git

2017-07-07 Thread Laurence Oberman
On 07/07/2017 02:08 PM, Christoph Hellwig wrote: On Fri, Jul 07, 2017 at 11:42:38AM -0400, Laurence Oberman wrote: What happens when hpsa_allow_any=1 with the Smart Array 64xx It should probe. But only if it has a HP vendor ID as far as I can tell. We'd still need to add the compaq i

Re: device support in hpasa, was: Re: OOPS from cciss_ioctl in 4.12+git

2017-07-07 Thread Laurence Oberman
On 07/07/2017 11:03 AM, Jens Axboe wrote: On 07/07/2017 09:00 AM, Christoph Hellwig wrote: On Thu, Jul 06, 2017 at 12:55:04PM +0300, Meelis Roos wrote: Also we're trying to move people away from the cciss driver, can you check if the hpsa SCSI driver works for you as well? I have older adap

Re: [PATCH RESEND] scsi: Add STARGET_CREATED_REMOVE state to scsi_target_state

2017-06-27 Thread Laurence Oberman
TARGET_CREATED_REMOVE, STARGET_DEL, }; This patch (similar patch modified for RHEL) has been tested and validated here for multiple customers. Reviewed-by: Laurence Oberman Tested-by: Laurence Oberman Thanks Laurence

Re: [PATCH v2] lpfc: Fix panic on BFS configuration.

2017-04-26 Thread Laurence Oberman
- Original Message - > From: jsmart2...@gmail.com > To: linux-scsi@vger.kernel.org, sta...@vger.kernel.org > Cc: jthumsh...@suse.de, linux-n...@lists.infradead.org, emi...@redhat.com, > "James Smart" , > "Dick Kennedy" , "James Smart" > > Sent: Wednesday, April 26, 2017 3:19:26 PM > Su

tcm_qla2xxx and target mode not stable at all on 4.10+

2017-04-10 Thread Laurence Oberman
Hello I have had issues with the target mode working since moving to 4.10+. I am using a qla25xx card at 8Gbit Latest testing with 4.11 RC6 sees the same issue. Going back to 4.10.4 I can map targets but when I use my jammer I get into other issues. Its rock solid on 4.9 with the jammer. I wil

Re: [PATCH] sd: Consider max_xfer_blocks if opt_xfer_blocks is unusable

2017-03-27 Thread Laurence Oberman
* Combine with controller limits */ > q->limits.max_sectors = min(rw_max, queue_max_hw_sectors(q)); > -- > 2.9.3 > > Looks good to me and addresses the issue we faced. FInal confirmation this change is OK to come from Martin or James. Reviewed-by: Laurence Oberman

Re: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

2017-03-16 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: "Himanshu Madhani" > Cc: "Chad Dupuis" , "Linux SCSI List" > > Sent: Tuesday, March 14, 2017 11:49:51 PM > Subject: Re: 4.10+ qla2xxx driver wont load for qla2xxx

Re: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

2017-03-14 Thread Laurence Oberman
- Original Message - > From: "Himanshu Madhani" > To: "Laurence Oberman" > Cc: "Chad Dupuis" , "Linux SCSI List" > > Sent: Tuesday, March 14, 2017 8:32:25 PM > Subject: Re: 4.10+ qla2xxx driver wont load for qla2xxx

Re: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

2017-03-14 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: "Himanshu Madhani" > Cc: "Chad Dupuis" , "Linux SCSI List" > > Sent: Tuesday, March 14, 2017 8:02:32 PM > Subject: Re: 4.10+ qla2xxx driver wont load for qla2xxx

Re: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

2017-03-14 Thread Laurence Oberman
- Original Message - > From: "Himanshu Madhani" > To: "Laurence Oberman" > Cc: "Chad Dupuis" , "Linux SCSI List" > > Sent: Tuesday, March 14, 2017 5:11:13 PM > Subject: Re: 4.10+ qla2xxx driver wont load for qla2xxx

Re: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

2017-03-13 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: "Himanshu Madhani" > Cc: "Chad Dupuis" , "Linux SCSI List" > > Sent: Monday, March 13, 2017 9:06:38 PM > Subject: Re: 4.10+ qla2xxx driver wont load for qla2xxx

Re: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

2017-03-13 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: "Himanshu Madhani" > Cc: "Chad Dupuis" , "Linux SCSI List" > > Sent: Monday, March 13, 2017 12:54:12 PM > Subject: Re: 4.10+ qla2xxx driver wont load for qla2xxx

Re: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

2017-03-13 Thread Laurence Oberman
- Original Message - > From: "Himanshu Madhani" > To: "Laurence Oberman" , "Chad Dupuis" > > Cc: "Linux SCSI List" > Sent: Monday, March 13, 2017 12:39:03 PM > Subject: RE: 4.10+ qla2xxx driver wont load for qla2xxx (ISP253

Re: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

2017-03-12 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: "Chad Dupuis" , "Himanshu Madhani" > > Cc: "Linux SCSI List" > Sent: Sunday, March 12, 2017 7:39:23 AM > Subject: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-

4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

2017-03-12 Thread Laurence Oberman
Chad, Himanshu Before I bisect or go chase changes, wanted to reach out because the driver seems to be the same version. Perhaps this is a PCIE change in the kernel for 4.10 affecting the load. Its the same targetLIO server I have been using for a long time with 4.9 27:00.0 Fibre Channel: QLogic

Chasing possible Intel driver issue on Intel Soft FCOE CNA card

2017-03-11 Thread Laurence Oberman
Hello Nicholas I am chasing the possibility of an OX_ID being prematurely re-used in the ixgbe and software fcoe stack when we have congestion. We have a situation where we have F/C traces showing this happening and in trying to track this down using LIO target as the array. I bumped into this

Re: [PATCH 11/20] lpfc: Fix eh_deadline setting for sli3 adapters.

2017-03-04 Thread Laurence Oberman
_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c > index 9d6384a..bcfd6d6 100644 > --- a/drivers/scsi/lpfc/lpfc_scsi.c > +++ b/drivers/scsi/lpfc/lpfc_scsi.c > @@ -5953,7 +5953,7 @@ struct scsi_host_template lpfc_template_nvme = { > .track_queue_depth = 0, > }; > > -struct scsi_host_t

Re: sg driver, sg_io and sg tablesize

2017-03-01 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: dgilb...@interlog.com, "Linux SCSI List" > Sent: Wednesday, March 1, 2017 10:44:32 AM > Subject: sg driver, sg_io and sg tablesize > > Hi Doug > I have a quick question here regard

sg driver, sg_io and sg tablesize

2017-03-01 Thread Laurence Oberman
Hi Doug I have a quick question here regarding the sg tablesize and retrieval of the supported size via a userspace ioctl. lpfc defaults to lpfc_sg_seg_cnt:Max Scatter Gather Segment Count (uint) = 64 For sg_io sent from qemu if we exceed 512K I/O we fail, qlogic allows 128 by default. 7:0:2:

Re: [PATCH] scsi_error: count medium access timeout only once per EH run

2017-02-23 Thread Laurence Oberman
ESET 0x2010 > > /* > * Midlevel queue return values. > -- > 1.8.5.6 > > Hello Hannes This makes sense to me what you are doing here. I will also wait for Ewan to weigh in but I wonder if we should make a simple change. Maybe good to clarify the RESET here by simply changing the name. Change +#define NEEDS_RESET 0x2010 to +#define MAX_MEDIUM_ERROR_NEEDS_RESET Of course then also change + if (eh_disp == NEEDS_RESET) { to + if (eh_disp == MAX_MEDIUM_ERROR_NEEDS_RESET) { Reviewed-by: Laurence Oberman

Re: Patch: lpfc: Modify Emulex lpfc LPFC_DEFAULT_SG_SEG_CNT to 128 for default larger sg_io capability

2017-02-08 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: "Linux SCSI List" > Sent: Wednesday, February 8, 2017 3:07:12 PM > Subject: Patch: lpfc: Modify Emulex lpfc LPFC_DEFAULT_SG_SEG_CNT to 128 for > default larger sg_io capability > > We have

Patch: lpfc: Modify Emulex lpfc LPFC_DEFAULT_SG_SEG_CNT to 128 for default larger sg_io capability

2017-02-08 Thread Laurence Oberman
this but lpfc does not. Would like to avoid having to set this in the module parameters to 128. Tested-by: Laurence Oberman Signed-off-by: Laurence Oberman >From 23996dcbdd9b505d18d59ecde961c87f76fc9c2e Mon Sep 17 00:00:00 2001 From: Laurence Oberman Date: Wed, 8 Feb 2017 14:49:05 -0500

Re: iscsi_trx going into D state

2017-01-15 Thread Laurence Oberman
- Original Message - > From: "Robert LeBlanc" > To: "Laurence Oberman" > Cc: "Doug Ledford" , "Nicholas A. Bellinger" > , "Zhu Lingshan" > , "linux-rdma" , > linux-scsi@vger.kernel.org, "Sagi Grimberg&

Re: iscsi_trx going into D state

2017-01-13 Thread Laurence Oberman
- Original Message - > From: "Robert LeBlanc" > To: "Laurence Oberman" > Cc: "Doug Ledford" , "Nicholas A. Bellinger" > , "Zhu Lingshan" > , "linux-rdma" , > linux-scsi@vger.kernel.org, "Sagi Grimber

  1   2   3   >