From: Ketan Mukadam
Update Broadcom copyright markings in all modified files.
Signed-off-by: Ketan Mukadam
Reviewed-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_iscsi.c | 15 +--
drivers/scsi/be2iscsi/be_main.c | 23 +--
drivers/scsi/be2iscsi/be_mgmt.c
This patch is generated against for-next branch.
Jitendra Bhivare (1):
scsi: be2iscsi: Include null char in SET_HOST_DATA
Ketan Mukadam (2):
scsi: be2iscsi: Add warnings for unsupported adapters
scsi: be2iscsi: Update copyright
drivers/scsi/be2iscsi/be_cmds.c | 2 +-
drivers/scsi
FW needs NULL terminated driver version string.
Signed-off-by: Ketan Mukadam
Reviewed-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_cmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c
index 2eb66df
From: Ketan Mukadam
Add a warning message to indicate obsolete/unsupported
BE3 Adapter Family devices.
Signed-off-by: Ketan Mukadam
Reviewed-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 2 ++
drivers/scsi/be2iscsi/be_mgmt.c | 3 ++-
2 files changed, 4 insertions(+), 1 deletion
de5 100644
> --- a/drivers/scsi/be2iscsi/be_main.h
> +++ b/drivers/scsi/be2iscsi/be_main.h
> @@ -155,8 +155,6 @@
> #define PAGES_REQUIRED(x) \
> ((x < PAGE_SIZE) ? 1 : ((x + PAGE_SIZE - 1) / PAGE_SIZE))
>
> -#define BEISCSI_MSI_NAME 20 /* size of msi_name string */
> -
> #define MEM_DESCR_OFFSET 8
> #define BEISCSI_DEFQ_HDR 1
> #define BEISCSI_DEFQ_DATA 0
> --
> 2.7.4
Looks good.
- Thanks.
Reviewed-by: Jitendra Bhivare
The patch fixes errors reported by tools like smatch:
- removes unused structure fields
- removes dead code
- fixes code identation
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be.h | 17
drivers/scsi/be2iscsi/be_cmds.c | 1 -
drivers/scsi/be2iscsi
Version 11.4.0.1
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h
index 3d21849..9bc7ef9 100644
--- a/drivers/scsi/be2iscsi/be_main.h
+++ b
Provide driver version in host data to FW.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_cmds.c | 46 +
drivers/scsi/be2iscsi/be_cmds.h | 26 +++
drivers/scsi/be2iscsi/be_main.c | 2 ++
3 files changed, 74 insertions
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be.h | 2 +-
drivers/scsi/be2iscsi/be_cmds.c | 2 +-
drivers/scsi/be2iscsi/be_cmds.h | 2 +-
drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
drivers/scsi/be2iscsi/be_iscsi.h | 2 +-
drivers/scsi/be2iscsi/be_main.c | 2 +-
drivers/scsi
Add version 1 of GET_HBA_NAME to fetch port specific IQN first.
If it fails use version 0 to get the IQN.
To use this old IQN names of interfaces needs to be cleared from
the iscsiadm database.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_iscsi.c | 12
drivers/scsi
mgmt_open_connection is expected to return tag not errno.
In error case, just return invalid tag 0.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi
The boot flags exported through sysfs was wrongly reverted to 2.
Use boot flag 3 required per spec.
Bit 0 Block valid flag
Bit 1 Firmware booting selected
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff
-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_cmds.c | 6 +-
drivers/scsi/be2iscsi/be_cmds.h | 4 +-
drivers/scsi/be2iscsi/be_mgmt.c | 212 ++--
3 files changed, 124 insertions(+), 98 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers
be_cmd_get_initname pulls GET_HBA_NAME response of 276 bytes in embedded
WRB buffer of 236 bytes.
Use non-embedded functions to issue the IOCTL.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_cmds.h | 2 --
drivers/scsi/be2iscsi/be_iscsi.c | 44
This patch is generated against for-next branch.
Jitendra Bhivare (10):
be2iscsi: Fix boot flags in sysfs
be2iscsi: Fix return value in mgmt_open_connection
be2iscsi: Free msi_name and disable HW intr
be2iscsi: Fix _modify_eq_delay buffer overflow
be2iscsi: Fix _get_initname buffer
In beiscsi_dev_probe, allocated msi_name does not get freed and enabled
HW interrupts are not disabled in iscsi_host_add error case.
Add beiscsi_free_irqs fn to handle the cleanup in probe and disable port.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 47
}
> -
> phba->shost->max_id = phba->params.cxns_per_ctrl;
> phba->shost->can_queue = phba->params.ios_per_ctrl;
> ret = beiscsi_get_memory(phba);
> @@ -5744,7 +5702,7 @@ static int beiscsi_dev_probe(struct pci_dev
> *pcidev,
> irq_poll_init(&pbe_eq->iopoll, be_iopoll_budget,
be_iopoll);
> }
>
> - i = (phba->msix_enabled) ? i : 0;
> + i = (phba->pcidev->msix_enabled) ? i : 0;
> /* Work item for MCC handling */
> pbe_eq = &phwi_context->be_eq[i];
> INIT_WORK(&pbe_eq->mcc_work, beiscsi_mcc_work); @@ -5815,8
> +5773,7 @@ static int beiscsi_dev_probe(struct pci_dev *pcidev,
> phba->ctrl.mbox_mem_alloced.dma);
> beiscsi_unmap_pci_function(phba);
> hba_free:
> - if (phba->msix_enabled)
> - pci_disable_msix(phba->pcidev);
> + pci_disable_msix(phba->pcidev);
> pci_dev_put(phba->pcidev);
> iscsi_host_free(phba->shost);
> pci_set_drvdata(pcidev, NULL);
> diff --git a/drivers/scsi/be2iscsi/be_main.h
b/drivers/scsi/be2iscsi/be_main.h
> index 2188579..d1d03ee 100644
> --- a/drivers/scsi/be2iscsi/be_main.h
> +++ b/drivers/scsi/be2iscsi/be_main.h
> @@ -323,9 +323,7 @@ struct beiscsi_hba {
> struct pci_dev *pcidev;
> unsigned int num_cpus;
> unsigned int nxt_cqid;
> - struct msix_entry msix_entries[MAX_CPUS];
> char *msi_name[MAX_CPUS];
> - bool msix_enabled;
> struct be_mem_descriptor *init_mem;
>
> unsigned short io_sgl_alloc_index;
> --
> 2.1.4
Reviewed-by: Jitendra Bhivare
Version 11.4.0.0
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h
index c6b95dc..ee18a95 100644
--- a/drivers/scsi/be2iscsi/be_main.h
+++ b
Update Broadcom Copyright markings in all files.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be.h | 11 ---
drivers/scsi/be2iscsi/be_cmds.c | 11 ---
drivers/scsi/be2iscsi/be_cmds.h | 11 ---
drivers/scsi/be2iscsi/be_iscsi.c | 13
With previous patch adding ASYNC Rx buffers to free_list is not required.
Remove all free_list related operations.
Add in_use to track if buffer posted is being processed by driver and
purge all buffers received for connection if found so.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi
Currently, ASYNC PDU default queue size is set to max connections.
This leaves only one buffer per connection for any ASYNC PDUs from
targets.
Double the size of the default queue.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 29 ++---
drivers
- session not to be saved on flash.
Add delay and process CQ before uploading connection.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be.h | 1 -
drivers/scsi/be2iscsi/be_cmds.h | 63 +--
drivers/scsi/be2iscsi/be_iscsi.c | 98
FW runs out of buffer if buffers are not posted back soon.
ASYNC Rx CQE indicates that FW has consumed 8 RQEs.
Use it to post back buffers instead of waiting for buffers
to be processed and freed by driver.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 124
This patch is generated against for-next branch.
v3 changes:
be2iscsi: Fix closing of connection
- Fixed per Tomas's review comments.
v2 changes:
+be2iscsi: Update Copyright
Jitendra Bhivare (10):
be2iscsi: Check tag in beiscsi_mccq_compl_wait
be2iscsi: Fix closing of conne
Data in buffers are gathered into a single buffer before giving to
iSCSI layer. Though less likely to have payload more than 8K in
ASYNC PDU, the data length is provide by FW and check is missing
for overrun.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 7 ++-
1
spin_unlock_bh back_lock is used in beiscsi_eh_device_reset instead of
spin_lock.
Signed-off-by: Jitendra Bhivare
Reviewed-by: Tomas Henzl tomash
---
drivers/scsi/be2iscsi/be_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers
prepare_to_wait.
Signed-off-by: Jitendra Bhivare
Reviewed-by: Tomas Henzl tomash
---
drivers/scsi/be2iscsi/be_cmds.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c
index 5d59e263..d14ddb2 100644
--- a/drivers/scsi/be2iscsi
scsi_flush_work flushes workqueue for the Scsi_Host.
In iSCSI offload enabled host, this would wait for all other
sessions under the host.
Use flush_work for the session being removed instead.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/scsi_transport_iscsi.c | 3 +--
1 file changed, 1
> > + attempts = 0;
> > + while (attempts++ < 3) {
> > + tag = beiscsi_invalidate_cxn(phba, beiscsi_ep);
> > + if (tag) {
> > + ret = beiscsi_mccq_compl_wait(phba, tag, NULL,
> NULL);
> > + if (!ret)
> > + break;
- session not to be saved on flash.
Add delay and process CQ before uploading connection.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be.h | 1 -
drivers/scsi/be2iscsi/be_cmds.h | 63 +--
drivers/scsi/be2iscsi/be_iscsi.c | 98
With previous patch adding ASYNC Rx buffers to free_list is not required.
Remove all free_list related operations.
Add in_use to track if buffer posted is being processed by driver and
purge all buffers received for connection if found so.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi
FW runs out of buffer if buffers are not posted back soon.
ASYNC Rx CQE indicates that FW has consumed 8 RQEs.
Use it to post back buffers instead of waiting for buffers
to be processed and freed by driver.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 124
spin_unlock_bh back_lock is used in beiscsi_eh_device_reset instead of
spin_lock.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index
Currently, ASYNC PDU default queue size is set to max connections.
This leaves only one buffer per connection for any ASYNC PDUs from
targets.
Double the size of the default queue.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 29 ++---
drivers
scsi_flush_work flushes workqueue for the Scsi_Host.
In iSCSI offload enabled host, this would wait for all other
sessions under the host.
Use flush_work for the session being removed instead.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/scsi_transport_iscsi.c | 3 +--
1 file changed, 1
Version 11.4.0.0
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h
index c6b95dc..ee18a95 100644
--- a/drivers/scsi/be2iscsi/be_main.h
+++ b
Update Broadcom Copyright markings in all files.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be.h | 11 ---
drivers/scsi/be2iscsi/be_cmds.c | 11 ---
drivers/scsi/be2iscsi/be_cmds.h | 11 ---
drivers/scsi/be2iscsi/be_iscsi.c | 13
prepare_to_wait.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_cmds.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c
index 5d59e263..d14ddb2 100644
--- a/drivers/scsi/be2iscsi/be_cmds.c
+++ b/drivers/scsi/be2iscsi
Data in buffers are gathered into a single buffer before giving to
iSCSI layer. Though less likely to have payload more than 8K in
ASYNC PDU, the data length is provide by FW and check is missing
for overrun.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 7 ++-
1
This patch is generated against for-next branch.
v2 changes:
+be2iscsi: Update Copyright
Jitendra Bhivare (10):
be2iscsi: Check tag in beiscsi_mccq_compl_wait
be2iscsi: Fix closing of connection
be2iscsi: Replace spin_unlock_bh with spin_lock
scsi_transport_iscsi: Use flush_work in
Data in buffers are gathered into a single buffer before giving to
iSCSI layer. Though less likely to have payload more than 8K in
ASYNC PDU, the data length is provide by FW and check is missing
for overrun.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 7 ++-
1
- session not to be saved on flash.
Add delay and process CQ before uploading connection.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be.h | 1 -
drivers/scsi/be2iscsi/be_cmds.h | 63 +--
drivers/scsi/be2iscsi/be_iscsi.c | 98
prepare_to_wait.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_cmds.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c
index 5d59e263..d14ddb2 100644
--- a/drivers/scsi/be2iscsi/be_cmds.c
+++ b/drivers/scsi/be2iscsi
With previous patch adding ASYNC Rx buffers to free_list is not required.
Remove all free_list related operations.
Add in_use to track if buffer posted is being processed by driver and
purge all buffers received for connection if found so.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi
Version 11.4.0.0
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h
index 9883a85..0f826fe 100644
--- a/drivers/scsi/be2iscsi/be_main.h
+++ b
This patch is generated against for-next branch.
Jitendra Bhivare (9):
be2iscsi: Check tag in beiscsi_mccq_compl_wait
be2iscsi: Fix closing of connection
be2iscsi: Replace spin_unlock_bh with spin_lock
scsi_transport_iscsi: Use flush_work in iscsi_remove_session
be2iscsi: Increase HDQ
FW runs out of buffer if buffers are not posted back soon.
ASYNC Rx CQE indicates that FW has consumed 8 RQEs.
Use it to post back buffers instead of waiting for buffers
to be processed and freed by driver.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 124
scsi_flush_work flushes workqueue for the Scsi_Host.
In iSCSI offload enabled host, this would wait for all other
sessions under the host.
Use flush_work for the session being removed instead.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/scsi_transport_iscsi.c | 3 +--
1 file changed, 1
Currently, ASYNC PDU default queue size is set to max connections.
This leaves only one buffer per connection for any ASYNC PDUs from
targets.
Double the size of the default queue.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 29 ++---
drivers
spin_unlock_bh back_lock is used in beiscsi_eh_device_reset instead of
spin_lock.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Saturday, January 21, 2017 5:56 AM
> To: Christoph Hellwig
> Cc: subbu.seethara...@broadcom.com; ketan.muka...@broadcom.com;
> jitendra.bhiv...@broadcom.com; linux-scsi@vger.kernel.org
> Subject: Re:
> -Original Message-
> From: Wei Yongjun [mailto:weiyj...@gmail.com]
> Sent: Thursday, January 12, 2017 7:52 PM
> To: Subbu Seetharaman; Ketan Mukadam; Jitendra Bhivare; James E.J.
> Bottomley; Martin K. Petersen
> Cc: Wei Yongjun; linux-scsi@vger.kernel.org
> Subjec
From: Ketan Mukadam
Add a warning message to indicate obsolete/unsupported
BE2 Adapter Family devices
Signed-off-by: Ketan Mukadam
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 2 ++
drivers/scsi/be2iscsi/be_mgmt.c | 3 ++-
2 files changed, 4 insertions(+), 1 deletion
Version 11.2.1.0
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h
index 02a9b2d..2188579 100644
--- a/drivers/scsi/be2iscsi/be_main.h
+++ b
-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 61 ++---
1 file changed, 20 insertions(+), 41 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index a8a23d6..d96f7068 100644
--- a/drivers/scsi/be2iscsi
Prepare the IOCTL with appropriate sizes of buffers of V0 and V1.
Set missing chute number in V1 IOCTL.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_cmds.c | 33 ++---
drivers/scsi/be2iscsi/be_main.c | 3 +--
2 files changed, 19 insertions(+), 17
Set CID slot to 0x to indicate empty.
Check if connection already exists in conn_table before binding.
Check if endpoint already NULL before putting back CID.
Break ep->conn link in free_ep to ignore completions after freeing.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2is
Fix errors reported in static analysis.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be.h | 3 --
drivers/scsi/be2iscsi/be_cmds.c | 8 +++---
drivers/scsi/be2iscsi/be_cmds.h | 17 ++--
drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
drivers/scsi/be2iscsi/be_main.c | 24
This duplicate code got added during manual merging.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 1b5a07f..c6af6e5 100644
--- a/drivers/scsi
wq_name is used only to set WQ name when its being allocated.
Remove it from beiscsi_hba structure and define locally.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 9 +
drivers/scsi/be2iscsi/be_main.h | 1 -
2 files changed, 5 insertions(+), 5 deletions(-)
diff
invalid bit in WRB indicates to FW that IO was invalidated before WRB
was fetched from host memory.
For SkyHawk, this invalid bit in WRB is at a different offset.
Use amap_iscsi_wrb_v2 to mark invalid bit for SkyHawk.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 19
IOCTL.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 85 -
drivers/scsi/be2iscsi/be_main.h | 16
drivers/scsi/be2iscsi/be_mgmt.c | 12 +++---
drivers/scsi/be2iscsi/be_mgmt.h | 40 +--
4 files changed, 83
This patch is generated against for-next branch.
v2 changes:
+be2iscsi: Reinit SGL handle, CID tables after TPE
Jitendra Bhivare (12):
be2iscsi: Fix use of invalidate command table req
be2iscsi: Fix for crash in beiscsi_eh_device_reset
be2iscsi: Take iscsi_task ref in abort handler
.
This prevents use of ICD when invalidation of that ICD is being processed.
Use frwd_lock for iscsi_tasks looping and back_lock to access
beiscsi_io_task structures.
Rewrite mgmt_invalidation_icds to handle allocation and freeing of IOCTL
buffer in one place.
Signed-off-by: Jitendra Bhivare
Added check in beiscsi_process_cq for pio_handle.
pio_handle is cleared in beiscsi_put_wrb_handle.
This catches any case where task gets cleaned up just before completion.
Use back_lock before accessing pio_handle.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 28
Hold the reference of iscsi_task till invalidation completes.
This prevents use of ICD when invalidation of that ICD is being processed.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 45 +
1 file changed, 19 insertions(+), 26
wq_name is used only to set WQ name when its being allocated.
Remove it from beiscsi_hba structure and define locally.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 9 +
drivers/scsi/be2iscsi/be_main.h | 1 -
2 files changed, 5 insertions(+), 5 deletions(-)
diff
From: Ketan Mukadam
Add a warning message to indicate obsolete/unsupported
BE2 Adapter Family devices
Signed-off-by: Ketan Mukadam
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 2 ++
drivers/scsi/be2iscsi/be_mgmt.c | 3 ++-
2 files changed, 4 insertions(+), 1 deletion
Version 11.2.1.0
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h
index 02a9b2d..2188579 100644
--- a/drivers/scsi/be2iscsi/be_main.h
+++ b
Fix errors reported in static analysis.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be.h | 3 --
drivers/scsi/be2iscsi/be_cmds.c | 8 +++---
drivers/scsi/be2iscsi/be_cmds.h | 17 ++--
drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
drivers/scsi/be2iscsi/be_main.c | 24
Set CID slot to 0x to indicate empty.
Check if connection already exists in conn_table before binding.
Check if endpoint already NULL before putting back CID.
Break ep->conn link in free_ep to ignore completions after freeing.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2is
invalid bit in WRB indicates to FW that IO was invalidated before WRB
was fetched from host memory.
For SkyHawk, this invalid bit in WRB is at a different offset.
Use amap_iscsi_wrb_v2 to mark invalid bit for SkyHawk.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 19
IOCTL.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 85 -
drivers/scsi/be2iscsi/be_main.h | 16
drivers/scsi/be2iscsi/be_mgmt.c | 12 +++---
drivers/scsi/be2iscsi/be_mgmt.h | 40 +--
4 files changed, 83
Added check in beiscsi_process_cq for pio_handle.
pio_handle is cleared in beiscsi_put_wrb_handle.
This catches any case where task gets cleaned up just before completion.
Use back_lock before accessing pio_handle.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 28
This duplicate code got added during manual merging.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 0fa24a3..9b8b79f 100644
--- a/drivers/scsi
.
This prevents use of ICD when invalidation of that ICD is being processed.
Use frwd_lock for iscsi_tasks looping and back_lock to access
beiscsi_io_task structures.
Rewrite mgmt_invalidation_icds to handle allocation and freeing of IOCTL
buffer in one place.
Signed-off-by: Jitendra Bhivare
This patch is generated against for-next branch.
Jitendra Bhivare (11):
be2iscsi: Fix use of invalidate command table req
be2iscsi: Fix for crash in beiscsi_eh_device_reset
be2iscsi: Take iscsi_task ref in abort handler
be2iscsi: Set WRB invalid bit for SkyHawk
be2iscsi: Add checks to
Hold the reference of iscsi_task till invalidation completes.
This prevents use of ICD when invalidation of that ICD is being processed.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 45 +
1 file changed, 19 insertions(+), 26
Prepare the IOCTL with appropriate sizes of buffers of V0 and V1.
Set missing chute number in V1 IOCTL.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_cmds.c | 33 ++---
drivers/scsi/be2iscsi/be_main.c | 3 +--
2 files changed, 19 insertions(+), 17
> -Original Message-
> From: Pan Bian [mailto:bianpan201...@163.com]
> Sent: Sunday, December 04, 2016 10:53 AM
> To: Subbu Seetharaman; Ketan Mukadam; Jitendra Bhivare; James E.J.
> Bottomley; Martin K. Petersen; linux-scsi@vger.kernel.org
> Cc: linux-ker...@vger.ke
> -Original Message-
> From: Pan Bian [mailto:bianpan201...@163.com]
> Sent: Sunday, December 04, 2016 10:52 AM
> To: Subbu Seetharaman; Ketan Mukadam; Jitendra Bhivare; James E.J.
> Bottomley; Martin K. Petersen; linux-scsi@vger.kernel.org
> Cc: linux-ker...@vger.ke
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Friday, November 18, 2016 5:24 PM
> To: Subbu Seetharaman; Jitendra Bhivare
> Cc: Ketan Mukadam; James E.J. Bottomley; Martin K. Petersen; linux-
> s...@vger.kernel.org; kernel-janit.
back_lock is safe.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/libiscsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index c051694..f9b6fba 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
causes a WARN_ON_ONCE in
spin_unlock_bh for wrb_lock/io_sgl_lock/mgmt_sgl_lock.
CPU was kept busy in lot of bottom half work with interrupts disabled
thus causing hard lock up.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 37 +++--
1 file
except for one in iscsi_eh_cmd_timeout.
This needs to be applied on top 11.2.0.0 of be2iscsi committed in
4.9/scsi-queue.
Jitendra Bhivare (2):
libiscsi: Fix locking in __iscsi_conn_send_pdu
be2iscsi: Replace _bh with _irqsave/irqrestore
drivers/scsi/be2iscsi/be_main.c | 37
> -Original Message-
> From: Jitendra Bhivare [mailto:jitendra.bhiv...@broadcom.com]
> Sent: Friday, September 23, 2016 8:38 PM
> To: 'Mike Christie'; 'Martin K. Petersen'
> Cc: 'linux-scsi@vger.kernel.org'
> Subject: RE: [PATCH 02/28] be2is
are only used in the file in which they are
declared and
> don't need a declaration, but can be made static.
>
> So this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie
> ---
[JB] Looks good.
Reviewed by: Jitendra Bhivare
--
To unsubs
Hi Mike,
I could reproduce hard lockup using for-next kernel only in
iscsi_eh_cmd_timeout path due to spin_lock_irqsave taken in blk_timeout_work
Please refer stack trace below.
The _bh version used for frwd_lock and back_lock does not seem to be causing
any issue similar to seen with be2iscsi af
These patches address some auto built issues of 11.2.0.0 be2iscsi
committed in 4.9/scsi-queue.
v2 changes:
Added NULL check for pwrb_handle in PATCH v2 2/3
Christophe JAILLET (1):
be2iscsi: Fix error return code
Jitendra Bhivare (2):
be2iscsi: Remove redundant iscsi_wrb desc memset
alloc_wrb_handle already does memset zero of iscsi_wrb descriptor so
remove redundant memset in WRB submission paths.
Add pwrb_handle NULL check before memsett'ing pwrb.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 5 +++--
drivers/scsi/be2iscsi/be_mgmt.c | 3 -
t with error code if hba_setup_cid_tbls fails.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 222edfc..b30db87
Julia pointed out beiscsi_boot_get_sinfo does not unlock
mbox_lock on nonemb_cmd memory allocation failure.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_mgmt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi
These patches address some auto built issues of 11.2.0.0 be2iscsi
committed in 4.9/scsi-queue.
Christophe JAILLET (1):
be2iscsi: Fix error return code
Jitendra Bhivare (2):
be2iscsi: Remove redundant iscsi_wrb desc memset
be2iscsi: Add missing unlock for mbox_lock
drivers/scsi/be2iscsi
These patches address some auto built issues of 11.2.0.0 be2iscsi
committed in 4.9/scsi-queue.
Christophe JAILLET (1):
be2iscsi: Fix error return code
Jitendra Bhivare (2):
be2iscsi: Remove redundant iscsi_wrb desc memset
be2iscsi: Add missing unlock for mbox_lock
drivers/scsi/be2iscsi
Julia pointed out beiscsi_boot_get_sinfo does not unlock
mbox_lock on nonemb_cmd memory allocation failure.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_mgmt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi
t with error code if hba_setup_cid_tbls fails.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 222edfc..b30db87
alloc_wrb_handle already does memset zero of iscsi_wrb descriptor so
remove redundant memset in WRB submission paths.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 1 -
drivers/scsi/be2iscsi/be_mgmt.c | 3 ---
2 files changed, 4 deletions(-)
diff --git a/drivers/scsi
to be re-established.
iscsi_session_failure needs process context hence this work.
Signed-off-by: Jitendra Bhivare
Reviewed-by: Hannes Reinecke
---
drivers/scsi/be2iscsi/be_main.c | 24 +---
drivers/scsi/be2iscsi/be_main.h | 1 +
2 files changed, 22 insertions(+), 3
Driver unload should call COMMON_FUNCTION_RESET. For TPE feature, this
ensures that FW has knowledge about driver getting unloaded and can
reset its bit vector.
Signed-off-by: Jitendra Bhivare
Reviewed-by: Hannes Reinecke
---
drivers/scsi/be2iscsi/be_cmds.c | 2 +-
drivers/scsi/be2iscsi
Rename mgmt_get_if_info to be consistent with APIs name.
Rename create/destroy APIs to indicate IFACE operations.
Remove legacy be2iscsi and use beiscsi.
Signed-off-by: Jitendra Bhivare
Reviewed-by: Hannes Reinecke
---
drivers/scsi/be2iscsi/be_iscsi.c | 42
1 - 100 of 263 matches
Mail list logo
