RE: [PATCH v2 02/10] be2iscsi: Fix closing of connection

[Jitendra Bhivare]

> > +   attempts = 0;
> > +   while (attempts++ < 3) {
> > +           tag = beiscsi_invalidate_cxn(phba, beiscsi_ep);
> > +           if (tag) {
> > +                   ret = beiscsi_mccq_compl_wait(phba, tag, NULL,
> NULL);
> > +                   if (!ret)
> > +                           break;
> > +                   beiscsi_log(phba, KERN_INFO, BEISCSI_LOG_CONFIG,
> > +                               "BS_%d : invalidate conn failed cid
%d\n",
> > +                               beiscsi_ep->ep_cid);
> > +           }
> >     }
> >
> > -   ret = beiscsi_mccq_compl_wait(phba, tag, NULL, NULL);
> > -
> > -   /* Flush the CQ entries */
> > +   /* wait for all completions to arrive, then process them */
> > +   msleep(250);
> > +   /* flush CQ entries */
> >     beiscsi_flush_cq(phba);
> >
> > -   return ret;
> > +   if (attempts == 3)
>
> Hi Jitendra,
> when attempts is updated after a '< 3' test, then I think that the test
here
> should be changed to 'if (attempts > 3)'
> tomash
>
[JB] Thanks for reviewing Tomas.
My bad, made some last minute changes to it. Will re-send the series.