Julia pointed out beiscsi_boot_get_sinfo does not unlock
mbox_lock on nonemb_cmd memory allocation failure.

Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@broadcom.com>
---
 drivers/scsi/be2iscsi/be_mgmt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
index b9ff939..aebc4dd 100644
--- a/drivers/scsi/be2iscsi/be_mgmt.c
+++ b/drivers/scsi/be2iscsi/be_mgmt.c
@@ -1085,8 +1085,10 @@ unsigned int beiscsi_boot_get_sinfo(struct beiscsi_hba 
*phba)
        nonemb_cmd->va = pci_alloc_consistent(phba->ctrl.pdev,
                                              sizeof(nonemb_cmd->size),
                                              &nonemb_cmd->dma);
-       if (!nonemb_cmd->va)
+       if (!nonemb_cmd->va) {
+               mutex_unlock(&ctrl->mbox_lock);
                return 0;
+       }
 
        req = nonemb_cmd->va;
        memset(req, 0, sizeof(*req));
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to