Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-06 Thread Arjan van de Ven
It sounds like Coverity was used to produce these patches? If so, is there a plan to have smatch (hey Dan) or other open source static analysis tool be possibly enhanced to do a similar type of work? I'd love for that to happen; the tricky part is being able to have even a sort of sensible conce

Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-05 Thread Arjan van de Ven
On 9/5/2014 3:52 PM, Dmitry Torokhov wrote: On Fri, Sep 05, 2014 at 03:45:08PM -0700, Arjan van de Ven wrote: On 9/5/2014 3:29 PM, Tejun Heo wrote: Hello, Dmitry. On Fri, Sep 05, 2014 at 11:10:03AM -0700, Dmitry Torokhov wrote: I do not agree that it is actually user-visible change

Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-05 Thread Arjan van de Ven
On 9/5/2014 3:29 PM, Tejun Heo wrote: Hello, Dmitry. On Fri, Sep 05, 2014 at 11:10:03AM -0700, Dmitry Torokhov wrote: I do not agree that it is actually user-visible change: generally speaking you do not really know if device is there or not. They come and go. Like I said, consider all permutat

Re: aic7xxx build failure

2008-02-05 Thread Arjan van de Ven
On Tue, 05 Feb 2008 12:30:56 -0600 > > make: *** [sub-make] Error 2 > > Do I assume from this that you have different source and object > directories? There shouldn't be a failure if this is building > in /home/bunk/linux/kernel-2.6/git/linux-2.6/ because the source file > should be there. > >

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Arjan van de Ven
On Thu, 31 Jan 2008 19:34:25 +0100 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Thu, Jan 31, 2008 at 09:48:01AM -0800, Arjan van de Ven wrote: > > On Thu, 31 Jan 2008 19:14:36 +0200 > > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > cpuhotplug is required

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Arjan van de Ven
On Thu, 31 Jan 2008 19:14:36 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > > cpuhotplug is required for suspend/resume. > > Not on UP computers. > great! someone who still has one of those and uses a kernel without it. Can you look at your system.map and see how many kilobytes you've gained? Eg

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Arjan van de Ven
On Thu, 31 Jan 2008 18:21:42 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Thu, Jan 31, 2008 at 08:11:20AM -0800, Arjan van de Ven wrote: > > On Thu, 31 Jan 2008 09:57:31 -0600 > > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > No-one seems

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Arjan van de Ven
exit and discard section removal might > produce more robust debate. I also think doing the hotplug removal > gives us 90% of the benefits and removes 90% of the section mismatch > problems. Since hotplug is so fundamental nowadays the value no longer outweighs the pain/cost to me, s

Re: [PATCH] MAINTAINERS: remove Adam Fritzler, update his email address in other sources

2007-12-18 Thread Arjan van de Ven
On Mon, 17 Dec 2007 20:28:00 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > > > btw, I cheerfully skipped all your spelling-fixes patches. Some will > have stuck via subsystem maintainers but I have a secret "no spelling > fixes unless they're end-user-visible" policy. That means I'll take >

Re: Subject: [PATCH] tgt: use KMEM_CACHE

2007-10-24 Thread Arjan van de Ven
log: why would you want to do this change? kmem_cache_create() is THE linux API to achieve this why would you not want to use it?? I'm sure you have a good reason for this change, but I can't figure out what that is from the changelog of your patch. Greetings, Arjan van de Ven -

Re: What still uses the block layer?

2007-10-15 Thread Arjan van de Ven
On Mon, 15 Oct 2007 22:04:01 -0600 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Mon, Oct 15, 2007 at 07:54:22PM -0700, [EMAIL PROTECTED] wrote: > > do PCI devices reorder their bus numbers spontaniously, or only if > > you change the hardware? > > The only system I've had that reordered PCI bus

Re: What still uses the block layer?

2007-10-15 Thread Arjan van de Ven
On Mon, 15 Oct 2007 03:36:15 -0500 Rob Landley <[EMAIL PROTECTED]> wrote: > The point I was trying to make is that it seems to me like it would > be possible to keep the namespace separate here, and thus reduce the > enumeration problems to the point where common cases (like my laptop) > aren't im

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-28 Thread Arjan van de Ven
On Tue, 28 Aug 2007 12:56:34 +010 Denys Vlasenko <[EMAIL PROTECTED]> wrote: > > > > make namespacecheck > > Thanks, nice tool. > > aic7xxx is kind of not very nice in this regard. > > See below what I get even on non-patched driver. > > I am willing to clean it up, but I still would like > "

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-25 Thread Arjan van de Ven
On Sat, 25 Aug 2007 22:57:07 +0100 Denys Vlasenko <[EMAIL PROTECTED]> wrote: > Hi, > > Attached patch deinlines and moves big functions from .h to .c files > in drivers/scsi/aic7xxx/*. I also had to add prototypes for > ahc_lookup_scb and ahd_lookup_scb to .h files. > one question... how many o

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Arjan van de Ven
> They were hardware problems. I don't think any amount of proper > implementation can fix them. I have one DVD RAM somewhere in my pile of > hardware which locks up solidly if any link PS mode is used and had a and the AHCI ALPM code decides to use power savings on this device? if so, please g

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Arjan van de Ven
On Tue, 2007-07-31 at 15:27 +0900, Tejun Heo wrote: > Jeff Garzik wrote: > > Any chance the SCSI peeps could ACK this, and then let me include it in > > the ALPM patchset in the libata tree? > > ATA link PS is pretty complex with HIPM, DIPM and AHCI ALPM. I'm not > sure whether this three level k

Re: [PATCH] buggered kmalloc()

2007-07-20 Thread Arjan van de Ven
On Fri, 2007-07-20 at 16:05 -0400, Dave Jones wrote: > On Fri, Jul 20, 2007 at 04:03:40PM +0100, Al Viro wrote: > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > > --- > > diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c > > index aebcd5f..7829ab1 100644 > > --- a/drivers/scsi/i

Re: [patch 0/3] AHCI Link Power Management

2007-06-11 Thread Arjan van de Ven
Tejun Heo wrote: do you have data to support this? Yeah, it was some Lenovo notebook. Pavel is more familiar with the hardware. Pavel, what was the notebook which didn't save much power with standard SATA power save but needed port to be completely turned off? Pavel, if you have time, could

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-11 Thread Arjan van de Ven
Henrique de Moraes Holschuh wrote: On Mon, 11 Jun 2007, Jeff Garzik wrote: on/off doesn't really make sense if the question is "do you favor power or do you favor performance"... Actually, it does if you think of it as "do you need hotplug right now or not?". that's a temporary shortcomi

Re: [patch 0/3] AHCI Link Power Management

2007-06-11 Thread Arjan van de Ven
Jeff Garzik wrote: Arjan van de Ven wrote: Tejun Heo wrote: Kristen Carlson Accardi wrote: Hi, This series of patches enables Aggressive Link Power Management for AHCI devices, as documented in the AHCI spec. On my laptop (a Lenovo X60), this saves me a full watt of power. On other

Re: [patch 0/3] AHCI Link Power Management

2007-06-11 Thread Arjan van de Ven
Tejun Heo wrote: Kristen Carlson Accardi wrote: Hi, This series of patches enables Aggressive Link Power Management for AHCI devices, as documented in the AHCI spec. On my laptop (a Lenovo X60), this saves me a full watt of power. On other systems, reported power savings range from .5-1.5 Wa

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-11 Thread Arjan van de Ven
Henrique de Moraes Holschuh wrote: On Mon, 11 Jun 2007, Kristen Carlson Accardi wrote: Setting Effect -- min_power ALPM is enabled, and link set to enter lowest power state (SLUMBER) when idle Hot plug not allowe

Re: Asynchronous scsi scanning

2007-05-15 Thread Arjan van de Ven
Satyam Sharma wrote: > >semantics of it (read-only? read-write? write-only? Well, it _has_ to be write, don't really care if it's read-write or write-only. I would still prefer read-write, but we can go ahead with write-only too. It doesn't really matter, does it? just to be devils advocate

RE: [PATCH] aacraid: Add likely() and unlikely()

2007-03-28 Thread Arjan van de Ven
On Tue, 2007-03-27 at 09:17 -0700, Allexio Ju wrote: > On Thu, 2007-03-22 at 2007 2:24 AM, Arjan van de Ven wrote: > > (I assume you're aware that likely/unlikely should only be > > used for 99:1 or higher ratios, this one looks correct for sure) > Could you share detai

Re: RFC: sg driver addition: SG_FLAG_SHARED_MMAP_IO

2007-03-22 Thread Arjan van de Ven
On Wed, 2007-03-21 at 22:37 -0400, Douglas Gilbert wrote: > > > In my experience mmap-ed IO using sg's reserve buffer mapped > into the user space is faster than direct IO schemes. However > one shortcoming is that if you try to copy between two devices > using this technique then you end up with

Re: [PATCH] aacraid: Add likely() and unlikely()

2007-03-22 Thread Arjan van de Ven
On Wed, 2007-03-21 at 15:43 -0400, Salyzyn, Mark wrote: > Add some likely() and unlikely() compiler hints in some of the aacraid > hardware interface layers. There should be no operational side effects > resulting from this patch and the changes should be mostly benign on x86 > platforms. > > Obli

Re: Fw: [Bugme-new] [Bug 7726] New: New LSI MegaRAID driver fails when ACPI is not present

2006-12-21 Thread Arjan van de Ven
On Thu, 2006-12-21 at 12:57 -0800, Andrew Morton wrote: > > Begin forwarded message: > > Date: Thu, 21 Dec 2006 10:36:55 -0800 > From: [EMAIL PROTECTED] > To: [EMAIL PROTECTED] > Subject: [Bugme-new] [Bug 7726] New: New LSI MegaRAID driver fails when ACPI > is not present > > > http://bugzilla

Re: [PATCH] scsi_execute_async() should add to the tail of the queue

2006-12-19 Thread Arjan van de Ven
ling requests. Are you sure this is the right change? At least I'd expect 2 apis, one for a head and one for a "normal" queueing... Greetings, Arjan van de Ven - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTE

Re: [2.6 patch] remove the broken SCSI_SEAGATE driver

2006-12-18 Thread Arjan van de Ven
On Mon, 2006-12-18 at 14:48 +0100, Krzysztof Halasa wrote: > Arjan van de Ven <[EMAIL PROTECTED]> writes: > > > if a tree falls in a forest but there's nobody around to hear it, does > > it make a sound? > > > > This sort of heisenbug questions aren'

Re: [2.6 patch] remove the broken SCSI_SEAGATE driver

2006-12-18 Thread Arjan van de Ven
On Sun, 2006-12-17 at 22:18 +0100, Krzysztof Halasa wrote: > James Bottomley <[EMAIL PROTECTED]> writes: > > > One of the touted benefits of Linux is that we run on old hardware. > > Unless the driver is demonstrably wrong (and they do become so as the > > APIs evolve) > > Sure, I expect they do

Re: Fw: [Bugme-new] [Bug 7614] New: kernel BUG at mm/slab.c:594! Seems to affect various SCSI systems in various ways.

2006-12-02 Thread Arjan van de Ven
On Sat, 2006-12-02 at 00:19 -0800, Andrew Morton wrote: > On Sat, 02 Dec 2006 09:01:40 +0100 > Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > > > > last sysfs file: /class/net/vmnet1/address > > > Modules linked in: ipv6 vmnet(U) vmmon(U) v

Re: Fw: [Bugme-new] [Bug 7614] New: kernel BUG at mm/slab.c:594! Seems to affect various SCSI systems in various ways.

2006-12-02 Thread Arjan van de Ven
> last sysfs file: /class/net/vmnet1/address > Modules linked in: ipv6 vmnet(U) vmmon(U) video sbs i2c_ec container button does this reproduce without these proprietary drivers as well ? - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL

Re: [PATCH 1/7] zfcp: introduce eh_timed_out handler

2005-09-03 Thread Arjan van de Ven
On Sat, 2005-09-03 at 14:30 +0200, Andreas Herrmann wrote: > zfcp: introduce eh_timed_out handler > > This handler is required to avoid offlined SCSI devices in a multipath > setup if scsi commands time out on cable pulls lasting longer than 30 > seconds. hmm why is this needed? doesn't the fc t

Re: [dm-devel] Re: fibre channel/multipath questions

2005-08-30 Thread Arjan van de Ven
> > there is mount-by-label (filesystem label that is) that at least Fedora > > and RHEL distros use, and I assume many other distros support too even > > if they don't use it by default. > > Although I don't really know what mount-by-label on Fedora and RHEL > means precisely, I suspect it may

Re: [dm-devel] Re: fibre channel/multipath questions

2005-08-30 Thread Arjan van de Ven
> the last rule poses the problem. depending on how many multipath devices i > have, i constantly have to change lilo.conf for every machine. > > in bsd, there is a way to set your drives to a fixed name, is there something > alike in linux? or a sollution to this problem? (i'm definately willi

Re: Fw: [Bugme-new] [Bug 5117] New: Panic when accessing scsi-tapedrives with 4G-remap

2005-08-28 Thread Arjan van de Ven
> > OK. I booted my test i386 machine with highmem=384m and did some tests. I > > also added a counter to st.c to count the highmem pages used for zero-copy > > DMA. I could not get dd to use highmem but with tar that succeeded. No > > extra messages were found in syslog during these tests. > > >

Re: libata: clustering on or off?

2005-08-28 Thread Arjan van de Ven
On Sun, 2005-08-28 at 05:42 -0400, Jeff Garzik wrote: > The constant ATA_SHT_USE_CLUSTERING in include/linux/libata.h controls > the use of SCSI layer's use_clustering feature, for a great many libata > drivers. > > The current setup has clustering disabled, which in theory causes the > block laye

Re: [PATCH] minimal SAS transport class

2005-08-20 Thread Arjan van de Ven
> > > that even if my minimal code goes in now there's absolutely no reason > > we can't replace it completely later on. See the evolution of the FC > > transport class. > > Who makes all those decisions? > > More generally, why is SCSI Core not being managed by > Documentation/ManagingStyle?

Re: [PATCH] minimal SAS transport class

2005-08-15 Thread Arjan van de Ven
On Mon, 2005-08-15 at 15:55 +0200, Christoph Hellwig wrote: > +EXPORT_SYMBOL(sas_add_target); should these exports be _GPL? After all they're very much linux specific functionality... - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROT

Re: hwo to adjust interrupt?

2005-08-12 Thread Arjan van de Ven
On Fri, 2005-08-12 at 10:35 -0700, Bryan Henderson wrote: > >>How much extra work does Linux have to do for each interrupt? > > > >usually 1 pci mmio read; the rest is negligible. > > I was hoping you would cater better to my ignorance of how PCI interrupt > handling works in Linux. > > Is it th

Re: hwo to adjust interrupt?

2005-08-12 Thread Arjan van de Ven
On Fri, 2005-08-12 at 09:59 -0700, Bryan Henderson wrote: > >(Not that it's a big problem, sharing irqs on a pci system isn't too big > >a deal) > > Just how big a deal is it? How much extra work does Linux have to do for > each interrupt? usually 1 pci mmio read; the rest is negliable. - To

Re: hwo to adjust interrupt?

2005-08-12 Thread Arjan van de Ven
On Thu, 2005-08-11 at 18:31 -0400, Ming Zhang wrote: > I have this eth1 and aic7xxx share 1 interrupt thus have impact on > performance, anyway i can change it? thx! realistically, either you need to find a bios setting tweak, or you need to move one of the two to a different pci slot in the machi

RE: [PATCH 7/7] aacraid: sgraw command support

2005-08-05 Thread Arjan van de Ven
On Fri, 2005-08-05 at 07:24 -0700, Mark Haverkamp wrote: > On Thu, 2005-08-04 at 07:40 -0400, Salyzyn, Mark wrote: > > In these cases, the 'addr' is an u64, so is it necessary to perform this > > modification? > > Arjan, > > Do you agree with the above? If so, is the patch OK as is? Ok you're o

RE: [PATCH 6/7] aacraid: unlock around kfree

2005-08-04 Thread Arjan van de Ven
On Thu, 2005-08-04 at 08:04 -0400, Salyzyn, Mark wrote: > Cool! Thanks for the information! Sounds like the patch will be > necessary. However, I have never seen the issue bite us, but who knows, > it may be the contributor to a system lockup after 8000 hours of uptime > ... I'd prefer the paranoid

RE: [PATCH 6/7] aacraid: unlock around kfree

2005-08-04 Thread Arjan van de Ven
On Thu, 2005-08-04 at 07:33 -0400, Salyzyn, Mark wrote: > Good to know. I went through one too many code reviews and had no > defense against the request. > > There is a follow-up to this one not yet submitted to MarkH where I > endeavor to pre-allocate with kmalloc(,GFP_ATOMIC|GFP_KERNEL) a pool

Re: [PATCH 2/3] cpqarray: ioctl support to configure LUNs dynamically

2005-08-04 Thread Arjan van de Ven
On Thu, 2005-08-04 at 10:15 +0530, Saripalli, Venkata Ramanamurthy (STSD) wrote: > Patch 2 of 3 > This patch adds support for IDAREGNEWDISK, IDADEREGDISK, IDAGETLOGINFO > ioctls required > to configure LUNs dynamically on SA4200 controller using ACU. I don't think it's a good idea to add new ioct

Re: [PATCH 7/7] aacraid: sgraw command support

2005-08-04 Thread Arjan van de Ven
On Wed, 2005-08-03 at 15:39 -0700, Mark Haverkamp wrote: > + psg->sg[0].addr[1] = cpu_to_le32((u32)(addr>>32)); this is very risky code; if addr is a 32 bit entity, then this is undefined behavior (which due to the vagities of x86 asm might get optimized out entirely). It is a lot sa

Re: Updated Patch for ServeRAID V7.12.02

2005-07-25 Thread Arjan van de Ven
On Mon, 2005-07-25 at 08:46 -0400, Hammer, Jack wrote: > I am resubmitting the 2.6 kernel patch for the Version 7.12.02 ips > driver. > I have eliminated a couple of inappropriate changes pointed out by > Arjan. > > Signed-off-by: Jack Hammer <[EMAIL PROTECTED]> > > --- a/drivers/scsi/ips.c

Re: ServeRAID V7.12

2005-07-22 Thread Arjan van de Ven
> > > --- a/drivers/scsi/ips.c Tue Jul 19 13:15:24 2005 > +++ b/drivers/scsi/ips.c Tue Jul 19 13:12:44 2005 > @@ -133,10 +133,12 @@ > > #ifdef MODULE > static char *ips = NULL; > -module_param(ips, charp, 0); > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,4,25) > +MODULE_PARM(ips, "s

Re: SCSI luns

2005-07-12 Thread Arjan van de Ven
On Tue, 2005-07-12 at 16:52 +0530, Amrut Joshi wrote: > Hi, > > Currently linux scsi subsystem doesnt store the 8-byte luns which are > recieved in REPORT_LUNS reply. This information is forver lost once > the scan is over. In my LDD I need this information. Currently I have > to snoop REPORT_LUN

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Arjan van de Ven
On Sat, 2005-07-09 at 13:51 -0400, Ben Collins wrote: > On Sat, Jul 09, 2005 at 07:00:52PM +0200, Stefan Richter wrote: > > On 9 Jul, Ben Collins wrote: > > > If it was orphaned it was done so mistakenly. I maintain that code, and > > > linux1394. > > > > sbp2 and eth1394 have been listed as orph

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Arjan van de Ven
On Sat, 2005-07-09 at 12:27 -0400, Ben Collins wrote: > If it was orphaned it was done so mistakenly. I maintain that code, and > linux1394. > > Aside from that, the the change was pushed into the mainstream kernel > without going through our repository, which means it would have been > caught bef

Re: [RFC 1 of 9] patches to add diskdump functionality to block layer

2005-04-18 Thread Arjan van de Ven
On Mon, 2005-04-18 at 10:36 -0500, [EMAIL PROTECTED] wrote: > + > +/* > + * Extended block operations for dump for preserving binary compatibility. > + */ > +struct block_dump_ops { > + int (*sanity_check)(void *device); > + int (*rw_block)(void *device, int rw, unsigned long dump_block_nr,

Re: [RFC 1 of 9] patches to add diskdump functionality to block layer

2005-04-18 Thread Arjan van de Ven
On Mon, 2005-04-18 at 10:36 -0500, [EMAIL PROTECTED] wrote: > Please review the following patches and provide any comments or feedback. > Patch 1 of 9 what diskdump do you use? Why do we even look at disk dump when kexec based dump can dump to disk too and is otherwise more flexible and superior?

Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-08 Thread Arjan van de Ven
On Fri, 2005-04-08 at 08:56 +0100, Christoph Hellwig wrote: > On Fri, Apr 08, 2005 at 12:23:46AM -0700, Jeremy Higdon wrote: > > > It works for those setups that already worked with 2.4.x, aka only a few > > > luns. > > > > Even if it's deprecated, wouldn't it be good to fix it as long as > > it's

Re: [OOPS] 2.6.11 - NMI lockup with CFQ scheduler

2005-04-06 Thread Arjan van de Ven
> @@ -324,6 +334,7 @@ > issue_flush_fn *issue_flush_fn; > prepare_flush_fn*prepare_flush_fn; > end_flush_fn*end_flush_fn; > + release_queue_data_fn *release_queue_data_fn; > > /* >* Auto-unplugging state where does this function

Re: [2.6 patch] SCSI: cleanups

2005-03-28 Thread Arjan van de Ven
On Mon, 2005-03-28 at 09:21 -0600, James Bottomley wrote: \ > > - remove the following unused functions: > > - scsi.h: print_driverbyte > > - scsi.h: print_hostbyte > > - #if 0 the following unused functions: > > - constants.c: scsi_print_hostbyte > > - constants.c: scsi_print_driverbyte >

Re: Fusion-MPT much faster as module

2005-03-22 Thread Arjan van de Ven
> > And there are places where it's actually useful: > > #if defined(CONFIG_FOO) || (defined(MODULE) && defined(CONFIG_FOO_MODULE)) > > is a good way to express that driver bar can use functionality of driver > foo if it's available. a good way? I'd disagree with that :) - To unsubscribe

RE: Fusion-MPT much faster as module

2005-03-22 Thread Arjan van de Ven
On Tue, 2005-03-22 at 02:29 -0800, Chen, Kenneth W wrote: > Before: > /dev/sdc: > Timing buffered disk reads: 92 MB in 3.03 seconds = 30.32 MB/sec > > After: > /dev/sdc: > Timing buffered disk reads: 174 MB in 3.02 seconds = 57.61 MB/sec nice! More proof that #ifdef MODULE is consider

Re: [PATCH 2.4.30-pre3] x86_64: pci_alloc_consistent() match 2.6 implementation

2005-03-19 Thread Arjan van de Ven
On Sat, 2005-03-19 at 08:16 -0600, Matt Domsch wrote: > On Sat, Mar 19, 2005 at 07:09:45AM +0100, Arjan van de Ven wrote: > > On Fri, 2005-03-18 at 15:23 -0600, Matt Domsch wrote: > > > For review and comment. > > > > > > On x86_64 systems with no IOMMU

Re: [PATCH 2.4.30-pre3] x86_64: pci_alloc_consistent() match 2.6 implementation

2005-03-18 Thread Arjan van de Ven
On Fri, 2005-03-18 at 15:23 -0600, Matt Domsch wrote: > For review and comment. > > On x86_64 systems with no IOMMU and with >4GB RAM (in fact, whenever > there are any pages mapped above 4GB), pci_alloc_consistent() falls > back to using ZONE_DMA for all allocations, even if the device's > dma_ma

RE: memcpy_toio/memcpy_fromio 64 bit safe?

2005-03-16 Thread Arjan van de Ven
On Wed, 2005-03-16 at 15:19 -0500, Salyzyn, Mark wrote: > Unsigned long is less than pointer, the reference passed in to the 'dst' > variable. that's on that other OS, not this one ;) - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTE

Re: memcpy_toio/memcpy_fromio 64 bit safe?

2005-03-16 Thread Arjan van de Ven
On Wed, 2005-03-16 at 15:08 -0500, Salyzyn, Mark wrote: > The dpt_i2o driver uses the function memcpy_toio to copy the message > frame to the adapter. Under arch/x86_64/lib/io.c, it's helper function > is defined as: > > void __memcpy_toio(unsigned long dst,const void*src,unsigned len) > { >

Re: PATCH: atp870u DMA mask

2005-03-11 Thread Arjan van de Ven
On Fri, 2005-03-11 at 14:17 +, Alan Cox wrote: > Noted by James Bottomley > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> > > --- drivers/scsi/atp870u.c.old2005-03-11 14:14:53.015465656 + > +++ drivers/scsi/atp870u.c2005-03-11 14:15:24.950610776 + > @@ -2634,7 +2634,7 @@ >

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread Arjan van de Ven
On Wed, 2005-03-09 at 12:44 -0500, Bagalkote, Sreenivas wrote: > >> > > >> >> . And since this is compile time > >> >> system-wide property, I kept it as driver global. > >> > > >> >that step I don't understand... why is it a global > >*VARIABLE* if it's > >> >compile time system-wide property...

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread Arjan van de Ven
On Wed, 2005-03-09 at 11:01 -0500, Bagalkote, Sreenivas wrote: > > > >> . And since this is compile time > >> system-wide property, I kept it as driver global. > > > >that step I don't understand... why is it a global *VARIABLE* if it's > >compile time system-wide property... > > > > I see your po

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread Arjan van de Ven
> . And since this is compile time > system-wide property, I kept it as driver global. that step I don't understand... why is it a global *VARIABLE* if it's compile time system-wide property... - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [E

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread Arjan van de Ven
On Tue, 2005-03-08 at 18:08 -0500, Bagalkote, Sreenivas wrote: > > I will make this an instance parameter if the idea to reduce as many > global variables as possible. But if the objection is because each > adapter > may have different value for variable, then it is indeed a global > value. > "is_

Re: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new module for LSI Logic's SAS based MegaRAID controllers

2005-03-07 Thread Arjan van de Ven
On Mon, 2005-03-07 at 16:12 -0500, Bagalkote, Sreenivas wrote: > +static int is_dma64; the fact that this is a global variable worries me. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] Mor

Re: [ANNOUNCE][PATCH 2.6.11 1/3] megaraid_sas: Announcing new module for LSI Logic's SAS based MegaRAID controllers

2005-03-07 Thread Arjan van de Ven
On Mon, 2005-03-07 at 16:09 -0500, Bagalkote, Sreenivas wrote: > Hello All, > > We are announcing a driver for LSI Logic's new SAS based MegaRAID > controllers. I am submitting the inlined patch in three parts. Please > review the patches. > > source "drivers/scsi/megaraid/Kconfig.megaraid" >

Re: [ANNOUNCE] iSCSI enterprise target software

2005-03-01 Thread Arjan van de Ven
On Tue, 2005-03-01 at 13:04 -0800, Bryan Henderson wrote: > >it is hard to beat linux kernel [page] cache performance though. > > It's quite easy to beat it for particular applications. You can use > special knowledge about the workload to drop pages that won't be accessed > soon in favor of pa

Re: [ANNOUNCE] iSCSI enterprise target software

2005-03-01 Thread Arjan van de Ven
On Tue, 2005-03-01 at 12:53 -0800, Bryan Henderson wrote: > >You want to *use* the kernel pagecache as much as you can. > > No, I really don't. Not always. I can think of only 2 reasons to > maximize my use of the kernel pagecache: 1) saves me duplicating code; 2) > allows me to share resource

Re: [ANNOUNCE] iSCSI enterprise target software

2005-03-01 Thread Arjan van de Ven
On Tue, 2005-03-01 at 10:24 -0800, Bryan Henderson wrote: > One thing that's implicit in your reasons for wanting to be in the kernel > is that you've chosen to exploit the kernel's page cache. As a user of > the page cache, you have more control from inside the kernel than from > user space.

Re: [Iscsitarget-devel] Re: [ANNOUNCE] iSCSI enterprise target software

2005-03-01 Thread Arjan van de Ven
On Tue, 2005-03-01 at 11:48 +0100, Libor Vanek wrote: > > > I don't know in detail what are you talking about (if whole disk must > fit address space) but please consider we're speaking about TBs (10-20 > TB RAID is quite cheap nowadays with 400 GB SATA disks). so? if you need one map/unmap per

Re: [Iscsitarget-devel] Re: [ANNOUNCE] iSCSI enterprise target software

2005-03-01 Thread Arjan van de Ven
On Tue, 2005-03-01 at 11:33 +0100, Arjan van de Ven wrote: > On Tue, 2005-03-01 at 19:22 +0900, FUJITA Tomonori wrote: > > From: Arjan van de Ven <[EMAIL PROTECTED]> > > Subject: [Iscsitarget-devel] Re: [ANNOUNCE] iSCSI enterprise target software > > Date: Tue,

Re: [Iscsitarget-devel] Re: [ANNOUNCE] iSCSI enterprise target software

2005-03-01 Thread Arjan van de Ven
On Tue, 2005-03-01 at 19:22 +0900, FUJITA Tomonori wrote: > From: Arjan van de Ven <[EMAIL PROTECTED]> > Subject: [Iscsitarget-devel] Re: [ANNOUNCE] iSCSI enterprise target software > Date: Tue, 01 Mar 2005 10:46:03 +0100 > > > fsync or msync() ? I would imagine the target

Re: [ANNOUNCE] iSCSI enterprise target software

2005-03-01 Thread Arjan van de Ven
On Tue, 2005-03-01 at 18:35 +0900, FUJITA Tomonori wrote: > From: Arjan van de Ven <[EMAIL PROTECTED]> > Subject: Re: [ANNOUNCE] iSCSI enterprise target software > Date: Tue, 01 Mar 2005 09:40:38 +0100 > > > > Could you please review the code? Any comments ar

Re: [ANNOUNCE] iSCSI enterprise target software

2005-03-01 Thread Arjan van de Ven
On Tue, 2005-03-01 at 16:19 +0900, FUJITA Tomonori wrote: > The user-space daemon handles authentication and the kernel threads > take care of network and disk I/O requests from initiators by using > the VFS interface. The kernel-space code is not intrusive. It doesn't > touch other parts of the k

Re: [Patch] QLogic qla2x00 driver fixes

2005-02-24 Thread Arjan van de Ven
On Thu, 2005-02-24 at 23:21 -0500, Doug Ledford wrote: > Don't use cmd->request->nr_hw_segments as it may not be initialized > (SG_IO in particular bypasses anything that initializes this and just > uses scsi_do_req to insert a scsi_request directly on the head of the > queue) should we fix that

Re: [ANNOUNCE] nsp32, nsp_cs driver update

2005-02-21 Thread Arjan van de Ven
Hi, could you please be so kind as to also provide a diff -u via email to this list, between your new driver and the existing driver in the 2.6 kernel series? That makes it a lot easier for everyone on this mailing list to look at only what changed. Thank you. Greetings, Arjan van de Ven - T

Re: About ARECA RAID driver for Linux i386/x86-64

2005-02-03 Thread Arjan van de Ven
On Wed, 2005-02-02 at 18:08 -0800, Andrew Morton wrote: > "erich" <[EMAIL PROTECTED]> wrote: > > > > I have contact with Andrew Morton about ARECA RAID Linux scsi driver release > > issue. > > I hope this package is as look like a Linux driver. > > No, it doesn't look anything like a Linux drive

Re: SCSI aic7xxx driver: Initialization Failure over a kdump reboot

2005-01-30 Thread Arjan van de Ven
On Sun, 2005-01-30 at 13:27 -0200, Marcelo Tosatti wrote: > On Fri, Jan 07, 2005 at 04:38:32AM +, Matthew Wilcox wrote: > > On Thu, Jan 06, 2005 at 11:53:27PM -0500, Lukasz Kosewski wrote: > > > I have an idea of something I might do for 2.6.11, but I doubt anyone > > > will actually agree with