[PATCH v2 1/3] scsi: core: allow auto suspend override by low-level driver

2019-09-11 Thread Stanley Chu
Rework from previous work by: Sujit Reddy Thumma Until now the scsi mid-layer forbids runtime suspend till userspace enables it. This is mainly to quarantine some disks with broken runtime power management or have high latencies executing suspend resume callbacks. If the userspace doesn't enable

[PATCH v2 3/3] scsi: ufs-mediatek: enable auto suspend capability

2019-09-11 Thread Stanley Chu
Enable auto suspend capability in MediaTek UFS driver. Signed-off-by: Stanley Chu Reviewed-by: Avri Altman --- drivers/scsi/ufs/ufs-mediatek.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c index 0f6ff33ce52e..b7b177c

[PATCH v2 2/3] scsi: ufs: override auto suspend tunables for ufs

2019-09-11 Thread Stanley Chu
Rework from previous work by: Sujit Reddy Thumma Override auto suspend tunables for UFS device LUNs during initialization so as to efficiently manage background operations and the power consumption. Signed-off-by: Stanley Chu Reviewed-by: Avri Altman --- drivers/scsi/ufs/ufshcd.c | 8 +++

[PATCH v2] scsi: allow auto suspend override by low-level driver

2019-09-11 Thread Stanley Chu
Until now the scsi mid-layer forbids runtime suspend till userspace enables it. This is mainly to quarantine some disks with broken runtime power management or have high latencies executing suspend resume callbacks. If the userspace doesn't enable the runtime suspend the underlying hardware will be

RE: [PATCH v1 3/3] scsi: ufs-mediatek: enable auto suspend capability

2019-09-11 Thread Stanley Chu
Hi Avri, On Wed, 2019-09-11 at 10:58 +, Avri Altman wrote: > > > > Enable auto suspend capability in MediaTek UFS driver. > > > > Signed-off-by: Stanley Chu > Reviewed-by: Avri Altman > > > --- > > drivers/scsi/ufs/ufs-mediatek.c | 7 +++ > > 1 file changed, 7 insertions(+) > > > >

Re: [PATCH 0/4] scsi: qla2xxx: Bug fixes

2019-09-11 Thread Bart Van Assche
On 9/12/19 1:39 AM, Roman Bolshakov wrote: > This series has a few bug fixes for the driver. > > Note, #1 only fixes the crash in the kernel. The complete fix for clean > ACL deletion from initiator side is in works and requires a discussion. > > As of now initiator is not aware that target no lo

RE: [PATCH v1 2/3] scsi: ufs: override auto suspend tunables for ufs

2019-09-11 Thread Stanley Chu
Hi Avri, > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index > > 30b752c61b97..d253a018a73b 100644 > > --- a/drivers/scsi/ufs/ufshcd.c > > +++ b/drivers/scsi/ufs/ufshcd.c > > @@ -88,6 +88,9 @@ > > /* Interrupt aggregation default timeout, unit: 40us */ > > #define INT_AG

Re: [RFC,v2] scsi: scan: map PQ=1, PDT=other values to SCSI_SCAN_TARGET_PRESENT

2019-09-11 Thread Zhong Li
> On Aug 29, 2019, at 11:49 PM, Andrey Melnikov wrote: > > Hello. > > This patch break exposing individual RAID disks from adaptec raid > controller. I need access to this disc's for S.M.A.R.T monitoring. Hello Andrey, Do you have any more details about how/why it is broken? Thanks, Zhong

RE: [PATCH v1 1/3] scsi: core: allow auto suspend override by low-level driver

2019-09-11 Thread Stanley Chu
Hi Avri, > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index > > 149d406aacc9..2218d57c4c0c 100644 > > --- a/drivers/scsi/sd.c > > +++ b/drivers/scsi/sd.c > > @@ -3371,6 +3371,9 @@ static int sd_probe(struct device *dev) > > } > > > > blk_pm_runtime_init(sdp->request_queu

[PATCH 4/4] scsi: qla2xxx: Change discovery state before PLOGI

2019-09-11 Thread Roman Bolshakov
When a port sends PLOGI, discovery state should be changed to login pending, otherwise RELOGIN_NEEDED bit is set in qla24xx_handle_plogi_done_event(). RELOGIN_NEEDED triggers another PLOGI, and it never goes out of the loop until login timer expires. Fixes: 8777e4314d397 ("scsi: qla2xxx: Migrate N

[PATCH 3/4] scsi: qla2xxx: Drop superfluous INIT_WORK of del_work

2019-09-11 Thread Roman Bolshakov
del_work is already initialized inside qla2x00_alloc_fcport, there's no need to overwrite it. Indeed, it might prevent complete traversal of workqueue list. Fixes: a01c77d2cbc45 ("scsi: qla2xxx: Move session delete to driver work queue") Cc: Quinn Tran Cc: Himanshu Madhani Cc: Hannes Reinecke S

[PATCH 2/4] scsi: qla2xxx: Initialize free_work before flushing it

2019-09-11 Thread Roman Bolshakov
Target creation triggers a new BUG_ON introduced in in 4d43d395fed12 ("workqueue: Try to catch flush_work() without INIT_WORK()."). The BUG_ON reveals an attempt to flush free_work in qla24xx_do_nack_work before it's initialized in qlt_unreg_sess: WARNING: CPU: 7 PID: 211 at kernel/workqueue.c:3

[PATCH 1/4] scsi: qla2xxx: Ignore NULL pointer in tcm_qla2xxx_free_mcmd

2019-09-11 Thread Roman Bolshakov
If ABTS cannot be completed in target mode, the driver attempts to free related management command and crashes: NIP [d00019181ee8] tcm_qla2xxx_free_mcmd+0x40/0x80 [tcm_qla2xxx] LR [d0001dc1e6f8] qlt_response_pkt+0x190/0xa10 [qla2xxx] Call Trace: [c03fff27bb50] [c03fff27bc10

[PATCH 0/4] scsi: qla2xxx: Bug fixes

2019-09-11 Thread Roman Bolshakov
Hi Martin, This series has a few bug fixes for the driver. Note, #1 only fixes the crash in the kernel. The complete fix for clean ACL deletion from initiator side is in works and requires a discussion. As of now initiator is not aware that target no longer wants talking to it, that implies unne

[Bug 204815] qla2xxx: firmware is not responding to mailbox commands

2019-09-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204815 Roman Bolshakov (r.bolsha...@yadro.com) changed: What|Removed |Added Regression|No |Yes -- You are

[Bug 204815] qla2xxx: firmware is not responding to mailbox commands

2019-09-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204815 --- Comment #1 from Roman Bolshakov (r.bolsha...@yadro.com) --- Created attachment 284927 --> https://bugzilla.kernel.org/attachment.cgi?id=284927&action=edit firmware behaves properly -- You are receiving this mail because: You are watching t

[Bug 204815] New: qla2xxx: firmware is not responding to mailbox commands

2019-09-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204815 Bug ID: 204815 Summary: qla2xxx: firmware is not responding to mailbox commands Product: SCSI Drivers Version: 2.5 Kernel Version: 5.2-rc1 up to 5.3-rc8 Hardware: PPC-6

[PATCH] bnx2fc: Handle scope bits when array returns BUSY or TASK_SET_FULL

2019-09-11 Thread Laurence Oberman
The qla2xxx driver had this issue as well when the newer array firmware returned the retry_delay_timer in the fcp_rsp. The bnx2fc is not handling the masking of the scope bits either so the retry_delay_timestamp value lands up being a large value added to the timer timestamp delaying I/O for up to

RE: [PATCH v1 3/3] scsi: ufs-mediatek: enable auto suspend capability

2019-09-11 Thread Avri Altman
> > Enable auto suspend capability in MediaTek UFS driver. > > Signed-off-by: Stanley Chu Reviewed-by: Avri Altman > --- > drivers/scsi/ufs/ufs-mediatek.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > index

RE: [PATCH v1 2/3] scsi: ufs: override auto suspend tunables for ufs

2019-09-11 Thread Avri Altman
> > Rework from previous work by: > Sujit Reddy Thumma > > Override auto suspend tunables for UFS device LUNs during initialization so > as to efficiently manage background operations and the power consumption. > > Signed-off-by: Stanley Chu Reviewed-by: Avri Altman > --- > drivers/scsi/ufs

RE: [PATCH v1 1/3] scsi: core: allow auto suspend override by low-level driver

2019-09-11 Thread Avri Altman
> > Rework from previous work by: > Sujit Reddy Thumma > > Until now the scsi mid-layer forbids runtime suspend till userspace enables > it. > This is mainly to quarantine some disks with broken runtime power > management or have high latencies executing suspend resume callbacks. If > the users

[PATCH v1] scsi: allow auto suspend override by low-level driver

2019-09-11 Thread Stanley Chu
Until now the scsi mid-layer forbids runtime suspend till userspace enables it. This is mainly to quarantine some disks with broken runtime power management or have high latencies executing suspend resume callbacks. If the userspace doesn't enable the runtime suspend the underlying hardware will be

[PATCH v1 2/3] scsi: ufs: override auto suspend tunables for ufs

2019-09-11 Thread Stanley Chu
Rework from previous work by: Sujit Reddy Thumma Override auto suspend tunables for UFS device LUNs during initialization so as to efficiently manage background operations and the power consumption. Signed-off-by: Stanley Chu --- drivers/scsi/ufs/ufshcd.c | 8 drivers/scsi/ufs/ufshcd

[PATCH v1 1/3] scsi: core: allow auto suspend override by low-level driver

2019-09-11 Thread Stanley Chu
Rework from previous work by: Sujit Reddy Thumma Until now the scsi mid-layer forbids runtime suspend till userspace enables it. This is mainly to quarantine some disks with broken runtime power management or have high latencies executing suspend resume callbacks. If the userspace doesn't enable

[PATCH v1 3/3] scsi: ufs-mediatek: enable auto suspend capability

2019-09-11 Thread Stanley Chu
Enable auto suspend capability in MediaTek UFS driver. Signed-off-by: Stanley Chu --- drivers/scsi/ufs/ufs-mediatek.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c index 0f6ff33ce52e..b7b177c6194c 100644 --- a/drivers